rake-n-bake 1.4.3 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 049ce86cee71aaffcb57eea2882c7bfcfe049565
-  data.tar.gz: d08e71bb5bce7fa32ad8affe346ac92dac41a5b7
+  metadata.gz: 4d7cf1122d6f3c6e074e72dc9f982177aeaad669
+  data.tar.gz: 35deb0087deb8f23f31ec4b07a05460cc2262bc1
 SHA512:
-  metadata.gz: 7deaa3c2067be7deb0f7165edf6172c8a7fe3e91e682f9650fda094463194a64d5c9e567fac43057224310c798a75a70424c808d7301fe6ea36d40ce7cb90709
-  data.tar.gz: c5bac1be478dcfc8e11c14c9e326f82bddeb288246457469b5d6b706409d3a87af10de6b4be11eb356474541afb627073d906720e02bee57b5e130f378eaa78c
+  metadata.gz: e83e1e44c433652d321e5e78a0ac948e31ad27ab0a4918d1ec229e448f213e0c739bfb5968ac52f25593b3d85929dee182400b33db94aed2aeab4851ab8cb3e9
+  data.tar.gz: 2e472ccc2b81879a66afb5001e5866697d814ae98b79f4acaf09cb1f728a0e928bff9628ac7dc78fa7d877f0b52b9f424f0fa1e8679b8d34c8b0fa043132990a

data/.semver

@@ -1,6 +1,6 @@
 ---
-:major: 1
-:minor: 4
-:patch: 3
+:major: 2
+:minor: 0
+:patch: 0
 :special: ''
 :metadata: ''

data/README.md

@@ -34,15 +34,14 @@ Usage
 ```ruby
 require "rake-n-bake"
 
-task :default => [
-  :clean,
-  :"bake:code_quality:all",
-  :"bake:rspec",
-  :"bake:coverage:check_specs",
-  :"bake:bundle-audit",
-  :"bake:rubocop",
-  :"bake:rubycritic",
-  :"bake:ok_rainbow",
+task :default => %i[
+  clean
+  bake:rubocop
+  bake:rspec
+  bake:coverage:check_specs
+  bake:bundle-audit
+  bake:rubycritic
+  bake:ok_rainbow
 ]
 
 ```
@@ -71,23 +70,6 @@ For example:
   ```
 You can also use the underlying checker object by creating an instance of `RakeNBake::DependencyChecker` with your array of dependencies and calling `#check` or `#missing` on it.
 
-### :code_quality
-#### :all
-Runs `[:trailing_spaces, :shoulds, :debugger, :pry, :console_log]` tasks. It does not run `:time_check`
-##### :trailing_spaces
-Check for trailing spaces in `[spec, features, lib, app, factories, db]`.
-##### :shoulds
-Check for legacy 'it "should blah"' style specs
-##### :debugger
-Check for debugger statements in `[lib, app, spec, features]`.
-##### :pry
-Check for binding.pry statements in `[lib, app, spec, features]`.
-##### :console_log
-Check for console.log statements in `app/assets/javascripys`.
-##### :time_check
-Check for `Time.now` statements in `[lib, app]` (Time.zone.now is more reliable for servers wanting to use UTC).
-This check is NOT part of :all as `Time.zone.now` is an ActiveSupport method.
-
 ### :coverage
 #### :check_specs
 Look at SimpleCov results for spec coverage in `log/coverage/spec` and fail the build if not 100%

data/Rakefile

@@ -6,7 +6,6 @@ require './lib/rake-n-bake'
 task default: [
   :clean,
   :"bake:check_external_dependencies",
-  :"bake:code_quality:all",
   :"bake:rspec",
   :"bake:ok_rainbow",
 ]

data/history.rdoc

@@ -1,3 +1,7 @@
+== v2.0.0 (17 November 2016)
+
+* Remove code quality tasks (Rubocop now does all of this)
+
 == v1.4.3 (17 November 2016)
 
 == v1.4.2 (12 October 2016)

data/lib/version.rb

@@ -1,3 +1,3 @@
 module RakeNBake
-  VERSION = '1.4.3'
+  VERSION = '2.0.0'
 end

data/tasks/code_quality.rake

@@ -1,85 +1,38 @@
 namespace :bake do
   namespace :code_quality do
-    desc 'Runs all code quality checks'
-    task :all => [:trailing_spaces, :shoulds, :debugger, :pry, :console_log]
+    desc 'Deprecated - Runs all code quality checks'
+    task :all do
+      RakeNBake::Baker.log_warn "This has been deprecated, use the rubocop task instead"
+    end
 
-    desc 'check for trailing spaces'
+    desc 'Deprecated - check for trailing spaces'
     task :trailing_spaces do
-      grep_for_trailing_space %w{spec features lib app factories db}
+      RakeNBake::Baker.log_warn "This has been deprecated, use the rubocop task instead"
     end
 
-    desc %(check for legacy 'it "should blah"' style specs)
+    desc %(Deprecated - check for legacy 'it "should blah"' style specs)
     task :shoulds do
-      grep_for_shoulds %w{spec}
+      RakeNBake::Baker.log_warn "This has been deprecated, use the rubocop task instead"
     end
 
-    desc 'check for debugger statements'
+    desc 'Deprecated - check for debugger statements'
     task :debugger do
-      grep_for_debugger %w{lib app spec features}
+      RakeNBake::Baker.log_warn "This has been deprecated, use the rubocop task instead"
     end
 
-    desc 'check for binding.pry statements'
+    desc 'Deprecated - check for binding.pry statements'
     task :pry do
-      grep_for_pry %w{lib app spec features}
+      RakeNBake::Baker.log_warn "This has been deprecated, use the rubocop task instead"
     end
 
-    desc 'check for console.log'
+    desc 'Deprecated - check for console.log'
     task :console_log do
-      grep_for_console_log %w{app/assets/javascripts }
+      RakeNBake::Baker.log_warn "This has been deprecated, use the rubocop task instead"
     end
 
-    desc 'check for Time.now; should use Time.now.utc or Time.current'
+    desc 'Deprecated - check for Time.now; should use Time.now.utc or Time.current'
     task :time_check do
-      grep_for_time_now %w{app lib}
-    end
-
-    def grep_for_trailing_space *file_patterns
-      grep '^.*[[:space:]]+$', file_patterns, 'trailing spaces', ['*.yml', '*.csv']
-    end
-
-    def grep_for_shoulds *file_patterns
-      grep '^[[:space:]]*it "should.*$',
-        file_patterns,
-        'it block description starting with should'
-    end
-
-    def grep_for_pry *file_patterns
-      grep 'binding.pry',
-        file_patterns,
-        'binding.pry statement found',
-        %w[common_spec_helper.rb code_quality.rake]
-    end
-
-    def grep_for_debugger *file_patterns
-      grep 'debugger',
-        file_patterns,
-        'debugger statement found',
-        %w[common_spec_helper.rb code_quality.rake angular.js]
-    end
-
-    def grep_for_console_log *file_patterns
-      grep 'console.log',
-        file_patterns,
-        'console.log statement found',
-        %w[angular.js jquery.flot-0.8.1.js]
-    end
-
-    def grep_for_time_now *file_patterns
-      grep "Time.now",
-        file_patterns,
-        "Time.now found, use Time.zone.now to prevent timezone conflicts",
-        %w{*.rake}
-    end
-
-    def grep regex, file_patterns, error_message, exclude_patterns=[], perl_regex=false
-      files_found = ""
-      command = "grep -r -n -s --binary-files=without-match '#{regex}' #{file_patterns.join(' ')}"
-      exclude_patterns.each do |exclude_pattern|
-        command << " --exclude '#{exclude_pattern}'"
-      end
-      command << (perl_regex ? ' -P' : ' -E')
-      files_found << `#{command}`
-      abort("#{error_message} found:\n#{files_found}") unless files_found.empty?
+      RakeNBake::Baker.log_warn "This has been deprecated, use the rubocop task instead"
     end
   end
 end

data/tasks/rubocop.rake

@@ -4,6 +4,12 @@ begin
   namespace :bake do
     require 'rubocop/rake_task'
     RuboCop::RakeTask.new
+
+    task :rubocop_announce do
+      RakeNBake::Baker.log_step "Running Rubocop"
+    end
+
+    task :rubocop => :rubocop_announce
   end
 
 rescue LoadError

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rake-n-bake
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 2.0.0
 platform: ruby
 authors:
 - Richard Vickerstaff
@@ -125,7 +125,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Common rake tasks, baked to perfection and ready to serve!