rake-funnel 0.1.0.pre → 0.2.0.pre

data/spec/rake/funnel/tasks/copy_spec.rb

@@ -3,7 +3,6 @@ include Rake::Funnel::Support
 
 describe Rake::Funnel::Tasks::Copy do
   before {
-    CLEAN.clear
     Task.clear
   }
 
@@ -11,89 +10,35 @@ describe Rake::Funnel::Tasks::Copy do
     its(:name) { should == :copy }
     its(:source) { should eq([]) }
     its(:target) { should be_nil }
-
-    it 'should not add the target file to the files to be cleaned' do
-      expect(CLEAN).to be_empty
-    end
-
-    describe 'overriding defaults' do
-      subject {
-        described_class.new do |t|
-          t.target = 'something'
-        end
-      }
-
-      it 'should add the target file to the files to be cleaned' do
-        expect(CLEAN).to include(subject.target)
-      end
-    end
   end
 
   describe 'execution' do
-    let(:source) { %w(bin/1 bin/2 bin/3/4 bin/directory/file bin/directory bin/directory-no-content) }
-    let(:target) { 'some path' }
+    let(:source) { %w(one two) }
+    let(:target) { 'target' }
+    let(:finder) { instance_double(Finder).as_null_object }
 
-    subject! {
+    before {
+      allow(finder).to receive(:all_or_default).and_return(source)
+      allow(Finder).to receive(:new).and_return(finder)
+    }
+
+    before {
+      allow(Copier).to receive(:copy)
+    }
+
+    subject {
       described_class.new do |t|
         t.source = source
         t.target = target
       end
     }
 
-    context 'failure' do
-      context 'target not defined' do
-        let(:target) { nil }
-
-        it 'should fail' do
-          expect { Task[subject.name].invoke }.to raise_error(/Target not defined/)
-        end
-      end
-    end
-
-    context 'success' do
-      let(:finder) { double(Finder).as_null_object }
-
-      before {
-        allow(finder).to receive(:all_or_default).and_return(source)
-        allow(Finder).to receive(:new).and_return(finder)
-
-        allow(File).to receive(:directory?).and_return(false)
-        source.last(2).each do |dir|
-          allow(File).to receive(:directory?).with(dir).and_return(true)
-        end
-
-        allow(RakeFileUtils).to receive(:mkdir_p)
-        allow(RakeFileUtils).to receive(:cp)
-      }
-
-      before {
-        Task[subject.name].invoke
-      }
-
-      def no_prefix(file)
-        file.sub(%r|bin/|, '')
-      end
-
-      it 'should create target directories' do
-        expect(RakeFileUtils).to have_received(:mkdir_p).with(subject.target + '/3')
-        expect(RakeFileUtils).to have_received(:mkdir_p).with(subject.target + '/directory')
-      end
-
-      it 'should skip source directories' do
-        source
-          .select { |src| File.directory?(src) }
-          .each do |src|
-          expect(RakeFileUtils).not_to have_received(:cp).with(src, anything)
-        end
-      end
+    before {
+      Task[subject.name].invoke
+    }
 
-      it 'should copy files with common path removed' do
-        source
-          .select { |src| !File.directory?(src) }
-          .each do |src|
-          expect(RakeFileUtils).to have_received(:cp).with(src, File.join(subject.target, no_prefix(src)), { preserve: true })
-        end
-      end
+    it 'should delegate to Copier' do
+      expect(Copier).to have_received(:copy).with(source, subject.target)
     end
   end
 end

data/spec/rake/funnel/tasks/environments_spec.rb

@@ -1,3 +1,5 @@
+require 'configatron'
+
 include Rake
 include Rake::Funnel::Support::Environments
 include Rake::Funnel::Tasks
@@ -9,14 +11,6 @@ describe Rake::Funnel::Tasks::Environments do
     Task.clear
   }
 
-  before {
-    module Kernel
-      def configatron
-        OpenStruct.new(name: 'fake configatron singleton')
-      end
-    end
-  }
-
   let(:files) { [] }
 
   before {
@@ -32,6 +26,7 @@ describe Rake::Funnel::Tasks::Environments do
       disable_default_env_setup
     }
 
+    its(:store) { should == configatron }
     its(:base_dir) { should == 'config' }
     its(:default_env) { should be_nil }
     its(:default_config) { should == 'default' }
@@ -39,8 +34,11 @@ describe Rake::Funnel::Tasks::Environments do
     its(:customizer) { should be_nil }
 
     describe 'overriding defaults' do
+      let(:store) { OpenStruct.new }
+
       subject {
         described_class.new do |t|
+          t.store = store
           t.base_dir = 'custom base_dir'
           t.default_env = 'custom default_env'
           t.default_config = 'custom default_config'
@@ -49,6 +47,7 @@ describe Rake::Funnel::Tasks::Environments do
         end
       }
 
+      its(:store) { should == store }
       its(:base_dir) { should == subject.base_dir }
       its(:default_env) { should == subject.default_env }
       its(:default_config) { should == subject.default_config }
@@ -85,6 +84,7 @@ describe Rake::Funnel::Tasks::Environments do
   end
 
   describe 'config files to load' do
+    let(:optional) { nil }
     let(:files) {
       %w(config/dev.yaml)
     }
@@ -98,16 +98,20 @@ describe Rake::Funnel::Tasks::Environments do
       allow(File).to receive(:exists?).with(optional).and_return(false)
     }
 
-    subject {
+    subject! {
       described_class.new do |t|
         t.default_env = 'dev'
       end
     }
 
     before {
-      expect(subject).to be
+      Task['dev'].invoke
     }
 
+    it 'should store configuration in configatron singleton' do
+      expect(Loader).to have_received(:load_configuration).with(anything, configatron, any_args)
+    end
+
     context 'default and local config files exist' do
       let(:optional) { nil }
 
@@ -136,32 +140,13 @@ describe Rake::Funnel::Tasks::Environments do
     end
   end
 
-  describe 'store' do
-    let(:files) {
-      %w(config/dev.yaml)
-    }
-
-    before {
-      allow(Loader).to receive(:load_configuration)
-    }
-
-    before {
-      expect(subject).to be
-      Task['dev'].invoke
-    }
-
-    it 'should store configuration in configatron singleton' do
-      expect(Loader).to have_received(:load_configuration).with(anything, configatron, any_args)
-    end
-  end
-
   describe 'customization' do
     let(:customizer) { Proc.new {} }
     let(:files) {
       %w(config/dev.yaml)
     }
 
-    subject {
+    subject! {
       described_class.new do |t|
         t.customizer = customizer
       end
@@ -172,7 +157,6 @@ describe Rake::Funnel::Tasks::Environments do
     }
 
     before {
-      expect(subject).to be
       Task['dev'].invoke
     }
 
@@ -187,104 +171,74 @@ describe Rake::Funnel::Tasks::Environments do
     }
 
     before {
-      allow(Loader).to receive(:load_configuration)
+      Rake.application.top_level_tasks.clear
+      Rake.application.top_level_tasks.push(*top_level_tasks)
     }
 
-    context 'no default environment configured' do
-      before {
-        expect(subject).to be
-      }
-
-      it 'should not invoke environment tasks' do
-        expect(Loader).not_to have_received(:load_configuration)
-      end
-    end
-
-    context 'default environment configured' do
-      subject {
+    context 'environment task defined in top-level Rake namespace' do
+      subject! {
         described_class.new do |t|
-          t.default_env = 'dev'
+          t.default_env = default_env
         end
       }
 
-      before {
-        allow(Rake.application).to receive(:top_level_tasks).and_return(user_defined_task)
-      }
-
-      before {
-        expect(subject).to be
-      }
-
-      context 'no user-defined environment' do
-        let(:user_defined_task) { %w(foo) }
-
-        it 'should invoke default environment task' do
-          expect(Loader)
-            .to have_received(:load_configuration).with(hash_including({ name: 'dev' }), any_args)
-        end
+      context 'no default environment configured' do
+        let(:default_env) { nil }
+        let(:top_level_tasks) { [] }
 
-        it 'should not invoke other environment tasks' do
-          expect(Loader)
-            .not_to have_received(:load_configuration).with(hash_including({ name: 'production' }), any_args)
+        it 'should not add top-level environment tasks' do
+          expect(Rake.application.top_level_tasks).to be_empty
         end
       end
 
-      context 'user-defined environment' do
-        let(:user_defined_task) { %w(foo production) }
+      context 'default environment configured' do
+        let(:default_env) { 'dev' }
 
-        it 'should invoke user-defined environment task' do
-          expect(Loader)
-            .to have_received(:load_configuration).with(hash_including({ name: 'production' }), any_args)
+        context 'no top-level environment task' do
+          let(:top_level_tasks) { %w(foo) }
+
+          it 'should prepend default top-level environment task' do
+            expect(Rake.application.top_level_tasks).to eq([default_env] + top_level_tasks)
+          end
         end
 
-        it 'should not invoke other environment tasks' do
-          expect(Loader)
-            .not_to have_received(:load_configuration).with(hash_including({ name: 'dev' }), any_args)
+        context 'top-level environment task' do
+          let(:top_level_tasks) { %w(foo production) }
+
+          it 'should move top-level environment task to front' do
+            expect(Rake.application.top_level_tasks).to eq(top_level_tasks.reverse)
+          end
         end
       end
+    end
 
-      context 'environment task defined in Rake namespace' do
-        subject {
-          namespace :foo do
-            namespace :bar do
-              described_class.new do |t|
-                t.default_env = 'dev'
-              end
+    context 'environment task defined in Rake namespace' do
+      subject! {
+        namespace :foo do
+          namespace :bar do
+            described_class.new do |t|
+              t.default_env = default_env
             end
           end
-        }
-
-        context 'default environment configured' do
-          before {
-            expect(subject).to be
-          }
+        end
+      }
 
-          context 'no user-defined environment' do
-            let(:user_defined_task) { %w(foo) }
+      context 'default environment configured' do
+        let(:default_env) { 'dev' }
 
-            it 'should invoke default environment task' do
-              expect(Loader)
-                .to have_received(:load_configuration).with(hash_including({ name: 'dev' }), any_args)
-            end
+        context 'no top-level environment task' do
+          let(:top_level_tasks) { %w(foo) }
 
-            it 'should not invoke other environment tasks' do
-              expect(Loader)
-                .not_to have_received(:load_configuration).with(hash_including({ name: 'production' }), any_args)
-            end
+          it 'should prepend default top-level environment task' do
+            expect(Rake.application.top_level_tasks).to eq(["foo:bar:#{default_env}"] + top_level_tasks)
           end
+        end
 
-          context 'user-defined environment' do
-            let(:user_defined_task) { %w(foo foo:bar:production) }
-
-            it 'should invoke user-defined environment task' do
-              expect(Loader)
-                .to have_received(:load_configuration).with(hash_including({ name: 'production' }), any_args)
-            end
+        context 'top-level environment task' do
+          let(:top_level_tasks) { %w(foo foo:bar:production) }
 
-            it 'should not invoke other environment tasks' do
-              expect(Loader)
-                .not_to have_received(:load_configuration).with(hash_including({ name: 'dev' }), any_args)
-            end
+          it 'should move top-level environment task to front' do
+            expect(Rake.application.top_level_tasks).to eq(top_level_tasks.reverse)
           end
         end
       end

data/spec/rake/funnel/tasks/msbuild_spec.rb

@@ -25,36 +25,6 @@ describe Rake::Funnel::Tasks::MSBuild do
     end
   end
 
-  describe 'overriding defaults' do
-    context 'when msbuild executable is specified' do
-      subject {
-        described_class.new do |t|
-          t.msbuild = 'custom build tool.exe'
-        end
-      }
-
-      its(:msbuild) { should == 'custom build tool.exe' }
-    end
-
-    context 'when project or solution is specified' do
-      before {
-        allow(Finder).to receive(:new).and_call_original
-      }
-
-      subject {
-        described_class.new do |t|
-          t.project_or_solution = 'project.sln'
-        end
-      }
-
-      its(:project_or_solution) { should be_instance_of(Finder) }
-
-      it 'should set project or solution' do
-        expect(Finder).to have_received(:new).with('project.sln', subject, 'No projects or more than one project found.')
-      end
-    end
-  end
-
   describe 'execution' do
     let(:args) { {} }
 
@@ -87,5 +57,35 @@ describe Rake::Funnel::Tasks::MSBuild do
     it 'should run with sh' do
       expect(subject).to have_received(:sh)
     end
+
+    describe 'overriding defaults' do
+      context 'when msbuild executable is specified' do
+        subject {
+          described_class.new do |t|
+            t.msbuild = 'custom build tool.exe'
+          end
+        }
+
+        its(:msbuild) { should == 'custom build tool.exe' }
+      end
+
+      context 'when project or solution is specified' do
+        before {
+          allow(Finder).to receive(:new).and_call_original
+        }
+
+        subject {
+          described_class.new do |t|
+            t.project_or_solution = 'project.sln'
+          end
+        }
+
+        its(:project_or_solution) { should be_instance_of(Finder) }
+
+        it 'should set project or solution' do
+          expect(Finder).to have_received(:new).with('project.sln', subject, 'No projects or more than one project found.')
+        end
+      end
+    end
   end
 end

data/spec/rake/funnel/tasks/msdeploy_spec.rb

@@ -5,7 +5,6 @@ include Rake::Funnel::Support::MSDeploy
 
 describe Rake::Funnel::Tasks::MSDeploy do
   before {
-    CLEAN.clear
     Task.clear
   }
 
@@ -15,33 +14,11 @@ describe Rake::Funnel::Tasks::MSDeploy do
     its(:log_file) { should == 'msdeploy.log' }
     its(:args) { should == {} }
 
-    it 'should add the log file to the files to be cleaned' do
-      expect(CLEAN).to include(subject.log_file)
-    end
-  end
-
-  describe 'overriding defaults' do
     context 'when task name is specified' do
       it 'should have a default log file equal to the task name' do
         expect(described_class.new(:foo).log_file).to eq('foo.log')
       end
     end
-
-    context 'when task name and log file is specified' do
-      subject! {
-        described_class.new(:foo) do |t|
-          t.log_file = 'bar.log'
-        end
-      }
-
-      it 'should use custom log file' do
-        expect(subject.log_file).to eq('bar.log')
-      end
-
-      it 'should add the log file to the files to be cleaned' do
-        expect(CLEAN).to include(subject.log_file)
-      end
-    end
   end
 
   describe 'execution' do

data/spec/rake/funnel/tasks/nunit_spec.rb

@@ -15,18 +15,6 @@ describe Rake::Funnel::Tasks::NUnit do
     its(:files) { should == %w(build/specs/**/*.dll build/specs/**/*.exe) }
   end
 
-  describe 'overriding defaults' do
-    context 'when NUnit executable is specified' do
-      subject {
-        described_class.new do |t|
-          t.nunit = 'custom nunit.exe'
-        end
-      }
-
-      its(:nunit) { should == 'custom nunit.exe' }
-    end
-  end
-
   describe 'execution' do
     let(:args) { {} }
 
@@ -40,7 +28,7 @@ describe Rake::Funnel::Tasks::NUnit do
       allow(Finder).to receive(:new).and_return(finder)
       allow(NUnitPlugin).to receive(:setup)
 
-      allow(Mono).to receive(:invocation).and_wrap_original do |original_method, *args, &block|
+      allow(Mono).to receive(:invocation).and_wrap_original do |_original_method, *args, &_block|
         args.compact
       end
     }
@@ -72,5 +60,15 @@ describe Rake::Funnel::Tasks::NUnit do
     it 'should run with sh' do
       expect(subject).to have_received(:sh)
     end
+
+    context 'with custom NUnit executable' do
+      subject {
+        described_class.new do |t|
+          t.nunit = 'custom nunit.exe'
+        end
+      }
+
+      its(:nunit) { should == 'custom nunit.exe' }
+    end
   end
 end

data/spec/rake/funnel/tasks/paket_spec.rb

@@ -14,57 +14,15 @@ describe Rake::Funnel::Tasks::Paket do
     its(:bootstrapper_args) { should == nil }
   end
 
-  describe 'overriding defaults' do
-    context 'when bootstrapper executable is specified' do
-      subject {
-        described_class.new do |t|
-          t.bootstrapper = 'custom bootstrapper.exe'
-        end
-      }
-
-      its(:bootstrapper) { should == 'custom bootstrapper.exe' }
-    end
-
-    context 'when bootstrapper args are specified' do
-      subject {
-        described_class.new do |t|
-          t.bootstrapper_args = %w(arg1 arg2)
-        end
-      }
-
-      its(:bootstrapper_args) { should == %w(arg1 arg2) }
-    end
-
-    context 'when paket executable is specified' do
-      subject {
-        described_class.new do |t|
-          t.paket = 'custom paket.exe'
-        end
-      }
-
-      its(:paket) { should == 'custom paket.exe' }
-    end
-
-    context 'when paket args are specified' do
-      subject {
-        described_class.new do |t|
-          t.paket_args = %w(arg1 arg2)
-        end
-      }
-
-      its(:paket_args) { should == %w(arg1 arg2) }
-    end
-  end
-
   describe 'execution' do
     before {
       allow(subject).to receive(:sh)
-      allow(Mono).to receive(:invocation).and_wrap_original do |original_method, *args, &block|
+      allow(Mono).to receive(:invocation).and_wrap_original do |_original_method, *args, &_block|
         args.compact
       end
     }
 
-    context 'with overridden defaults' do
+    context 'overriding defaults' do
       subject {
         described_class.new do |t|
           t.bootstrapper = 'custom bootstrapper.exe'
@@ -75,7 +33,7 @@ describe Rake::Funnel::Tasks::Paket do
       }
 
       before {
-        allow(File).to receive(:exist?).with(subject.paket).and_return(false)
+        allow(File).to receive(:exist?).and_return(false)
         allow(subject).to receive(:sh)
       }
 

data/spec/rake/funnel/tasks/quick_template_spec.rb

@@ -5,7 +5,6 @@ include Rake::Funnel::Support
 
 describe Rake::Funnel::Tasks::QuickTemplate do
   before {
-    CLEAN.clear
     Task.clear
   }
 
@@ -13,32 +12,6 @@ describe Rake::Funnel::Tasks::QuickTemplate do
     its(:name) { should == :template }
     its(:search_pattern) { should eq(%w(**/*.erb)) }
     its(:context) { should kind_of?(Binding) }
-
-    describe 'target files are cleaned' do
-      let(:templates) { [] }
-      let(:finder) { double(Finder).as_null_object }
-
-      before {
-        allow(finder).to receive(:all_or_default).and_return(templates)
-        allow(Finder).to receive(:new).and_return(finder)
-      }
-
-      subject! { described_class.new }
-
-      context 'no templates found' do
-        it 'should not add the target files' do
-          expect(CLEAN).to be_empty
-        end
-      end
-
-      context 'templates found' do
-        let(:templates) { %w(1.template foo/2.template bar/3.some_other_extension) }
-
-        it 'should add the target files' do
-          expect(CLEAN).to match_array(%w(1 foo/2 bar/3))
-        end
-      end
-    end
   end
 
   describe 'execution' do

data/spec/rake/funnel/tasks/side_by_side_specs_spec.rb

@@ -2,7 +2,6 @@ require 'tmpdir'
 
 include Rake
 include Rake::Funnel::Support
-include Rake::Funnel::Support::SideBySideSpecs
 
 describe Rake::Funnel::Tasks::SideBySideSpecs do
   before {
@@ -28,7 +27,7 @@ describe Rake::Funnel::Tasks::SideBySideSpecs do
     }
 
     before {
-      allow(Remover).to receive(:remove)
+      allow(SpecsRemover).to receive(:remove)
     }
 
     before {
@@ -39,7 +38,7 @@ describe Rake::Funnel::Tasks::SideBySideSpecs do
       let(:enabled) { true }
 
       it 'should use remover' do
-        expect(Remover).to have_received(:remove)
+        expect(SpecsRemover).to have_received(:remove)
             .with({
                 projects: subject.projects,
                 references: subject.references,
@@ -52,7 +51,7 @@ describe Rake::Funnel::Tasks::SideBySideSpecs do
       let(:enabled) { false }
 
       it 'should do nothing' do
-        expect(Remover).not_to have_received(:remove)
+        expect(SpecsRemover).not_to have_received(:remove)
       end
     end
   end