rake-delphi 0.0.4 → 0.0.5

data/test/resources/testproject/testproject.xe5.dproj

@@ -0,0 +1,179 @@
+<Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+    <PropertyGroup>
+        <ProjectGuid>{A045E9FA-AB18-4219-936D-16A329020CB9}</ProjectGuid>
+        <ProjectVersion>15.1</ProjectVersion>
+        <FrameworkType>None</FrameworkType>
+        <MainSource>Project1.dpr</MainSource>
+        <Base>True</Base>
+        <Config Condition="'$(Config)'==''">Debug</Config>
+        <Platform Condition="'$(Platform)'==''">Win32</Platform>
+        <TargetedPlatforms>1</TargetedPlatforms>
+        <AppType>Console</AppType>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Config)'=='Base' or '$(Base)'!=''">
+        <Base>true</Base>
+    </PropertyGroup>
+    <PropertyGroup Condition="('$(Platform)'=='Android' and '$(Base)'=='true') or '$(Base_Android)'!=''">
+        <Base_Android>true</Base_Android>
+        <CfgParent>Base</CfgParent>
+        <Base>true</Base>
+    </PropertyGroup>
+    <PropertyGroup Condition="('$(Platform)'=='Win32' and '$(Base)'=='true') or '$(Base_Win32)'!=''">
+        <Base_Win32>true</Base_Win32>
+        <CfgParent>Base</CfgParent>
+        <Base>true</Base>
+    </PropertyGroup>
+    <PropertyGroup Condition="('$(Platform)'=='Win64' and '$(Base)'=='true') or '$(Base_Win64)'!=''">
+        <Base_Win64>true</Base_Win64>
+        <CfgParent>Base</CfgParent>
+        <Base>true</Base>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Config)'=='Debug' or '$(Cfg_1)'!=''">
+        <Cfg_1>true</Cfg_1>
+        <CfgParent>Base</CfgParent>
+        <Base>true</Base>
+    </PropertyGroup>
+    <PropertyGroup Condition="('$(Platform)'=='Win32' and '$(Cfg_1)'=='true') or '$(Cfg_1_Win32)'!=''">
+        <Cfg_1_Win32>true</Cfg_1_Win32>
+        <CfgParent>Cfg_1</CfgParent>
+        <Cfg_1>true</Cfg_1>
+        <Base>true</Base>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Config)'=='Release' or '$(Cfg_2)'!=''">
+        <Cfg_2>true</Cfg_2>
+        <CfgParent>Base</CfgParent>
+        <Base>true</Base>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Base)'!=''">
+        <DCC_Namespace>System;Xml;Data;Datasnap;Web;Soap;$(DCC_Namespace)</DCC_Namespace>
+        <DCC_DcuOutput>.\$(Platform)\$(Config)</DCC_DcuOutput>
+        <DCC_ExeOutput>.\$(Platform)\$(Config)</DCC_ExeOutput>
+        <DCC_E>false</DCC_E>
+        <DCC_N>false</DCC_N>
+        <DCC_S>false</DCC_S>
+        <DCC_F>false</DCC_F>
+        <DCC_K>false</DCC_K>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Base_Android)'!=''">
+        <DCC_UsePackage>FireDACSqliteDriver;bindcompfmx;DBXSqliteDriver;fmx;rtl;dbrtl;DbxClientDriver;IndySystem;FireDACCommon;bindcomp;DBXInterBaseDriver;DataSnapClient;DataSnapCommon;DataSnapProviderClient;xmlrtl;ibxpress;DbxCommonDriver;IndyProtocols;dbxcds;FireDACCommonDriver;bindengine;soaprtl;bindcompdbx;FMXTee;fmxFireDAC;CustomIPTransport;FireDAC;dsnap;IndyCore;FireDACDataSnapDriver;IndyIPCommon;CloudService;FireDACIBDriver;inet;FireDACDBXDriver;FmxTeeUI;RESTComponents;dbexpress;IndyIPClient;$(DCC_UsePackage)</DCC_UsePackage>
+        <Android_LauncherIcon72>$(BDS)\bin\Artwork\Android\FM_LauncherIcon_72x72.png</Android_LauncherIcon72>
+        <Android_LauncherIcon36>$(BDS)\bin\Artwork\Android\FM_LauncherIcon_36x36.png</Android_LauncherIcon36>
+        <Android_LauncherIcon144>$(BDS)\bin\Artwork\Android\FM_LauncherIcon_144x144.png</Android_LauncherIcon144>
+        <Android_LauncherIcon48>$(BDS)\bin\Artwork\Android\FM_LauncherIcon_48x48.png</Android_LauncherIcon48>
+        <Android_LauncherIcon96>$(BDS)\bin\Artwork\Android\FM_LauncherIcon_96x96.png</Android_LauncherIcon96>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Base_Win32)'!=''">
+        <VerInfo_Locale>1033</VerInfo_Locale>
+        <DCC_Namespace>Winapi;System.Win;Data.Win;Datasnap.Win;Web.Win;Soap.Win;Xml.Win;Bde;$(DCC_Namespace)</DCC_Namespace>
+        <VerInfo_Keys>CompanyName=;FileDescription=;FileVersion=1.0.0.0;InternalName=;LegalCopyright=;LegalTrademarks=;OriginalFilename=;ProductName=;ProductVersion=1.0.0.0;Comments=</VerInfo_Keys>
+        <DCC_UsePackage>DataSnapIndy10ServerTransport;FireDACASADriver;FireDACSqliteDriver;bindcompfmx;DBXSqliteDriver;vcldbx;FireDACPgDriver;FireDACODBCDriver;fmx;rtl;dbrtl;DbxClientDriver;IndySystem;FireDACCommon;bindcomp;inetdb;TeeDB;vclib;inetdbbde;DBXInterBaseDriver;DataSnapClient;DataSnapCommon;DBXOdbcDriver;DataSnapServer;Tee;vclFireDAC;DataSnapProviderClient;xmlrtl;svnui;ibxpress;DbxCommonDriver;DBXSybaseASEDriver;vclimg;IndyProtocols;dbxcds;DBXMySQLDriver;DatasnapConnectorsFreePascal;FireDACCommonDriver;MetropolisUILiveTile;bindengine;vclactnband;vcldb;soaprtl;bindcompdbx;vcldsnap;bindcompvcl;FMXTee;TeeUI;vclie;fmxFireDAC;FireDACADSDriver;vcltouch;DBXDb2Driver;DBXOracleDriver;CustomIPTransport;vclribbon;VclSmp;FireDACMSSQLDriver;FireDAC;dsnap;Intraweb;fmxase;vcl;IndyCore;FireDACDataSnapDriver;IndyIPServer;IndyIPCommon;VCLRESTComponents;CloudService;dsnapcon;FireDACIBDriver;DBXFirebirdDriver;inet;DBXMSSQLDriver;fmxobj;FireDACDBXDriver;DBXInformixDriver;DataSnapConnectors;FireDACMySQLDriver;FmxTeeUI;vclx;CodeSiteExpressPkg;inetdbxpress;svn;DBXSybaseASADriver;FireDACOracleDriver;fmxdae;FireDACDb2Driver;RESTComponents;bdertl;FireDACMSAccDriver;adortl;dbexpress;IndyIPClient;$(DCC_UsePackage)</DCC_UsePackage>
+        <DCC_ConsoleTarget>true</DCC_ConsoleTarget>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Base_Win64)'!=''">
+        <DCC_ConsoleTarget>true</DCC_ConsoleTarget>
+        <DCC_UsePackage>DataSnapIndy10ServerTransport;FireDACASADriver;FireDACSqliteDriver;bindcompfmx;DBXSqliteDriver;FireDACPgDriver;FireDACODBCDriver;fmx;rtl;dbrtl;DbxClientDriver;IndySystem;FireDACCommon;bindcomp;inetdb;TeeDB;vclib;DBXInterBaseDriver;DataSnapClient;DataSnapCommon;DBXOdbcDriver;DataSnapServer;Tee;vclFireDAC;DataSnapProviderClient;xmlrtl;ibxpress;DbxCommonDriver;DBXSybaseASEDriver;vclimg;IndyProtocols;dbxcds;DBXMySQLDriver;DatasnapConnectorsFreePascal;FireDACCommonDriver;MetropolisUILiveTile;bindengine;vclactnband;vcldb;soaprtl;bindcompdbx;vcldsnap;bindcompvcl;FMXTee;TeeUI;vclie;fmxFireDAC;FireDACADSDriver;vcltouch;DBXDb2Driver;DBXOracleDriver;CustomIPTransport;vclribbon;VclSmp;FireDACMSSQLDriver;FireDAC;dsnap;Intraweb;fmxase;vcl;IndyCore;FireDACDataSnapDriver;IndyIPServer;IndyIPCommon;VCLRESTComponents;CloudService;dsnapcon;FireDACIBDriver;DBXFirebirdDriver;inet;DBXMSSQLDriver;fmxobj;FireDACDBXDriver;DBXInformixDriver;DataSnapConnectors;FireDACMySQLDriver;FmxTeeUI;vclx;inetdbxpress;DBXSybaseASADriver;FireDACOracleDriver;fmxdae;FireDACDb2Driver;RESTComponents;FireDACMSAccDriver;adortl;dbexpress;IndyIPClient;$(DCC_UsePackage)</DCC_UsePackage>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Cfg_1)'!=''">
+        <DCC_Define>DEBUG;$(DCC_Define)</DCC_Define>
+        <DCC_DebugDCUs>true</DCC_DebugDCUs>
+        <DCC_Optimize>false</DCC_Optimize>
+        <DCC_GenerateStackFrames>true</DCC_GenerateStackFrames>
+        <DCC_DebugInfoInExe>true</DCC_DebugInfoInExe>
+        <DCC_RemoteDebug>true</DCC_RemoteDebug>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Cfg_1_Win32)'!=''">
+        <DCC_RemoteDebug>false</DCC_RemoteDebug>
+    </PropertyGroup>
+    <PropertyGroup Condition="'$(Cfg_2)'!=''">
+        <DCC_LocalDebugSymbols>false</DCC_LocalDebugSymbols>
+        <DCC_Define>RELEASE;$(DCC_Define)</DCC_Define>
+        <DCC_SymbolReferenceInfo>0</DCC_SymbolReferenceInfo>
+        <DCC_DebugInformation>0</DCC_DebugInformation>
+    </PropertyGroup>
+    <ItemGroup>
+        <DelphiCompile Include="$(MainSource)">
+            <MainSource>MainSource</MainSource>
+        </DelphiCompile>
+        <BuildConfiguration Include="Release">
+            <Key>Cfg_2</Key>
+            <CfgParent>Base</CfgParent>
+        </BuildConfiguration>
+        <BuildConfiguration Include="Base">
+            <Key>Base</Key>
+        </BuildConfiguration>
+        <BuildConfiguration Include="Debug">
+            <Key>Cfg_1</Key>
+            <CfgParent>Base</CfgParent>
+        </BuildConfiguration>
+    </ItemGroup>
+    <ProjectExtensions>
+        <Borland.Personality>Delphi.Personality.12</Borland.Personality>
+        <Borland.ProjectType/>
+        <BorlandProject>
+            <Delphi.Personality>
+                <VersionInfo>
+                    <VersionInfo Name="IncludeVerInfo">False</VersionInfo>
+                    <VersionInfo Name="AutoIncBuild">False</VersionInfo>
+                    <VersionInfo Name="MajorVer">1</VersionInfo>
+                    <VersionInfo Name="MinorVer">0</VersionInfo>
+                    <VersionInfo Name="Release">0</VersionInfo>
+                    <VersionInfo Name="Build">0</VersionInfo>
+                    <VersionInfo Name="Debug">False</VersionInfo>
+                    <VersionInfo Name="PreRelease">False</VersionInfo>
+                    <VersionInfo Name="Special">False</VersionInfo>
+                    <VersionInfo Name="Private">False</VersionInfo>
+                    <VersionInfo Name="DLL">False</VersionInfo>
+                    <VersionInfo Name="Locale">1049</VersionInfo>
+                    <VersionInfo Name="CodePage">1251</VersionInfo>
+                </VersionInfo>
+                <VersionInfoKeys>
+                    <VersionInfoKeys Name="CompanyName">Rake</VersionInfoKeys>
+                    <VersionInfoKeys Name="FileDescription">Test rake-delphi project XE5 description</VersionInfoKeys>
+                    <VersionInfoKeys Name="FileVersion">4.3.2.1</VersionInfoKeys>
+                    <VersionInfoKeys Name="InternalName">testproject.exe</VersionInfoKeys>
+                    <VersionInfoKeys Name="LegalCopyright">Copyright. Копирайт</VersionInfoKeys>
+                    <VersionInfoKeys Name="LegalTrademarks">Trademark. Торговая марка</VersionInfoKeys>
+                    <VersionInfoKeys Name="OriginalFilename">testproject.exe</VersionInfoKeys>
+                    <VersionInfoKeys Name="ProductName">Test rake-delphi project XE5 product name</VersionInfoKeys>
+                    <VersionInfoKeys Name="ProductVersion">1.2.3.4</VersionInfoKeys>
+                    <VersionInfoKeys Name="Comments">Test project comment</VersionInfoKeys>
+                    <VersionInfoKeys Name="CFBundleName"/>
+                    <VersionInfoKeys Name="CFBundleDisplayName"/>
+                    <VersionInfoKeys Name="UIDeviceFamily"/>
+                    <VersionInfoKeys Name="CFBundleIdentifier"/>
+                    <VersionInfoKeys Name="CFBundleVersion"/>
+                    <VersionInfoKeys Name="CFBundlePackageType"/>
+                    <VersionInfoKeys Name="CFBundleSignature"/>
+                    <VersionInfoKeys Name="CFBundleAllowMixedLocalizations"/>
+                    <VersionInfoKeys Name="UISupportedInterfaceOrientations"/>
+                    <VersionInfoKeys Name="CFBundleExecutable"/>
+                    <VersionInfoKeys Name="CFBundleResourceSpecification"/>
+                    <VersionInfoKeys Name="LSRequiresIPhoneOS"/>
+                    <VersionInfoKeys Name="CFBundleInfoDictionaryVersion"/>
+                    <VersionInfoKeys Name="CFBundleDevelopmentRegion"/>
+                    <VersionInfoKeys Name="package"/>
+                    <VersionInfoKeys Name="label"/>
+                    <VersionInfoKeys Name="versionCode"/>
+                    <VersionInfoKeys Name="versionName"/>
+                    <VersionInfoKeys Name="persistent"/>
+                    <VersionInfoKeys Name="restoreAnyVersion"/>
+                    <VersionInfoKeys Name="installLocation"/>
+                    <VersionInfoKeys Name="largeHeap"/>
+                    <VersionInfoKeys Name="theme"/>
+                </VersionInfoKeys>
+                <Source>
+                    <Source Name="MainSource">Project1.dpr</Source>
+                </Source>
+            </Delphi.Personality>
+            <Deployment/>
+            <Platforms>
+                <Platform value="Android">False</Platform>
+                <Platform value="Win32">True</Platform>
+                <Platform value="Win64">False</Platform>
+            </Platforms>
+        </BorlandProject>
+        <ProjectFileVersion>12</ProjectFileVersion>
+    </ProjectExtensions>
+    <Import Project="$(BDS)\Bin\CodeGear.Delphi.Targets" Condition="Exists('$(BDS)\Bin\CodeGear.Delphi.Targets')"/>
+    <Import Project="$(APPDATA)\Embarcadero\$(BDSAPPDATABASEDIR)\$(PRODUCTVERSION)\UserTools.proj" Condition="Exists('$(APPDATA)\Embarcadero\$(BDSAPPDATABASEDIR)\$(PRODUCTVERSION)\UserTools.proj')"/>
+</Project>

data/test/test-delphi.rb

@@ -8,10 +8,11 @@ require 'rake/delphi/project'
 require 'rake/delphi/tool'
 require 'rake/helpers/unittest'
 require 'helpers/consts'
+require 'helpers/verinfo'
 
 module DelphiTests
 
-class TestDelphi <  Test::Unit::TestCase
+class TestDelphi < TestVerInfo
 private
     def reenable_tasks(task)
         return unless task.class <= Rake::Task
@@ -52,15 +53,18 @@ private
     end
 
     def exe
-        exe = PROJECT_EXE % name.gsub(/[():]/, '_')
+        return PROJECT_EXE % name.gsub(/[():]/, '_')
     end
+
 public
     def setup
+        Rake::Delphi::Dcc32Tool.reinit
+        ENV['DELPHI_DIR'] = nil
+        super
         ENV['RAKE_DIR'] = PROJECT_PATH
         File.unlink(exe) if File.exists?(exe)
         res = PROJECT_PATH + '/resources.res'
         File.unlink(res) if File.exists?(res)
-#        assert(! File.exists?(exe), 'File %s exists' % exe)
         require PROJECT_PATH + '/Rakefile.rb'
     end
 
@@ -109,6 +113,18 @@ public
             'testproject works-=CONFIG=-')
     end
 
+    def test_compile_use_absent_config
+        RakeFileUtils.verbose(Rake::Delphi::Logger.debug?) do
+            mv PROJECT_PATH.pathmap('%p%s%f.cfg'), PROJECT_PATH.pathmap('%p%s%f.absent.cfg')
+            begin
+                _test_compile_and_output({:usecfg => true},
+                    'testproject works')
+            ensure
+                mv PROJECT_PATH.pathmap('%p%s%f.absent.cfg'), PROJECT_PATH.pathmap('%p%s%f.cfg')
+            end
+        end
+    end
+
     def test_compile_use_library_path
         # usually Indy components are in Delphi library paths
         _test_compile_and_output({:defines => 'INDY', :uselibrarypath => true},
@@ -146,7 +162,19 @@ public
     end
 end
 
-class TestRCResourceCompiler <  Test::Unit::TestCase
+# extend Rake::Delphi::RCResourceCompiler with .delphidir method
+# (just for tests)
+module Rake::Delphi
+
+class RCResourceCompiler
+    def delphidir
+        @@delphidir
+    end
+end
+
+end
+
+class TestRCResourceCompiler < Test::Unit::TestCase
 private
 public
     def setup
@@ -163,4 +191,4 @@ public
     end
 end
 
-end
+end

data/test/test-envvariables.rb

@@ -0,0 +1,23 @@
+# encoding: utf-8
+
+require 'rake'
+require 'test/unit'
+require 'rake/delphi/envvariables'
+require 'rake/helpers/unittest'
+
+class TestEnvVariables < Test::Unit::TestCase
+
+    def setup
+        ENV['BDS_PLATFORM'] = 'BDS platform'
+        ENV['BDS_PLATFORM_CASE'] = 'BDS platform case'
+    end
+
+    def test_expands
+        env_vars = Rake::Delphi::EnvVariables.new(nil, 'c:/delphi directory/')
+        assert_equal('c:/delphi directory', env_vars['BDS'])
+        assert_equal('c:/delphi directory/Lib', env_vars['BDSLIB'])
+        assert_equal('Platform: BDS platform', env_vars.expand('Platform: $(BDS_PLATFORM)'))
+        assert_equal('Platform: BDS platform case', env_vars.expand('Platform: $(bds_platform_case)'))
+        assert_equal('Env: $(BDS_NON_EXISTANT)', env_vars.expand('Env: $(BDS_NON_EXISTANT)'))
+    end
+end

data/test/test-git.rb

@@ -15,8 +15,8 @@ private
         Rake::Delphi::ChDir.new(@rake_task, @test_git_dir) do
             `rm -rf .git *`
             `git init .`
-            `git config --global user.email "git@test.ru"`
-            `git config --global user.name "Git test"`
+            `git config user.email "git@test.ru"`
+            `git config user.name "Git test"`
             `echo file content > file.txt`
             `git add file.txt`
             `git commit -m "first commit"`

data/test/test-hashes.rb

@@ -1,7 +1,6 @@
 # encoding: utf-8
 
 require 'rake'
-require 'fileutils'
 require 'test/unit'
 require 'rake/common/hashtask'
 require 'rake/helpers/unittest'

data/test/test-projectinfo.rb

@@ -7,6 +7,7 @@ require 'rake/delphi/projectinfo'
 require 'rake/delphi/dcc32'
 require 'rake/helpers/unittest'
 require 'helpers/consts'
+require 'helpers/verinfo'
 
 module Rake
     module Delphi
@@ -21,27 +22,37 @@ end
 
 module DelphiTests
 
-class TestBDSVersionInfo <  Test::Unit::TestCase
+class TestBDSVersionInfo < TestVerInfo
 private
     def version
-        2006
+        '2006'
+    end
+protected
+    def delphi_version
+        return '10'
+    end
+
+    def do_getinfo
+        @info = Rake::Delphi::BDSVersionInfo.new(@rake_task)
     end
 public
     def setup
+        super
         @rake_task = Rake::Delphi::Dcc32Task.new('some-task-' + name, Rake.application)
         @rake_task.systempath = PROJECT_PATH + '/testproject.dpr'
-        @info = Rake::Delphi::BDSVersionInfo.new(@rake_task)
+        do_getinfo
     end
 
     def test_info
+        return unless prepare_ver_info_file?
         assert_equal '4.3.2.1', @info['FileVersion']
         assert_equal 'Rake', @info['CompanyName']
-        assert_equal 'Test rake-delphi project %d description' % version, @info['FileDescription']
+        assert_equal 'Test rake-delphi project %s description' % version, @info['FileDescription']
         assert_equal 'testproject.exe', @info['InternalName']
         assert_equal 'Copyright. ��������', @info['LegalCopyright']
         assert_equal 'Trademark. �������� �����', @info['LegalTrademarks']
         assert_equal 'testproject.exe', @info['OriginalFilename']
-        assert_equal 'Test rake-delphi project %d product name' % version, @info['ProductName']
+        assert_equal 'Test rake-delphi project %s product name' % version, @info['ProductName']
         assert_equal '1.2.3.4', @info['ProductVersion']
         assert_equal 'Test project comment', @info['Comments']
     end
@@ -50,17 +61,86 @@ end
 class TestRAD2007VersionInfo < TestBDSVersionInfo
 private
     def version
-        2007
+        '2007'
+    end
+protected
+    def do_getinfo
+        @info = Rake::Delphi::RAD2007VersionInfo.new(@rake_task)
+    end
+
+    def delphi_version
+        return '11'
     end
 public
-    def setup
+    def test_info
         super
-        @info = Rake::Delphi::RAD2007VersionInfo.new(@rake_task)
+    end
+end
+
+class TestRAD2010VersionInfo < TestBDSVersionInfo
+private
+    def version
+        '2010'
+    end
+protected
+    def do_getinfo
+        @info = Rake::Delphi::RAD2010VersionInfo.new(@rake_task)
+    end
+
+    def delphi_version
+        return '13'
+    end
+public
+    def test_info
+        super
+    end
+end
+
+class TestXEVersionInfo < TestBDSVersionInfo
+private
+    def version
+        'XE5'
+    end
+protected
+    def delphi_version
+        return '18'
     end
 
+    def do_getinfo
+        @info = Rake::Delphi::XEVersionInfo.new(@rake_task)
+    end
+public
     def test_info
         super
     end
 end
 
-end
+class TestBDSVersionInfoAbsent < TestBDSVersionInfo
+protected
+    def prepare_ver_info_file?
+        return false
+    end
+end
+
+class TestRAD2007VersionInfoAbsent < TestRAD2007VersionInfo
+protected
+    def prepare_ver_info_file?
+        return false
+    end
+end
+
+class TestRAD2010VersionInfoAbsent < TestRAD2010VersionInfo
+protected
+    def prepare_ver_info_file?
+        return false
+    end
+end
+
+class TestXEVersionInfoAbsent < TestBDSVersionInfo
+protected
+    def prepare_ver_info_file?
+        return false
+    end
+end
+
+end

data/test/test-zip.rb

@@ -14,14 +14,6 @@ public
         File.unlink(@zip) if File.exists?(@zip)
     end
 
-    def test_zip_no_task
-        assert_raise NoMethodError do
-            # first argument must be a Rake::Task
-            # "undefined method `application' for nil:NilClass" must be raised
-            Rake::Delphi::ZipTask.new(nil, nil, nil)
-        end
-    end
-
     def test_zip_no_filename
         assert_raise RuntimeError do
             # second argument must be non-empty