rake-commander 0.4.1 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fced681b17be5244fd8cf23294e246e060d7d52daba92a11f84e396d3f0c2ec4
-  data.tar.gz: b7937192c15dab0e9acf907ee4d7dacc505de9724967b96064881a30be2c5f6e
+  metadata.gz: df772a60961a47e57f4904ffd9b813add5a6d4477a07834eb4f177fb25eb536a
+  data.tar.gz: 2a7225798390df7f5ed428092803e3e3d4facf31900bc9085f8cdda2b61122fd
 SHA512:
-  metadata.gz: 2c36cf00c0dc4afa116e548e7e643b39a7f64f38f64990c9b8f7c11b2dca340979de9f0b6a9d53c532fa041898182dcc4a1c634ba2eedf874515c4257091a999
-  data.tar.gz: cecf9b603645401cf14e38d4745be6d6619f505adf3cbf1f2f482f4901d220e45539b434bcf75d99d61e6bb460c22594d7eb52e3da15312ebcd85fd4c46d94fd
+  metadata.gz: 45e87f2067c2370748eb96d9929d133b8ccacdf724c100823cbf6a6a3374ad53b106f7d04742a0aee1e3bd6700668d49d0dc89285536b482c42fa580c788abbf
+  data.tar.gz: 907efaa1b66452cd63c43f36176a07462b0a7f4061196567aaa8b75fe572db0bf230245900488722b8acc39f7084b1abd968533e048607e15e6898ffe7ef935f

data/.gitignore

@@ -10,6 +10,8 @@ Gemfile.lock
 # build artifacts
 *.gem
 /.bundle/
+/.vscode
+.solargraph.yml
 /vendor/bundle
 /spec/reports/
 /tmp/

data/.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 3.2.2
+  TargetRubyVersion: 3.2
   NewCops: enable
 
 Metrics/ClassLength:

data/CHANGELOG.md

@@ -31,7 +31,27 @@ All notable changes to this project will be documented in this file.
   - Example: `on_options(:t, :s, present: true) {|options| do-stuff}` <- block to be called only when the option `:t` and `:s` are both present in the parsed `options` result.
   - Once this has been done,  think about it being a hash-alike object with methods for the option names (i.e. `options.debug?`)
 
-## [0.4.1] - 2025-02-xx
+## [0.4.4] - 2026-04-xx
+
+### Added
+
+### Fixed
+
+### Changed
+
+## [0.4.3] - 2026-04-15
+
+### Fixed
+
+- Option block wasn't correctly handling `value`.
+
+## [0.4.2] - 2025-02-25
+
+### Fixed
+
+- `Option#type_coercion` should be dupped on inheritance.
+
+## [0.4.1] - 2025-02-20
 
 ### Added
 

data/lib/rake-commander/base/class_inheritable.rb

@@ -15,11 +15,14 @@ class RakeCommander
         attrs = attrs.map(&:to_sym)
         inheritable_class_var(*attrs, deep_dup: deep_dup, &block)
         return unless add_accessors
+
         attrs.each do |attr|
           class_eval <<-RUBY, __FILE__, __LINE__ + 1
-            class << self; attr_accessor :#{attr} end
+            # class << self; attr_accessor :class_var; end
+            class << self; attr_accessor :#{attr}; end
           RUBY
         end
+
         self
       end
 
@@ -35,7 +38,8 @@ class RakeCommander
       #   that should NOT be inheritable.
       def attr_not_inheritable(*attrs)
         attrs.each do |attr|
-          next unless method = inheritable_class_var_method(attr)
+          next unless (method = inheritable_class_var_method(attr))
+
           inheritable_class_var[method].delete(attr)
         end
         self
@@ -86,6 +90,7 @@ class RakeCommander
         }.tap do |hash|
           hash[:deep_dup][:inheritable_class_var] = :default
         end
+
         @inheritable_class_var.tap do |_methods|
           vars.each {|var| inheritable_class_var_add(var, deep_dup: deep_dup, &block)}
         end
@@ -97,7 +102,9 @@ class RakeCommander
         # Remove previous definition if present
         attr_not_inheritable(var)
         method = deep_dup || block ? :deep_dup : :mirror
+
         inheritable_class_var[method][var] = block || :default
+
         self
       end
 

data/lib/rake-commander/base/object_helpers.rb

@@ -20,21 +20,26 @@ class RakeCommander
         return yield(value)   if block_given?
         return value          unless dup_objects
         return value.deep_dup if value.respond_to?(:deep_dup)
+
         value.dup
       end
 
       # Custom Hash#deep_dup for rake commander
       def custom_hash_deep_dup(original, dup_objects: true, &dup_block)
         raise ArgumentError, "Expecting Hash. Given: #{original.class}" unless original.is_a?(Hash)
+
         hash = original.dup
+
         original.each_pair do |key, value|
           unless key.frozen? && key.is_a?(::String)
             hash.delete(key)
             key = custom_deep_dup(key, dup_objects: dup_objects, &dup_block) if dup_objects
           end
-          value     = dup_objects ? custom_deep_dup(value, dup_objects: dup_objects, &dup_block) : value
+
+          value     = custom_deep_dup(value, dup_objects: dup_objects, &dup_block) if dup_objects
           hash[key] = value
         end
+
         hash
       end
     end

data/lib/rake-commander/option.rb

@@ -152,11 +152,11 @@ class RakeCommander
       {}.tap do |kargs|
         configure_other
 
-        kargs.merge!(short:    short.dup.freeze)      if short
-        kargs.merge!(name:     name_full.dup.freeze)  if name_full
-        kargs.merge!(desc:     @desc.dup)             if @desc
-        kargs.merge!(default:  @default.dup)          if default?
-        kargs.merge!(type:     @type_coercion)        if allowed_type?(@type_coercion)
+        kargs.merge!(short:    short.dup.freeze)     if short
+        kargs.merge!(name:     name_full.dup.freeze) if name_full
+        kargs.merge!(desc:     @desc.dup)            if @desc
+        kargs.merge!(default:  @default.dup)         if default?
+        kargs.merge!(type:     dupped_type)          if allowed_type?(@type_coercion)
         kargs.merge!(required: required?)
       end
     end
@@ -178,12 +178,10 @@ class RakeCommander
       block_extra_args = [default, short, name, self]
 
       proc do |value|
-        value = !value if type_coercion == FalseClass
-        args  = block_extra_args.dup.unshift(value)
-
-        original_block&.call(*args)
-
-        middleware&.call(*args)
+        value = !value                                        if type_coercion == FalseClass
+        value = original_block.call(value, *block_extra_args) if original_block
+        value = middleware.call(value, *block_extra_args)     if middleware
+        value
       end
     end
 
@@ -282,5 +280,17 @@ class RakeCommander
     def fetch_desc_from_other(original = nil)
       joined_lines(original, fetch_desc!(other_args))
     end
+
+    def dupped_type
+      return @type_coercion if @type_coercion.is_a?(Class)
+      return @type_coercion unless @type_coercion.is_a?(Array)
+
+      @type_coercion.map do |value|
+        next value if value.is_a?(Class)
+        next value unless value.respond_to?(:dup)
+
+        value.dup
+      end
+    end
   end
 end

data/lib/rake-commander/options/arguments.rb

@@ -3,8 +3,8 @@ class RakeCommander
     # Offers helpers to treat `ARGV`
     module Arguments
       RAKE_COMMAND_EXTENDED_OPTIONS_START = '--'.freeze
-      NAME_ARGUMENT    = /^--(?<option>[\w_-]*).*?$/
-      BOOLEAN_ARGUMENT = /(?:^|--)no-(?<option>[\w_-]*).*?$/
+      NAME_ARGUMENT    = /^--(?<option>[\w-]*).*?$/ # \w already has _
+      BOOLEAN_ARGUMENT = /(?:^|--)no-(?<option>[\w-]*).*?$/
 
       class << self
         def included(base)
@@ -237,7 +237,7 @@ class RakeCommander
           argv.each_with_object([]) do |arg, out|
             if single_hyphen?(arg) # short option(s)
               options = arg.match(SINGLE_HYPHEN_REGEX)[:options]
-              options.split('').each do |short|
+              options.split('').each do |short| # rubocop:disable Style/StringChars
                 out << short_sym(short)
               end
             elsif double_hyphen?(arg) # name option

data/lib/rake-commander/options/result.rb

@@ -34,7 +34,12 @@ class RakeCommander
         # @param results [Hash] with `short` option as `key` and final value as `value`.
         # @see `RakeCommander::Options#parse_options`
         def parse_options(argv = ARGV, results: {}, leftovers: [], &middleware)
-          leftovers.push(*super(argv, &results_collector(results, &middleware)))
+          leftovers.push(
+            *super(
+              argv,
+              &results_collector(results, &middleware)
+            )
+          )
         end
 
         # **Extend** method to ensure options are parsed before calling task.

data/lib/rake-commander/version.rb

@@ -1,3 +1,3 @@
 class RakeCommander
-  VERSION = '0.4.1'.freeze
+  VERSION = '0.4.3'.freeze
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: rake-commander
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.3
 platform: ruby
 authors:
 - Oscar Segura Samper
-autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-02-20 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dotenv
@@ -124,7 +123,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '14'
-description:
 email:
 - oscar@ecoportal.co.nz
 executables: []
@@ -191,7 +189,6 @@ licenses:
 - MIT
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -206,8 +203,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.23
-signing_key:
+rubygems_version: 4.0.8
 specification_version: 4
 summary: Classing rake tasks with options. Creating re-usable tasks, options and samples
   thereof.