rake-builder 0.9.2 → 0.10.1

data/spec/unit/rake/builder/local_config_spec.rb

@@ -2,9 +2,9 @@ require 'spec_helper'
 
 describe Rake::Builder::LocalConfig do
   let(:local_config_file) { 'local_config' }
-  let(:include_paths) { ['/foo/bar'] }
-  let(:compilation_options) { ['foo', 'bar'] }
-  let(:config_data) do
+  let(:include_paths) { [] }
+  let(:compilation_options) { [] }
+  let(:good_config_data) do
     {
       :rake_builder => {
         :config_file => {:version => '1.1'},
@@ -14,27 +14,28 @@ describe Rake::Builder::LocalConfig do
     }
   end
   let(:bad_config_data) do
-    config_data[:rake_builder][:config_file][:version] = '0.1'
-    config_data
+    config = good_config_data.clone
+    config[:rake_builder][:config_file][:version] = '0.1'
+    config
   end
+  let(:config_data) { good_config_data }
 
-  before { YAML.stub(:load_file).and_return(config_data) }
+  before { allow(YAML).to receive(:load_file) { config_data } }
 
-  subject { Rake::Builder::LocalConfig.new(local_config_file) }
+  subject { described_class.new(local_config_file) }
 
   context '#load' do
-    it 'loads the file' do
-      YAML.should_receive(:load_file).and_return(config_data)
+    let(:include_paths) { ['/foo/bar'] }
+    let(:compilation_options) { ['foo', 'bar'] }
 
-      subject.load
-    end
-
-    it 'fails if the version is not recognized' do
-      YAML.should_receive(:load_file).and_return(bad_config_data)
+    context 'if the version is not recognized' do
+      let(:config_data) { bad_config_data }
 
-      expect {
-        subject.load
-      }.to raise_error(Rake::Builder::Error, /version incorrect/)
+      it 'fails' do
+        expect {
+          subject.load
+        }.to raise_error(Rake::Builder::Error, /version incorrect/)
+      end
     end
 
     it 'sets the include_paths' do
@@ -51,29 +52,17 @@ describe Rake::Builder::LocalConfig do
   end
 
   context '#save' do
-    let(:file) { stub('File') }
+    let(:file) { double(File, write: nil) }
+    let(:data) { config_data.to_yaml }
 
     before do
-      File.stub(:open).with(local_config_file, 'w') do |&block|
-        block.call file
-      end
+      allow(File).to receive(:open).with(local_config_file, 'w').and_yield(file)
     end
 
-    it 'write to the file' do
-      File.should_receive(:open).with(local_config_file, 'w') {}
-
+    it 'writes to the file' do
       subject.save
-    end
 
-    it 'saves the data' do
-      expected = {
-        :rake_builder        => {:config_file => {:version => '1.1'}},
-        :include_paths       => [],
-        :compilation_options => []
-      }.to_yaml
-      file.should_receive(:write).with(expected)
-
-      subject.save
+      expect(file).to have_received(:write).with(data)
     end
   end
 end

data/spec/unit/rake/builder/presenters/makefile/builder_presenter_spec.rb

@@ -46,9 +46,9 @@ describe Rake::Builder::Presenters::Makefile::BuilderPresenter do
     )
   end
   
-  let(:executable_builder) { stub('Rake::Builder', executable_attributes) }
-  let(:static_library_builder) { stub('Rake::Builder', static_library_attributes) }
-  let(:shared_library_builder) { stub('Rake::Builder', shared_library_attributes) }
+  let(:executable_builder) { double(Rake::Builder, executable_attributes) }
+  let(:static_library_builder) { double('Rake::Builder', static_library_attributes) }
+  let(:shared_library_builder) { double('Rake::Builder', shared_library_attributes) }
 
   let(:executable_subject) { Rake::Builder::Presenters::Makefile::BuilderPresenter.new(executable_builder) }
   let(:static_library_subject) { Rake::Builder::Presenters::Makefile::BuilderPresenter.new(static_library_builder) }
@@ -66,12 +66,20 @@ describe Rake::Builder::Presenters::Makefile::BuilderPresenter do
   end
 
   context '#to_s' do
-    it 'fails with unknown target types' do
-      executable_builder.should_receive(:target_type).any_number_of_times.and_return(:foo)
+    context 'with unknown target types' do
+      let(:executable_attributes) do
+        common_attributes.merge(
+          :target => executable_target,
+          :target_type => :foo,
+        )
+      end
+
+      it 'fails' do
+        expect {
+          Rake::Builder::Presenters::Makefile::BuilderPresenter.new(executable_builder)
+        }.to raise_error(RuntimeError, /Unknown.*?target type/)
+      end
 
-      expect {
-        Rake::Builder::Presenters::Makefile::BuilderPresenter.new(executable_builder)
-      }.to raise_error(RuntimeError, /Unknown.*?target type/)
     end
 
     context 'target' do
@@ -142,21 +150,16 @@ EOT
   end
 
   context '#save' do
-    it 'creates the makefile' do
-      File.should_receive(:open).with(makefile_name, 'w')
+    let(:file) { double(File, write: nil) }
 
-      executable_subject.save
+    before do
+      allow(File).to receive(:open).with(makefile_name, 'w').and_yield(file)
     end
 
-    it 'saves' do
-      file = stub('File')
-      File.stub(:open).with(makefile_name, 'w') do |&block|
-        block.call file
-      end
-
-      file.should_receive(:write).with(/COMPILER.*?= the_compiler/)
-
+    it 'saves a makefile' do
       executable_subject.save
+
+      expect(file).to have_received(:write).with(/COMPILER.*?= the_compiler/)
     end
   end
 end

data/spec/unit/rake/builder/presenters/makefile_am/builder_collection_presenter_spec.rb

@@ -5,26 +5,22 @@ describe Rake::Builder::Presenters::MakefileAm::BuilderCollectionPresenter do
     it 'takes one parameter' do
       expect {
         Rake::Builder::Presenters::MakefileAm::BuilderCollectionPresenter.new
-      }.to raise_error(ArgumentError, 'wrong number of arguments (0 for 1)')
+      }.to raise_error(ArgumentError, /wrong number of arguments/)
     end
   end
 
   context '#to_s' do
-    let(:program_builder) { stub('Rake::Builder', :label => 'the_program', :target_path => 'the_program', :is_library? => false) }
-    let(:library_builder) { stub('Rake::Builder', :label => 'the_library', :target_path => 'the_library', :is_library? => true) }
+    let(:program_builder) { double(Rake::Builder, :label => 'the_program', :target_path => 'the_program', :is_library? => false) }
+    let(:library_builder) { double(Rake::Builder, :label => 'the_library', :target_path => 'the_library', :is_library? => true) }
     let(:builders) { [program_builder, library_builder] }
 
-    subject { Rake::Builder::Presenters::MakefileAm::BuilderCollectionPresenter.new(builders) }
+    subject { described_class.new(builders) }
 
     before do
-      Rake::Builder::Presenters::MakefileAm::BuilderPresenter.
-        stub(:new).
-        with(program_builder).
-        and_return("AAA\nBBB\n")
-      Rake::Builder::Presenters::MakefileAm::BuilderPresenter.
-        stub(:new).
-        with(library_builder).
-        and_return("XXX\nYYY\n")
+      allow(Rake::Builder::Presenters::MakefileAm::BuilderPresenter)
+        .to receive(:new).with(program_builder) { "AAA\nBBB\n" }
+      allow(Rake::Builder::Presenters::MakefileAm::BuilderPresenter)
+        .to receive(:new). with(library_builder) { "XXX\nYYY\n" }
     end
 
     it 'lists libraries' do
@@ -36,15 +32,6 @@ describe Rake::Builder::Presenters::MakefileAm::BuilderCollectionPresenter do
     end
 
     it 'includes builder text' do
-      Rake::Builder::Presenters::MakefileAm::BuilderPresenter.
-        should_receive(:new).
-        with(program_builder).
-        and_return("AAA\nBBB\n")
-      Rake::Builder::Presenters::MakefileAm::BuilderPresenter.
-        should_receive(:new).
-        with(library_builder).
-        and_return("XXX\nYYY\n")
-
       output = subject.to_s
 
       expect(output).to include("AAA\nBBB\n")
@@ -52,4 +39,3 @@ describe Rake::Builder::Presenters::MakefileAm::BuilderCollectionPresenter do
     end
   end
 end
-

data/spec/unit/rake/builder/presenters/makefile_am/builder_presenter_spec.rb

@@ -4,33 +4,26 @@ describe Rake::Builder::Presenters::MakefileAm::BuilderPresenter do
   context '.new' do
     it 'takes one parameter' do
       expect {
-        Rake::Builder::Presenters::MakefileAm::BuilderPresenter.new
-      }.to raise_error(ArgumentError, 'wrong number of arguments (0 for 1)')
+        described_class.new
+      }.to raise_error(ArgumentError, /wrong number of arguments/)
     end
   end
 
   context '#to_s' do
     let(:builder) do
-      stub(
-        'Rake::Builder',
-        :is_library?               => false,
-        :label                     => 'fubar',
-        :source_files              => ['path/to/1', 'path/to/2'],
-        :compiler_flags            => '-D FOO -D BAR',
-        :library_dependencies_list => '-lfoo -lbar'
+      double(
+        Rake::Builder,
+        is_library?:               is_library?,
+        label:                     'fubar',
+        source_files:              ['path/to/1', 'path/to/2'],
+        compiler_flags:            '-D FOO -D BAR',
+        library_dependencies_list: library_dependencies_list
       )
     end
-    let(:library) do
-      builder.stub(:is_library? => true)
-      builder.stub(:library_dependencies_list => [])
-      builder
-    end
-    let(:binary) do
-      builder.stub(:is_library? => false)
-      builder
-    end
+    let(:library_dependencies_list) { [] }
+    let(:is_library?) { true }
 
-    subject { Rake::Builder::Presenters::MakefileAm::BuilderPresenter.new(builder) }
+    subject { described_class.new(builder) }
 
     it 'lists sources' do
       sources_match = %r(fubar_SOURCES\s+=\s+path/to/1 path/to/2)
@@ -46,8 +39,6 @@ describe Rake::Builder::Presenters::MakefileAm::BuilderPresenter do
     end
 
     context 'library builder' do
-      subject { Rake::Builder::Presenters::MakefileAm::BuilderPresenter.new(library) }
-
       it "doesn't show ld flags" do
         expect(subject.to_s).to_not include('fubar_LDFLAGS')
       end
@@ -58,7 +49,8 @@ describe Rake::Builder::Presenters::MakefileAm::BuilderPresenter do
     end
 
     context 'executable builder' do
-      subject { Rake::Builder::Presenters::MakefileAm::BuilderPresenter.new(binary) }
+      let(:is_library?) { false }
+      let(:library_dependencies_list) { '-lfoo -lbar' }
 
       it 'shows ld flags' do
         expect(subject.to_s).to match(%r(fubar_LDFLAGS\s+=\s+-L))
@@ -70,4 +62,3 @@ describe Rake::Builder::Presenters::MakefileAm::BuilderPresenter do
     end
   end
 end
-

data/spec/unit/rake/builder/task_definers/builder_collection_task_definer_spec.rb

@@ -2,30 +2,39 @@ require 'spec_helper'
 
 describe Rake::Builder::BuilderCollectionTaskDefiner do
   context '#run' do
-    subject { Rake::Builder::BuilderCollectionTaskDefiner.new }
+    let(:builder) do
+      double(
+        Rake::Builder,
+        source_files: ['foo'],
+        rakefile_path: '/path',
+        is_library?: false,
+        target_path: '/path2',
+        label: 'path2',
+        compiler_flags: [],
+        library_dependencies_list: [],
+      )
+    end
+    let(:params) { ['foo', '1.11.1111'] }
 
     before do
       Rake::Task.clear
+      allow(Rake::Builder).to receive(:create_autoconf)
     end
 
     it 'defines an autoconf task' do
       subject.run
 
-      expect(Rake::Task.task_defined?('autoconf')).to be_true
+      expect(Rake::Task.task_defined?('autoconf')).to be_truthy
     end
 
     it 'calls create_autoconf' do
-      Rake::Builder.instances << stub(
-        'Rake::Builder',
-        :source_files => ['foo'],
-        :rakefile_path => '/path',
-      )
+      Rake::Builder.instances << builder
 
       subject.run
 
-      Rake::Builder.should_receive(:create_autoconf)
+      Rake::Task['autoconf'].invoke(*params)
 
-      Rake::Task['autoconf'].invoke
+      expect(Rake::Builder).to have_received(:create_autoconf)
     end
 
     it 'fails if no builders have been instantiated' do
@@ -34,7 +43,7 @@ describe Rake::Builder::BuilderCollectionTaskDefiner do
       subject.run
 
       expect {
-        Rake::Task['autoconf'].invoke
+        Rake::Task['autoconf'].invoke(*params)
       }.to raise_error(RuntimeError, 'No Rake::Builder projects have been defined')
     end
   end

data/spec/unit/rake/builder/task_definers/builder_task_definer_spec.rb

@@ -44,41 +44,48 @@ describe Rake::Builder::BuilderTaskDefiner do
   let(:executable_target) { self.class.executable_target }
   let(:objects_path) { self.class.objects_path }
   let(:custom_prerequisite) { self.class.custom_prerequisite }
-  let(:logger) { stub('Logger') }
+  let(:logger) { double(Logger, :'level=' => nil) }
   let(:builder) do
-    stub(
-      'Rake::Builder',
-      :task_namespace => nil,
-      :target_type => :executable,
-      :target       => executable_target,
-      :target_basename => executable_target,
-      :target_prerequisites => [custom_prerequisite],
-      :makedepend_file => self.class.makedepend_file,
-      :source_files => self.class.source_files,
-      :object_files => self.class.object_files,
-      :object_path  => self.class.object_files[0],
-      :objects_path => objects_path,
-      :generated_files => [],
-      :local_config => self.class.local_config,
-      :generated_headers => self.class.generated_headers,
-      :install_path => 'install/path',
-      :makefile_name => self.class.makefile_name,
-      :default_task => :build,
-      :logger       => logger,
+    double(
+      Rake::Builder,
+      task_namespace:       task_namespace,
+      target_type:          :executable,
+      target:               executable_target,
+      target_basename:      executable_target,
+      target_prerequisites: [custom_prerequisite],
+      makedepend_file:      self.class.makedepend_file,
+      source_files:         self.class.source_files,
+      object_files:         self.class.object_files,
+      object_path:          self.class.object_files[0],
+      objects_path:         objects_path,
+      generated_files:      [],
+      local_config:         self.class.local_config,
+      generated_headers:    self.class.generated_headers,
+      install_path:         'install/path',
+      makefile_name:        self.class.makefile_name,
+      default_task:         :build,
+      logger:               logger,
     )
   end
-  let(:namespaced_builder) { builder.stub(:task_namespace => 'foo'); builder }
+  let(:task_namespace) { nil }
 
-  subject { Rake::Builder::BuilderTaskDefiner.new(builder) }
+  subject { described_class.new(builder) }
 
   before do
     Rake::Task.clear
+    %w(
+      run clean build install uninstall compile
+      create_makedepend_file create_local_config ensure_headers
+      load_local_config
+    ).each do |m|
+      allow(builder).to receive(m.intern)
+    end
   end
 
   context '#new' do
     it 'takes a parameter' do
       expect {
-        Rake::Builder::BuilderTaskDefiner.new 
+        described_class.new
       }.to raise_error(ArgumentError)
     end
   end
@@ -105,7 +112,7 @@ describe Rake::Builder::BuilderTaskDefiner do
       it "defines '#{task}'" do
         subject.run
 
-        expect(Rake::Task.task_defined?(task)).to be_true
+        expect(Rake::Task.task_defined?(task)).to be_truthy
       end
     end
 
@@ -113,36 +120,36 @@ describe Rake::Builder::BuilderTaskDefiner do
       it 'defines run' do
         subject.run
 
-        expect(Rake::Task.task_defined?('run')).to be_true
+        expect(Rake::Task.task_defined?('run')).to be_truthy
       end
     end
 
     context 'with a namespace' do
-      subject { Rake::Builder::BuilderTaskDefiner.new(namespaced_builder) }
+      let(:task_namespace) { 'foo' }
 
       it 'namespaces tasks' do
         subject.run
 
-        expect(Rake::Task.task_defined?('foo:run')).to be_true
+        expect(Rake::Task.task_defined?('foo:run')).to be_truthy
       end
 
       it 'defines the namespace default task' do
         subject.run
 
-        expect(Rake::Task.task_defined?('foo')).to be_true
+        expect(Rake::Task.task_defined?('foo')).to be_truthy
       end
 
       it 'does not fiddle up the local_config file' do
         subject.run
 
-        expect(Rake::Task['foo:load_local_config'].prerequisites).to eq([namespaced_builder.local_config])
+        expect(Rake::Task['foo:load_local_config'].prerequisites).to eq([builder.local_config])
       end
     end
   end
 
   context 'dependencies' do
     before do
-      Rake::Builder::BuilderTaskDefiner.new(builder).run
+      described_class.new(builder).run
     end
 
     [
@@ -177,52 +184,25 @@ describe Rake::Builder::BuilderTaskDefiner do
 
   context 'tasks' do
     before do
-      Rake::Builder::BuilderTaskDefiner.new(builder).run
-    end
-
-    context 'run' do
-      it 'runs the builder' do
-        clear_prerequisites 'run'
-
-        builder.should_receive(:run)
-
-        Rake::Task['run'].invoke
-      end
-    end
-
-    context 'the target' do
-      it 'builds the target' do
-        clear_prerequisites executable_target
-
-        builder.should_receive(:build)
-
-        Rake::Task[executable_target].invoke
-      end
-    end
-
-    context 'clean' do
-      it 'cleans the build' do
-        builder.should_receive(:clean)
-
-        Rake::Task['clean'].invoke
-      end
-    end
-
-    context 'install' do
-      it 'installs the target' do
-        clear_prerequisites 'install'
-
-        builder.should_receive(:install)
-
-        Rake::Task['install'].invoke
-      end
+      described_class.new(builder).run
     end
 
-    context 'uninstall' do
-      it 'uninstalls the target' do
-        builder.should_receive(:uninstall)
-
-        Rake::Task['uninstall'].invoke
+    [
+      ['run', 'runs the builder', :run],
+      [executable_target, 'builds the target', :build],
+      ['clean', 'cleans the build', :clean],
+      ['install', 'installs the target', :install],
+      ['uninstall', 'uninstalls the target', :uninstall],
+      ['load_local_config', 'loads local config', :load_local_config],
+    ].each do |task, action, command|
+      context task do
+        it action do
+          clear_prerequisites task
+
+          Rake::Task[task].invoke
+
+          expect(builder).to have_received(command)
+        end
       end
     end
 
@@ -230,28 +210,19 @@ describe Rake::Builder::BuilderTaskDefiner do
       it 'compiles the file' do
         clear_prerequisites 'src/file1.o'
 
-        builder.should_receive(:compile).
-          with('src/file1.cpp', 'src/file1.o')
-
         Rake::Task['src/file1.o'].invoke
+
+
+        expect(builder).to have_received(:compile).
+          with('src/file1.cpp', 'src/file1.o')
       end
     end
 
     context 'local_config' do
       it 'creates local config' do
-        builder.should_receive(:create_local_config)
-
         Rake::Task[self.class.local_config].invoke
-      end
-    end
 
-    context 'load_local_config' do
-      it 'loads local config' do
-        clear_prerequisites 'load_local_config'
-
-        builder.should_receive(:load_local_config)
-
-        Rake::Task['load_local_config'].invoke
+        expect(builder).to have_received(:create_local_config)
       end
     end
 
@@ -261,17 +232,17 @@ describe Rake::Builder::BuilderTaskDefiner do
       end
 
       it 'calls ensure_headers' do
-        builder.should_receive(:ensure_headers)
-
         Rake::Task['missing_headers'].invoke
+
+        expect(builder).to have_received(:ensure_headers)
       end
 
       it 'fails if builder raises an error' do
-        builder.stub(:ensure_headers).and_raise('foo')
+        allow(builder).to receive(:ensure_headers).and_raise('foo')
 
         expect {
           Rake::Task['missing_headers'].invoke
-        }.to raise_error
+        }.to raise_error(RuntimeError, /foo/)
       end
     end
 
@@ -279,9 +250,9 @@ describe Rake::Builder::BuilderTaskDefiner do
       it 'creates the makedepend file' do
         clear_prerequisites self.class.makedepend_file
 
-        builder.should_receive(:create_makedepend_file)
-
         Rake::Task[self.class.makedepend_file].invoke
+
+        expect(builder).to have_received(:create_makedepend_file)
       end
     end
 
@@ -289,13 +260,7 @@ describe Rake::Builder::BuilderTaskDefiner do
       before do
         clear_prerequisites 'load_makedepend'
         @object_file = self.class.object_files[0]
-        builder.stub(:load_makedepend).and_return({@object_file => ['include/header1.h']})
-      end
-
-      it 'gets dependency information from builder' do
-        builder.should_receive(:load_makedepend).and_return({@object_file => ['include/header1.h']})
-
-        Rake::Task['load_makedepend'].invoke
+        allow(builder).to receive(:load_makedepend) { {@object_file => ['include/header1.h']} }
       end
 
       it 'creates tasks for headers' do
@@ -312,18 +277,20 @@ describe Rake::Builder::BuilderTaskDefiner do
     end
 
     context 'makefile' do
-      let(:presenter) { stub('BuilderPresenter') }
+      let(:presenter) do
+        double(Rake::Builder::Presenters::Makefile::BuilderPresenter, save: nil)
+      end
+
+      before do
+        allow(Rake::Builder::Presenters::Makefile::BuilderPresenter).to receive(:new).with(builder) { presenter }
+      end
 
       it 'creates a makefile' do
         clear_prerequisites self.class.makefile_name
 
-        Rake::Builder::Presenters::Makefile::BuilderPresenter.
-          should_receive(:new).
-          with(builder).
-          and_return(presenter)
-        presenter.should_receive(:save)
-
         Rake::Task[self.class.makefile_name].invoke
+
+        expect(presenter).to have_received(:save)
       end
     end
 
@@ -331,9 +298,9 @@ describe Rake::Builder::BuilderTaskDefiner do
       it 'sets the logger level if required' do
         ENV['DEBUG'] = 'true'
 
-        logger.should_receive(:level=).with(0)
-
         Rake::Task['environment'].invoke
+
+        expect(logger).to have_received(:level=).with(0)
       end
     end
   end