rainforest-cli 1.6.4 → 1.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e77dec4702b93e1e965863ef17de691657fd03ae
-  data.tar.gz: 578b1fa55a182adf52f74c1f2201219c4af1c72a
+  metadata.gz: 70b20280040fce6f6790e5e18149596eccb2824e
+  data.tar.gz: 1f83c0cc0e433bfc36baf775023c0b3f7f49780d
 SHA512:
-  metadata.gz: 2f9ff110e6d916871ad66b1c47ab4e19c02392629a97f9c5de5f7ad8337382a3b068dad60252163ecc31be684cc5aaa53d1b4c162b685298f2b01a5f1abbd8ea
-  data.tar.gz: 09a7e1779f9cec02042ee8845ae9f89a7e99718b8245f7a45f65bdd4beffe162d1819afae81557cdd923756b3888a42d5ab2765338478aa3f14a0457732b54f4
+  metadata.gz: d9a8325fe43ba3a84017701f0ab3be81bad42c7e6bd04853909835a7afa2fa3867e8e4e91320fa24c6549df9691015003b6a25c5c141a8c12754523be4ae3051
+  data.tar.gz: 9be91de080050e86660f0962d534d97632f22298f5240747e52aa05855e7cfa961daa0d21002794641409dd9731909425351ecba3d047c9677c0b4daa57996c4

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Rainforest CLI Changelog
 
+## 1.6.5 - 13th June 2016
+- Exit with non-zero status code when `validate` fails. (8db1d38be39aa50d2afcdef817f78c654b3108b6,
+@DyerSituation)
+- Increase the amount of folders fetched from API to 100. (7fc7d426c029d35e73fe45712a79b35fda54ad60,
+@DyerSituation)
+
 ## 1.6.4 - 10th June 2016
 - Add redirects to non-embedded steps that need them as well. (2a5918d1a448f78016587c1711261e90a7be120f,
 @epaulet)
@@ -7,7 +13,7 @@
 (b604a5607e707057375ecc14db836d4b3ec537b1, @epaulet)
 
 ## 1.6.3 - 9th June 2016
-- Add redirects to exported steps. (ccbdaec2a9fb52c775ffbee05e203e1026b256f7, @theonegri)
+- Add redirects to exported embedded tests. (ccbdaec2a9fb52c775ffbee05e203e1026b256f7, @theonegri)
 
 ## 1.6.2 - 8th June 2016
 - Lower concurrent thread count to 16 and allow users to modify the amount of threads used.

data/lib/rainforest/cli/resources.rb

@@ -18,8 +18,7 @@ class RainforestCli::Resources
   end
 
   def folders
-    folders = @client.get('/folders').map { |f| Resource.new(f['id'], f['title']) }
-
+    folders = @client.get('/folders?page_size=100').map { |f| Resource.new(f['id'], f['title']) }
     if folders.empty?
       logger.info('No folders found on your account.')
       logger.info('Please visit https://app.rainforestqa.com/folders to create and edit your sites.')

data/lib/rainforest/cli/validator.rb

@@ -13,7 +13,7 @@ class RainforestCli::Validator
 
   def validate
     check_test_directory_for_tests!
-    invalid?
+    exit 1 if invalid?
   end
 
   def validate_with_exception!

data/lib/rainforest/cli/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module RainforestCli
-  VERSION = '1.6.4'
+  VERSION = '1.6.5'
 end

data/spec/resources_spec.rb

@@ -82,7 +82,17 @@ describe RainforestCli::Resources do
       let(:expected_name) { api_response.first['title'] }
 
       it_should_behave_like 'a properly formatted resource', :folders
+
+
+      it 'should make a get request for 100 pages' do
+        expect_any_instance_of(RainforestCli::HttpClient).to receive(:get) do |_obj, message|
+          expect(message).to include('page_size=100')
+        end.and_return(api_response)
+        subject.folders
+      end
     end
+
+
   end
 
   describe '#browsers' do

data/spec/validator_spec.rb

@@ -8,11 +8,7 @@ describe RainforestCli::Validator do
       .with(array_including(test_with_file_name(file_path)))
       .and_call_original
 
-    if raises_error
-      expect { subject.public_send(tested_method) }.to raise_error(SystemExit)
-    else
-      expect { subject.public_send(tested_method) }.to_not raise_error
-    end
+    expect { subject.public_send(tested_method) }.to raise_error(SystemExit)
   end
 
   def does_not_notify_for_wrong_file_names
@@ -20,16 +16,11 @@ describe RainforestCli::Validator do
       .with(array_excluding(test_with_file_name(file_path)))
       .and_call_original
 
-    if raises_error
-      expect { subject.public_send(tested_method) }.to raise_error(SystemExit)
-    else
-      expect { subject.public_send(tested_method) }.to_not raise_error
-    end
+    expect { subject.public_send(tested_method) }.to raise_error(SystemExit)
   end
 
   shared_examples 'it detects all the correct errors' do
     let(:tested_method) { :validate }
-    let(:raises_error) { false }
     let(:options) { instance_double('RainforestCli::Options', test_folder: test_directory, token: 'api_token', command: '') }
     subject { described_class.new(options) }
 
@@ -108,14 +99,28 @@ describe RainforestCli::Validator do
       it 'logs the errors' do
         expect(subject).to receive(:duplicate_rfml_ids_notification).with({'a-test' => 2}).and_call_original
 
-        subject.validate
+        expect { subject.validate }.to raise_error(SystemExit)
+      end
+
+
+      context 'when invalid' do
+        before do
+          allow(subject).to receive(:invalid?).and_return(true)
+        end
+        it 'exits 1' do
+          begin
+            subject.validate
+            fail "validate did not exit with status 1"
+          rescue SystemExit => e
+            expect(e.status).to eq(1)
+          end
+        end
       end
     end
   end
 
   describe '#validate_with_exception!' do
     let(:tested_method) { :validate_with_exception! }
-    let(:raises_error) { true }
 
     it_behaves_like 'it detects all the correct errors'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rainforest-cli
 version: !ruby/object:Gem::Version
-  version: 1.6.4
+  version: 1.6.5
 platform: ruby
 authors:
 - Russell Smith
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-10 00:00:00.000000000 Z
+date: 2016-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty