railwatch 0.3.2 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a2929e5724d581361c5ce2e20a4184dcde4ad190edca068527a5f565043c5a9c
-  data.tar.gz: e63ea3bc8d89318bc4e296d17c006eb87dfb3ea06be0db5dea4dea6035a0dfc5
+  metadata.gz: 3d212beaade3dc390933ea8a41bd49eb1bbf2c896056071516aac8242b39eb07
+  data.tar.gz: e647976f9634c1e0ba390f6dec52866d190401728363e3dcd1fa93aa2976af3d
 SHA512:
-  metadata.gz: b9477f54a79df466ad5113b56d7206cc7da3d6dd76db86e30c568bc6a9e6378a6545d2a3013fae33d6cef2ffd4d986fd18e9b07051ba67429a52fe38bb33fdee
-  data.tar.gz: '0892577170dc73fcd351ce620da0908afd9d2bd4b78f672e2931efb7130eacde83219664cd8d6afac36416d97c691d4897ab2355e6ff5c3f976ec3b4e73ac80b'
+  metadata.gz: c669c17f558dec72be16f175b06abc5769680591349c2169f6598fc26575191558bd00b903ead0f1f4287bab718c5097b0550ff60e7cfe5fe82fa53940c7a953
+  data.tar.gz: fc9a32a877b22e12e22b7738b4b479c2aa8b9d1dcc5c97f7ed003f5b421ea3e1a95f917221c195c9b01a487ac124d413dc561a22f96e7483e4891bb5db95b685

data/CHANGELOG.md

@@ -1,5 +1,37 @@
 # Changelog
 
+## 0.3.4 (2026-09-20)
+
+- Fix the embedded dashboard offering its install steps to an install that is
+  already reporting. `last_seen_at` was process-local state, set by whichever
+  process ingested a batch. A deployed embedded install ingests in the writer
+  process the Puma plugin forks and renders the dashboard in a web one, so the
+  web process never saw it set and read the nil as "no events yet" -- add the
+  gem, run the generator, set the token, run the doctor -- no matter how much
+  had been recorded. It now reads the newest batch row from the telemetry
+  database, which every process shares.
+- Fix live updates never connecting. The channel asked for
+  `connection.request`, which Action Cable defines below `private` for use
+  inside a Connection subclass; from a channel it raises NoMethodError, so
+  every subscribe failed and the dashboard sat on "Disconnected" while the
+  client retried. It now builds the request from the connection's public `env`.
+- Add the gem's first channel spec, with a connection stub that mirrors
+  ActionCable::Connection::Base's real method visibility. Action Cable's own
+  ConnectionStub defines neither `request` nor `env`, so a stub that exposed a
+  public `request` would have agreed with the broken code.
+
+## 0.3.3 (2026-09-19)
+
+- Fix `railwatch:install --local` writing test databases that parallel test
+  runners cannot share. The generated `test` entries named
+  `storage/test_railwatch*.sqlite3` with no `TEST_ENV_NUMBER`, so every worker
+  in a parallel run opened the same two SQLite files and raced through them:
+  `ActiveRecord::PendingMigrationError` and `SQLite3::IOException: disk I/O
+  error` out of `configure_connection`, on every shard. Rails' own test
+  database naming carries the number for this reason, and the generated names
+  now do too. An app with no parallel runner sets no `TEST_ENV_NUMBER`, so its
+  generated file is unchanged and no existing install needs migrating.
+
 ## 0.3.2 (2026-09-19)
 
 - Fix an embedded install's rake tasks reporting over HTTP instead of into

data/app/channels/railwatch/environment_channel.rb

@@ -18,11 +18,32 @@ module Railwatch
   # timestamp and per-type counts), never telemetry records.
   class EnvironmentChannel < ActionCable::Channel::Base
     def subscribed
-      if params[:id].to_i == Environment::ID && Railwatch.config.dashboard_channel_allowed?(connection.request)
+      if params[:id].to_i == Environment::ID && Railwatch.config.dashboard_channel_allowed?(connection_request)
         stream_from "environment_#{Environment::ID}"
       else
         reject
       end
     end
+
+    private
+
+    # Built from the connection's env rather than asking it for its request:
+    # ActionCable::Connection::Base#request is private (Rails documents it for
+    # use inside a Connection subclass, not from a channel), so the obvious
+    # call raises NoMethodError, every subscribe fails, and the dashboard sits
+    # on "Disconnected" retrying forever. `env` is public and carries
+    # everything a gate reads -- the Authorization header for HTTP Basic, the
+    # cookies a dashboard_user resolver looks at.
+    #
+    # Merging env_config first is what makes those cookies readable: it is
+    # where the key generator, the secret and the cookie serializer live, so
+    # without it `cookie_jar.signed` finds nothing and a resolver that
+    # authenticates by signed cookie refuses a subscriber it should admit.
+    # Same construction Connection#request itself uses.
+    def connection_request
+      env = connection.env
+      env = Rails.application.env_config.merge(env) if defined?(Rails.application) && Rails.application
+      ActionDispatch::Request.new(env)
+    end
   end
 end

data/app/models/railwatch/environment.rb

@@ -31,7 +31,20 @@ module Railwatch
     def paused? = false
     def token_prefix = "embedded"
     def retention_days = 7
-    def last_seen_at = Railwatch::Embedded.last_seen_at
+    # Deliberately read from the telemetry database rather than held in this
+    # process. A deployed embedded install ingests in the writer process and
+    # renders the dashboard in a web one, so a value set during ingest is
+    # invisible to the page that needs it -- and a nil here is what the
+    # dashboard treats as "no events yet", so it showed its install steps no
+    # matter how much had been recorded. The newest batch row is the same
+    # fact, in the file both processes already share, one indexed lookup away.
+    # Ordered by received_at, not id: batches are written concurrently, so one
+    # that captured an earlier receipt time can land after a later one, and
+    # taking the newest row by insertion order would hand the dashboard a
+    # timestamp that goes backwards. `recent` is the scope that states this.
+    def last_seen_at
+      with_telemetry { Telemetry::IngestBatch.recent.pick(:received_at) }
+    end
     def application = Application.current
     def issues = Issue.where(environment_id: ID)
     def deploys = Deploy.where(environment_id: ID)
@@ -43,8 +56,9 @@ module Railwatch
     # dashboard can flag silent ones. One embedded install is its own server.
     def expected_servers = []
 
-    # Ingest::Batch touches this in embedded mode; there is no row to update.
-    def update_columns(last_seen_at:) = Railwatch::Embedded.last_seen_at = last_seen_at
+    # Ingest::Batch touches this after writing a batch. Nothing to record: the
+    # batch row it just wrote is what last_seen_at reads.
+    def update_columns(last_seen_at:) = nil
 
     # GlobalID for Active Job arguments (RollupJob.perform_later(environment, bucket)).
     include GlobalID::Identification

data/lib/generators/railwatch/install/install_generator.rb

@@ -383,12 +383,26 @@ module Railwatch
             lines.insert(start + 1, "  primary:\n")
             stop += 1
           end
-          entries = format(RAILWATCH_DATABASES, env: env).lines.map { |line| "  #{line}" }
+          entries = format(RAILWATCH_DATABASES, env: database_prefix(env)).lines.map { |line| "  #{line}" }
           lines = insert_lines(lines, stop, entries.join).lines
         end
         lines.join
       end
 
+      # What the database filenames are built from. For test that has to carry
+      # TEST_ENV_NUMBER, the way Rails' own test database naming does: runners
+      # like parallel_tests give each worker its own number and expect a
+      # database per worker. Without it every worker in a run opens the same
+      # two SQLite files and they fight over them -- observed as
+      # PendingMigrationError and "disk I/O error" from configure_connection,
+      # on an app running four workers. An app with no such runner sets no
+      # TEST_ENV_NUMBER, so the suffix is empty and the name is unchanged.
+      def self.database_prefix(env)
+        return env unless env == "test"
+
+        %(test<%= ENV["TEST_ENV_NUMBER"] %>)
+      end
+
       # Unconditional: `bundle exec puma` evaluates this file before it loads
       # the Rack app, so `if defined?(Railwatch)` would be false there and the
       # writer would never start. The plugin itself is inert when Railwatch is

data/lib/railwatch/embedded.rb

@@ -46,9 +46,5 @@ module Railwatch
       def quota_exhausted? = false
       def as_json(*) = { id: id, name: name, slug: slug, plan: plan }
     end
-
-    class << self
-      attr_accessor :last_seen_at
-    end
   end
 end

data/lib/railwatch/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Railwatch
-  VERSION = "0.3.2"
+  VERSION = "0.3.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: railwatch
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.4
 platform: ruby
 authors:
 - Cole Robertson