railties 8.1.3.1 → 8.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 44ab729e5deb7599cf91a750769465ad9680904063216343370c70ebc7f45b6c
-  data.tar.gz: 70f6e32de8df59af394830475c52c87afedf11966cbefb3cf1140d684aedb49f
+  metadata.gz: f244c9087e2dbf369180ece7173b2e14a38469a18adf60c5e162dfb0e9951324
+  data.tar.gz: fd0fb4cde8bd683e20f8390b82f7dcadfa596fb33d6fe81a57d3009895298517
 SHA512:
-  metadata.gz: 47aed6615183f73c08d252999ab0fd35d661b295cef1fc10b83abe6d9539250049f3a4c06b7192595da2218ce8cd7b14697f0dafb148a4e5a104c19554e95d03
-  data.tar.gz: d9628a991c5f7b498b49be56df1d7a5c7c61c7fab7c4fdbaf33c1c9747d040926c7c7f2e892f6ce6a36151c18572727ea932ab7bd8cf0461084301f40c8bfd99
+  metadata.gz: 5195af7a6c02302d6e1dd99586658b0b1fe866884db12852abee6c7f27b95b45af02e3ab2f2608d8d4b6119f94251e168c567bd6a4d34c3d5db107ddf7dbd644
+  data.tar.gz: 02f47c8613c4863e5d1557b2d2e4dbec321e50d72e04696f4d9fb4bdb91d3ece6e29b948db8daec8820dc60e24ce6a3e644703789f486fdf1f19f2107c4ba187

data/CHANGELOG.md

@@ -1,3 +1,86 @@
+## Rails 8.1.4 (September 24, 2026) ##
+
+*   Include the offending value in the `secret_key_base=` error message.
+
+    *Jean Boussier*
+
+*   Load database config when a connection is absent from the shared section.
+
+    `database_configuration` no longer raises `NoMethodError` when a shared
+    config section is missing a subsection for a particular connection name.
+
+    *Kenta Ishizaki*
+
+*   Round-trip the `null: false` attribute modifier in `GeneratedAttribute#to_s`.
+
+    `rails generate` now emits the `!` modifier for attributes with `null: false`,
+    so the generated command string can be used to regenerate the same migration.
+
+    *Kenta Ishizaki*
+
+*   Fix infinite route reload when `after_routes_loaded` hooks access routes.
+
+    The `:loading` state is now held across `after_routes_loaded` hooks, so a
+    hook that touches routes no longer triggers a redundant reload.
+
+    *Chedli Bourguiba*
+
+*   Fix `LazyRouteSet` thrashing when `url_helpers` are included into `Object`.
+
+    `method_missing` and `respond_to_missing?` now only trigger a route reload
+    for methods ending in `_path` or `_url`, preventing every `respond_to?`
+    call from re-entering the route loader.
+
+    *Chedli Bourguiba*
+
+*   Add `RoutesReloader#loaded` to check whether routes have been loaded.
+
+    *Rafael Mendonça França*
+
+*   Mark routes as loaded when the routes reloader executes standalone.
+
+    `RoutesReloader#execute` now sets the load state to `loaded`, so calling
+    it directly (outside of `execute_unless_loaded`) no longer leaves the
+    reloader in a state where routes are considered unloaded.
+
+    *Kenta Ishizaki*
+
+*   Make mounted route helpers (e.g. `main_app`, engine mount proxies) trigger
+    the lazy route load instead of raising `NoMethodError` when called before
+    routes are drawn.
+
+    Named url helpers already loaded routes on demand, but mounted helpers are
+    only defined when `mount` runs during the route draw, so calling one first
+    (in the console or a test) failed until something else drew the routes.
+
+    *Abdelkader Boudih*
+
+*   Make lazy route loading thread-safe.
+
+    Since routes are drawn on the first request in environments where
+    `config.eager_load` is `false` (development and test by default),
+    concurrent first requests could dispatch against an empty or half-drawn
+    route set, resulting in a 404 for a perfectly valid route. Route drawing
+    is now synchronized: concurrent requests wait for the initial draw to
+    complete and are then dispatched against the fully drawn route set.
+
+    *grk*
+
+*   Validate subcommand in `rails plugin` command.
+
+    `rails plugin foo bar` silently ignored the invalid subcommand "foo"
+    and proceeded to create a plugin named "bar". Now it prints an error
+    and exits with status 1.
+
+    Fixes #57430.
+
+    *Ruy Rocha*
+
+*   Prevent the internal development welcome route from being duplicated on route reloads.
+
+    *Elliot Temple*
+
+
 ## Rails 8.1.3.1 (July 29, 2026) ##
 
 *   No changes.

data/lib/rails/application/configuration.rb

@@ -461,7 +461,7 @@ module Rails
               if config.is_a?(Hash) && config.values.all?(Hash)
                 if shared.is_a?(Hash) && shared.values.all?(Hash)
                   config.map do |name, sub_config|
-                    sub_config.reverse_merge!(shared[name])
+                    sub_config.reverse_merge!(shared[name]) if shared[name]
                   end
                 else
                   config.map do |name, sub_config|
@@ -538,7 +538,7 @@ module Rails
         elsif new_secret_key_base.is_a?(String) && new_secret_key_base.present?
           @secret_key_base = new_secret_key_base
         elsif new_secret_key_base
-          raise ArgumentError, "`secret_key_base` for #{Rails.env} environment must be a type of String`"
+          raise ArgumentError, "`secret_key_base` for #{Rails.env} environment must be a type of String, got: #{new_secret_key_base.inspect}`"
         else
           raise ArgumentError, "Missing `secret_key_base` for '#{Rails.env}' environment, set this string with `bin/rails credentials:edit`"
         end

data/lib/rails/application/finisher.rb

@@ -146,7 +146,7 @@ module Rails
             get "/rails/info"            => "rails/info#index",      internal: true
           end
 
-          routes_reloader.run_after_load_paths = -> do
+          routes_reloader.run_once_after_load_paths = -> do
             app.routes.append do
               get "/" => "rails/welcome#index", internal: true
             end

data/lib/rails/application/routes_reloader.rb

@@ -1,43 +1,80 @@
 # frozen_string_literal: true
 
+require "monitor"
 
 module Rails
   class Application
     class RoutesReloader
       include ActiveSupport::Callbacks
 
-      attr_reader :route_sets, :paths, :external_routes, :loaded
+      attr_reader :route_sets, :paths, :external_routes
       attr_accessor :eager_load
-      attr_writer :run_after_load_paths, :loaded # :nodoc:
+      attr_writer :run_once_after_load_paths # :nodoc:
       delegate :execute_if_updated, :updated?, to: :updater
 
-      def initialize
+      def initialize(file_watcher: ActiveSupport::FileUpdateChecker)
         @paths      = []
         @route_sets = []
         @external_routes = []
         @eager_load = false
-        @loaded = false
+        @load_state = nil # nil (not loaded yet) | :loading | :loaded
+        @load_lock = Monitor.new
+        @file_watcher = file_watcher
+      end
+
+      # Returns +true+ if the routes are loaded.
+      def loaded
+        @load_state == :loaded
       end
 
       def reload!
-        clear!
-        load_paths
-        finalize!
-        route_sets.each(&:eager_load!) if eager_load
-      ensure
-        revert
+        @load_lock.synchronize do
+          previous_state, @load_state = @load_state, :loading
+          clear!
+          load_paths
+          finalize!
+          route_sets.each(&:eager_load!) if eager_load
+        ensure
+          @load_state = previous_state
+          revert
+        end
       end
 
       def execute
-        @loaded = true
-        updater.execute
+        @load_lock.synchronize do
+          updater.execute
+          @load_state ||= :loaded
+        end
       end
 
       def execute_unless_loaded
-        unless @loaded
-          execute
-          ActiveSupport.run_load_hooks(:after_routes_loaded, Rails.application)
-          true
+        return false if @load_state == :loaded
+
+        @load_lock.synchronize do
+          # Another thread finished the load while this one was blocked on
+          # @load_lock. Return true so callers like
+          # LazyRouteSet#method_missing retry the url helper that was
+          # missing when they were called.
+          return true if @load_state == :loaded
+
+          # Drawing the routes re-enters this method on the same thread —
+          # config/routes.rb itself calls routes.draw — through the
+          # reentrant Monitor; without this check the nested call would
+          # recurse into another draw.
+          return false if @load_state == :loading
+
+          # Hold :loading across after_routes_loaded as well. reload! restores
+          # the previous state when it finishes, so if we left that as nil a
+          # hook that touched routes would re-enter and draw again.
+          @load_state = :loading
+          begin
+            execute
+            ActiveSupport.run_load_hooks(:after_routes_loaded, Rails.application)
+            @load_state = :loaded
+            true
+          ensure
+            @load_state = nil if @load_state == :loading
+          end
         end
       end
 
@@ -48,7 +85,7 @@ module Rails
             hash[dir.to_s] = %w(rb)
           end
 
-          ActiveSupport::FileUpdateChecker.new(paths, dirs) { reload! }
+          @file_watcher.new(paths, dirs) { reload! }
         end
       end
 
@@ -61,11 +98,14 @@ module Rails
 
       def load_paths
         paths.each { |path| load(path) }
-        run_after_load_paths.call
+        run_after_load_paths_callback
       end
 
-      def run_after_load_paths
-        @run_after_load_paths ||= -> { }
+      def run_after_load_paths_callback
+        if @run_once_after_load_paths
+          @run_once_after_load_paths.call
+          @run_once_after_load_paths = nil
+        end
       end
 
       def finalize!

data/lib/rails/application.rb

@@ -156,11 +156,7 @@ module Rails
 
     # Reload application routes regardless if they changed or not.
     def reload_routes!
-      if routes_reloader.execute_unless_loaded
-        routes_reloader.loaded = false
-      else
-        routes_reloader.reload!
-      end
+      routes_reloader.reload!
     end
 
     def reload_routes_unless_loaded # :nodoc:

data/lib/rails/commands/plugin/plugin_command.rb

@@ -21,7 +21,16 @@ module Rails
       class_option :no_rc, desc: "Skip evaluating .railsrc."
 
       def perform(type = nil, *plugin_args)
-        plugin_args << "--help" unless type == "new"
+        if type
+          unless type == "new"
+            error "'#{type}' is not a valid plugin subcommand. Valid subcommand: new."
+            error "Run '#{self.class.executable} -h' for help."
+            exit 1
+          end
+        else
+          plugin_args << "--help"
+        end
+
 
         unless options.key?("no_rc") # Thor's not so indifferent access hash.
           railsrc = File.expand_path(options[:rc])

data/lib/rails/engine/lazy_route_set.rb

@@ -38,6 +38,39 @@ module Rails
         end
       end
 
+      # Mounted helpers are only defined when `mount` runs during the route
+      # draw. _path/_url names are left to method_missing_module, which owns
+      # them and relies on reload_routes_unless_loaded returning true only to
+      # the caller that performed the load.
+      module MountedHelpers
+        extend ActiveSupport::Concern
+
+        include ActionDispatch::Routing::RouteSet::MountedHelpers
+
+        private
+          def method_missing(method_name, ...)
+            if method_name.end_with?("_path", "_url")
+              super
+            else
+              Rails.application&.reload_routes_unless_loaded
+              if ActionDispatch::Routing::RouteSet::MountedHelpers.method_defined?(method_name)
+                public_send(method_name, ...)
+              else
+                super
+              end
+            end
+          end
+
+          def respond_to_missing?(method_name, include_private = false)
+            if method_name.end_with?("_path", "_url")
+              super
+            else
+              Rails.application&.reload_routes_unless_loaded
+              ActionDispatch::Routing::RouteSet::MountedHelpers.method_defined?(method_name) || super
+            end
+          end
+      end
+
       def initialize(config = DEFAULT_CONFIG)
         super
         self.named_routes = NamedRouteCollection.new
@@ -85,21 +118,40 @@ module Rails
         super
       end
 
+      def mounted_helpers
+        MountedHelpers
+      end
+
+      def define_mounted_helper(name, script_namer = nil)
+        super
+
+        return if MountedHelpers.method_defined?(name)
+
+        shared = ActionDispatch::Routing::RouteSet::MountedHelpers
+        MountedHelpers.define_method("_#{name}", shared.instance_method("_#{name}"))
+        MountedHelpers.define_method(name, shared.instance_method(name))
+      end
+
       private
         def method_missing_module
           @method_missing_module ||= Module.new do
             private
-              def method_missing(...)
-                if Rails.application&.reload_routes_unless_loaded
-                  public_send(...)
+              # NamedRouteCollection#define_url_helper only defines "#{name}_path"
+              # and "#{name}_url" in these modules, so other suffixes can never be
+              # lazy route helpers. Without this guard, including url_helpers into
+              # Object makes every respond_to?(:to_ary) (and similar) re-enter
+              # reload_routes_unless_loaded and thrash while routes are drawing.
+              def method_missing(method_name, ...)
+                if method_name.end_with?("_path", "_url") && Rails.application&.reload_routes_unless_loaded
+                  public_send(method_name, ...)
                 else
                   super
                 end
               end
 
-              def respond_to_missing?(...)
-                if Rails.application&.reload_routes_unless_loaded
-                  respond_to?(...)
+              def respond_to_missing?(method_name, include_private = false)
+                if method_name.end_with?("_path", "_url") && Rails.application&.reload_routes_unless_loaded
+                  respond_to?(method_name, include_private)
                 else
                   super
                 end

data/lib/rails/engine.rb

@@ -307,7 +307,7 @@ module Rails
   #     helper MyEngine::SharedEngineHelper
   #   end
   #
-  # If you want to include all of the engine's helpers, you can use the #helper method on an engine's
+  # If you want to include all of the engine's helpers, you can use the #helpers method on an engine's
   # instance:
   #
   #   class ApplicationController < ActionController::Base

data/lib/rails/gem_version.rb

@@ -9,8 +9,8 @@ module Rails
   module VERSION
     MAJOR = 8
     MINOR = 1
-    TINY  = 3
-    PRE   = "1"
+    TINY  = 4
+    PRE   = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/rails/generators/generated_attribute.rb

@@ -257,17 +257,23 @@ module Rails
 
       private
         def print_attribute_options
-          if attr_options.empty?
-            ""
-          elsif attr_options[:size]
-            "{#{attr_options[:size]}}"
-          elsif attr_options[:limit]
-            "{#{attr_options[:limit]}}"
-          elsif attr_options[:precision] && attr_options[:scale]
-            "{#{attr_options[:precision]},#{attr_options[:scale]}}"
-          else
-            "{#{attr_options.keys.join(",")}}"
-          end
+          options = attr_options.except(:null)
+          modifier = "!" if attr_options[:null] == false
+
+          body =
+            if options.empty?
+              ""
+            elsif options[:size]
+              "{#{options[:size]}}"
+            elsif options[:limit]
+              "{#{options[:limit]}}"
+            elsif options[:precision] && options[:scale]
+              "{#{options[:precision]},#{options[:scale]}}"
+            else
+              "{#{options.keys.join(",")}}"
+            end
+
+          "#{body}#{modifier}"
         end
     end
   end

data/lib/rails/generators/rails/db/system/change/change_generator.rb

@@ -183,7 +183,7 @@ module Rails
             def devcontainer_json
               return unless File.exist?(devcontainer_json_path)
 
-              @devcontainer_json ||= JSON.parse(File.read(devcontainer_json_path))
+              @devcontainer_json ||= JSON.parse(File.read(devcontainer_json_path), allow_comments: true)
             end
 
             def devcontainer_json_path

data/lib/rails/paths.rb

@@ -22,10 +22,10 @@ module Rails
     # allows you to easily add extra paths:
     #
     #   path.is_a?(Enumerable) # => true
-    #   path.to_ary.inspect    # => ["app/controllers"]
+    #   path.to_ary    # => ["app/controllers"]
     #
     #   path << "lib/controllers"
-    #   path.to_ary.inspect    # => ["app/controllers", "lib/controllers"]
+    #   path.to_ary    # => ["app/controllers", "lib/controllers"]
     #
     # Notice that when you add a path using #add, the
     # Path[rdoc-ref:Rails::Paths::Path] object created already contains the path
@@ -33,7 +33,7 @@ module Rails
     # want this behavior, so you can give <tt>:with</tt> as option.
     #
     #   root.add "config/routes", with: "config/routes.rb"
-    #   root["config/routes"].inspect # => ["config/routes.rb"]
+    #   root["config/routes"].to_ary # => ["config/routes.rb"]
     #
     # The #add method accepts the following options as arguments:
     # +eager_load+, +autoload+, +autoload_once+, and +glob+.

data/lib/rails/templates/rails/mailers/email.html.erb

@@ -117,8 +117,8 @@
     <% if @email.html_part && @email.text_part %>
       <dd>
         <select id="part" onchange="refreshBody(false);">
-          <option <%= request.format == Mime[:html] ? 'selected' : '' %> value="<%= part_query('text/html') %>">View as HTML email</option>
-          <option <%= request.format == Mime[:text] ? 'selected' : '' %> value="<%= part_query('text/plain') %>">View as plain-text email</option>
+          <option<% if request.format == Mime[:html] %> selected<% end %> value="<%= part_query('text/html') %>">View as HTML email</option>
+          <option<% if request.format == Mime[:text] %> selected<% end %> value="<%= part_query('text/plain') %>">View as plain-text email</option>
         </select>
       </dd>
     <% elsif @part %>
@@ -132,7 +132,7 @@
       <dd>
         <select id="locale" onchange="refreshBody(true);">
           <% I18n.available_locales.each do |locale| %>
-            <option <%= I18n.locale == locale ? 'selected' : '' %> value="<%= locale_query(locale) %>"><%= locale %></option>
+            <option<% if I18n.locale == locale %> selected<% end %> value="<%= locale_query(locale) %>"><%= locale %></option>
           <% end %>
         </select>
       </dd>

data/lib/rails.rb

@@ -130,6 +130,59 @@ module Rails
       application && Pathname.new(application.paths["public"].first)
     end
 
+    # Provides access to the application autoloaders.
+    #
+    # The autoloader that manages `autoload_paths` is reachable as
+    #
+    #   Rails.autoloaders.main
+    #
+    # This autoloader manages the constants that are reloaded when reloading is
+    # enabled.
+    #
+    # The autoloader that manages `autoload_once_paths` is reachable as
+    #
+    #   Rails.autoloaders.once
+    #
+    # This autoloader manages constants that are autoloaded, but not reloaded.
+    #
+    # You can use these objects to customize their behavior, defining custom
+    # root namespaces, collapsing directories, configuring callbacks, etc.
+    #
+    #   # config/environments/development.rb
+    #   Rails.autoloaders.main.on_load("MyGateway") do
+    #     MyGateway.endpoint = "https://my-gateway.localhost"
+    #   end
+    #
+    #   # config/environments/production.rb
+    #   Rails.autoloaders.main.on_load("MyGateway") do
+    #     MyGateway.endpoint = "https://my-gateway.example.com"
+    #   end
+    #
+    # The +each+ iterator allows you to iterate over both loaders:
+    #
+    #   Rails.autoloaders.each do |loader|
+    #     loader.log!
+    #   end
+    #
+    # which may be handy if you want to run the same code for both of them.
+    #
+    # Indeed, there is a shortcut for that common use case:
+    #
+    #   Rails.autoloaders.log!
+    #
+    # which is handy to watch the activity of the autoloaders.
+    #
+    # Finally, +zeitwerk_enabled?+ allows you to check if autoloading is powered
+    # by Zeitwerk. This predicate returns a hard-coded true since Rails 7, but
+    # it is still in place for engines that support Rails 6.
+    #
+    # The autoloaders are available really early, you can access them in the
+    # application class body, environment configuration, initializers, etc.
+    #
+    # Please check the {Autoloading and Reloading
+    # Constants}[https://guides.rubyonrails.org/autoloading_and_reloading_constants.html]
+    # guide and the documentation of {Zeitwerk}[https://github.com/fxn/zeitwerk]
+    # itself for more details and usage patterns.
     def autoloaders
       application.autoloaders
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: railties
 version: !ruby/object:Gem::Version
-  version: 8.1.3.1
+  version: 8.1.4
 platform: ruby
 authors:
 - David Heinemeier Hansson
@@ -15,28 +15,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
 - !ruby/object:Gem::Dependency
   name: rackup
   requirement: !ruby/object:Gem::Requirement
@@ -133,14 +133,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 8.1.3.1
+        version: 8.1.4
 description: 'Rails internals: application bootup, plugins, generators, and rake tasks.'
 email: david@loudthinking.com
 executables:
@@ -509,10 +509,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v8.1.3.1/railties/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v8.1.3.1/
+  changelog_uri: https://github.com/rails/rails/blob/v8.1.4/railties/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v8.1.4/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v8.1.3.1/railties
+  source_code_uri: https://github.com/rails/rails/tree/v8.1.4/railties
   rubygems_mfa_required: 'true'
 rdoc_options:
 - "--exclude"
@@ -530,7 +530,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.16
+rubygems_version: 4.0.20
 specification_version: 4
 summary: Tools for creating, working with, and running Rails applications.
 test_files: []