railties 7.2.0 → 8.0.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bfbc258d03c709473511d240ffab0b5bbb1b0f439158c768c113054dea8d296a
-  data.tar.gz: 9640e2920bd9ada2cec2f8d684ddcb40f778be9a44dba03be29b5db3fb820b97
+  metadata.gz: 8e33b7c8f20e79a1706cdcad58be19d009563111e20a59f96d8c387d4088883c
+  data.tar.gz: 4490c2625c393ab52a69d98a61caaa3a3b3f5093899e8203dad3d28a8a5dbc99
 SHA512:
-  metadata.gz: 8ab08f5e3bb2fc56427effe82fc71728e4fc0294ac20b74eaebc518a8acf90eed0efab83744a323ea8c5587952097f164b38ffc1d8c95cc6a0e9903f306608f9
-  data.tar.gz: 873c2117ffa487d4d82c956e02935180277dbf9157476e207a2f6f1f92f650f2c534ed956b3437e580e22b32ad4bb7b58fcdd39725cf6f66f2e0512bba2215d9
+  metadata.gz: 7fd02c87add0fdf9ac0b0a1b5ed6b79a278b258f8d40fc02c912e24d6995a4155bdea1a460b795c180e938a7b9f7af793f23a8ff3feec9cb15c4812101d22ce5
+  data.tar.gz: 4788fa68c076ebb9901afd5fc6e24112939de491353096659b1151d841a37872d17f45b21b659287a976916d1b02a1342f2de536a835108a46559cfbd7af3ba2

data/CHANGELOG.md

@@ -1,328 +1,185 @@
-## Rails 7.2.0 (August 09, 2024) ##
+## Rails 8.0.0.beta1 (September 26, 2024) ##
 
-*   The new `bin/rails boot` command boots the application and exits. Supports the
-    standard `-e/--environment` options.
+*   Exit `rails g` with code 1 if generator could not be found.
 
-    *Xavier Noria*
+    Previously `rails g` returned 0, which would make it harder to catch typos in scripts calling `rails g`.
 
-*   Create a Dev Container Generator that generates a Dev Container setup based on the current configuration
-    of the application. Usage:
+    *Christopher Özbek*
 
-    `bin/rails devcontainer`
+*   Remove `require_*` statements from application.css to align with the transition from Sprockets to Propshaft.
 
-    *Andrew Novoselac*
+    With Propshaft as the default asset pipeline in Rails 8, the require_tree and require_self clauses in application.css are no longer necessary, as they were specific to Sprockets. Additionally, the comment has been updated to clarify that CSS precedence now follows standard cascading order without automatic prioritization by the asset pipeline.
 
-*   Add Rubocop and GitHub Actions to plugin generator.
-    This can be skipped using --skip-rubocop and --skip-ci.
+    *Eduardo Alencar*
 
-    *Chris Oliver*
+*   Do not include redis by default in generated Dev Containers.
 
-*   Remove support for `oracle`, `sqlserver` and JRuby specific database adapters from the
-    `rails new` and `rails db:system:change` commands.
+    Now that applications use the Solid Queue and Solid Cache gems by default, we do not need to include redis
+    in the Dev Container. We will only include redis if `--skip-solid` is used when generating an app that uses
+    Active Job or Action Cable.
 
-    The supported options are `sqlite3`, `mysql`, `postgresql` and `trilogy`.
+    When generating a Dev Container for an existing app, we will not include redis if either of the solid gems
+    are in use.
 
     *Andrew Novoselac*
 
-*   Add options to `bin/rails app:update`.
-
-    `bin/rails app:update` now supports the same generic options that generators do:
-
-    * `--force`: Accept all changes to existing files
-    * `--skip`: Refuse all changes to existing files
-    * `--pretend`: Don't make any changes
-    * `--quiet`: Don't output all changes made
-
-    *Étienne Barrié*
-
-*   Implement Rails console commands and helpers with IRB v1.13's extension APIs.
-
-    Rails console users will now see `helper`, `controller`, `new_session`, and `app` under
-    IRB help message's `Helper methods` category. And `reload!` command will be displayed under
-    the new `Rails console` commands category.
-
-    Prior to this change, Rails console's commands and helper methods are added through IRB's
-    private components and don't show up in its help message, which led to poor discoverability.
-
-    *Stan Lo*
-
-*   Remove deprecated `Rails::Generators::Testing::Behaviour`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `find_cmd_and_exec` console helper.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `Rails.config.enable_dependency_loading`.
-
-    *Rafael Mendonça França*
-
-*   Remove deprecated `Rails.application.secrets`.
-
-    *Rafael Mendonça França*
-
-*   Generated Gemfile will include `require: "debug/prelude"` for the `debug` gem.
-
-    Requiring `debug` gem directly automatically activates it, which could introduce
-    additional overhead and memory usage even without entering a debugging session.
-
-    By making Bundler require `debug/prelude` instead, developers can keep their access
-    to breakpoint methods like `debugger` or `binding.break`, but the debugger won't be
-    activated until a breakpoint is hit.
-
-    *Stan Lo*
-
-*   Skip generating a `test` job in ci.yml when a new application is generated with the
-    `--skip-test` option.
-
-    *Steve Polito*
+*   Use [Solid Cable](https://github.com/rails/solid_cable) as the default Action Cable adapter in production, configured as a separate queue database in config/database.yml. It keeps messages in a table and continuously polls for updates. This makes it possible to drop the common dependency on Redis, if it isn't needed for any other purpose. Despite polling, the performance of Solid Cable is comparable to Redis in most situations. And in all circumstances, it makes it easier to deploy Rails when Redis is no longer a required dependency for Action Cable functionality.
 
-*   Update the `.node-version` file conditionally generated for new applications to 20.11.1
-
-    *Steve Polito*
-
-*   Fix sanitizer vendor configuration in 7.1 defaults.
-
-    In apps where rails-html-sanitizer was not eagerly loaded, the sanitizer default could end up
-    being Rails::HTML4::Sanitizer when it should be set to Rails::HTML5::Sanitizer.
-
-    *Mike Dalessio*, *Rafael Mendonça França*
-
-*   Set `action_mailer.default_url_options` values in `development` and `test`.
-
-    Prior to this commit, new Rails applications would raise `ActionView::Template::Error`
-    if a mailer included a url built with a `*_path` helper.
-
-    *Steve Polito*
+    *DHH*
 
-*   Introduce `Rails::Generators::Testing::Assertions#assert_initializer`.
+*   Use [Solid Queue](https://github.com/rails/solid_queue) as the default Active Job backend in production, configured as a separate queue database in config/database.yml. In a single-server deployment, it'll run as a Puma plugin. This is configured in `config/deploy.yml` and can easily be changed to use a dedicated jobs machine.
 
-    Compliments the existing `initializer` generator action.
+    *DHH*
 
-    ```rb
-    assert_initializer "mail_interceptors.rb"
-    ```
+*   Use [Solid Cache](https://github.com/rails/solid_cache) as the default Rails.cache backend in production, configured as a separate cache database in config/database.yml.
 
-    *Steve Polito*
+    *DHH*
 
-*   Generate a .devcontainer folder and its contents when creating a new app.
+*   Add Rails::Rack::SilenceRequest middleware and use it via `config.silence_healthcheck_path = path`
+    to silence requests to "/up". This prevents the Kamal-required health checks from clogging up
+    the production logs.
 
-    The .devcontainer folder includes everything needed to boot the app and do development in a remote container.
+    *DHH*
 
-    The container setup includes:
-     - A redis container for Kredis, ActionCable etc.
-     - A database (SQLite, Postgres, MySQL or MariaDB)
-     - A Headless chrome container for system tests
-     - Active Storage configured to use the local disk and with preview features working
+*   Introduce `mariadb-mysql` and `mariadb-trilogy` database options for `rails new`
 
-    If any of these options are skipped in the app setup they will not be included in the container configuration.
+    When used with the `--devcontainer` flag, these options will use `mariadb` as the database for the
+    Dev Container. The original `mysql` and `trilogy` options will use `mysql`. Users who are not
+    generating a Dev Container do not need to use the new options.
 
-    These files can be skipped using the `--skip-devcontainer` option.
+    *Andrew Novoselac*
 
-    *Andrew Novoselac & Rafael Mendonça França*
+*   Deprecate `::STATS_DIRECTORIES`.
 
-*   Introduce `SystemTestCase#served_by` for configuring the System Test application server.
+    The global constant `STATS_DIRECTORIES` has been deprecated in favor of
+    `Rails::CodeStatistics.register_directory`.
 
-    By default this is localhost. This method allows the host and port to be specified manually.
+    Add extra directories with `Rails::CodeStatistics.register_directory(label, path)`:
 
     ```ruby
-    class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
-      served_by host: "testserver", port: 45678
-    end
+    require "rails/code_statistics"
+    Rails::CodeStatistics.register_directory('My Directory', 'path/to/dir')
     ```
 
-    *Andrew Novoselac & Rafael Mendonça França*
+    *Petrik de Heus*
 
-*   `bin/rails test` will no longer load files named `*_test.rb` if they are located in the `fixtures` folder.
+*   Enable query log tags by default on development env
 
-    *Edouard Chin*
+    This can be used to trace troublesome SQL statements back to the application
+    code that generated these statements. It is also useful when using multiple
+    databases because the query logs can identify which database is being used.
 
-*   Ensure logger tags configured with `config.log_tags` are still active in `request.action_dispatch` handlers.
+    *Matheus Richard*
 
-    *KJ Tsanaktsidis*
+*   Defer route drawing to the first request, or when url_helpers are called
 
-*   Setup jemalloc in the default Dockerfile for memory optimization.
+    Executes the first routes reload in middleware, or when a route set's
+    url_helpers receives a route call / asked if it responds to a route.
+    Previously, this was executed unconditionally on boot, which can
+    slow down boot time unnecessarily for larger apps with lots of routes.
 
-    *Matt Almeida*, *Jean Boussier*
+    Environments like production that have `config.eager_load = true` will
+    continue to eagerly load routes on boot.
 
-*   Commented out lines in .railsrc file should not be treated as arguments when using
-    rails new generator command. Update ARGVScrubber to ignore text after `#` symbols.
+    *Gannon McGibbon*
 
-    *Willian Tenfen*
+*   Generate form helpers to use `textarea*` methods instead of `text_area*` methods
 
-*   Skip CSS when generating APIs.
+    *Sean Doyle*
 
-    *Ruy Rocha*
+*   Add authentication generator to give a basic start to an authentication system using database-tracked sessions and password reset.
 
-*   Rails console now indicates application name and the current Rails environment:
+    Generate with...
 
-    ```txt
-    my-app(dev)> # for RAILS_ENV=development
-    my-app(test)> # for RAILS_ENV=test
-    my-app(prod)> # for RAILS_ENV=production
-    my-app(my_env)> # for RAILS_ENV=my_env
+    ```
+    bin/rails generate authentication
     ```
 
-    The application name is derived from the application's module name from `config/application.rb`.
-    For example, `MyApp` will displayed as `my-app` in the prompt.
-
-    Additionally, the environment name will be colorized when the environment is
-    `development` (blue), `test` (blue), or `production` (red), if your
-    terminal supports it.
-
-    *Stan Lo*
-
-*   Ensure `autoload_paths`, `autoload_once_paths`, `eager_load_paths`, and
-    `load_paths` only have directories when initialized from engine defaults.
-
-    Previously, files under the `app` directory could end up there too.
-
-    *Takumasa Ochi*
-
-*   Prevent unnecessary application reloads in development.
-
-    Previously, some files outside autoload paths triggered unnecessary reloads.
-    With this fix, application reloads according to `Rails.autoloaders.main.dirs`,
-    thereby preventing unnecessary reloads.
-
-    *Takumasa Ochi*
-
-*   Use `oven-sh/setup-bun` in GitHub CI when generating an app with Bun.
-
-    *TangRufus*
-
-*   Disable `pidfile` generation in the `production` environment.
+    Generated files:
 
-    *Hans Schnedlitz*
+    ```
+    app/models/current.rb
+    app/models/user.rb
+    app/models/session.rb
+    app/controllers/sessions_controller.rb
+    app/controllers/passwords_controller.rb
+    app/mailers/passwords_mailer.rb
+    app/views/sessions/new.html.erb
+    app/views/passwords/new.html.erb
+    app/views/passwords/edit.html.erb
+    app/views/passwords_mailer/reset.html.erb
+    app/views/passwords_mailer/reset.text.erb
+    db/migrate/xxxxxxx_create_users.rb
+    db/migrate/xxxxxxx_create_sessions.rb
+    test/mailers/previews/passwords_mailer_preview.rb
+    ```
 
-*   Set `config.action_view.annotate_rendered_view_with_filenames` to `true` in
-    the `development` environment.
+    *DHH*
 
-    *Adrian Marin*
 
-*   Support the `BACKTRACE` environment variable to turn off backtrace cleaning.
+*   Add not-null type modifier to migration attributes.
 
-    Useful for debugging framework code:
+    Generating with...
 
-    ```sh
-    BACKTRACE=1 bin/rails server
+    ```
+    bin/rails generate migration CreateUsers email_address:string!:uniq password_digest:string!
     ```
 
-    *Alex Ghiculescu*
-
-*   Raise `ArgumentError` when reading `config.x.something` with arguments:
+    Produces:
 
     ```ruby
-    config.x.this_works.this_raises true # raises ArgumentError
+    class CreateUsers < ActiveRecord::Migration[8.0]
+      def change
+        create_table :users do |t|
+          t.string :email_address, null: false
+          t.string :password_digest, null: false
+
+          t.timestamps
+        end
+        add_index :users, :email_address, unique: true
+      end
+    end
     ```
 
-    *Sean Doyle*
-
-*   Add default PWA files for manifest and service-worker that are served from `app/views/pwa` and can be dynamically rendered through ERB. Mount these files explicitly at the root with default routes in the generated routes file.
-
     *DHH*
 
-*   Updated system tests to now use headless Chrome by default for the new applications.
-
-    *DHH*
-
-*   Add GitHub CI files for Dependabot, Brakeman, RuboCop, and running tests by default. Can be skipped with `--skip-ci`.
-
-    *DHH*
-
-*   Add Brakeman by default for static analysis of security vulnerabilities. Allow skipping with `--skip-brakeman option`.
-
-    *vipulnsward*
-
-*   Add RuboCop with rules from `rubocop-rails-omakase` by default. Skip with `--skip-rubocop`.
-
-    *DHH* and *zzak*
-
-*   Use `bin/rails runner --skip-executor` to not wrap the runner script with an
-    Executor.
-
-    *Ben Sheldon*
-
-*   Fix isolated engines to take `ActiveRecord::Base.table_name_prefix` into consideration.
-
-    This will allow for engine defined models, such as inside Active Storage, to respect
-    Active Record table name prefix configuration.
-
-    *Chedli Bourguiba*
+*   Add a `script` folder to applications, and a scripts generator.
 
-*   Fix running `db:system:change` when the app has no Dockerfile.
+    The new `script` folder is meant to hold one-off or general purpose scripts,
+    such as data migration scripts, cleanup scripts, etc.
 
-    *Hartley McGuire*
-
-*   In Action Mailer previews, list inline attachments separately from normal
-    attachments.
-
-    For example, attachments that were previously listed like
-
-      > Attachments: logo.png file1.pdf file2.pdf
-
-    will now be listed like
-
-      > Attachments: file1.pdf file2.pdf (Inline: logo.png)
-
-    *Christian Schmidt* and *Jonathan Hefner*
-
-*   In mailer preview, only show SMTP-To if it differs from the union of To, Cc and Bcc.
-
-    *Christian Schmidt*
-
-*   Enable YJIT by default on new applications running Ruby 3.3+.
-
-    This can be disabled by setting `Rails.application.config.yjit = false`
-
-    *Jean Boussier*, *Rafael Mendonça França*
-
-*   In Action Mailer previews, show date from message `Date` header if present.
-
-    *Sampat Badhe*
-
-*   Exit with non-zero status when the migration generator fails.
-
-    *Katsuhiko YOSHIDA*
-
-*   Use numeric UID and GID in Dockerfile template.
-
-    The Dockerfile generated by `rails new` sets the default user and group
-    by name instead of UID:GID. This can cause the following error in Kubernetes:
+    A new script generator allows you to create such scripts:
 
     ```
-    container has runAsNonRoot and image has non-numeric user (rails), cannot verify user is non-root
+    bin/rails generate script my_script
+    bin/rails generate script data/backfill
     ```
 
-    This change sets default user and group by their numeric values.
-
-    *Ivan Fedotov*
+    You can run the generated script using:
 
-*   Disallow invalid values for rails new options.
+    ```
+    bundle exec ruby script/my_script.rb
+    bundle exec ruby script/data/backfill.rb
+    ```
 
-    The `--database`, `--asset-pipeline`, `--css`, and `--javascript` options
-    for `rails new` take different arguments. This change validates them.
+    *Jerome Dalbert*, *Haroon Ahmed*
 
-    *Tony Drake*, *Akhil G Krishnan*, *Petrik de Heus*
+*   Deprecate `bin/rake stats` in favor of `bin/rails stats`.
 
-*   Conditionally print `$stdout` when invoking `run_generator`.
+    *Juan Vásquez*
 
-    In an effort to improve the developer experience when debugging
-    generator tests, we add the ability to conditionally print `$stdout`
-    instead of capturing it.
+*   Add internal page `/rails/info/notes`, that displays the same information as `bin/rails notes`.
 
-    This allows for calls to `binding.irb` and `puts` work as expected.
+    *Deepak Mahakale*
 
-    ```sh
-    RAILS_LOG_TO_STDOUT=true ./bin/test test/generators/actions_test.rb
-    ```
+*   Add Rubocop and GitHub Actions to plugin generator.
+    This can be skipped using --skip-rubocop and --skip-ci.
 
-    *Steve Polito*
+    *Chris Oliver*
 
-*   Remove the option `config.public_file_server.enabled` from the generators
-    for all environments, as the value is the same in all environments.
+*   Use Kamal for deployment by default, which includes generating a Rails-specific config/deploy.yml.
+    This can be skipped using --skip-kamal. See more: https://kamal-deploy.org/
 
-    *Adrian Hirt*
+    *DHH*
 
-Please check [7-1-stable](https://github.com/rails/rails/blob/7-1-stable/railties/CHANGELOG.md) for previous changes.
+Please check [7-2-stable](https://github.com/rails/rails/blob/7-2-stable/railties/CHANGELOG.md) for previous changes.

data/lib/minitest/rails_plugin.rb

@@ -110,7 +110,7 @@ module Minitest
   # minitest-reporters, maxitest, and others.
   def self.plugin_rails_init(options)
     # Don't mess with Minitest unless RAILS_ENV is set
-    return unless ENV["RAILS_ENV"]
+    return unless ENV["RAILS_ENV"] || ENV["RAILS_MINITEST_PLUGIN"]
 
     unless options[:full_backtrace]
       # Plugin can run without Rails loaded, check before filtering.

data/lib/rails/application/configuration.rb

@@ -15,7 +15,7 @@ module Rails
                     :cache_classes, :cache_store, :consider_all_requests_local, :console,
                     :eager_load, :exceptions_app, :file_watcher, :filter_parameters, :precompile_filter_parameters,
                     :force_ssl, :helpers_paths, :hosts, :host_authorization, :logger, :log_formatter,
-                    :log_tags, :railties_order, :relative_url_root,
+                    :log_tags, :silence_healthcheck_path, :railties_order, :relative_url_root,
                     :ssl_options, :public_file_server,
                     :session_options, :time_zone, :reload_classes_only_on_change,
                     :beginning_of_week, :filter_redirect, :x,
@@ -62,6 +62,7 @@ module Rails
         @exceptions_app                          = nil
         @autoflush_log                           = true
         @log_formatter                           = ActiveSupport::Logger::SimpleFormatter.new
+        @silence_healthcheck_path                = nil
         @eager_load                              = nil
         @secret_key_base                         = nil
         @api_only                                = false
@@ -114,7 +115,9 @@ module Rails
             action_controller.forgery_protection_origin_check = true
           end
 
-          ActiveSupport.to_time_preserves_timezone = true
+          if respond_to?(:active_support)
+            active_support.to_time_preserves_timezone = :offset
+          end
 
           if respond_to?(:active_record)
             active_record.belongs_to_required_by_default = true
@@ -335,6 +338,16 @@ module Rails
             active_record.postgresql_adapter_decode_dates = true
             active_record.validate_migration_timestamps = true
           end
+        when "8.0"
+          load_defaults "7.2"
+
+          if respond_to?(:active_support)
+            active_support.to_time_preserves_timezone = :zone
+          end
+
+          if respond_to?(:action_dispatch)
+            action_dispatch.strict_freshness = true
+          end
         else
           raise "Unknown version #{target_version.to_s.inspect}"
         end

data/lib/rails/application/default_middleware_stack.rb

@@ -54,6 +54,10 @@ module Rails
           middleware.use ::ActionDispatch::RequestId, header: config.action_dispatch.request_id_header
           middleware.use ::ActionDispatch::RemoteIp, config.action_dispatch.ip_spoofing_check, config.action_dispatch.trusted_proxies
 
+          if path = config.silence_healthcheck_path
+            middleware.use ::Rails::Rack::SilenceRequest, path: path
+          end
+
           middleware.use ::Rails::Rack::Logger, config.log_tags
           middleware.use ::ActionDispatch::ShowExceptions, show_exceptions_app
           middleware.use ::ActionDispatch::DebugExceptions, app, config.debug_exception_response_format

data/lib/rails/application/finisher.rb

@@ -143,6 +143,7 @@ module Rails
           app.routes.prepend do
             get "/rails/info/properties" => "rails/info#properties", internal: true
             get "/rails/info/routes"     => "rails/info#routes",     internal: true
+            get "/rails/info/notes"      => "rails/info#notes",      internal: true
             get "/rails/info"            => "rails/info#index",      internal: true
           end
 
@@ -159,7 +160,6 @@ module Rails
       initializer :set_routes_reloader_hook do |app|
         reloader = routes_reloader
         reloader.eager_load = app.config.eager_load
-        reloader.execute
         reloaders << reloader
 
         app.reloader.to_run do
@@ -177,7 +177,7 @@ module Rails
           ActiveSupport.run_load_hooks(:after_routes_loaded, self)
         end
 
-        ActiveSupport.run_load_hooks(:after_routes_loaded, self)
+        reloader.execute_unless_loaded if !app.routes.is_a?(Engine::LazyRouteSet) || app.config.eager_load
       end
 
       # Set clearing dependencies after the finisher hook to ensure paths

data/lib/rails/application/routes_reloader.rb

@@ -7,7 +7,7 @@ module Rails
     class RoutesReloader
       include ActiveSupport::Callbacks
 
-      attr_reader :route_sets, :paths, :external_routes
+      attr_reader :route_sets, :paths, :external_routes, :loaded
       attr_accessor :eager_load
       attr_writer :run_after_load_paths # :nodoc:
       delegate :execute_if_updated, :execute, :updated?, to: :updater
@@ -17,9 +17,11 @@ module Rails
         @route_sets = []
         @external_routes = []
         @eager_load = false
+        @loaded = false
       end
 
       def reload!
+        @loaded = true
         clear!
         load_paths
         finalize!
@@ -28,6 +30,14 @@ module Rails
         revert
       end
 
+      def execute_unless_loaded
+        unless @loaded
+          execute
+          ActiveSupport.run_load_hooks(:after_routes_loaded, Rails.application)
+          true
+        end
+      end
+
     private
       def updater
         @updater ||= begin

data/lib/rails/application.rb

@@ -9,6 +9,7 @@ require "active_support/deprecation"
 require "active_support/encrypted_configuration"
 require "active_support/hash_with_indifferent_access"
 require "active_support/configuration_file"
+require "active_support/parameter_filter"
 require "rails/engine"
 require "rails/autoloaders"
 
@@ -134,6 +135,13 @@ module Rails
       @initialized
     end
 
+    # Returns the dasherized application name.
+    #
+    #   MyApp::Application.new.name => "my-app"
+    def name
+      self.class.name.underscore.dasherize.delete_suffix("/application")
+    end
+
     def run_load_hooks! # :nodoc:
       return self if @ran_load_hooks
       @ran_load_hooks = true
@@ -153,6 +161,10 @@ module Rails
       routes_reloader.reload!
     end
 
+    def reload_routes_unless_loaded # :nodoc:
+      initialized? && routes_reloader.execute_unless_loaded
+    end
+
     # Returns a key generator (ActiveSupport::CachingKeyGenerator) for a
     # specified +secret_key_base+. The return value is memoized, so additional
     # calls with the same +secret_key_base+ will return the same key generator