railties 7.1.0.beta1 → 7.1.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f6bd5ef3fd826daba56de7c93ff5b7ca0481090c6699f69a86493c32878e3bb1
-  data.tar.gz: a2605e31ee7524c2aae5fb88f89201f22e97219fcb42f391a359a60cd1b667c3
+  metadata.gz: 4d9c922d487cf3c067c1a65e48220c5073060674bc98fd7d1bb8b1fd8ff9a557
+  data.tar.gz: 47298c50c11159f36d8f213fffc70aa1d416c114c1ee4a48d980e521ae88fb5c
 SHA512:
-  metadata.gz: 03b9cbaa154995862acc1d1e6f2cdcf1780fea3ddb9e3f0af8586b0d4698d08869e517d2d2f61057dd316e1cc723759da66de1ae6a8d01dfff30edd8c824711d
-  data.tar.gz: 59ccbc1582559ddc5baff3ea789bbf8e56a463100ed2d8858b852eaeb4feeb6cb0c178d4bf2e2abafce0b1e2b8145756a068d32996fd3e71ab992facb4ad646f
+  metadata.gz: 1479a364eb0e3afd7b3f8824819fe96a6145b7e144ffef4956d1f9083e932ff555432622897d6f845f7848d2b90e67868ad376fefc1bb56d7ba5789fa34975a5
+  data.tar.gz: 96ee0b4198d8b5d725ab27dd2caae58958fad652c11d4823c4c3107f39a89620b70e4ea05587100c862c5982d2108e05c7acdd803b7f4b3604022994f31f26dd

data/CHANGELOG.md

@@ -1,9 +1,48 @@
+## Rails 7.1.0.rc2 (October 01, 2023) ##
+
+*   Always set the Rails logger to be an instance of `ActiveSupport::BroadcastLogger`.
+
+    *Edouard Chin*
+
+
+## Rails 7.1.0.rc1 (September 27, 2023) ##
+
+*   Require `concurrent-ruby` in `config/puma.rb` so that Puma can boot in
+    production when `WEB_CONCURRENCY` is not explicitly specified.
+
+    Fixes #49323.
+
+    *Matt Brictson*
+
+*   Raise error when generating attribute with dangerous name.
+
+    The following will now raise an error as `save` and `hash` are already
+    defined by Active Record.
+
+    ```bash
+    $ bin/rails generate model Post save
+    $ bin/rails generate model Post hash
+    ```
+
+    *Petrik de Heus*
+
+
 ## Rails 7.1.0.beta1 (September 13, 2023) ##
 
+*   Add ability to show slow tests to the test runner
+
+    ```bash
+    $ bin/test --profile # additionally prints 10 (default) slowest tests
+    # or
+    $ bin/test --profile 20 # prints 20 slowest tests
+    ```
+
+    *fatkodima*
+
 *   `rails new --javascript` generator now supports Bun
 
     ```bash
-    rails new my_new_app --javascript=bun
+    $ rails new my_new_app --javascript=bun
     ```
 
     *Jason Meller*

data/lib/rails/application/bootstrap.rb

@@ -56,6 +56,10 @@ module Rails
         end
         Rails.logger.level = ActiveSupport::Logger.const_get(config.log_level.to_s.upcase)
 
+        broadcast_logger = ActiveSupport::BroadcastLogger.new(Rails.logger)
+        broadcast_logger.formatter = Rails.logger.formatter
+        Rails.logger = broadcast_logger
+
         unless config.consider_all_requests_local
           Rails.error.logger = Rails.logger
         end

data/lib/rails/commands/server/server_command.rb

@@ -80,7 +80,7 @@ module Rails
         console.level = Rails.logger.level
 
         unless ActiveSupport::Logger.logger_outputs_to?(Rails.logger, STDERR, STDOUT)
-          Rails.logger.extend(ActiveSupport::Logger.broadcast(console))
+          Rails.logger.broadcast_to(console)
         end
       end
 

data/lib/rails/gem_version.rb

@@ -10,7 +10,7 @@ module Rails
     MAJOR = 7
     MINOR = 1
     TINY  = 0
-    PRE   = "beta1"
+    PRE   = "rc2"
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".")
   end

data/lib/rails/generators/app_base.rb

@@ -345,6 +345,10 @@ module Rails
         options[:skip_active_storage]
       end
 
+      def skip_action_cable? # :doc:
+        options[:skip_action_cable]
+      end
+
       def skip_action_mailer? # :doc:
         options[:skip_action_mailer]
       end
@@ -497,7 +501,7 @@ module Rails
       end
 
       def dockerfile_bun_version
-        using_bun? and "bun-v#{`bun --version`[/\d+\.\d+\.\d+/]}"
+        using_bun? and `bun --version`[/\d+\.\d+\.\d+/]
       rescue
         BUN_VERSION
       end

data/lib/rails/generators/database.rb

@@ -27,6 +27,26 @@ module Rails
         end
       end
 
+      def docker_for_database_build(database = options[:database])
+        case database
+        when "mysql"          then "build-essential default-libmysqlclient-dev git"
+        when "trilogy"        then "build-essential default-libmysqlclient-dev git"
+        when "postgresql"     then "build-essential git libpq-dev"
+        when "sqlite3"        then "build-essential git"
+        else nil
+        end
+      end
+
+      def docker_for_database_deploy(database = options[:database])
+        case database
+        when "mysql"          then "curl default-mysql-client libvips"
+        when "trilogy"        then "curl default-mysql-client libvips"
+        when "postgresql"     then "curl libvips postgresql-client"
+        when "sqlite3"        then "curl libsqlite3-0 libvips"
+        else nil
+        end
+      end
+
       def convert_database_option_for_jruby
         if defined?(JRUBY_VERSION)
           opt = options.dup

data/lib/rails/generators/generated_attribute.rb

@@ -43,6 +43,10 @@ module Rails
           type, attr_options = *parse_type_and_options(type)
           type = type.to_sym if type
 
+          if dangerous_name?(name)
+            raise Error, "Could not generate field '#{name}', as it is already defined by Active Record."
+          end
+
           if type && !valid_type?(type)
             raise Error, "Could not generate field '#{name}' with unknown type '#{type}'."
           end
@@ -60,8 +64,14 @@ module Rails
           new(name, type, index_type, attr_options)
         end
 
+        def dangerous_name?(name)
+          defined?(ActiveRecord::Base) &&
+            ActiveRecord::Base.dangerous_attribute_method?(name)
+        end
+
         def valid_type?(type)
           DEFAULT_TYPES.include?(type.to_s) ||
+            !defined?(ActiveRecord::Base) ||
             ActiveRecord::Base.connection.valid_type?(type)
         end
 

data/lib/rails/generators/rails/app/USAGE

@@ -9,11 +9,18 @@ Description:
     Note that the arguments specified in the .railsrc file don't affect the
     default values shown above in this help message.
 
+    You can specify which version to use when creating a new rails application 
+    using `rails _<version>_ new`.
+
 Examples:
     `rails new ~/Code/Ruby/weblog`
 
     This generates a new Rails app in ~/Code/Ruby/weblog.
 
+    `rails _<version>_ new weblog`
+
+    This generates a new Rails app with the provided version in ./weblog.
+
     `rails new weblog --api`
 
     This generates a new Rails app in API mode in ./weblog.

data/lib/rails/generators/rails/app/templates/Dockerfile.tt

@@ -32,21 +32,18 @@ RUN curl -sL https://github.com/nodenv/node-build/archive/master.tar.gz | tar xz
     rm -rf /tmp/node-build-master
 
 <% end -%>
-
 <% if using_bun? -%>
 ENV BUN_INSTALL=/usr/local/bun
 ENV PATH=/usr/local/bun/bin:$PATH
 ARG BUN_VERSION=<%= dockerfile_bun_version %>
-RUN curl -fsSL https://bun.sh/install | bash -s -- "${BUN_VERSION}"
+RUN curl -fsSL https://bun.sh/install | bash -s -- "bun-v${BUN_VERSION}"
 
 <% end -%>
-
 # Install application gems
 COPY Gemfile Gemfile.lock ./
 RUN bundle install && \
     rm -rf ~/.bundle/ "${BUNDLE_PATH}"/ruby/*/cache "${BUNDLE_PATH}"/ruby/*/bundler/gems/*/.git<% if depend_on_bootsnap? -%> && \
-    bundle exec bootsnap precompile --gemfile
-<% end %>
+    bundle exec bootsnap precompile --gemfile<% end %>
 
 <% if using_node? -%>
 # Install node modules
@@ -54,7 +51,6 @@ COPY package.json yarn.lock ./
 RUN yarn install --frozen-lockfile
 
 <% end -%>
-
 <% if using_bun? -%>
 # Install node modules
 COPY package.json bun.lockb ./

data/lib/rails/generators/rails/app/templates/Gemfile.tt

@@ -51,7 +51,7 @@ group :development do
   # Speed up commands on slow machines / big apps [https://github.com/rails/spring]
   # gem "spring"
 
-<%- if RUBY_VERSION >= "3.1" -%>
+<%- if RUBY_VERSION >= "3.1" && RUBY_VERSION < "3.2" -%>
   gem "error_highlight", ">= 0.4.0", platforms: [:ruby]
 <%- end -%>
 end
@@ -63,6 +63,6 @@ group :test do
   gem "selenium-webdriver"
 <%- if RUBY_VERSION < "3.0" -%>
   gem "webdrivers"
-<% end %>
+<%- end -%>
 end
 <%- end -%>

data/lib/rails/generators/rails/app/templates/config/application.rb.tt

@@ -15,7 +15,9 @@ module <%= app_const_base %>
     config.load_defaults Rails::VERSION::STRING.to_f
 <%- end -%>
 
-    # Please, see https://guides.rubyonrails.org/autoloading_and_reloading_constants.html#config-autoload-lib-ignore.
+    # Please, add to the `ignore` list any other `lib` subdirectories that do
+    # not contain `.rb` files, or that should not be reloaded or eager loaded.
+    # Common ones are `templates`, `generators`, or `middleware`, for example.
     config.autoload_lib(ignore: %w(assets tasks))
 
     # Configuration for the application, engines, and railties goes here.

data/lib/rails/generators/rails/app/templates/config/environments/development.rb.tt

@@ -80,9 +80,11 @@ Rails.application.configure do
   # Annotate rendered view with file names.
   # config.action_view.annotate_rendered_view_with_filenames = true
 
+  <%- unless skip_action_cable? -%>
   # Uncomment if you wish to allow Action Cable access from any origin.
   # config.action_cable.disable_request_forgery_protection = true
 
+  <%- end -%>
   # Raise error when a before_action's only/except options reference missing actions
   config.action_controller.raise_on_missing_callback_actions = true
 end

data/lib/rails/generators/rails/app/templates/config/environments/production.rb.tt

@@ -45,7 +45,7 @@ Rails.application.configure do
   config.active_storage.service = :local
 
   <%- end -%>
-  <%- unless options[:skip_action_cable] -%>
+  <%- unless skip_action_cable? -%>
   # Mount Action Cable outside main process or domain.
   # config.action_cable.mount_path = nil
   # config.action_cable.url = "wss://example.com/cable"

data/lib/rails/generators/rails/app/templates/config/initializers/filter_parameter_logging.rb.tt

@@ -1,8 +1,8 @@
 # Be sure to restart your server when you modify this file.
 
-# Configure parameters to be filtered from the log file. Use this to limit dissemination of
-# sensitive information. See the ActiveSupport::ParameterFilter documentation for supported
-# notations and behaviors.
+# Configure parameters to be partially matched (e.g. passw matches password) and filtered from the log file. 
+# Use this to limit dissemination of sensitive information. 
+# See the ActiveSupport::ParameterFilter documentation for supported notations and behaviors.
 Rails.application.config.filter_parameters += [
   :passw, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn
 ]

data/lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults_7_1.rb.tt

@@ -11,7 +11,7 @@
 
 # No longer add autoloaded paths into `$LOAD_PATH`. This means that you won't be able
 # to manually require files that are managed by the autoloader, which you shouldn't do anyway.
-# This reduce the size of the load path, making `require` faster if you don't use bootsnap, or reduce the size
+# This will reduce the size of the load path, making `require` faster if you don't use bootsnap, or reduce the size
 # of the bootsnap cache if you use it.
 # Rails.application.config.add_autoload_paths_to_load_path = false
 

data/lib/rails/generators/rails/app/templates/config/puma.rb.tt

@@ -13,6 +13,7 @@ threads min_threads_count, max_threads_count
 
 # Specifies that the worker count should equal the number of processors in production.
 if ENV["RAILS_ENV"] == "production"
+  require "concurrent-ruby"
   worker_count = Integer(ENV.fetch("WEB_CONCURRENCY") { Concurrent.physical_processor_count })
   workers worker_count if worker_count > 1
 end

data/lib/rails/generators/rails/app/templates/config/routes.rb.tt

@@ -6,5 +6,5 @@ Rails.application.routes.draw do
   get "up" => "rails/health#show", as: :rails_health_check
 
   # Defines the root path route ("/")
-  # root "articles#index"
+  # root "posts#index"
 end

data/lib/rails/generators/rails/app/templates/dockerignore.tt

@@ -6,14 +6,14 @@
 # Ignore bundler config.
 /.bundle
 
+# Ignore all environment files (except templates).
+/.env*
+!/.env*.erb
+
 # Ignore all default key files.
 /config/master.key
 /config/credentials/*.key
 
-# Ignore all environment files.
-/.env*
-!/.env.example
-
 # Ignore all logfiles and tempfiles.
 /log/*
 /tmp/*

data/lib/rails/generators/rails/app/templates/gitignore.tt

@@ -7,6 +7,10 @@
 # Ignore bundler config.
 /.bundle
 
+# Ignore all environment files (except templates).
+/.env*
+!/.env*.erb
+
 # Ignore all logfiles and tempfiles.
 /log/*
 /tmp/*

data/lib/rails/generators/rails/db/system/change/change_generator.rb

@@ -40,16 +40,43 @@ module Rails
             gsub_file("Gemfile", gem_entry_regex_for(name), gem_entry_for(name, *version))
           end
 
+          def edit_dockerfile
+            build_name = docker_for_database_build
+            deploy_name = docker_for_database_deploy
+            if build_name
+              gsub_file("Dockerfile", all_docker_builds_regex, build_name)
+            end
+            if deploy_name
+              gsub_file("Dockerfile", all_docker_deploys_regex, deploy_name)
+            end
+          end
+
           private
             def all_database_gems
               DATABASES.map { |database| gem_for_database(database) }
             end
 
+            def all_docker_builds
+              DATABASES.map { |database| docker_for_database_build(database).nil? ? nil : docker_for_database_build(database) }.compact!
+            end
+
+            def all_docker_deploys
+              DATABASES.map { |database| docker_for_database_deploy(database).nil? ? nil : docker_for_database_deploy(database) }.compact!
+            end
+
             def all_database_gems_regex
               all_database_gem_names = all_database_gems.map(&:first)
               /(\b#{all_database_gem_names.join('\b|\b')}\b)/
             end
 
+            def all_docker_builds_regex
+              /(\b#{all_docker_builds.join('\b|\b')}\b)/
+            end
+
+            def all_docker_deploys_regex
+              /(\b#{all_docker_deploys.join('\b|\b')}\b)/
+            end
+
             def gem_entry_regex_for(gem_name)
               /^gem.*\b#{gem_name}\b.*/
             end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: railties
 version: !ruby/object:Gem::Version
-  version: 7.1.0.beta1
+  version: 7.1.0.rc2
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-09-13 00:00:00.000000000 Z
+date: 2023-10-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.1.0.beta1
+        version: 7.1.0.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.1.0.beta1
+        version: 7.1.0.rc2
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.1.0.beta1
+        version: 7.1.0.rc2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.1.0.beta1
+        version: 7.1.0.rc2
 - !ruby/object:Gem::Dependency
   name: rackup
   requirement: !ruby/object:Gem::Requirement
@@ -120,14 +120,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.1.0.beta1
+        version: 7.1.0.rc2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 7.1.0.beta1
+        version: 7.1.0.rc2
 description: 'Rails internals: application bootup, plugins, generators, and rake tasks.'
 email: david@loudthinking.com
 executables:
@@ -457,10 +457,10 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/rails/rails/issues
-  changelog_uri: https://github.com/rails/rails/blob/v7.1.0.beta1/railties/CHANGELOG.md
-  documentation_uri: https://api.rubyonrails.org/v7.1.0.beta1/
+  changelog_uri: https://github.com/rails/rails/blob/v7.1.0.rc2/railties/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v7.1.0.rc2/
   mailing_list_uri: https://discuss.rubyonrails.org/c/rubyonrails-talk
-  source_code_uri: https://github.com/rails/rails/tree/v7.1.0.beta1/railties
+  source_code_uri: https://github.com/rails/rails/tree/v7.1.0.rc2/railties
   rubygems_mfa_required: 'true'
 post_install_message:
 rdoc_options: