railties 5.2.4.1 → 6.0.1

data/lib/rails/tasks.rb

@@ -15,6 +15,7 @@ require "rake"
   routes
   tmp
   yarn
+  zeitwerk
 ).tap { |arr|
   arr << "statistics" if Rake.application.current_scope.empty?
 }.each do |task|

data/lib/rails/tasks/annotations.rake

@@ -2,21 +2,21 @@
 
 require "rails/source_annotation_extractor"
 
-desc "Enumerate all annotations (use notes:optimize, :fixme, :todo for focus)"
-task :notes do
-  SourceAnnotationExtractor.enumerate "OPTIMIZE|FIXME|TODO", tag: true
+task notes: :environment do
+  Rails::SourceAnnotationExtractor::Annotation.notes_task_deprecation_warning
+  Rails::Command.invoke :notes
 end
 
 namespace :notes do
   ["OPTIMIZE", "FIXME", "TODO"].each do |annotation|
-    # desc "Enumerate all #{annotation} annotations"
-    task annotation.downcase.intern do
-      SourceAnnotationExtractor.enumerate annotation
+    task annotation.downcase.intern => :environment do
+      Rails::SourceAnnotationExtractor::Annotation.notes_task_deprecation_warning
+      Rails::Command.invoke :notes, ["--annotations", annotation]
     end
   end
 
-  desc "Enumerate a custom annotation, specify with ANNOTATION=CUSTOM"
-  task :custom do
-    SourceAnnotationExtractor.enumerate ENV["ANNOTATION"]
+  task custom: :environment do
+    Rails::SourceAnnotationExtractor::Annotation.notes_task_deprecation_warning
+    Rails::Command.invoke :notes, ["--annotations", ENV["ANNOTATION"]]
   end
 end

data/lib/rails/tasks/dev.rake

@@ -1,10 +1,11 @@
 # frozen_string_literal: true
 
-require "rails/dev_caching"
+require "rails/command"
+require "active_support/deprecation"
 
 namespace :dev do
-  desc "Toggle development mode caching on/off"
-  task :cache do
-    Rails::DevCaching.enable_by_file
+  task cache: :environment do
+    ActiveSupport::Deprecation.warn("Using `bin/rake dev:cache` is deprecated and will be removed in Rails 6.1. Use `bin/rails dev:cache` instead.\n")
+    Rails::Command.invoke "dev:cache"
   end
 end

data/lib/rails/tasks/framework.rake

@@ -2,7 +2,7 @@
 
 namespace :app do
   desc "Update configs and some other initially generated files (or use just update:configs or update:bin)"
-  task update: [ "update:configs", "update:bin", "update:upgrade_guide_info" ]
+  task update: [ "update:configs", "update:bin", "update:active_storage", "update:upgrade_guide_info" ]
 
   desc "Applies the template supplied by LOCATION=(/path/to/template) or URL"
   task template: :environment do
@@ -51,6 +51,10 @@ namespace :app do
       Rails::AppUpdater.invoke_from_app_generator :update_bin_files
     end
 
+    task :active_storage do
+      Rails::AppUpdater.invoke_from_app_generator :update_active_storage
+    end
+
     task :upgrade_guide_info do
       Rails::AppUpdater.invoke_from_app_generator :display_upgrade_guide_info
     end

data/lib/rails/tasks/initializers.rake

@@ -1,8 +1,9 @@
 # frozen_string_literal: true
 
-desc "Print out all defined initializers in the order they are invoked by Rails."
+require "rails/command"
+require "active_support/deprecation"
+
 task initializers: :environment do
-  Rails.application.initializers.tsort_each do |initializer|
-    puts "#{initializer.context_class}.#{initializer.name}"
-  end
+  ActiveSupport::Deprecation.warn("Using `bin/rake initializers` is deprecated and will be removed in Rails 6.1. Use `bin/rails initializers` instead.\n")
+  Rails::Command.invoke "initializers"
 end

data/lib/rails/tasks/log.rake

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 namespace :log do
-
   ##
   # Truncates all/specified log files
   # ENV['LOGS']

data/lib/rails/tasks/routes.rake

@@ -1,31 +1,9 @@
 # frozen_string_literal: true
 
-require "optparse"
+require "rails/command"
+require "active_support/deprecation"
 
-desc "Print out all defined routes in match order, with names. Target specific controller with -c option, or grep routes using -g option"
 task routes: :environment do
-  all_routes = Rails.application.routes.routes
-  require "action_dispatch/routing/inspector"
-  inspector = ActionDispatch::Routing::RoutesInspector.new(all_routes)
-
-  routes_filter = nil
-
-  OptionParser.new do |opts|
-    opts.banner = "Usage: rails routes [options]"
-
-    Rake.application.standard_rake_options.each { |args| opts.on(*args) }
-
-    opts.on("-c CONTROLLER") do |controller|
-      routes_filter = { controller: controller }
-    end
-
-    opts.on("-g PATTERN") do |pattern|
-      routes_filter = pattern
-    end
-
-  end.parse!(ARGV.reject { |x| x == "routes" })
-
-  puts inspector.format(ActionDispatch::Routing::ConsoleFormatter.new, routes_filter)
-
-  exit 0 # ensure extra arguments aren't interpreted as Rake tasks
+  ActiveSupport::Deprecation.warn("Using `bin/rake routes` is deprecated and will be removed in Rails 6.1. Use `bin/rails routes` instead.\n")
+  Rails::Command.invoke "routes"
 end

data/lib/rails/tasks/statistics.rake

@@ -9,14 +9,18 @@ STATS_DIRECTORIES = [
   %w(Jobs               app/jobs),
   %w(Models             app/models),
   %w(Mailers            app/mailers),
+  %w(Mailboxes          app/mailboxes),
   %w(Channels           app/channels),
   %w(JavaScripts        app/assets/javascripts),
+  %w(JavaScript         app/javascript),
   %w(Libraries          lib/),
   %w(APIs               app/apis),
   %w(Controller\ tests  test/controllers),
   %w(Helper\ tests      test/helpers),
   %w(Model\ tests       test/models),
   %w(Mailer\ tests      test/mailers),
+  %w(Mailbox\ tests     test/mailboxes),
+  %w(Channel\ tests     test/channels),
   %w(Job\ tests         test/jobs),
   %w(Integration\ tests test/integration),
   %w(System\ tests      test/system),

data/lib/rails/tasks/yarn.rake

@@ -8,7 +8,7 @@ namespace :yarn do
     node_env = ENV.fetch("NODE_ENV") do
       valid_node_envs.include?(Rails.env) ? Rails.env : "production"
     end
-    system({ "NODE_ENV" => node_env }, "./bin/yarn install --no-progress")
+    system({ "NODE_ENV" => node_env }, "#{Rails.root}/bin/yarn install --no-progress --frozen-lockfile")
   end
 end
 

data/lib/rails/tasks/zeitwerk.rake

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+ensure_zeitwerk_mode = ->() do
+  unless Rails.autoloaders.zeitwerk_enabled?
+    abort "Please, enable :zeitwerk mode in config/application.rb and try again."
+  end
+end
+
+eager_load = ->() do
+  puts "Hold on, I am eager loading the application."
+  Zeitwerk::Loader.eager_load_all
+end
+
+report_not_checked = ->(not_checked) do
+  puts
+  puts <<~EOS
+    WARNING: The files in these directories cannot be checked because they
+    are not eager loaded:
+  EOS
+  puts
+
+  not_checked.each { |dir| puts "  #{dir}" }
+  puts
+
+  puts <<~EOS
+    You may verify them manually, or add them to config.eager_load_paths
+    in config/application.rb and run zeitwerk:check again.
+  EOS
+  puts
+end
+
+report = ->(not_checked) do
+  if not_checked.any?
+    report_not_checked[not_checked]
+    puts "Otherwise, all is good!"
+  else
+    puts "All is good!"
+  end
+end
+
+namespace :zeitwerk do
+  desc "Checks project structure for Zeitwerk compatibility"
+  task check: :environment do
+    ensure_zeitwerk_mode[]
+
+    begin
+      eager_load[]
+    rescue NameError => e
+      if e.message =~ /expected file .*? to define constant [\w:]+/
+        abort $&.sub(/expected file #{Regexp.escape(Rails.root.to_s)}./, "expected file ")
+      else
+        raise
+      end
+    end
+
+    eager_load_paths = Rails.configuration.eager_load_namespaces.map do |eln|
+      eln.config.eager_load_paths if eln.respond_to?(:config)
+    end.compact.flatten
+
+    not_checked = ActiveSupport::Dependencies.autoload_paths - eager_load_paths
+    not_checked.select! { |dir| Dir.exist?(dir) }
+    not_checked.reject! { |dir| Dir.empty?(dir) }
+
+    report[not_checked]
+  end
+end

data/lib/rails/templates/rails/welcome/index.html.erb

@@ -62,11 +62,11 @@
 
       <h1>Yay! You&rsquo;re on Rails!</h1>
 
-      
+      
 
       <p class="version">
         <strong>Rails version:</strong> <%= Rails.version %><br />
-        <strong>Ruby version:</strong> <%= RUBY_VERSION %> (<%= RUBY_PLATFORM %>)
+        <strong>Ruby version:</strong> <%= RUBY_DESCRIPTION %>
       </p>
     </section>
   </div>

data/lib/rails/test_help.rb

@@ -20,27 +20,29 @@ if defined?(ActiveRecord::Base)
     exit 1
   end
 
-  module ActiveSupport
-    class TestCase
-      include ActiveRecord::TestFixtures
-      self.fixture_path = "#{Rails.root}/test/fixtures/"
-      self.file_fixture_path = fixture_path + "files"
-    end
+  ActiveSupport.on_load(:active_support_test_case) do
+    include ActiveRecord::TestDatabases
+    include ActiveRecord::TestFixtures
+
+    self.fixture_path = "#{Rails.root}/test/fixtures/"
+    self.file_fixture_path = fixture_path + "files"
   end
 
-  ActionDispatch::IntegrationTest.fixture_path = ActiveSupport::TestCase.fixture_path
+  ActiveSupport.on_load(:action_dispatch_integration_test) do
+    self.fixture_path = ActiveSupport::TestCase.fixture_path
+  end
 end
 
 # :enddoc:
 
-class ActionController::TestCase
+ActiveSupport.on_load(:action_controller_test_case) do
   def before_setup # :nodoc:
     @routes = Rails.application.routes
     super
   end
 end
 
-class ActionDispatch::IntegrationTest
+ActiveSupport.on_load(:action_dispatch_integration_test) do
   def before_setup # :nodoc:
     @routes = Rails.application.routes
     super

data/lib/rails/test_unit/reporter.rb

@@ -5,7 +5,7 @@ require "minitest"
 
 module Rails
   class TestUnitReporter < Minitest::StatisticsReporter
-    class_attribute :executable, default: "bin/rails test"
+    class_attribute :executable, default: "rails test"
 
     def record(result)
       super

data/lib/rails/test_unit/runner.rb

@@ -12,8 +12,8 @@ module Rails
 
       class << self
         def attach_before_load_options(opts)
-          opts.on("--warnings", "-w", "Run with Ruby warnings enabled") {}
-          opts.on("-e", "--environment ENV", "Run tests in the ENV environment") {}
+          opts.on("--warnings", "-w", "Run with Ruby warnings enabled") { }
+          opts.on("-e", "--environment ENV", "Run tests in the ENV environment") { }
         end
 
         def parse_options(argv)
@@ -63,7 +63,7 @@ module Rails
             # Extract absolute and relative paths but skip -n /.*/ regexp filters.
             argv.select { |arg| arg =~ %r%^/?\w+/% && !arg.end_with?("/") }.map do |path|
               case
-              when path =~ /(:\d+)+$/
+              when /(:\d+)+$/.match?(path)
                 file, *lines = path.split(":")
                 filters << [ file, lines ]
                 file
@@ -87,7 +87,7 @@ module Rails
         @filters = [ @named_filter, *derive_line_filters(patterns) ].compact
       end
 
-      # Minitest uses === to find matching filters.
+      # minitest uses === to find matching filters.
       def ===(method)
         @filters.any? { |filter| filter === method }
       end
@@ -96,7 +96,7 @@ module Rails
         def derive_named_filter(filter)
           if filter.respond_to?(:named_filter)
             filter.named_filter
-          elsif filter =~ %r%/(.*)/% # Regexp filtering copied from Minitest.
+          elsif filter =~ %r%/(.*)/% # Regexp filtering copied from minitest.
             Regexp.new $1
           elsif filter.is_a?(String)
             filter

data/lib/rails/test_unit/testing.rake

@@ -28,7 +28,7 @@ namespace :test do
   desc "Run tests quickly, but also reset db"
   task db: %w[db:test:prepare test]
 
-  ["models", "helpers", "controllers", "mailers", "integration", "jobs"].each do |name|
+  ["models", "helpers", "channels", "controllers", "mailers", "integration", "jobs", "mailboxes"].each do |name|
     task name => "test:prepare" do
       $: << "test"
       Rails::TestUnit::Runner.rake_run(["test/#{name}"])

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: railties
 version: !ruby/object:Gem::Version
-  version: 5.2.4.1
+  version: 6.0.1
 platform: ruby
 authors:
 - David Heinemeier Hansson
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-12-18 00:00:00.000000000 Z
+date: 2019-11-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.2.4.1
+        version: 6.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.2.4.1
+        version: 6.0.1
 - !ruby/object:Gem::Dependency
   name: actionpack
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.2.4.1
+        version: 6.0.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.2.4.1
+        version: 6.0.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -58,7 +58,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.19.0
+        version: 0.20.3
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -68,7 +68,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.19.0
+        version: 0.20.3
     - - "<"
       - !ruby/object:Gem::Version
         version: '2.0'
@@ -92,14 +92,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.2.4.1
+        version: 6.0.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 5.2.4.1
+        version: 6.0.1
 description: 'Rails internals: application bootup, plugins, generators, and rake tasks.'
 email: david@loudthinking.com
 executables:
@@ -123,9 +123,11 @@ files:
 - lib/rails/application/bootstrap.rb
 - lib/rails/application/configuration.rb
 - lib/rails/application/default_middleware_stack.rb
+- lib/rails/application/dummy_erb_compiler.rb
 - lib/rails/application/finisher.rb
 - lib/rails/application/routes_reloader.rb
 - lib/rails/application_controller.rb
+- lib/rails/autoloaders.rb
 - lib/rails/backtrace_cleaner.rb
 - lib/rails/cli.rb
 - lib/rails/code_statistics.rb
@@ -136,21 +138,27 @@ files:
 - lib/rails/command/behavior.rb
 - lib/rails/command/environment_argument.rb
 - lib/rails/command/helpers/editor.rb
+- lib/rails/command/spellchecker.rb
 - lib/rails/commands.rb
 - lib/rails/commands/application/application_command.rb
 - lib/rails/commands/console/console_command.rb
 - lib/rails/commands/credentials/USAGE
 - lib/rails/commands/credentials/credentials_command.rb
+- lib/rails/commands/db/system/change/change_command.rb
 - lib/rails/commands/dbconsole/dbconsole_command.rb
 - lib/rails/commands/destroy/destroy_command.rb
+- lib/rails/commands/dev/dev_command.rb
 - lib/rails/commands/encrypted/USAGE
 - lib/rails/commands/encrypted/encrypted_command.rb
 - lib/rails/commands/generate/generate_command.rb
 - lib/rails/commands/help/USAGE
 - lib/rails/commands/help/help_command.rb
+- lib/rails/commands/initializers/initializers_command.rb
 - lib/rails/commands/new/new_command.rb
+- lib/rails/commands/notes/notes_command.rb
 - lib/rails/commands/plugin/plugin_command.rb
 - lib/rails/commands/rake/rake_command.rb
+- lib/rails/commands/routes/routes_command.rb
 - lib/rails/commands/runner/USAGE
 - lib/rails/commands/runner/runner_command.rb
 - lib/rails/commands/secrets/USAGE
@@ -173,10 +181,12 @@ files:
 - lib/rails/generators/actions/create_migration.rb
 - lib/rails/generators/active_model.rb
 - lib/rails/generators/app_base.rb
+- lib/rails/generators/app_name.rb
 - lib/rails/generators/base.rb
 - lib/rails/generators/css/assets/assets_generator.rb
 - lib/rails/generators/css/assets/templates/stylesheet.css
 - lib/rails/generators/css/scaffold/scaffold_generator.rb
+- lib/rails/generators/database.rb
 - lib/rails/generators/erb.rb
 - lib/rails/generators/erb/controller/controller_generator.rb
 - lib/rails/generators/erb/controller/templates/view.html.erb.tt
@@ -192,8 +202,6 @@ files:
 - lib/rails/generators/erb/scaffold/templates/new.html.erb.tt
 - lib/rails/generators/erb/scaffold/templates/show.html.erb.tt
 - lib/rails/generators/generated_attribute.rb
-- lib/rails/generators/js/assets/assets_generator.rb
-- lib/rails/generators/js/assets/templates/javascript.js
 - lib/rails/generators/migration.rb
 - lib/rails/generators/model_helpers.rb
 - lib/rails/generators/named_base.rb
@@ -203,24 +211,23 @@ files:
 - lib/rails/generators/rails/app/templates/README.md.tt
 - lib/rails/generators/rails/app/templates/Rakefile.tt
 - lib/rails/generators/rails/app/templates/app/assets/config/manifest.js.tt
-- lib/rails/generators/rails/app/templates/app/assets/javascripts/application.js.tt
-- lib/rails/generators/rails/app/templates/app/assets/javascripts/cable.js.tt
 - lib/rails/generators/rails/app/templates/app/assets/stylesheets/application.css.tt
 - lib/rails/generators/rails/app/templates/app/channels/application_cable/channel.rb.tt
 - lib/rails/generators/rails/app/templates/app/channels/application_cable/connection.rb.tt
 - lib/rails/generators/rails/app/templates/app/controllers/application_controller.rb.tt
 - lib/rails/generators/rails/app/templates/app/helpers/application_helper.rb.tt
+- lib/rails/generators/rails/app/templates/app/javascript/channels/consumer.js
+- lib/rails/generators/rails/app/templates/app/javascript/channels/index.js
+- lib/rails/generators/rails/app/templates/app/javascript/packs/application.js.tt
 - lib/rails/generators/rails/app/templates/app/jobs/application_job.rb.tt
 - lib/rails/generators/rails/app/templates/app/mailers/application_mailer.rb.tt
 - lib/rails/generators/rails/app/templates/app/models/application_record.rb.tt
 - lib/rails/generators/rails/app/templates/app/views/layouts/application.html.erb.tt
 - lib/rails/generators/rails/app/templates/app/views/layouts/mailer.html.erb.tt
 - lib/rails/generators/rails/app/templates/app/views/layouts/mailer.text.erb.tt
-- lib/rails/generators/rails/app/templates/bin/bundle.tt
 - lib/rails/generators/rails/app/templates/bin/rails.tt
 - lib/rails/generators/rails/app/templates/bin/rake.tt
 - lib/rails/generators/rails/app/templates/bin/setup.tt
-- lib/rails/generators/rails/app/templates/bin/update.tt
 - lib/rails/generators/rails/app/templates/bin/yarn.tt
 - lib/rails/generators/rails/app/templates/config.ru.tt
 - lib/rails/generators/rails/app/templates/config/application.rb.tt
@@ -250,7 +257,7 @@ files:
 - lib/rails/generators/rails/app/templates/config/initializers/filter_parameter_logging.rb.tt
 - lib/rails/generators/rails/app/templates/config/initializers/inflections.rb.tt
 - lib/rails/generators/rails/app/templates/config/initializers/mime_types.rb.tt
-- lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults_5_2.rb.tt
+- lib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults_6_0.rb.tt
 - lib/rails/generators/rails/app/templates/config/initializers/wrap_parameters.rb.tt
 - lib/rails/generators/rails/app/templates/config/locales/en.yml
 - lib/rails/generators/rails/app/templates/config/puma.rb.tt
@@ -269,16 +276,17 @@ files:
 - lib/rails/generators/rails/app/templates/public/robots.txt
 - lib/rails/generators/rails/app/templates/ruby-version.tt
 - lib/rails/generators/rails/app/templates/test/application_system_test_case.rb.tt
+- lib/rails/generators/rails/app/templates/test/channels/application_cable/connection_test.rb.tt
 - lib/rails/generators/rails/app/templates/test/test_helper.rb.tt
 - lib/rails/generators/rails/application_record/application_record_generator.rb
 - lib/rails/generators/rails/assets/USAGE
 - lib/rails/generators/rails/assets/assets_generator.rb
-- lib/rails/generators/rails/assets/templates/javascript.js
 - lib/rails/generators/rails/assets/templates/stylesheet.css
 - lib/rails/generators/rails/controller/USAGE
 - lib/rails/generators/rails/controller/controller_generator.rb
 - lib/rails/generators/rails/controller/templates/controller.rb.tt
 - lib/rails/generators/rails/credentials/credentials_generator.rb
+- lib/rails/generators/rails/db/system/change/change_generator.rb
 - lib/rails/generators/rails/encrypted_file/encrypted_file_generator.rb
 - lib/rails/generators/rails/encryption_key_file/encryption_key_file_generator.rb
 - lib/rails/generators/rails/generator/USAGE
@@ -403,6 +411,7 @@ files:
 - lib/rails/tasks/statistics.rake
 - lib/rails/tasks/tmp.rake
 - lib/rails/tasks/yarn.rake
+- lib/rails/tasks/zeitwerk.rake
 - lib/rails/templates/layouts/application.html.erb
 - lib/rails/templates/rails/info/properties.html.erb
 - lib/rails/templates/rails/info/routes.html.erb
@@ -418,12 +427,15 @@ files:
 - lib/rails/test_unit/testing.rake
 - lib/rails/version.rb
 - lib/rails/welcome_controller.rb
-homepage: http://rubyonrails.org
+homepage: https://rubyonrails.org
 licenses:
 - MIT
 metadata:
-  source_code_uri: https://github.com/rails/rails/tree/v5.2.4.1/railties
-  changelog_uri: https://github.com/rails/rails/blob/v5.2.4.1/railties/CHANGELOG.md
+  bug_tracker_uri: https://github.com/rails/rails/issues
+  changelog_uri: https://github.com/rails/rails/blob/v6.0.1/railties/CHANGELOG.md
+  documentation_uri: https://api.rubyonrails.org/v6.0.1/
+  mailing_list_uri: https://groups.google.com/forum/#!forum/rubyonrails-talk
+  source_code_uri: https://github.com/rails/rails/tree/v6.0.1/railties
 post_install_message: 
 rdoc_options:
 - "--exclude"
@@ -434,7 +446,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.2.2
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="