railspress-engine 1.0.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00fa3ef64f615a9f1a7bb10c79085c50657dfa462e3f61e57002dfdc9e181d5e
-  data.tar.gz: c241000c9554ac492a6fed87f1d1bded59ea3257541d14e6a855c3102463cf03
+  metadata.gz: f1ca2f73a89851d3359c2d32b51c5b5a3770e9e5d3c4f81655e5436fcf249fd4
+  data.tar.gz: 5c8c712b7139a6ab50be2b30831de8320b254a99a96e8f23fa69c0ad4d2ab8ae
 SHA512:
-  metadata.gz: aa8e9ad5cf137778317c7c94bf9c75fdffe5a32356a3a2681ef6278868e16d16d9b9686edab3bcd4c190136f8fcfc0cefab0799d50fed20c37a74978cfea7e7b
-  data.tar.gz: 2fe456078ff4a52b014a43b56f3ad8e434b62f001ac42b07dd5cc5eb335af88a5ae428c13863cf467df69e0c749bd74792b7590d94ccacc6e63b2aa528fc9089
+  metadata.gz: fc61ccdaa5f8af6baa55c5186c07525a5272bb87bf4bec19f09c1ec6bdd710d8107d804a384f4d339a5243a8d44d0ca4dc82655a6328775587a831077567b470
+  data.tar.gz: d8d931f5f83c225d75b7d939a5251e4d8343c6b223fc7e56d8855024da7c58fae3c3236348e51aafc2e80f144cfc6e2dc40899db430e6da5df87f8b01530dd45

data/README.md

@@ -4,7 +4,7 @@
 </p>
 
 <p align="center">
-  <a href="https://rubygems.org/gems/railspress-engine"><img src="https://img.shields.io/gem/v/railspress-engine.svg?style=flat" alt="Gem Version"></a>
+  <a href="https://rubygems.org/gems/railspress-engine"><img src="https://img.shields.io/gem/v/railspress-engine.svg?style=flat&bump=true" alt="Gem Version"></a>
   <img src="https://img.shields.io/badge/Rails-8.1%2B-red.svg?style=flat" alt="Rails 8.1+">
   <img src="https://img.shields.io/badge/Ruby-3.3%2B-red.svg?style=flat" alt="Ruby 3.3+">
   <a href="https://osaasy.dev/"><img src="https://img.shields.io/badge/License-O'Saasy-blue.svg?style=flat" alt="License"></a>
@@ -14,6 +14,8 @@
 
 RailsPress is a mountable Rails engine that gives your app a complete content management system — namespaced and isolated so it stays out of your way.
 
+You can read more at [Railspress.org](https://railspress.org).
+
 It manages three kinds of content:
 
 ## Posts, Entities, and Blocks

data/app/assets/stylesheets/railspress/admin/components/lexxy.css

@@ -4,11 +4,21 @@
  */
 
 :where(lexxy-toolbar){
+  position: sticky;
+  top: 0;
+  z-index: 10;
+  background: var(--rp-bg-elevated, #fff);
   margin-bottom: 20px;
   padding-bottom: 10px;
+  border-bottom: 1px solid var(--rp-border);
 }
 
-/* Fix toolbar dropdown alignment (color/link buttons) */
+/*
+ * Disabled custom Lexxy dropdown sizing override.
+ * Lexxy 0.9.8.beta manages dropdown layout internally; forcing fixed 34x34
+ * sizing can break toolbar dropdown/picker rendering.
+ */
+/*
 .lexxy-editor__toolbar-dropdown {
   width: 34px !important;
   height: 34px !important;
@@ -30,6 +40,7 @@
 .lexxy-editor__toolbar-dropdown > summary::-webkit-details-marker {
   display: none;
 }
+*/
 
 /* Rich text content spacing */
 .rp-rich-text p,

data/app/helpers/railspress/cms_helper.rb

@@ -153,8 +153,9 @@ module Railspress
     private
 
     # Wrap content in a Stimulus-controlled <span> for inline editing.
-    # Includes a display Turbo Frame, hidden context menu with form Turbo Frame,
-    # and hidden backdrop.
+    # Only the display Turbo Frame lives inside the span — the menu and
+    # backdrop are created dynamically on document.body by the JS controller
+    # to avoid inheriting ancestor stacking contexts (opacity, transforms).
     def inline_wrapper_for(content_element, rendered_content)
       suffix = SecureRandom.hex(4)
       display_frame_id = "cms_display_#{content_element.id}_#{suffix}"
@@ -177,27 +178,7 @@ module Railspress
         },
         style: "display:contents"
       ) do
-        # Display frame (replaced after save)
-        display = content_tag("turbo-frame", rendered_content, id: display_frame_id)
-
-        # Context menu panel (hidden by default)
-        menu = content_tag(:div, class: "rp-inline-menu rp-inline-hidden",
-          data: { "rp--cms-inline-editor-target": "menu" }
-        ) do
-          # Form Turbo Frame (lazy-loaded on first open)
-          content_tag("turbo-frame", "", id: form_frame_id,
-            src: nil,
-            data: { "rp--cms-inline-editor-target": "frame" })
-        end
-
-        # Backdrop (hidden by default)
-        backdrop = content_tag(:div, "", class: "rp-inline-backdrop rp-inline-hidden",
-          data: {
-            "rp--cms-inline-editor-target": "backdrop",
-            action: "click->rp--cms-inline-editor#close"
-          })
-
-        safe_join([ display, menu, backdrop ])
+        content_tag("turbo-frame", rendered_content, id: display_frame_id)
       end
     end
 

data/app/javascript/railspress/controllers/cms_inline_editor_controller.js

@@ -7,6 +7,9 @@ import { Controller } from "@hotwired/stimulus"
  * Opens a positioned context menu with a Turbo Frame that lazy-loads an
  * inline edit form from the admin controller.
  *
+ * The menu and backdrop are created dynamically on document.body to avoid
+ * inheriting ancestor stacking contexts (opacity, transforms, etc.).
+ *
  * Usage (generated by CmsHelper#inline_wrapper_for):
  *   <span data-controller="rp--cms-inline-editor"
  *         data-rp--cms-inline-editor-inline-path-value="/railspress/admin/content_elements/1/inline"
@@ -15,17 +18,10 @@ import { Controller } from "@hotwired/stimulus"
  *         data-rp--cms-inline-editor-element-id-value="1"
  *         data-action="contextmenu->rp--cms-inline-editor#open"
  *         style="display:contents">
- *
  *     <turbo-frame id="cms_display_1_abc123">Content here</turbo-frame>
- *     <div class="rp-inline-menu rp-inline-hidden" data-rp--cms-inline-editor-target="menu">
- *       <turbo-frame id="cms_form_1_abc123" data-rp--cms-inline-editor-target="frame"></turbo-frame>
- *     </div>
- *     <div class="rp-inline-backdrop rp-inline-hidden" data-rp--cms-inline-editor-target="backdrop"></div>
  *   </span>
  */
 export default class extends Controller {
-  static targets = ["menu", "frame", "backdrop"]
-
   static values = {
     inlinePath: String,
     frameId: String,
@@ -37,32 +33,53 @@ export default class extends Controller {
   connect() {
     this._handleKeydown = this.handleKeydown.bind(this)
     this._handleSubmitEnd = this.handleSubmitEnd.bind(this)
+    this._handleBackdropClick = () => this.close()
   }
 
   disconnect() {
     document.removeEventListener("keydown", this._handleKeydown)
-    this.element.removeEventListener("turbo:submit-end", this._handleSubmitEnd)
+    if (this._menu) this._menu.remove()
+    if (this._backdrop) this._backdrop.remove()
+  }
+
+  // Lazily create the menu and backdrop on document.body (once per controller)
+  _ensureMenuExists() {
+    if (this._menu) return
+
+    this._backdrop = document.createElement("div")
+    this._backdrop.className = "rp-inline-backdrop rp-inline-hidden"
+    this._backdrop.addEventListener("click", this._handleBackdropClick)
+    document.body.appendChild(this._backdrop)
+
+    this._menu = document.createElement("div")
+    this._menu.className = "rp-inline-menu rp-inline-hidden"
+    document.body.appendChild(this._menu)
+
+    this._frame = document.createElement("turbo-frame")
+    this._frame.id = this.formFrameIdValue
+    this._menu.appendChild(this._frame)
   }
 
   open(event) {
     event.preventDefault()
     event.stopPropagation()
 
+    this._ensureMenuExists()
+
     // Close any other open inline editors (one-at-a-time)
     document.querySelectorAll(".rp-inline-menu:not(.rp-inline-hidden)").forEach(menu => {
-      const controller = this.application.getControllerForElementAndIdentifier(
-        menu.closest("[data-controller*='rp--cms-inline-editor']"),
-        "rp--cms-inline-editor"
-      )
-      if (controller && controller !== this) controller.close()
+      if (menu !== this._menu) menu.classList.add("rp-inline-hidden")
+    })
+    document.querySelectorAll(".rp-inline-backdrop:not(.rp-inline-hidden)").forEach(backdrop => {
+      if (backdrop !== this._backdrop) backdrop.classList.add("rp-inline-hidden")
     })
 
     // Lazy-load the form Turbo Frame on first open
-    if (!this.loadedValue && this.hasFrameTarget) {
+    if (!this.loadedValue) {
       const url = new URL(this.inlinePathValue, window.location.origin)
       url.searchParams.set("form_frame_id", this.formFrameIdValue)
       url.searchParams.set("display_frame_id", this.frameIdValue)
-      this.frameTarget.setAttribute("src", url.toString())
+      this._frame.setAttribute("src", url.toString())
       this.loadedValue = true
     }
 
@@ -70,19 +87,19 @@ export default class extends Controller {
     this.positionMenu(event.clientX, event.clientY)
 
     // Show menu and backdrop
-    this.menuTarget.classList.remove("rp-inline-hidden")
-    this.backdropTarget.classList.remove("rp-inline-hidden")
+    this._menu.classList.remove("rp-inline-hidden")
+    this._backdrop.classList.remove("rp-inline-hidden")
 
     // Listen for escape and form submission
     document.addEventListener("keydown", this._handleKeydown)
-    this.element.addEventListener("turbo:submit-end", this._handleSubmitEnd)
+    this._menu.addEventListener("turbo:submit-end", this._handleSubmitEnd)
   }
 
   close() {
-    this.menuTarget.classList.add("rp-inline-hidden")
-    this.backdropTarget.classList.add("rp-inline-hidden")
+    if (this._menu) this._menu.classList.add("rp-inline-hidden")
+    if (this._backdrop) this._backdrop.classList.add("rp-inline-hidden")
     document.removeEventListener("keydown", this._handleKeydown)
-    this.element.removeEventListener("turbo:submit-end", this._handleSubmitEnd)
+    if (this._menu) this._menu.removeEventListener("turbo:submit-end", this._handleSubmitEnd)
   }
 
   handleKeydown(event) {
@@ -101,7 +118,7 @@ export default class extends Controller {
   }
 
   positionMenu(x, y) {
-    const menu = this.menuTarget
+    const menu = this._menu
     // Reset position to measure natural dimensions
     menu.style.left = "0px"
     menu.style.top = "0px"

data/app/javascript/railspress/index.js

@@ -16,6 +16,9 @@
  *   register(application)
  */
 
+// Lexxy rich text editor
+import "lexxy"
+
 // Import Turbo for Turbo Frames support
 import "@hotwired/turbo-rails"
 

data/app/models/railspress/focal_point.rb

@@ -30,7 +30,7 @@ module Railspress
 
     # Get override for specific context
     def override_for(context)
-      overrides[context.to_s]&.with_indifferent_access
+      overrides&.dig(context.to_s)&.with_indifferent_access
     end
 
     # Check if context has custom override (not using focal point)

data/app/models/railspress/post_export_processor.rb

@@ -132,7 +132,7 @@ module Railspress
       zip_filename = "posts_export_#{timestamp}.zip"
       zip_path = Rails.root.join("tmp", zip_filename)
 
-      Zip::File.open(zip_path, Zip::File::CREATE) do |zipfile|
+      Zip::File.open(zip_path, create: true) do |zipfile|
         add_directory_to_zip(zipfile, @export_dir, "")
       end
 

data/app/models/railspress/post_import_processor.rb

@@ -60,9 +60,9 @@ module Railspress
           zip_file.each do |entry|
             next if entry.name.start_with?("__MACOSX", ".")
 
-            destination = File.join(@extract_dir, entry.name)
-            FileUtils.mkdir_p(File.dirname(destination))
-            entry.extract(destination) unless File.exist?(destination)
+            # rubyzip 3+ expects extraction with a destination directory.
+            destination = File.join(@extract_dir.to_s, entry.name)
+            entry.extract(entry.name, destination_directory: @extract_dir.to_s) unless File.exist?(destination)
           end
         end
 

data/app/models/railspress/tag.rb

@@ -21,7 +21,9 @@ module Railspress
       return [] if csv_string.blank?
 
       tag_names = csv_string.split(",").map { |t| t.strip.downcase }.reject(&:blank?).uniq
-      tag_names.map { |name| find_or_create_by(name: name) }
+      tag_names.map do |name|
+        find_by(name: name) || find_by(slug: name.parameterize) || create!(name: name)
+      end
     end
 
     private

data/app/services/railspress/content_import_service.rb

@@ -73,9 +73,9 @@ module Railspress
             break
           end
 
-          destination = File.join(@extract_dir, entry.name)
-          FileUtils.mkdir_p(File.dirname(destination))
-          entry.extract(destination) unless File.exist?(destination)
+          # rubyzip 3+ expects extraction with a destination directory.
+          destination = File.join(@extract_dir.to_s, entry.name)
+          entry.extract(entry.name, destination_directory: @extract_dir.to_s) unless File.exist?(destination)
         end
       end
     rescue Zip::Error => e

data/config/importmap.rb

@@ -8,6 +8,9 @@
 #
 # This auto-registers all RailsPress Stimulus controllers.
 
+# Lexxy rich text editor (hard dependency — auto-pinned so host apps don't need to)
+pin "lexxy", to: "lexxy.js"
+
 # Turbo for Turbo Frames support
 pin "@hotwired/turbo-rails", to: "turbo.min.js"
 

data/lib/generators/railspress/install/install_generator.rb

@@ -10,6 +10,10 @@ module Railspress
 
       desc "Install RailsPress: copy migrations, mount engine, and configure JavaScript"
 
+      def detect_install_mode
+        @upgrading_existing_install = existing_railspress_installation?
+      end
+
       def copy_railspress_migrations
         run "bundle exec rake railspress:install:migrations"
       end
@@ -59,17 +63,7 @@ module Railspress
           say_status :pinned, "@rails/activestorage in importmap", :green
         end
 
-        # Pin Lexxy editor
-        if importmap_content.include?('"lexxy"')
-          say_status :skip, "Lexxy already pinned in importmap", :yellow
-        else
-          append_to_file importmap_file, <<~RUBY
-
-            # RailsPress rich text editor
-            pin "lexxy", to: "lexxy.js"
-          RUBY
-          say_status :pinned, "Lexxy in importmap", :green
-        end
+        # Lexxy is auto-pinned by the engine's importmap — no host app pin needed
       end
 
       def generate_initializer
@@ -84,21 +78,34 @@ module Railspress
       end
 
       def show_post_install_message
+        upgrading = !!@upgrading_existing_install
+
         say ""
         say "=" * 60, :green
-        say "  RailsPress installed successfully!", :green
+        say("  RailsPress #{upgrading ? "upgrade setup completed!" : "installed successfully!"}", :green)
         say "=" * 60, :green
         say ""
-        say "Next steps:", :yellow
+        say(upgrading ? "Upgrade next steps:" : "Next steps:", :yellow)
         say ""
-        say "  1. Run migrations:"
-        say "     $ rails db:migrate", :cyan
-        say ""
-        say "  2. Access the admin dashboard:"
-        say "     http://localhost:3000/railspress/admin", :cyan
-        say ""
-        say "  3. (Optional) Change the mount path in config/routes.rb:"
-        say "     mount Railspress::Engine => \"/blog\"", :cyan
+        if upgrading
+          say "  1. Review upgrade notes:"
+          say "     docs/UPGRADING.md", :cyan
+          say ""
+          say "  2. Run migrations:"
+          say "     $ rails db:migrate", :cyan
+          say ""
+          say "  3. Verify your JS integration if using host-page features:"
+          say '     app/javascript/application.js includes: import "railspress"', :cyan
+        else
+          say "  1. Run migrations:"
+          say "     $ rails db:migrate", :cyan
+          say ""
+          say "  2. Access the admin dashboard:"
+          say "     http://localhost:3000/railspress/admin", :cyan
+          say ""
+          say "  3. (Optional) Change the mount path in config/routes.rb:"
+          say '     mount Railspress::Engine => "/blog"', :cyan
+        end
         say ""
         say "Optional features:", :yellow
         say "  Edit config/initializers/railspress.rb to enable:"
@@ -106,6 +113,9 @@ module Railspress
         say "    - Inline CMS editing (config.inline_editing_check)"
         say "  See docs/CONFIGURING.md and docs/INLINE_EDITING.md for details."
         say ""
+        say "Full guides & documentation:", :yellow
+        say "  https://railspress.org", :cyan
+        say ""
         say "=" * 60, :green
       end
 
@@ -130,6 +140,16 @@ module Railspress
       def importmap_available?
         defined?(Importmap) && Rails.root.join("config", "importmap.rb").exist?
       end
+
+      def existing_railspress_installation?
+        routes_mounted = File.read(rails_route_file).include?("Railspress::Engine")
+        initializer_exists = Rails.root.join("config", "initializers", "railspress.rb").exist?
+        migrations_copied = Dir.glob(migrations_dir.join("*railspress*.rb")).any?
+
+        routes_mounted || initializer_exists || migrations_copied
+      rescue Errno::ENOENT
+        false
+      end
     end
   end
 end

data/lib/railspress/version.rb

@@ -1,3 +1,3 @@
 module Railspress
-  VERSION = "1.0.0"
+  VERSION = "1.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: railspress-engine
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Avi Flombaum
@@ -27,42 +27,42 @@ dependencies:
   name: lexxy
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.6.beta
+        version: 0.9.0.beta
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.7.6.beta
+        version: 0.9.0.beta
 - !ruby/object:Gem::Dependency
   name: rubyzip
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.3'
 - !ruby/object:Gem::Dependency
   name: redcarpet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.6'
 - !ruby/object:Gem::Dependency
@@ -297,14 +297,19 @@ metadata:
 post_install_message: |2+
 
   ============================================================
-    RailsPress installed! Run the generator to complete setup:
+    RailsPress installed/updated.
 
+    New install:
       $ rails generate railspress:install
 
-    This will:
-      - Copy database migrations
-      - Mount the engine in your routes
-      - Install ActionText (if needed)
+    Upgrading existing app:
+      $ rails railspress:install:migrations
+      $ rails db:migrate
+
+    Guides:
+      - Install/setup: README.md + docs/CONFIGURING.md
+      - Upgrading: docs/UPGRADING.md
+      - Full docs: https://railspress.org
   ============================================================
 
 rdoc_options: []