rails_validations 1.1.2 → 1.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fc1dd77a7c0210226a3a1d51326400739d74839b
-  data.tar.gz: a6d84e924ef157d550e5a1d560eebb69d6801902
+  metadata.gz: ddd6882125ca697433e2c84a1abe00d27915a047
+  data.tar.gz: c5989625d5445cc3c945dacca0508af06326bc34
 SHA512:
-  metadata.gz: 354295b2cd7f84d48ac1cc619da220cf79ae65205f876118da20bb626fa69f8304d3808836ebc6dcbeb012c165417cceedddf3282bbe8234a7a373d6eaa38d02
-  data.tar.gz: 05fd3b1468787d6252cc663b0fafe84ed6986142133cb523f755bc9d8aabba9661651e3efaacff55eff9cb0b7c5bdc055da629b811e34ba36162e42a03928cf6
+  metadata.gz: ec30b335a30fe9d5edcb557305aba2801d7311482ae6524beed630a6c4b0a26ee445211cf911b217663d316807c73fe537468a27b7dc54e14433106e1d763ffd
+  data.tar.gz: 28d39fdf01a7018dd1497b02188016bb350fb85655c1c773695b6d673f016f5f7098b749970a5c81e2b37ccd49ddf9685f31c82a5da0ff8c901f47dbe12fe6fa

data/README.markdown

@@ -97,26 +97,32 @@ Currently implemented countries:
 ChangeLog
 =========
 
-version 1.1.2, 20141201
------------------------
+Version 1.1.3, 2014-12-03
+-------------------------
+- Make sure that the date validator doesn’t throw an exception if
+  `'invalid'.to_date` fails.
+
+
+Version 1.1.2, 2014-12-01
+-------------------------
 - Fix typo in Dutch translation.
 - Update some docs.
 
 
-version 1.1.1, 20141013
------------------------
+Version 1.1.1, 2014-10-13
+-------------------------
 - Fix i18n key for `phone`.
 - Allow passing a Proc to `date` without an argument.
 
 
-version 1.1, 20141003
----------------------
+Version 1.1, 2014-10-03
+-----------------------
 - Make the date validation work if the column it points to is `nil`.
 - Add documentation.
 
 
-version 1.0, 20140905
----------------------
+Version 1.0, 2014-09-05
+-----------------------
 - Initial release.
 
 

data/lib/validators/date_validator.rb

@@ -33,7 +33,11 @@ class DateValidator < ActiveModel::EachValidator
     value = if raw_value.is_a? Fixnum
               time.at(raw_value).to_date
             elsif raw_value.respond_to? :to_date
-              raw_value.to_date
+              begin
+                raw_value.to_date
+              rescue ArgumentError
+                false
+              end
             else
               false
             end

data/spec/spec_helper.rb

@@ -9,6 +9,7 @@ require 'action_view'
 require 'active_model'
 require 'active_record'
 require 'active_support'
+require 'active_support/all'
 
 #require 'rspec/rails'
 

data/spec/validations/date_spec.rb

@@ -1,5 +1,4 @@
 require 'spec_helper'
-require 'active_support/core_ext/date/calculations'
 
 module ValidationsSpecHelper
   class Date < ValidationsSpecHelper::Record
@@ -62,4 +61,11 @@ describe ValidationsSpecHelper::Date do
       expect(model(Date.today.advance days: -1).valid?).to eq(true)
     end
   end
+
+
+  it "works with input that is not even remotely a date" do
+    with_validation 'date: true' do
+      expect(model('Yesterday, a fish nibbled my toe.')).to_not be_valid
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_validations
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
 platform: ruby
 authors:
 - Martin Tournoij
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-01 00:00:00.000000000 Z
+date: 2014-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack