rails_twirp 0.13.2 → 0.15

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46c49b6df28547639b8c56395dfb5c9f327a4ec4b0c2b73b14cdf6b6594f1e17
-  data.tar.gz: f232e0c6f6eac4d4034050cf6cc38a8c6bdfa6a77b260fe54a2d4473a0512350
+  metadata.gz: 4e1b6e06cf246cc4ab4a639ca805033c8f96a24d2a1f468b733001b5f4ca9732
+  data.tar.gz: 4e03e912af4c785bbe9852245ed6e763e6d398c335dd63d4d0c4c3751402b814
 SHA512:
-  metadata.gz: e788cdd4ca43c5524ecc34f3dd43dbbbf7081689e0154133def3fcefd92955a46a3aa5abe280a44b51faef30b630f651bdcdbb00b5cade1194e83d969ddfac95
-  data.tar.gz: 1bb844a44698a1a9d1c85f80a555191f8ce5d43a8212e5629b4bdd657b3f908a37b6b50a65d1f28913015bfb477d984c40a09a6a4ba3bf86b20f0da4914c89ae
+  metadata.gz: 6cdc2a1d80937bbb85a513cc4807e9a91c5bd0848d5b959e90d226477231387c0e9250ec30bf7ff8da170c8cf64ca7136bcd47deb3fb23206797749bdbe624b8
+  data.tar.gz: 68c342ad35489011bc921dc4c7529d5ff7a18f47fce4aef9c597cebd2a789bdcec8050b6738cad457bcb54fce0b1c9f262558a964d42b26e1063a34f73f9d250

data/.github/workflows/test.yml

@@ -11,7 +11,7 @@ jobs:
       - name: Setup Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.0.0
+          ruby-version: 3.3.0
           bundler-cache: true
 
       - name: Run tests

data/.ruby-version

@@ -1 +1 @@
-3.0.3
+3.3.0

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+### 0.15.0
+
+* Exclude versions of Rails 7 which were incompatible with the pbbuilder ActionView handler, as pbbuilder cannot work there at all
+* Fix decode_rack_response to be compatible with Rack response body wrappers (and conform to the Rack SPEC)
+
+### 0.14.0
+* Adding frozen_string_literal: true to all files.
+
 ### 0.13.2
 * revert - include `test/` folder in a final gem distribution
 

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 # Specify your gem's dependencies in rails_twirp.gemspec.

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "bundler/setup"
 require "bundler/gem_tasks"
 require "rake/testtask"

data/lib/commands/twirp/routes_command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RailsTwirp
   module Command
     class RoutesCommand < Rails::Command::Base

data/lib/rails_twirp/application.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_twirp/route_set"
 
 module RailsTwirp

data/lib/rails_twirp/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_twirp/application"
 require "rails_twirp/route_set"
 require "rails/railtie"

data/lib/rails_twirp/errors.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "twirp/error"
 
 module RailsTwirp

data/lib/rails_twirp/exception_handling.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "twirp/error"
 
 module RailsTwirp

data/lib/rails_twirp/implicit_render.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "action_controller/metal/basic_implicit_render"
 
 module RailsTwirp

data/lib/rails_twirp/instrumentation.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RailsTwirp
   module Instrumentation
     extend ActiveSupport::Concern

data/lib/rails_twirp/log_subscriber.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/log_subscriber"
 
 module RailsTwirp

data/lib/rails_twirp/mapper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "forwardable"
 
 module RailsTwirp
@@ -57,10 +59,10 @@ module RailsTwirp
       @module = nil
     end
 
-    def service(service_definition, **options, &block)
+    def service(service_definition, **, &block)
       service_route_set = @route_set.services[service_definition]
       service_mapper = ServiceMapper.new(service_route_set, self)
-      scope(**options) { service_mapper.instance_exec(&block) }
+      scope(**) { service_mapper.instance_exec(&block) }
     end
 
     def scope(**options)

data/lib/rails_twirp/render_pb.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RailsTwirp
   # RenderPb makes it possible to do 'render pb: <proto object>', skipping templates
   # The way this module is written is inspired by ActionController::Renderers

data/lib/rails_twirp/rescue.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RailsTwirp
   module Rescue
     extend ActiveSupport::Concern

data/lib/rails_twirp/route_set.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Most of this logic is stolen from Rails ActionDispatch::Routing::RouteSet
 
 require "rails_twirp/mapper"

data/lib/rails_twirp/testing/integration_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "twirp/encoding"
 
 module RailsTwirp
@@ -89,7 +91,7 @@ module RailsTwirp
     end
 
     def decode_rack_response(service, rpc, status, headers, body)
-      body = body.join # body is an Enumerable
+      body = Array.wrap(body).join # body is each-able
 
       if status === 200
         output_class = service.rpcs[rpc][:output_class]

data/lib/rails_twirp/url_for.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "abstract_controller/url_for"
 
 module RailsTwirp

data/lib/rails_twirp/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RailsTwirp
-  VERSION = "0.13.2"
+  VERSION = "0.15"
 end

data/lib/rails_twirp.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "rails_twirp/version"
 
 require "rails_twirp/application"

data/rails_twirp.gemspec

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "lib/rails_twirp/version"
 
 Gem::Specification.new do |spec|
@@ -11,7 +13,10 @@ Gem::Specification.new do |spec|
 
   spec.files = `git ls-files`.split("\n")
 
-  spec.add_dependency "rails", ">= 6.1.3"
-  spec.add_dependency "twirp", ">= 1.9", "< 1.11"
+  # Rails has shipped an incompatible change in ActiveView, that was reverted in later versions.
+  # @see https://github.com/rails/rails/pull/51023
+  excluded_versions = ["7.1.0", "7.1.1", "7.1.2", "7.1.3"].map { |v| "!= #{v}" }
+  spec.add_runtime_dependency "rails", ">= 6.1.3", *excluded_versions
+  spec.add_runtime_dependency "twirp", ">= 1.9", "< 1.11"
   spec.required_ruby_version = ">= 3"
 end

data/test/dummy/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 

data/test/dummy/app/channels/application_cable/channel.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationCable
   class Channel < ActionCable::Channel::Base
   end

data/test/dummy/app/channels/application_cable/connection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ApplicationCable
   class Connection < ActionCable::Connection::Base
   end

data/test/dummy/app/controllers/application_controller.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 class ApplicationController < ActionController::Base
 end

data/test/dummy/app/controllers/application_twirp_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationTwirpController < RailsTwirp::Base
   rescue_from ActiveRecord::RecordNotFound, with: :handle_not_found
 

data/test/dummy/app/controllers/dummy_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DummyController < RailsTwirp::Base
   def rpc_name_check
     @rpc_name = rpc_name

data/test/dummy/app/controllers/pings_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PingsController < ApplicationTwirpController
   before_action :respond_error, only: :before_error
 

data/test/dummy/app/controllers/testmod/nested/other_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Testmod
   module Nested
     class OtherController < ApplicationTwirpController

data/test/dummy/app/helpers/application_helper.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 module ApplicationHelper
 end

data/test/dummy/app/helpers/random_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RandomHelper
   def does_this_work(n)
     n * 2

data/test/dummy/app/jobs/application_job.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationJob < ActiveJob::Base
   # Automatically retry jobs that encountered a deadlock
   # retry_on ActiveRecord::Deadlocked

data/test/dummy/app/mailers/application_mailer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationMailer < ActionMailer::Base
   default from: "from@example.com"
   layout "mailer"

data/test/dummy/app/models/application_record.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApplicationRecord < ActiveRecord::Base
   self.abstract_class = true
 end

data/test/dummy/config/application.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "boot"
 
 require "rails/all"

data/test/dummy/config/boot.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Set up gems listed in the Gemfile.
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../../Gemfile", __dir__)
 

data/test/dummy/config/environment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Load the Rails application.
 require_relative "application"
 

data/test/dummy/config/environments/development.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/integer/time"
 
 Rails.application.configure do

data/test/dummy/config/environments/production.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/integer/time"
 
 Rails.application.configure do

data/test/dummy/config/environments/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_support/core_ext/integer/time"
 
 # The test environment is used exclusively to run your application's

data/test/dummy/config/initializers/application_controller_renderer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # ActiveSupport::Reloader.to_prepare do

data/test/dummy/config/initializers/backtrace_silencers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.

data/test/dummy/config/initializers/content_security_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Define an application-wide content security policy

data/test/dummy/config/initializers/cookies_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Specify a serializer for the signed and encrypted cookie jars.

data/test/dummy/config/initializers/filter_parameter_logging.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Configure sensitive parameters which will be filtered from the log file.

data/test/dummy/config/initializers/inflections.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Add new inflection rules using the following format. Inflections

data/test/dummy/config/initializers/mime_types.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Add new mime types for use in respond_to blocks:

data/test/dummy/config/initializers/permissions_policy.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Define an application-wide HTTP permissions policy. For further
 # information see https://developers.google.com/web/updates/2018/06/feature-policy
 #

data/test/dummy/config/initializers/wrap_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # This file contains settings for ActionController::ParamsWrapper which

data/test/dummy/config/puma.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Puma can serve each request in a thread from an internal thread pool.
 # The `threads` method setting takes two numbers: a minimum and maximum.
 # Any libraries that use thread pools should be configured to match
@@ -19,10 +21,10 @@ port ENV.fetch("PORT", 3000)
 
 # Specifies the `environment` that Puma will run in.
 #
-environment ENV.fetch("RAILS_ENV") { "development" }
+environment ENV.fetch("RAILS_ENV", "development")
 
 # Specifies the `pidfile` that Puma will use.
-pidfile ENV.fetch("PIDFILE") { "tmp/pids/server.pid" }
+pidfile ENV.fetch("PIDFILE", "tmp/pids/server.pid")
 
 # Specifies the number of `workers` to boot in clustered mode.
 # Workers are forked web server processes. If using threads and workers together

data/test/dummy/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.routes.draw do
   mount RailsTwirp::Engine => "/twirp"
 end

data/test/dummy/config/twirp/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "../../proto/api_twirp"
 
 Rails.application.twirp.routes.draw do

data/test/dummy/config.ru

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This file is used by Rack-based servers to start the application.
 
 require_relative "config/environment"

data/test/dummy/proto/api_pb.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Generated by the protocol buffer compiler.  DO NOT EDIT!
 # source: api.proto
 

data/test/dummy/proto/api_twirp.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Code generated by protoc-gen-twirp_ruby 1.8.0, DO NOT EDIT.
 require "twirp"
 require_relative "api_pb"

data/test/dummy_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class DummyControllerTest < RailsTwirp::IntegrationTest

data/test/other_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class OtherControllerTest < RailsTwirp::IntegrationTest

data/test/ping_controller_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class PingControllerTest < RailsTwirp::IntegrationTest

data/test/rails_twirp_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "test_helper"
 
 class RailsTwirpTest < ActiveSupport::TestCase

data/test/test_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Configure Rails Environment
 ENV["RAILS_ENV"] = "test"
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_twirp
 version: !ruby/object:Gem::Version
-  version: 0.13.2
+  version: '0.15'
 platform: ruby
 authors:
 - Bouke van der Bijl
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-25 00:00:00.000000000 Z
+date: 2024-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -17,6 +17,18 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 6.1.3
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 7.1.0
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 7.1.1
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 7.1.2
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 7.1.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -24,6 +36,18 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 6.1.3
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 7.1.0
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 7.1.1
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 7.1.2
+    - - "!="
+      - !ruby/object:Gem::Version
+        version: 7.1.3
 - !ruby/object:Gem::Dependency
   name: twirp
   requirement: !ruby/object:Gem::Requirement
@@ -167,7 +191,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: Integrate Twirp into Rails