rails_spreadsheet_reader 0.1.0 → 0.1.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    YTMwNzIzNDhlOTA5ZDU4NzYxNzQ4OWY3ODhiNWZlZjhhZmI0NDg3ZA==
+    Nzc2ODllYzU0OGI0N2I4MzRhMDIzMmUzNTAxOWEzYWI4MjI2OWQ1MQ==
   data.tar.gz: !binary |-
-    NTZjOGQwNDdjZDVkYzIyNzkyNGZjM2Y0YTc2Zjg3ZGI4YWI1NzRmNw==
+    OTI2ODJlYTgzNDZlZjM4OTkzNDA3ZWRhNzQ1MWY5ODIxZjBjYmIxOQ==
 SHA512:
   metadata.gz: !binary |-
-    NGNkMjk0NDM5YThjMzE3NWNhMTE1MTIyZjhiOTQ0NTMwZjUwZjM1MmQxZDIw
-    ZGZiNTA3ZGYxMDU5YjFlNTAwMTg2NTcwYTkxNTliN2FkZWM2ODk1YzgzNzM1
-    YTg5Y2M0YzU4MWQxMGY0MWI3ZTRjZmZmNzVkZDEwYzBlMmMyMzA=
+    MDIxMTAxMDM0ZjdiOTcyZTA0NjE5YmMwMzVjNGE3MjAzODc1NjNhNDlhNzFj
+    MzAwMTc4MDAxOTA1MTQ4ZGMyYjM0OWNmMmQ4OWM3NDJjMjJjOTNkZjMxNTZl
+    MzQzMjAxMmQxMjNhMjc5Nzg2MGMyMjQ5N2Y5ODhjMTg1OGU0MTQ=
   data.tar.gz: !binary |-
-    MmUzMDAzZTJkZDQ5OWNmNDZmMGIxNDYyYzI1MzUxYWMwYjdkNjExYTBkMTQz
-    ZDRiZTI2YTI5MDI2NjM3YWZhYTk3ZmMwNmNhZDNlZTIzNTFhMTdkNWQzYzVk
-    Y2Q0MWVlNGNkNDcxMzI5NjRlMGJkNWQ3NWQxNTZkODE2ZDQ5YzA=
+    OTY3MDgwYmYwMjMwMTc5YzRmMWRjZDQ4ZTg1MGYwNDJjODc2YmRjZjgwZjBj
+    YjczYjdjZDMwMWQ0ZTUyNGNkMzFjYmVkOTgzNzgyMGNiOTQwNzhhZDUxZmI0
+    M2NlNzVmZDUzZmIwMjA2YWEwNmM4MDYxZGZmMTMwNGRjYzYxNGI=

data/lib/rails_spreadsheet_reader/base.rb

@@ -16,7 +16,7 @@ module RailsSpreadsheetReader
     # Copy a ActiveModel::Model errors
     def copy_errors(model)
       model.errors.each do |key, value|
-        self.errors[key] = value
+        errors.add(key, value)
       end
     end
 

data/lib/rails_spreadsheet_reader/version.rb

@@ -1,3 +1,3 @@
 module RailsSpreadsheetReader
-  VERSION = '0.1.0'
+  VERSION = '0.1.1'
 end

data/spec/base_spec.rb

@@ -73,4 +73,14 @@ describe RailsSpreadsheetReader::Base do
     expect(row_collection.errors.full_messages).to eq(["Email can't be blank"])
   end
 
+  it 'copy_errors' do
+    user_spreadsheet = UserSpreadsheet.new
+    user_spreadsheet.errors.add(:username, 'is unique')
+    expect(user_spreadsheet.valid?).to eq(false)
+    expect(user_spreadsheet.invalid?).to eq(true)
+    valid = UserSpreadsheet.new
+    valid.copy_errors(user_spreadsheet)
+    expect(valid.valid?).to eq(false)
+  end
+
 end

data/spec/models/user_spreadsheet.rb

@@ -8,4 +8,8 @@ class UserSpreadsheet < RailsSpreadsheetReader::Base
     { :username => 0, :email => 1, :gender => 2 }
   end
 
+  def make_invalid
+    errors[:username] = 'is invalid'
+  end
+
 end

data/spec/row_collection_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+require_relative 'models/invalid_column_spreadsheet'
+require_relative 'models/user_spreadsheet'
+require_relative 'models/user_invalid_spreadsheet'
+require_relative 'models/empty_column_spreadsheet.rb'
+
+describe RailsSpreadsheetReader::RowCollection do
+
+  it 'empty properties' do
+    collection = RailsSpreadsheetReader::RowCollection.new
+    expect(collection.rows).to eq([])
+    expect(collection.invalid?).to eq(false)
+    expect(collection.valid?).to eq(true)
+    expect(collection.errors).to eq(nil)
+  end
+
+  it 'push rows' do
+    collection = RailsSpreadsheetReader::RowCollection.new
+    user_spreadsheet = UserSpreadsheet.new
+    collection.push(user_spreadsheet)
+    expect(collection.rows.count).to eq(1)
+  end
+
+  it 'push invalid rows' do
+    collection = RailsSpreadsheetReader::RowCollection.new
+    user_spreadsheet = UserSpreadsheet.new
+    user_spreadsheet.make_invalid
+    expect(user_spreadsheet.invalid?).to eq(true)
+    collection.push(user_spreadsheet)
+    expect(collection.valid?).to eq(false)
+    expect(collection.invalid?).to eq(true)
+  end
+
+  it 'set_invalid_row' do
+    collection = RailsSpreadsheetReader::RowCollection.new
+    row = UserSpreadsheet.new
+    model = UserSpreadsheet.new
+    model.make_invalid
+    collection.push(row)
+    collection.set_invalid_row(row, model)
+    expect(collection.valid?).to eq(false)
+    expect(collection.invalid?).to eq(true)
+    expect(collection.invalid_row).to_not eq(nil)
+  end
+
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_spreadsheet_reader
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - muzk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-10 00:00:00.000000000 Z
+date: 2015-09-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -120,6 +120,7 @@ files:
 - spec/models/invalid_column_spreadsheet.rb
 - spec/models/user_invalid_spreadsheet.rb
 - spec/models/user_spreadsheet.rb
+- spec/row_collection_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/HasuSoftware/rails_spreadsheet_reader
 licenses:
@@ -153,4 +154,5 @@ test_files:
 - spec/models/invalid_column_spreadsheet.rb
 - spec/models/user_invalid_spreadsheet.rb
 - spec/models/user_spreadsheet.rb
+- spec/row_collection_spec.rb
 - spec/spec_helper.rb