rails_relations_fix 1.0.0

data/.document

@@ -0,0 +1,5 @@
+README.rdoc
+lib/**/*.rb
+bin/*
+features/**/*.feature
+LICENSE

data/.gitignore

@@ -0,0 +1,21 @@
+## MAC OS
+.DS_Store
+
+## TEXTMATE
+*.tmproj
+tmtags
+
+## EMACS
+*~
+\#*
+.\#*
+
+## VIM
+*.swp
+
+## PROJECT::GENERAL
+coverage
+rdoc
+pkg
+
+## PROJECT::SPECIFIC

data/LICENSE

@@ -0,0 +1,20 @@
+Copyright (c) 2009 Stanisław Kolarzowski
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.rdoc

@@ -0,0 +1,11 @@
+= rails_relations_fix
+
+This is fix for 2 rails bugs:
+  
+* Counter_cache is not updated in polymorhpic assocation https://rails.lighthouseapp.com/projects/8994/tickets/3005-counter_cache-not-updated-if-polymorphic-true-when-assigning-association 
+* destroy for association collection does not delete object from parent array https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets/3964-destroy-for-association-collection-does-not-delete-object-from-parent-array
+
+== Copyright
+
+* Used patch made by Hsume2 [http://github.com/hsume2]
+* Copyright (c) 2010 Stanisław Kolarzowski. See LICENSE for details.

data/Rakefile

@@ -0,0 +1,53 @@
+require 'rubygems'
+require 'rake'
+
+begin
+  require 'jeweler'
+  Jeweler::Tasks.new do |gem|
+    gem.name = "rails_relations_fix"
+    gem.summary = "Fix for 2 rails bugs"
+    gem.description = "Fix for 2 rails bugs. #3005 Counter_cache and polymorhic association. #3964 Not refreshing association after destroy"
+    gem.email = "stanislaw.kolarzowski@gmail.com"
+    gem.homepage = "http://github.com/staszek/rails_relations_fix"
+    gem.authors = ["Stanisław Kolarzowski"]
+    # gem.add_development_dependency "thoughtbot-shoulda", ">= 0"
+    # gem is a Gem::Specification... see http://www.rubygems.org/read/chapter/20 for additional settings
+  end
+  Jeweler::GemcutterTasks.new
+rescue LoadError
+  puts "Jeweler (or a dependency) not available. Install it with: gem install jeweler"
+end
+
+require 'rake/testtask'
+Rake::TestTask.new(:test) do |test|
+  test.libs << 'lib' << 'test'
+  test.pattern = 'test/**/test_*.rb'
+  test.verbose = true
+end
+
+begin
+  require 'rcov/rcovtask'
+  Rcov::RcovTask.new do |test|
+    test.libs << 'test'
+    test.pattern = 'test/**/test_*.rb'
+    test.verbose = true
+  end
+rescue LoadError
+  task :rcov do
+    abort "RCov is not available. In order to run rcov, you must: sudo gem install spicycode-rcov"
+  end
+end
+
+task :test => :check_dependencies
+
+task :default => :test
+
+require 'rake/rdoctask'
+Rake::RDocTask.new do |rdoc|
+  version = File.exist?('VERSION') ? File.read('VERSION') : ""
+
+  rdoc.rdoc_dir = 'rdoc'
+  rdoc.title = "rails_relations_fix #{version}"
+  rdoc.rdoc_files.include('README*')
+  rdoc.rdoc_files.include('lib/**/*.rb')
+end

data/VERSION

@@ -0,0 +1 @@
+1.0.0

data/lib/rails_relations_fix/association.rb

@@ -0,0 +1,11 @@
+module ActiveRecord
+  module Associations
+    class AssociationCollection < AssociationProxy
+      alias old_destroy destroy
+      def destroy(*records)
+        old_destroy(*records)
+        records.each{ |record| @target.delete(record)}
+      end
+    end
+  end
+end

data/lib/rails_relations_fix/counter_cache.rb

@@ -0,0 +1,83 @@
+module ActiveRecord
+  module Callbacks
+    NEW_CALLBACKS = %w(
+      before_add after_add before_remove after_remove
+    )
+
+    def self.define_callback_methods
+      base = ActiveRecord::Base
+      [:create, :update, :destroy].each do |method|
+        # Due to using aliast_method_chain for methods like method_name_with_callbacks they are not reading from this file. 
+        # They need to be reloaded.
+        base.send :alias_method, method, "#{method}_without_callbacks".to_sym
+        base.send :alias_method_chain, method, :callbacks
+      end
+      base.define_callbacks *NEW_CALLBACKS
+    end
+    
+    def create_with_callbacks #:nodoc:
+      return false if callback(:before_create) == false
+      return false if callback(:before_add) == false if changed?
+      result = create_without_callbacks
+      callback(:after_add) if changed?
+      callback(:after_create)
+      result
+    end
+    
+    def update_with_callbacks(*args) #:nodoc:
+      return false if callback(:before_update) == false
+      return false if callback(:before_add) == false if changed?
+      result = update_without_callbacks(*args)
+      callback(:after_add) if changed?
+      callback(:after_update)
+      result
+    end
+    
+    def destroy_with_callbacks #:nodoc:
+      return false if callback(:before_destroy) == false
+      return false if callback(:before_remove) == false
+      result = destroy_without_callbacks
+      callback(:after_remove)
+      callback(:after_destroy)
+      result
+    end
+    
+    def before_add()    end #:nodoc:
+    def after_add()     end #:nodoc:
+    def before_remove() end #:nodoc:
+    def after_remove()  end #:nodoc:
+    
+  end
+  
+  module Associations
+    module ClassMethods
+      def add_counter_cache_callbacks(reflection)
+        cache_column = reflection.counter_cache_column
+
+        method_name = "belongs_to_counter_cache_after_add_for_#{reflection.name}".to_sym
+        define_method(method_name) do
+
+          association = send(reflection.name, true) rescue nil
+          
+          if send("#{reflection.primary_key_name}_changed?") && send("#{reflection.primary_key_name}_change") != send("#{reflection.primary_key_name}_change").compact
+            association.class.increment_counter(cache_column, association.id) unless association.nil?
+          end
+        end
+        after_add(method_name)
+
+        method_name = "belongs_to_counter_cache_before_remove_for_#{reflection.name}".to_sym
+        define_method(method_name) do
+          association = send(reflection.name)
+          association.class.decrement_counter(cache_column, association.id) unless association.nil?
+        end
+        before_remove(method_name)
+
+        module_eval(
+          "#{reflection.class_name}.send(:attr_readonly,\"#{cache_column}\".intern) if defined?(#{reflection.class_name}) && #{reflection.class_name}.respond_to?(:attr_readonly)"
+        )
+      end
+    end
+  end
+  
+end
+

data/lib/rails_relations_fix.rb

@@ -0,0 +1,4 @@
+require "rails_relations_fix/association"
+require "rails_relations_fix/counter_cache"
+
+ActiveRecord::Callbacks.define_callback_methods

data/rails_relations_fix.gemspec

@@ -0,0 +1,53 @@
+# Generated by jeweler
+# DO NOT EDIT THIS FILE DIRECTLY
+# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
+# -*- encoding: utf-8 -*-
+
+Gem::Specification.new do |s|
+  s.name = %q{rails_relations_fix}
+  s.version = "1.0.0"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.authors = ["Stanis\305\202aw Kolarzowski"]
+  s.date = %q{2010-02-15}
+  s.description = %q{Fix for 2 rails bugs. #3005 Counter_cache and polymorhic association. #3964 Not refreshing association after destroy}
+  s.email = %q{stanislaw.kolarzowski@gmail.com}
+  s.extra_rdoc_files = [
+    "LICENSE",
+     "README.rdoc"
+  ]
+  s.files = [
+    ".document",
+     ".gitignore",
+     "LICENSE",
+     "README.rdoc",
+     "Rakefile",
+     "VERSION",
+     "lib/rails_relations_fix.rb",
+     "lib/rails_relations_fix/association.rb",
+     "lib/rails_relations_fix/counter_cache.rb",
+     "rails_relations_fix.gemspec",
+     "test/helper.rb",
+     "test/test_rails_relations_fix.rb"
+  ]
+  s.homepage = %q{http://github.com/staszek/rails_relations_fix}
+  s.rdoc_options = ["--charset=UTF-8"]
+  s.require_paths = ["lib"]
+  s.rubygems_version = %q{1.3.5}
+  s.summary = %q{Fix for 2 rails bugs}
+  s.test_files = [
+    "test/helper.rb",
+     "test/test_rails_relations_fix.rb"
+  ]
+
+  if s.respond_to? :specification_version then
+    current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION
+    s.specification_version = 3
+
+    if Gem::Version.new(Gem::RubyGemsVersion) >= Gem::Version.new('1.2.0') then
+    else
+    end
+  else
+  end
+end
+

data/test/helper.rb

@@ -0,0 +1,44 @@
+require 'rubygems'
+require 'test/unit'
+require 'shoulda'
+require "mocha"
+require "action_controller"
+require 'active_resource'
+require 'active_record'
+require 'active_support'
+require "active_record/base"
+require "active_record/associations"
+
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+
+require 'rails_relations_fix'
+
+ActiveRecord::Base.establish_connection(:adapter => "sqlite3", :database => ":memory:")
+ActiveRecord::Base.configurations = true
+ 
+ActiveRecord::Schema.verbose = false
+ActiveRecord::Schema.define(:version => 1) do
+  create_table :users do |t|
+    t.string :name
+    t.integer :movies_count
+  end
+  
+  create_table :movies do |t|
+    t.string :name
+    t.string :subject_type
+    t.integer :subject_id
+  end
+
+end
+
+class Test::Unit::TestCase
+  
+  class User < ActiveRecord::Base
+    has_many :movies, :as => :subject
+  end
+  
+  class Movie < ActiveRecord::Base
+    belongs_to :subject, :polymorphic => true, :counter_cache => true
+  end
+end

data/test/test_rails_relations_fix.rb

@@ -0,0 +1,48 @@
+require 'helper'
+
+class TestRailsRelationFix< Test::Unit::TestCase
+  context "RailsRelationFix tests" do
+    setup do
+      @user = User.create(:name => "John Rambo") 
+      @titanic = @user.movies.create(:name => "Titanic")
+    end
+
+    context "Models testing" do
+      should "User has movie" do
+        assert_equal(@titanic, @user.movies.first)
+      end 
+    
+      should "Movie belongs to user" do
+        assert_equal(@user, @titanic.subject)
+      end 
+    end
+    
+    context "Association bug tests" do      
+      should "return empty collection after destroy its only movie" do
+        assert_equal([@titanic], @user.movies)
+        @user.movies.destroy(@titanic)
+        assert_equal([], @user.movies)
+      end
+    end
+    
+    context "Counter_cache for polymorhpic association bug test" do
+      should "Update movies_count column after adding movie by << or destroing" do
+        @user.movies << Movie.create(:name => "Matrix")
+        assert_equal(2, @user.reload.movies_count)
+        @titanic.destroy
+        assert_equal(1, @user.reload.movies_count)
+      end
+      
+      should "Increment counter_cache only once when create" do
+        assert_equal(1, @user.reload.movies_count)
+      end
+      
+      should "Refresh size after adding movie by << or destroing" do
+        @user.movies << Movie.create(:name => "Matrix")
+        assert_equal(2, @user.movies.size)
+        @titanic.destroy
+        assert_equal(1, @user.movies.size)
+      end
+    end
+  end
+end

metadata

@@ -0,0 +1,68 @@
+--- !ruby/object:Gem::Specification 
+name: rails_relations_fix
+version: !ruby/object:Gem::Version 
+  version: 1.0.0
+platform: ruby
+authors: 
+- "Stanis\xC5\x82aw Kolarzowski"
+autorequire: 
+bindir: bin
+cert_chain: []
+
+date: 2010-02-15 00:00:00 +01:00
+default_executable: 
+dependencies: []
+
+description: "Fix for 2 rails bugs. #3005 Counter_cache and polymorhic association. #3964 Not refreshing association after destroy"
+email: stanislaw.kolarzowski@gmail.com
+executables: []
+
+extensions: []
+
+extra_rdoc_files: 
+- LICENSE
+- README.rdoc
+files: 
+- .document
+- .gitignore
+- LICENSE
+- README.rdoc
+- Rakefile
+- VERSION
+- lib/rails_relations_fix.rb
+- lib/rails_relations_fix/association.rb
+- lib/rails_relations_fix/counter_cache.rb
+- rails_relations_fix.gemspec
+- test/helper.rb
+- test/test_rails_relations_fix.rb
+has_rdoc: true
+homepage: http://github.com/staszek/rails_relations_fix
+licenses: []
+
+post_install_message: 
+rdoc_options: 
+- --charset=UTF-8
+require_paths: 
+- lib
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+  version: 
+requirements: []
+
+rubyforge_project: 
+rubygems_version: 1.3.5
+signing_key: 
+specification_version: 3
+summary: Fix for 2 rails bugs
+test_files: 
+- test/helper.rb
+- test/test_rails_relations_fix.rb