rails_pulse 0.4.2 → 0.5.0.pre.2

data/app/models/rails_pulse/queries/cards/average_query_times.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Queries
     module Cards
       class AverageQueryTimes < RailsPulse::Cards::Base
-        def initialize(query: nil, disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @query = query
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(query: nil, **kwargs)
+          super(subject: query, **kwargs)
         end
 
         def to_metric_card
@@ -19,10 +13,10 @@ module RailsPulse
           metrics = base_query.select(
             "SUM(avg_duration * count) AS total_weighted_duration",
             "SUM(count) AS total_requests",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN avg_duration * count ELSE 0 END) AS current_weighted_duration",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN count ELSE 0 END) AS current_requests",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN avg_duration * count ELSE 0 END) AS previous_weighted_duration",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN count ELSE 0 END) AS previous_requests"
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN avg_duration * count ELSE 0 END) AS current_weighted_duration"),
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN count ELSE 0 END) AS current_requests"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN avg_duration * count ELSE 0 END) AS previous_weighted_duration"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN count ELSE 0 END) AS previous_requests")
           ).take
 
           # Calculate metrics from single query result

data/app/models/rails_pulse/queries/cards/database_load.rb

@@ -2,15 +2,6 @@ module RailsPulse
   module Queries
     module Cards
       class DatabaseLoad < RailsPulse::Cards::Base
-        def initialize(disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
-        end
-
         def to_metric_card
           # Use base class time period helpers
           last_n_units = current_window_start

data/app/models/rails_pulse/queries/cards/execution_rate.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Queries
     module Cards
       class ExecutionRate < RailsPulse::Cards::Base
-        def initialize(query: nil, disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @query = query
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(query: nil, **kwargs)
+          super(subject: query, **kwargs)
         end
 
         def to_metric_card
@@ -18,8 +12,8 @@ module RailsPulse
 
           metrics = base_query.select(
             "SUM(count) AS total_count",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN count ELSE 0 END) AS current_count",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN count ELSE 0 END) AS previous_count"
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN count ELSE 0 END) AS current_count"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN count ELSE 0 END) AS previous_count")
           ).take
 
           # Calculate metrics from single query result
@@ -38,7 +32,7 @@ module RailsPulse
               period_type: @period_type,
               period_start: current_window_start..now
             )
-          sparkline_query = sparkline_query.where(summarizable_id: @query.id) if @query
+          sparkline_query = sparkline_query.where(summarizable_id: @subject.id) if @subject
 
           grouped_data = bucket_by_period(sparkline_query) { |relation| relation.sum(:count) }
 

data/app/models/rails_pulse/queries/cards/percentile_query_times.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Queries
     module Cards
       class PercentileQueryTimes < RailsPulse::Cards::Base
-        def initialize(query: nil, disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @query = query
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(query: nil, **kwargs)
+          super(subject: query, **kwargs)
         end
 
         def to_metric_card
@@ -19,8 +13,8 @@ module RailsPulse
           metrics = base_query.select(
             "SUM(p95_duration * count) / NULLIF(SUM(count), 0) AS overall_p95",
             "SUM(count) AS total_count",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN count ELSE 0 END), 0) AS current_p95",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN count ELSE 0 END), 0) AS previous_p95"
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= :current_start THEN count ELSE 0 END), 0) AS current_p95"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN count ELSE 0 END), 0) AS previous_p95")
           ).take
 
           # Calculate metrics from single query result
@@ -28,7 +22,7 @@ module RailsPulse
           current_period_p95 = metrics.current_p95 || 0
           previous_period_p95 = metrics.previous_p95 || 0
 
-          baseline = baseline_trend_for(@query, metric: :p95)
+          baseline = baseline_trend_for(@subject, metric: :p95)
 
           if baseline
             trend_icon, trend_amount, trend_caption = baseline
@@ -44,7 +38,7 @@ module RailsPulse
               period_type: @period_type,
               period_start: current_window_start..now
             )
-          sparkline_query = sparkline_query.where(summarizable_id: @query.id) if @query
+          sparkline_query = sparkline_query.where(summarizable_id: @subject.id) if @subject
 
           weighted_sums = bucket_by_period(sparkline_query) { |relation| relation.sum("p95_duration * count") }
           period_counts = bucket_by_period(sparkline_query) { |relation| relation.sum(:count) }

data/app/models/rails_pulse/queries/charts/database_load.rb

@@ -2,24 +2,21 @@ module RailsPulse
   module Queries
     module Charts
       class DatabaseLoad
-        def initialize(start_time:, end_time:, period_type: :day, disabled_tags: [], show_non_tagged: true)
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(window:, period_type: :day, disabled_tags: [], show_non_tagged: true)
+          @window = window
           @period_type = period_type
           @disabled_tags = disabled_tags
           @show_non_tagged = show_non_tagged
         end
 
         def to_chart_data
-          step = @period_type.to_s == "hour" ? 3600 : 86400
-
           # Get query summaries (DB time)
           query_summaries = RailsPulse::Summary
             .with_tag_filters(@disabled_tags, @show_non_tagged)
             .where(
               summarizable_type: "RailsPulse::Query",
               period_type: @period_type,
-              period_start: Time.at(@start_time)..Time.at(@end_time)
+              period_start: @window.start_time..@window.end_time
             )
 
           # Get route summaries (total request time)
@@ -28,7 +25,7 @@ module RailsPulse
             .where(
               summarizable_type: "RailsPulse::Route",
               period_type: @period_type,
-              period_start: Time.at(@start_time)..Time.at(@end_time)
+              period_start: @window.start_time..@window.end_time
             )
 
           return nil if query_summaries.empty? || route_summaries.empty?
@@ -52,7 +49,7 @@ module RailsPulse
           # <25% = green (healthy), 25-40% = yellow (watch), >40% = red (bottleneck)
           bar_data = []
 
-          (@start_time.to_i..@end_time.to_i).step(step) do |timestamp|
+          @window.bucket_timestamps(@period_type).each do |timestamp|
             query_time = query_time_by_period[timestamp] || 0
             request_time = request_time_by_period[timestamp] || 0
             percentage = request_time > 0 ? (query_time.to_f / request_time * 100).round(1) : 0

data/app/models/rails_pulse/queries/charts/execution_volume.rb

@@ -18,7 +18,7 @@ module RailsPulse
           end
 
           # Pad missing data with zeros using base class helper
-          execution_data = pad_data_with_zeros(raw_data, @start_time, @end_time, time_step)
+          execution_data = pad_data_with_zeros(raw_data)
 
           # Build series data as [timestamp_ms, value] pairs for ECharts time axis
           series = [ {

data/app/models/rails_pulse/request.rb

@@ -66,7 +66,7 @@ module RailsPulse
     end
 
     def to_s
-      occurred_at.getlocal.strftime("%b %d, %Y %l:%M %p")
+      occurred_at.strftime("%b %d, %Y %l:%M %p")
     end
 
     private

data/app/models/rails_pulse/routes/cards/error_rates.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Routes
     module Cards
       class ErrorRates < RailsPulse::Cards::Base
-        def initialize(route: nil, disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @route = route
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(route: nil, **kwargs)
+          super(subject: route, **kwargs)
         end
 
         def to_metric_card
@@ -20,8 +14,8 @@ module RailsPulse
             "SUM(error_count) AS total_errors",
             "SUM(status_4xx) AS total_4xx",
             "SUM(count) AS total_requests",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN error_count + status_4xx ELSE 0 END) AS current_total_errors",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN error_count + status_4xx ELSE 0 END) AS previous_total_errors"
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN error_count + status_4xx ELSE 0 END) AS current_total_errors"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN error_count + status_4xx ELSE 0 END) AS previous_total_errors")
           ).take
 
           total_errors = metrics.total_errors || 0
@@ -35,7 +29,7 @@ module RailsPulse
           server_rate = has_data ? (total_errors.to_f / total_requests * 100).round(2) : 0
           client_rate = has_data ? (total_4xx.to_f / total_requests * 100).round(2) : 0
 
-          baseline = baseline_trend_for(@route, metric: :error_rate)
+          baseline = baseline_trend_for(@subject, metric: :error_rate)
 
           if baseline
             trend_icon, trend_amount, trend_caption = baseline
@@ -72,10 +66,6 @@ module RailsPulse
 
         private
 
-        def subject_id
-          @route&.id
-        end
-
         def sparkline_from_error_rates(errors_by_period, client_errors_by_period, counts_by_period)
           if @period_type == "hour"
             sparkline_hours.each_with_object({}) do |current_time, result|

data/app/models/rails_pulse/routes/cards/percentile_response_times.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Routes
     module Cards
       class PercentileResponseTimes < RailsPulse::Cards::Base
-        def initialize(route: nil, disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @route = route
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(route: nil, **kwargs)
+          super(subject: route, **kwargs)
         end
 
         def to_metric_card
@@ -18,8 +12,8 @@ module RailsPulse
 
           metrics = base_query.select(
             "SUM(p95_duration * count) / NULLIF(SUM(count), 0) AS overall_p95",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN count ELSE 0 END), 0) AS current_p95",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN count ELSE 0 END), 0) AS previous_p95",
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= :current_start THEN count ELSE 0 END), 0) AS current_p95"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN p95_duration * count ELSE 0 END) / NULLIF(SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN count ELSE 0 END), 0) AS previous_p95"),
             "SUM(count) AS total_count"
           ).take
 
@@ -32,7 +26,7 @@ module RailsPulse
 
           # Prefer a comparison against this route's own history; fall back to
           # period-over-period on the index, where there is no single subject.
-          baseline = baseline_trend_for(@route, metric: :p95)
+          baseline = baseline_trend_for(@subject, metric: :p95)
 
           if baseline
             trend_icon, trend_amount, trend_caption = baseline
@@ -69,12 +63,6 @@ module RailsPulse
             help_text: "The 95th percentile response time — 95% of requests are faster than this. Weighted by request volume across all routes. A rising P95 indicates increasing slowness affecting your users."
           }
         end
-
-        private
-
-        def subject_id
-          @route&.id
-        end
       end
     end
   end

data/app/models/rails_pulse/routes/cards/request_count_totals.rb

@@ -2,14 +2,8 @@ module RailsPulse
   module Routes
     module Cards
       class RequestCountTotals < RailsPulse::Cards::Base
-        def initialize(route: nil, disabled_tags: [], show_non_tagged: true, period: 7, period_type: "day", start_time: nil, end_time: nil)
-          @route = route
-          @disabled_tags = disabled_tags
-          @show_non_tagged = show_non_tagged
-          @period = period
-          @period_type = period_type
-          @start_time = start_time
-          @end_time = end_time
+        def initialize(route: nil, **kwargs)
+          super(subject: route, **kwargs)
         end
 
         def to_metric_card
@@ -18,8 +12,8 @@ module RailsPulse
 
           metrics = base_query.select(
             "SUM(count) AS total_count",
-            "SUM(CASE WHEN period_start >= #{quote(current_window_start)} THEN count ELSE 0 END) AS current_count",
-            "SUM(CASE WHEN period_start >= #{quote(range_start)} AND period_start < #{quote(current_window_start)} THEN count ELSE 0 END) AS previous_count"
+            window_sql("SUM(CASE WHEN period_start >= :current_start THEN count ELSE 0 END) AS current_count"),
+            window_sql("SUM(CASE WHEN period_start >= :range_start AND period_start < :current_start THEN count ELSE 0 END) AS previous_count")
           ).take
 
           # Calculate metrics from single query result
@@ -42,7 +36,7 @@ module RailsPulse
               period_type: @period_type,
               period_start: current_window_start..now
             )
-          sparkline_query = sparkline_query.where(summarizable_id: @route.id) if @route
+          sparkline_query = sparkline_query.where(summarizable_id: @subject.id) if @subject
 
           grouped_data = bucket_by_period(sparkline_query) { |relation| relation.sum(:count) }
 
@@ -83,12 +77,6 @@ module RailsPulse
             help_text: "Total HTTP requests served over the last 14 days, expressed as an average rate. Use this to understand traffic patterns and capacity planning needs."
           }
         end
-
-        private
-
-        def subject_id
-          @route&.id
-        end
       end
     end
   end

data/app/models/rails_pulse/routes/charts/error_rate.rb

@@ -30,7 +30,7 @@ module RailsPulse
           # Pad missing data with defaults
           default_value = { error_rate: nil, client_error_rate: nil }
           daily_data = {}
-          (@start_time.to_i..@end_time.to_i).step(time_step) do |timestamp|
+          @window.bucket_timestamps(@period_type).each do |timestamp|
             daily_data[timestamp] = raw_data[timestamp] || default_value
           end
 

data/app/models/rails_pulse/routes/charts/request_volume.rb

@@ -22,7 +22,7 @@ module RailsPulse
           end
 
           # Pad missing data with zeros
-          daily_data = pad_data_with_zeros(raw_data, @start_time, @end_time, time_step)
+          daily_data = pad_data_with_zeros(raw_data)
 
           # Build series data as [timestamp_ms, value] pairs for ECharts time axis
           series = [ {

data/app/models/rails_pulse/summary.rb

@@ -171,7 +171,11 @@ module RailsPulse
     end
 
     class << self
+      # A Date is read as midnight in Time.zone, the aggregation zone, so
+      # boundaries are always times: Date#end_of_week is the last day itself,
+      # and a period ending there would drop that whole day.
       def calculate_period_end(period_type, start_time)
+        start_time = start_time.in_time_zone if start_time.is_a?(Date)
         case period_type
         when "hour"  then start_time.end_of_hour
         when "day"   then start_time.end_of_day
@@ -181,6 +185,7 @@ module RailsPulse
       end
 
       def normalize_period_start(period_type, time)
+        time = time.in_time_zone if time.is_a?(Date)
         case period_type
         when "hour"  then time.beginning_of_hour
         when "day"   then time.beginning_of_day

data/app/models/rails_pulse/tables/base.rb

@@ -4,10 +4,9 @@ module RailsPulse
       WEIGHTED_P95 = "SUM(rails_pulse_summaries.p95_duration * rails_pulse_summaries.count) / NULLIF(SUM(rails_pulse_summaries.count), 0)"
       WEIGHTED_P99 = "SUM(rails_pulse_summaries.p99_duration * rails_pulse_summaries.count) / NULLIF(SUM(rails_pulse_summaries.count), 0)"
 
-      def initialize(ransack_query:, period_type: nil, start_time:, params:, disabled_tags: [], show_non_tagged: true)
+      def initialize(ransack_query:, period_type: nil, params:, disabled_tags: [], show_non_tagged: true)
         @ransack_query = ransack_query
         @period_type = period_type
-        @start_time = start_time
         @params = params
         @disabled_tags = disabled_tags
         @show_non_tagged = show_non_tagged
@@ -41,11 +40,11 @@ module RailsPulse
       def apply_tag_filters(query)
         actual_disabled_tags = @disabled_tags.reject { |tag| tag == "non_tagged" }
 
-        # Explicit ESCAPE: SQLite has no default escape character, so without
-        # it an underscore in a tag is never matched literally there.
         actual_disabled_tags.each do |tag|
-          sanitized_tag = ActiveRecord::Base.sanitize_sql_like(tag.to_s, RailsPulse::Taggable::LIKE_ESCAPE)
-          query = query.where.not("#{model_table}.tags LIKE ? ESCAPE '!'", "%#{sanitized_tag}%")
+          query = query.where.not(
+            "#{model_table}.tags LIKE ? #{RailsPulse::LikePattern::CLAUSE}",
+            RailsPulse::LikePattern.containing(tag)
+          )
         end
 
         unless @show_non_tagged