rails_pulse 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 851f283c6c93bde26b1f79d3053a9cb7888381eedb0cd82118fdfbae6abf2a59
-  data.tar.gz: 622ea59d374bac1a3aa0b1dea374d86537b8bf815c1546b00c1545ee1e6787f7
+  metadata.gz: f1a0c55a1386d00790c4bada3da5ed8b34c17e670c7bf1a0c8c55a55c662b16c
+  data.tar.gz: 6de45806d2c72656dcc2ef06e61e00a7dd013e826a69a3f12f49cecf9efd360e
 SHA512:
-  metadata.gz: f4462e133722e0ef971e3f3c75fe0ea26f23c8167f24d31a8817550c6b91fe1cfd0bf6a35f59d29bd32cc432a9951de77fecdbb09e131fb385ddfe628d6ab660
-  data.tar.gz: 0c7d9706fc3a128b7c48fc4d09b78a698ff00bdd2e9b110e360c8124d5fccb5e552e4d351da70623f5d392c4c69916dbd39f930e0c1ef62eac2d3832db481cb5
+  metadata.gz: a946a339e72c604b0202f28f2e5650f9034619c1737f308cc14a640331a9d25ed60cfa86fc03c2c5a5bc9ab0793ab661844c93bcd1d394d0eedf7984e2fca211
+  data.tar.gz: ebb59bb9f9c60c0a9b5ce5ab0a778d08396a841cab960b6f4f4a16a41ca86a38e5ab54e3902b949327b84f5bb6618a7de35366993fded467e8a3b6e5e946ddc6

data/CHANGELOG.md

@@ -7,7 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
-## [0.4.0] - 2026-09-22
+## [0.4.1] - 2026-09-23
+
+### Added
+
+- A test that fails, naming the key, when a default in `RailsPulse::Configuration` and the install template drift apart. (#272)
+
+### Changed
+
+- Documented what a tracked request costs, measured against the bounded writer: about 25 microseconds of request-thread overhead per request on SQLite and PostgreSQL. (#275)
+- The release gate and CI now fail if anything under `app/` branches on `Rails.env`, so a code path the test suite cannot reach can no longer ship. (#273)
+- Loosened the `ransack` dependency from `~> 4.0` to `>= 4.0, < 6` so host apps can upgrade to ransack 5 without dropping Rails Pulse.
+- `rake test` now refuses to run when the dummy database was last set up for a different adapter, instead of loading that adapter's `schema.rb` and failing two index tests. (#276)
+
+### Fixed
+
+- SQL normalization no longer raises `Regexp::TimeoutError` on long queries, which could fail the whole request when N+1 detection ran during collection.
+- **Metric card headline numbers now honour the global tag filter.** Disabling a tag changed each card's sparkline but not the number beside it, so the two disagreed. Both are now computed over the same summaries. (#274)
 
 ## [0.4.0] - 2026-09-22
 

data/app/models/rails_pulse/cards/base.rb

@@ -62,10 +62,10 @@ module RailsPulse
           period_start: range_start..now
         )
 
-        # Apply tag filters if available
-        if respond_to?(:disabled_tags, true) && respond_to?(:show_non_tagged, true)
-          query = query.with_tag_filters(@disabled_tags, @show_non_tagged)
-        end
+        # The same tag filter the sparkline applies, so the headline number and
+        # the sparkline beside it are computed over the same summaries. Cards
+        # receive the filter as instance variables; nil means unfiltered.
+        query = query.with_tag_filters(@disabled_tags || [], @show_non_tagged != false)
 
         # Filter to specific resource if provided
         query = query.where(summarizable_id: subject_id) if subject_id

data/app/services/rails_pulse/sql_query_normalizer.rb

@@ -1,5 +1,15 @@
 module RailsPulse
   class SqlQueryNormalizer
+    # Above this length, skip the regex-based literal scan in favor of a
+    # slower-per-char but backtracking-free manual scan. Regex matching here
+    # is linear (benchmarked at ~0.4s for an 8,000,000-char literal under a
+    # 1s Regexp.timeout), but a host app can configure Regexp.timeout far
+    # below that, and very long queries are rare enough that the fast path
+    # isn't worth the risk. 100_000 chars leaves generous headroom below
+    # where even an aggressive timeout config could plausibly trip — see
+    # issue #286.
+    LONG_QUERY_THRESHOLD = 100_000
+
     # Smart normalization: preserve table/column names, replace only literal values
     def self.normalize(query_string)
       new(query_string).normalize
@@ -72,6 +82,14 @@ module RailsPulse
     def replace_literal_values(query)
       normalized = query.dup
 
+      # Replace string literals (single quotes) FIRST so a very long literal
+      # collapses to a single "?" before any other regex in this method has
+      # to scan across it — see LONG_QUERY_THRESHOLD and issue #286.
+      normalized = replace_quoted_literals(normalized, "'")
+
+      # Replace double-quoted string literals (not protected identifiers)
+      normalized = replace_quoted_literals(normalized, '"')
+
       # Replace floating-point numbers FIRST (before integers) to avoid double replacement
       normalized = normalized.gsub(/(?<![a-zA-Z_])\b\d+\.\d+\b(?![a-zA-Z_])/, "?")
 
@@ -79,18 +97,78 @@ module RailsPulse
       # Negative lookbehind/lookahead prevents replacing numbers in table/column names
       normalized = normalized.gsub(/(?<![a-zA-Z_])\b\d+\b(?![a-zA-Z_])/, "?")
 
-      # Replace string literals (single quotes)
-      normalized = normalized.gsub(/'(?:[^']|'')*'/, "?")
-
-      # Replace double-quoted string literals (not protected identifiers)
-      normalized = normalized.gsub(/"(?:[^"]|"")*"/, "?")
-
       # Handle boolean literals
       normalized = normalized.gsub(/\b(true|false)\b/i, "?")
 
       normalized
     end
 
+    # Replaces quote_char-delimited string literals with a single placeholder.
+    # Uses a regex for the common case (fast — see benchmarks in
+    # LONG_QUERY_THRESHOLD's comment) and falls back to a manual scan for
+    # very long queries, where that regex risks Regexp::TimeoutError under
+    # an aggressively configured Regexp.timeout — see issue #286.
+    def replace_quoted_literals(query, quote_char)
+      if query.length < LONG_QUERY_THRESHOLD
+        pattern = quote_char == "'" ? /'(?:[^']|'')*'/ : /"(?:[^"]|"")*"/
+        query.gsub(pattern, "?")
+      else
+        scan_quoted_literals(query, quote_char)
+      end
+    end
+
+    # Linear, non-regex scan used above LONG_QUERY_THRESHOLD. A quote left
+    # unterminated for the rest of the string is left untouched rather than
+    # rescanned from every possible start position, which is what would make
+    # a naive manual reimplementation quadratic.
+    def scan_quoted_literals(query, quote_char)
+      result = +""
+      i = 0
+      len = query.length
+
+      while i < len
+        char = query[i]
+
+        unless char == quote_char
+          result << char
+          i += 1
+          next
+        end
+
+        close_index = find_closing_quote(query, i + 1, quote_char)
+
+        if close_index
+          result << "?"
+          i = close_index + 1
+        else
+          result << query[i..]
+          break
+        end
+      end
+
+      result
+    end
+
+    # Returns the index of the unescaped closing quote_char starting the
+    # search at `start`, treating a doubled quote_char (e.g. '') as an
+    # escaped literal quote rather than a terminator. Returns nil if the
+    # string is never closed.
+    def find_closing_quote(query, start, quote_char)
+      j = start
+      len = query.length
+
+      while j < len
+        if query[j] == quote_char
+          return j unless query[j + 1] == quote_char
+          j += 2
+        else
+          j += 1
+        end
+      end
+
+      nil
+    end
+
     def handle_special_constructs(query)
       normalized = normalize_in_clauses(query)
       normalized.gsub(/\bBETWEEN\s+\?\s+AND\s+\?/i, "BETWEEN ? AND ?")

data/app/views/layouts/rails_pulse/application.html.erb

@@ -69,7 +69,7 @@
       </div>
 
       <div class="flex items-center gap">
-        <%= link_to rails_pulse.root_path, class: "flex items-center gap mie-2" do %>
+        <%= link_to rails_pulse.root_path, class: "flex items-center gap mie-2", title: "Rails Pulse v#{RailsPulse::VERSION}" do %>
           <span class="font-bold">Rails Pulse</span>
         <% end %>
         <nav class="flex items-center gap text-sm text-subtle show@md" style="--column-gap: 1rem">

data/lib/rails_pulse/version.rb

@@ -1,3 +1,3 @@
 module RailsPulse
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_pulse
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Scott Harvey
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-09-22 00:00:00.000000000 Z
+date: 2026-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -48,16 +48,22 @@ dependencies:
   name: ransack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '4.0'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -545,7 +551,7 @@ metadata:
   bug_tracker_uri: https://github.com/railspulse/rails_pulse/issues
   rubygems_mfa_required: 'true'
 post_install_message: |
-  Rails Pulse 0.4.0 installed.
+  Rails Pulse 0.4.1 installed.
 
   UPGRADING from any 0.3.x? This release changes route identity and DROPS
   rails_pulse_routes.method. Back up your database first, then run: