rails_pulse 0.4.0.pre.1 → 0.4.0.pre.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 19b495bf5ea042672667ee099947d337731557f880af30f7d2dc26f507cbea0f
-  data.tar.gz: cb8946047ebb55a662742d42d143f47b5b3f3b982779fb289e4abfe418ac1c59
+  metadata.gz: b102fc4776d7fe701b47011e02d682f47a2784500103f3cb7d7598a757b174ff
+  data.tar.gz: 34f4055047c1bb9151c9e811f14c4e90fe83e52508c61ea4433929b2b431d568
 SHA512:
-  metadata.gz: 428db96f32b2624638e99aacad09ef5dbeac23b6e11df316f7db66757c997777e846907830993657f4c76c0ea81dbfc92246ad93e1f5f3cc1c5b53ca80cb6065
-  data.tar.gz: 3f73d50c25352fc8a3dbaabe8cee59a51624fbebb1d23dfc58208bf42add67a33a56003d98769610559cd8211f8dab76a7a478da6cac0883f7a0d0e6d07f6ebb
+  metadata.gz: 974fcf20833ab11e46a00db96d21590f32a699a73de8d2af229d1fa5559f0817c107ba684f4ada34cdb067a77f6293ecc11ee3d24f7911f9fe074353a2991d79
+  data.tar.gz: 507afdae03f11fef23d0bbd7cc5ee8e8123656e41efbc219a10f8b6682602bfb7dcfa91e9ac424352d68ad05b3bceed4070eead220d053713f56aa1ade7bec01

data/CHANGELOG.md

@@ -7,6 +7,33 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.4.0.pre.2] - 2026-09-04
+
+### Fixed
+
+- **`rails generate rails_pulse:upgrade` wrote a migration that would not parse.**
+  The schema parser matched a column comment with `comment: "([^"]*)"`, which stops
+  at the first escaped quote. The `http_methods` comment embeds a `["GET","POST"]`
+  example, so it was truncated mid-escape and the trailing backslash escaped the
+  closing quote of the generated `comment:` string — the copied
+  `upgrade_rails_pulse_tables.rb` then failed to load with
+  `unterminated string meets end of file`. Comments are now matched as complete Ruby
+  string literals, decoded with `String#undump`, and re-escaped with `String#inspect`
+  when the migration is rendered.
+
+- **Background tracking writes corrupted the host app's test database connection.**
+  Under `use_transactional_tests` Rails pins one connection per pool and hands that
+  same connection to every thread, so the tracker's writer thread interleaved its
+  INSERTs with the test's own statements on a single socket. PostgreSQL reported
+  this as `message type 0x5a arrived from server while idle` and
+  `server sent data ("D" message) without prior row description`, and suites hung
+  or failed at random. The gem's own dummy app avoided it with
+  `config.async = false if Rails.env.test?`, but the installed initializer never
+  shipped that line. The tracker now writes inline whenever the pool's connection
+  is shared across threads, and `rails generate rails_pulse:install` adds the
+  test-environment line to the initializer. Existing installs should add
+  `config.async = false if Rails.env.test?` to `config/initializers/rails_pulse.rb`.
+
 ## [0.4.0.pre.1] - 2026-09-03
 
 This release contains a **breaking schema change** and requires a one-time data

data/lib/generators/rails_pulse/schema_parser.rb

@@ -48,6 +48,25 @@ module RailsPulse
 
       private
 
+      # Column definitions look like: t.text :column_name, comment: "..."
+      # The comment capture must tolerate escaped quotes — the http_methods
+      # comment embeds a JSON example, [\"GET\",\"POST\"] — so it matches a
+      # full Ruby string literal (quotes included) rather than stopping at the
+      # first quote character.
+      COLUMN_DEFINITION = /t\.(\w+)\s+:([a-zA-Z_][a-zA-Z0-9_]*)(?:.*?comment:\s*("(?:[^"\\]|\\.)*"))?/
+
+      # Turn the matched Ruby string literal back into the string it denotes, so
+      # callers hold the real comment text and re-escape it themselves (the
+      # upgrade migration template uses String#inspect). Falls back to stripping
+      # the quotes if the literal uses an escape String#undump rejects.
+      def decode_comment(literal)
+        return nil if literal.nil?
+
+        literal.undump
+      rescue RuntimeError
+        literal.delete_prefix('"').delete_suffix('"')
+      end
+
       # Parse column definitions from a table block
       # Returns hash of column_name => { type:, comment: }
       def parse_table_columns(table_block)
@@ -55,9 +74,10 @@ module RailsPulse
 
         table_block.split("\n").each do |line|
           # Match column definitions: t.text :column_name, comment: "..."
-          next unless match = line.match(/t\.(\w+)\s+:([a-zA-Z_][a-zA-Z0-9_]*)(?:.*?comment:\s*"([^"]*)")?/)
+          next unless match = line.match(COLUMN_DEFINITION)
 
-          column_type, column_name, comment = match.captures
+          column_type, column_name, comment_literal = match.captures
+          comment = decode_comment(comment_literal)
 
           # Skip timestamps and references (Rails handles these)
           next if %w[timestamps references].include?(column_type)

data/lib/generators/rails_pulse/templates/migrations/upgrade_rails_pulse_tables.rb

@@ -4,7 +4,7 @@ class UpgradeRailsPulseTables < ActiveRecord::Migration[<%= @migration_version %
     <% @missing_columns.each do |table_name, columns| %>
       <% columns.each do |column_name, definition| %>
     # Add <%= column_name %> column to <%= table_name %>
-    add_column :<%= table_name %>, :<%= column_name %>, :<%= definition[:type] %><% if definition[:comment] %>, comment: "<%= definition[:comment] %>"<% end %>
+    add_column :<%= table_name %>, :<%= column_name %>, :<%= definition[:type] %><% if definition[:comment] %>, comment: <%= definition[:comment].inspect %><% end %>
       <% end %>
     <% end %>
   end

data/lib/generators/rails_pulse/templates/rails_pulse.rb

@@ -6,6 +6,11 @@ RailsPulse.configure do |config|
   # Enable or disable Rails Pulse
   config.enabled = true
 
+  # Tracking writes happen on a background thread by default (see `config.async`
+  # under ADVANCED). Transactional tests share one database connection across
+  # threads, so write inline there to keep the writer off the test's connection.
+  config.async = false if Rails.env.test?
+
   # ====================================================================================================
   #                                               THRESHOLDS
   # ====================================================================================================

data/lib/rails_pulse/tracker.rb

@@ -11,7 +11,7 @@ module RailsPulse
       def track_request(data)
         return if RequestStore.store[:skip_recording_rails_pulse_activity]
 
-        if RailsPulse.configuration.async
+        if RailsPulse.configuration.async && !connection_shared_across_threads?
           Thread.new do
             perform_tracking(data)
           rescue => e
@@ -62,6 +62,22 @@ module RailsPulse
         RequestStore.store[:skip_recording_rails_pulse_activity] = false
       end
 
+      # Transactional tests pin one connection per pool and hand that same
+      # connection to every thread that asks for one. A background writer would
+      # then interleave its statements with the test's on a single socket, which
+      # PostgreSQL reports as "message type 0x5a arrived from server while idle".
+      # Rails 7.2+ records the pin in the pool's @pinned_connection; 7.1 sets a
+      # @lock_thread on the pool instead. Neither is public API, so read both
+      # defensively and treat any failure as "not shared".
+      def connection_shared_across_threads?
+        pool = RailsPulse::ApplicationRecord.connection_pool
+        return true if pool.instance_variable_get(:@pinned_connection)
+
+        pool.instance_variable_get(:@lock_thread) ? true : false
+      rescue StandardError
+        false
+      end
+
       def clear_aborted_transaction(conn)
         raw = conn.raw_connection
         # Non-PostgreSQL adapters don't expose transaction_status, so this is a no-op for them.

data/lib/rails_pulse/version.rb

@@ -1,3 +1,3 @@
 module RailsPulse
-  VERSION = "0.4.0.pre.1"
+  VERSION = "0.4.0.pre.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_pulse
 version: !ruby/object:Gem::Version
-  version: 0.4.0.pre.1
+  version: 0.4.0.pre.2
 platform: ruby
 authors:
 - Scott Harvey
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-09-03 00:00:00.000000000 Z
+date: 2026-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -543,7 +543,7 @@ metadata:
   bug_tracker_uri: https://github.com/railspulse/rails_pulse/issues
   rubygems_mfa_required: 'true'
 post_install_message: |
-  Rails Pulse 0.4.0.pre.1 installed.
+  Rails Pulse 0.4.0.pre.2 installed.
 
   UPGRADING from any 0.3.x? This release changes route identity and DROPS
   rails_pulse_routes.method. Back up your database first, then run: