rails_pulse 0.1.4 → 0.2.3

data/app/views/rails_pulse/requests/index.html.erb

@@ -1,4 +1,4 @@
-<%= render 'rails_pulse/components/breadcrumbs' %>
+<%= render 'rails_pulse/components/page_header', show_active_filters: true %>
 
 <% unless turbo_frame_request? %>
   <div class="row">
@@ -9,69 +9,51 @@
   </div>
 <% end %>
 
-<div
-  data-controller="rails-pulse--index"
-  data-rails-pulse--index-chart-id-value="average_response_times_chart"
->
-  <%= render 'rails_pulse/components/panel', { title: 'Average Response Time', } do %>
-    <%= search_form_for @ransack_query, url: requests_path, class: "flex items-center justify-between gap mb-4" do |form| %>
-      <div class="flex items-center grow gap">
-        <%= form.select :period_start_range,
-          RailsPulse::RequestsController::TIME_RANGE_OPTIONS,
-          { selected: @selected_time_range },
-          { class: "input" }
-        %>
-        <%= form.select :avg_duration,
-          duration_options(:request),
-          { selected: @selected_response_range },
-          { class: "input" }
-        %>
-        <%= link_to "Reset", requests_path, class: "btn btn--borderless show@md" if params.has_key?(:q) %>
-        <%= form.submit "Search", class: "btn show@sm" %>
-      </div>
-    <% end %>
+<%= render 'rails_pulse/components/panel', { title: 'Requests', } do %>
+  <%= search_form_for @ransack_query, url: requests_path, class: "flex items-center justify-between gap mb-4", data: { controller: "rails-pulse--custom-range" } do |form| %>
+    <div class="flex items-center grow gap">
+      <%= time_range_selector(form,
+        time_range_options: RailsPulse::RequestsController::TIME_RANGE_OPTIONS,
+        selected_time_range: @selected_time_range,
+        mode: :recent_custom
+      ) %>
+
+      <%= form.search_field :route_path_cont,
+        placeholder: "Filter by route",
+        autocomplete: "off",
+        class: "input"
+      %>
 
-    <% if @has_data %>
-      <% if @chart_data && @chart_data.values.any? { |v| v > 0 } %>
-        <div
-          class="chart-container chart-container--slim"
-          data-rails-pulse--index-target="chart"
-        >
-          <%= bar_chart(
-            @chart_data,
-            code: false,
-            id: "average_response_times_chart",
-            height: "100%",
-            options: bar_chart_options(
-              units: "ms",
-              zoom: true,
-              chart_start: 0,
-              chart_end: @chart_data.length - 1,
-              xaxis_formatter: @xaxis_formatter,
-              tooltip_formatter: @tooltip_formatter,
-              zoom_start: @zoom_start,
-              zoom_end: @zoom_end,
-              chart_data: @chart_data
-            )
-          ) %>
-        </div>
-      <% else %>
-        <div class="p-4 text-center text-muted">
-          No response time data available for the selected filters.
-        </div>
-      <% end %>
+      <%= form.select :status_category_eq,
+        [
+          ["All statuses", ""],
+          ["2xx Success", "2"],
+          ["3xx Redirect", "3"],
+          ["4xx Client Error", "4"],
+          ["5xx Server Error", "5"]
+        ],
+        {},
+        { class: "input" }
+      %>
 
-      <div class="alert flex items-start mbs-8" role="alert">
-        <p>The chart above shows aggregated average response times grouped by time periods while the table below shows specific request details.</p>
-      </div>
+      <%= form.select :duration_gteq,
+        duration_options(:request),
+        { selected: @selected_response_range, prompt: "Min duration" },
+        { class: "input" }
+      %>
 
-      <%= turbo_frame_tag :index_table, data: { rails_pulse__index_target: "indexTable" } do %>
-        <%= render 'rails_pulse/requests/table' %>
-      <% end %>
-    <% else %>
-      <%= render 'rails_pulse/components/empty_state',
-          title: 'No request data found for the selected filters.',
-          description: 'Try adjusting your time range or filters to see results.' %>
+      <%= link_to "Reset", requests_path, class: "btn btn--borderless show@md" if params.has_key?(:q) %>
+      <%= form.submit "Search", class: "btn show@sm" %>
+    </div>
+  <% end %>
+
+  <% if @has_data %>
+    <%= turbo_frame_tag :index_table do %>
+      <%= render 'rails_pulse/requests/table' %>
     <% end %>
+  <% else %>
+    <%= render 'rails_pulse/components/empty_state',
+        title: 'No request data found for the selected filters.',
+        description: 'Try adjusting your time range or filters to see results.' %>
   <% end %>
-</div>
+<% end %>

data/app/views/rails_pulse/requests/show.html.erb

@@ -1,4 +1,4 @@
-<%= render 'rails_pulse/components/breadcrumbs' %>
+<%= render 'rails_pulse/components/page_header', taggable: @request %>
 
 <div class="row">
   <div class="grid-item">

data/app/views/rails_pulse/routes/_requests_table.html.erb

@@ -1,7 +1,8 @@
 <% columns = [
   { field: :occurred_at, label: 'Timestamp', class: 'w-auto' },
   { field: :duration, label: 'Response Time', class: 'w-36' },
-  { field: :status, label: 'Status', class: 'w-20' }
+  { field: :status, label: 'Status', class: 'w-20' },
+  { field: nil, label: 'Tags', class: 'w-32' }
 ] %>
 
 <table class="table mbs-4" data-controller="rails-pulse--table-sort">
@@ -31,6 +32,7 @@
             <span class="text-green-600"><%= request.status %></span>
           <% end %>
         </td>
+        <td class="whitespace-nowrap"><%= display_tag_badges(request) %></td>
       </tr>
     <% end %>
   </tbody>

data/app/views/rails_pulse/routes/_table.html.erb

@@ -2,7 +2,8 @@
   { field: :route_path, label: 'Route', class: 'w-auto' },
   { field: :avg_duration_sort, label: 'Average Response Time', class: 'w-48' },
   { field: :max_duration_sort, label: 'Max Response Time', class: 'w-44' },
-  { field: :count_sort, label: 'Requests', class: 'w-24' }
+  { field: :count_sort, label: 'Requests', class: 'w-24' },
+  { field: nil, label: 'Tags', class: 'w-32' }
 ] %>
 
 <table class="table mbs-4" data-controller="rails-pulse--table-sort">
@@ -15,6 +16,7 @@
         <td class="whitespace-nowrap"><%= summary.avg_duration.to_i %> ms</td>
         <td class="whitespace-nowrap"><%= summary.max_duration.to_i %> ms</td>
         <td class="whitespace-nowrap"><%= number_with_delimiter summary.count %></td>
+        <td class="whitespace-nowrap"><%= display_tag_badges(summary.tags) %></td>
       </tr>
     <% end %>
   </tbody>

data/app/views/rails_pulse/routes/index.html.erb

@@ -1,4 +1,4 @@
-<%= render 'rails_pulse/components/breadcrumbs' %>
+<%= render 'rails_pulse/components/page_header', show_active_filters: true %>
 
 <% unless turbo_frame_request? %>
   <div class="row">
@@ -14,14 +14,10 @@
   data-rails-pulse--index-chart-id-value="average_response_times_chart"
 >
   <%= render 'rails_pulse/components/panel', { title: 'Average Response Time', card_classes: 'b-full' } do %>
-    <%= search_form_for @ransack_query, url: routes_path, class: "flex items-center justify-between gap mb-4" do |form| %>
+    <%= search_form_for @ransack_query, url: routes_path, class: "flex items-center justify-between gap mb-4", data: { controller: "rails-pulse--custom-range" } do |form| %>
       <div class="flex items-center grow gap">
-        <%= form.search_field :route_path_cont, placeholder: "Filter by route", autocomplete: "off", class: "input", style: "max-inline-size: 250px" %>
-        <%= form.select :period_start_range,
-          RailsPulse::RoutesController::TIME_RANGE_OPTIONS,
-          { selected: @selected_time_range },
-          { class: "input" }
-        %>
+        <%= time_range_selector(form, time_range_options: RailsPulse::RoutesController::TIME_RANGE_OPTIONS, selected_time_range: @selected_time_range) %>
+        <%= form.search_field :route_path_cont, placeholder: "Filter by route", autocomplete: "off", class: "input" %>
         <%= form.select :avg_duration,
           duration_options(:route),
           { selected: @selected_response_range },

data/app/views/rails_pulse/routes/show.html.erb

@@ -1,4 +1,4 @@
-<%= render 'rails_pulse/components/breadcrumbs' %>
+<%= render 'rails_pulse/components/page_header', taggable: @route %>
 
 <% unless turbo_frame_request? %>
   <div class="row">
@@ -16,13 +16,9 @@
 >
   <div class="grid-item">
     <%= render 'rails_pulse/components/panel', { title: 'Route Reqeusts', } do %>
-      <%= search_form_for @ransack_query, url: route_path(@route), class: "flex items-center justify-between gap mb-4" do |form| %>
+      <%= search_form_for @ransack_query, url: route_path(@route), class: "flex items-center justify-between gap mb-4", data: { controller: "rails-pulse--custom-range" } do |form| %>
         <div class="flex items-center grow gap">
-          <%= form.select :period_start_range,
-            RailsPulse::RoutesController::TIME_RANGE_OPTIONS,
-            { selected: @selected_time_range },
-            { class: "input" }
-          %>
+          <%= time_range_selector(form, time_range_options: RailsPulse::RoutesController::TIME_RANGE_OPTIONS, selected_time_range: @selected_time_range) %>
           <%= form.select :avg_duration,
             duration_options(:route),
             { selected: @selected_response_range },

data/app/views/rails_pulse/tags/_tag_manager.html.erb

@@ -0,0 +1,73 @@
+<%
+  taggable_type = taggable.class.name.demodulize.underscore
+  available_tags = RailsPulse.configuration.tags
+  current_tags = taggable.tag_list
+  available_to_add = available_tags - current_tags
+%>
+
+<div
+  id="tag_manager_<%= taggable_type %>_<%= taggable.id %>"
+  class="tag-manager"
+>
+  <div class="tag-list">
+    <% current_tags.each do |tag| %>
+      <span class="badge badge--secondary font-normal">
+        <%= tag %>
+        <%= button_to remove_tag_path(taggable_type, taggable.id, tag: tag),
+              method: :delete,
+              class: "tag-remove",
+              data: {
+                turbo_frame: "_top"
+              } do %>
+          <span aria-hidden="true">&times;</span>
+        <% end %>
+      </span>
+    <% end %>
+
+    <% if available_to_add.any? %>
+      <div class="tag-add-container" data-controller="rails-pulse--popover" data-rails-pulse--popover-placement-value="bottom-start">
+        <button
+          type="button"
+          id="tag_menu_button_<%= taggable_type %>_<%= taggable.id %>"
+          class="badge badge--positive tag-add-button font-normal"
+          data-rails-pulse--popover-target="button"
+          data-action="rails-pulse--popover#toggle"
+          aria-haspopup="true"
+          aria-controls="tag_menu_<%= taggable_type %>_<%= taggable.id %>"
+        >
+          + tag
+        </button>
+
+        <div
+          popover
+          class="popover"
+          style="--popover-size: 12rem;"
+          data-rails-pulse--popover-target="menu"
+        >
+          <div
+            id="tag_menu_<%= taggable_type %>_<%= taggable.id %>"
+            class="menu"
+            data-controller="rails-pulse--menu"
+            data-action="keydown.up->rails-pulse--menu#prev keydown.down->rails-pulse--menu#next"
+            role="menu"
+            aria-labelledby="tag_menu_button_<%= taggable_type %>_<%= taggable.id %>"
+          >
+            <% available_to_add.each do |tag| %>
+              <%= button_to add_tag_path(taggable_type, taggable.id, tag: tag),
+                    method: :post,
+                    class: "btn menu__item i-full",
+                    data: {
+                      turbo_frame: "_top",
+                      rails_pulse__menu_target: "item"
+                    },
+                    style: "cursor: pointer;",
+                    role: "menuitem" do %>
+                <%= tag %>
+              <% end %>
+            <% end %>
+          </div>
+        </div>
+      </div>
+    <% end %>
+  </div>
+</div>

data/config/initializers/rails_charts_csp_patch.rb

@@ -61,15 +61,15 @@ if defined?(RailsCharts)
   end
 end
 
-# Apply the patch to ApplicationHelper and any modules that include chart helpers
+# Apply the CSP patch only to Rails Pulse helpers, not the entire application
+# By prepending to ChartHelper instead of ApplicationHelper, we scope the patch to RailsPulse
+# namespace only, avoiding conflicts with any chart libraries in the host application
+# (Chartkick, Highcharts, Google Charts, ApexCharts, custom helpers, etc.)
 Rails.application.config.to_prepare do
-  if defined?(RailsCharts)
-    # Patch ActionView::Base to include our CSP patch for line_chart
-    ActionView::Base.prepend(RailsCharts::CspPatch)
-
-    # Also patch any Rails Pulse helpers that might use charts
-    if defined?(RailsPulse::ApplicationHelper)
-      RailsPulse::ApplicationHelper.prepend(RailsCharts::CspPatch)
-    end
+  if defined?(RailsCharts) && defined?(RailsPulse::ChartHelper)
+    # Prepend CSP patch to RailsPulse::ChartHelper
+    # This wraps only the rails_charts methods, ensuring clean CSP nonce injection
+    # without affecting the host application's chart helpers
+    RailsPulse::ChartHelper.prepend(RailsCharts::CspPatch)
   end
 end

data/config/routes.rb

@@ -11,6 +11,11 @@ RailsPulse::Engine.routes.draw do
   resources :operations, only: %i[show]
   resources :caches, only: %i[show], as: :cache
   patch "pagination/limit", to: "application#set_pagination_limit"
+  patch "settings/global_filters", to: "application#set_global_filters"
+
+  # Tag management
+  post "tags/:taggable_type/:taggable_id/add", to: "tags#create", as: :add_tag
+  delete "tags/:taggable_type/:taggable_id/remove", to: "tags#destroy", as: :remove_tag
 
   # CSP compliance testing
   get "csp_test", to: "csp_test#show", as: :csp_test

data/db/rails_pulse_schema.rb

@@ -18,6 +18,7 @@ RailsPulse::Schema = lambda do |connection|
   connection.create_table :rails_pulse_routes do |t|
     t.string :method, null: false, comment: "HTTP method (e.g., GET, POST)"
     t.string :path, null: false, comment: "Request path (e.g., /posts/index)"
+    t.text :tags, comment: "JSON array of tags for filtering and categorization"
     t.timestamps
   end
 
@@ -34,6 +35,7 @@ RailsPulse::Schema = lambda do |connection|
     t.text :index_recommendations, comment: "JSON array of database index recommendations"
     t.text :n_plus_one_analysis, comment: "JSON object with enhanced N+1 query detection results"
     t.text :suggestions, comment: "JSON array of optimization recommendations"
+    t.text :tags, comment: "JSON array of tags for filtering and categorization"
     t.timestamps
   end
 
@@ -47,6 +49,7 @@ RailsPulse::Schema = lambda do |connection|
     t.string :request_uuid, null: false, comment: "Unique identifier for the request (e.g., UUID)"
     t.string :controller_action, comment: "Controller and action handling the request (e.g., PostsController#show)"
     t.timestamp :occurred_at, null: false, comment: "When the request started"
+    t.text :tags, comment: "JSON array of tags for filtering and categorization"
     t.timestamps
   end
 

data/lib/generators/rails_pulse/install_generator.rb

@@ -22,6 +22,25 @@ module RailsPulse
         create_file "db/rails_pulse_migrate/.keep"
       end
 
+      def copy_gem_migrations
+        gem_migrations_path = File.expand_path("../../../db/rails_pulse_migrate", __dir__)
+        destination_dir = separate_database? ? "db/rails_pulse_migrate" : "db/migrate"
+
+        if File.directory?(gem_migrations_path)
+          Dir.glob("#{gem_migrations_path}/*.rb").each do |migration_file|
+            migration_name = File.basename(migration_file)
+            destination_path = File.join(destination_dir, migration_name)
+
+            # Only copy if it doesn't already exist in the destination
+            # Use File.join with destination_root to check the actual location
+            full_destination_path = File.join(destination_root, destination_path)
+            unless File.exist?(full_destination_path)
+              copy_file migration_file, destination_path
+            end
+          end
+        end
+      end
+
       def copy_initializer
         copy_file "rails_pulse.rb", "config/initializers/rails_pulse.rb"
       end
@@ -84,7 +103,7 @@ module RailsPulse
           3. Restart your Rails server
 
           The schema file db/rails_pulse_schema.rb is your single source of truth.
-          Future schema changes will come as regular migrations in db/rails_pulse_migrate/
+          Future upgrades will automatically copy new migrations to db/rails_pulse_migrate/
 
         MESSAGE
       end
@@ -99,7 +118,7 @@ module RailsPulse
           2. Restart your Rails server
 
           The schema file db/rails_pulse_schema.rb is your single source of truth.
-          Future schema changes will come as regular migrations in db/migrate/
+          Future upgrades will automatically copy new migrations to db/migrate/
 
           Note: The installation migration loads from db/rails_pulse_schema.rb
           and includes all current Rails Pulse tables and columns.

data/lib/generators/rails_pulse/templates/db/rails_pulse_schema.rb

@@ -18,6 +18,7 @@ RailsPulse::Schema = lambda do |connection|
   connection.create_table :rails_pulse_routes do |t|
     t.string :method, null: false, comment: "HTTP method (e.g., GET, POST)"
     t.string :path, null: false, comment: "Request path (e.g., /posts/index)"
+    t.text :tags, comment: "JSON array of tags for filtering and categorization"
     t.timestamps
   end
 
@@ -34,6 +35,7 @@ RailsPulse::Schema = lambda do |connection|
     t.text :index_recommendations, comment: "JSON array of database index recommendations"
     t.text :n_plus_one_analysis, comment: "JSON object with enhanced N+1 query detection results"
     t.text :suggestions, comment: "JSON array of optimization recommendations"
+    t.text :tags, comment: "JSON array of tags for filtering and categorization"
     t.timestamps
   end
 
@@ -47,6 +49,7 @@ RailsPulse::Schema = lambda do |connection|
     t.string :request_uuid, null: false, comment: "Unique identifier for the request (e.g., UUID)"
     t.string :controller_action, comment: "Controller and action handling the request (e.g., PostsController#show)"
     t.timestamp :occurred_at, null: false, comment: "When the request started"
+    t.text :tags, comment: "JSON array of tags for filtering and categorization"
     t.timestamps
   end
 

data/lib/generators/rails_pulse/templates/rails_pulse.rb

@@ -71,6 +71,27 @@ RailsPulse.configure do |config|
   config.ignored_requests = []
   config.ignored_queries  = []
 
+  # ====================================================================================================
+  #                                                 TAGGING
+  # ====================================================================================================
+  # Define custom tags for categorizing routes, requests, and queries.
+  # You can add any custom tags you want for filtering and organization.
+  #
+  # Tag names should be in present tense and describe the current state or category.
+  # Examples of good tag names:
+  #   - "critical" (for high-priority endpoints)
+  #   - "experimental" (for routes under development)
+  #   - "deprecated" (for routes being phased out)
+  #   - "external" (for third-party API calls)
+  #   - "background" (for async job-related operations)
+  #   - "admin" (for administrative routes)
+  #   - "public" (for public-facing routes)
+  #
+  # Example configuration:
+  #   config.tags = ["ignored", "critical", "experimental", "deprecated", "external", "admin"]
+
+  config.tags = [ "ignored", "critical", "experimental" ]
+
   # ====================================================================================================
   #                                            DATABASE CONFIGURATION
   # ====================================================================================================