rails_pulse 0.1.3 → 0.2.2

data/app/assets/stylesheets/rails_pulse/components/datepicker.css

@@ -0,0 +1,191 @@
+@import url("https://esm.sh/flatpickr@4.6.13/dist/flatpickr.min.css");
+
+.flatpickr-calendar {
+  --calendar-size: 250px;
+  --container-size: 220px;
+  --day-size: var(--size-8);
+
+  background: var(--color-bg);
+  border: 1px solid var(--color-border);
+  border-radius: var(--rounded-md);
+  box-shadow: var(--shadow-md);
+  font-size: var(--text-sm);
+  inline-size: var(--calendar-size);
+
+  .flatpickr-innerContainer {
+    justify-content: center;
+    padding-block-end: var(--size-3);
+  }
+
+  .flatpickr-days {
+    inline-size: var(--container-size);
+  }
+
+  .dayContainer {
+    inline-size: var(--container-size);
+    min-inline-size: var(--container-size);
+    max-inline-size: var(--container-size);
+  }
+
+  .dayContainer + .dayContainer {
+    box-shadow: -1px 0 0 var(--color-border);
+  }
+
+  .flatpickr-months {
+    .flatpickr-month {
+      color: var(--color-text);
+    }
+
+    span.cur-month {
+      font-size: var(--text-sm);
+      font-weight: var(--font-medium);
+    }
+
+    svg {
+      fill: var(--color-border-dark);
+    }
+
+    .flatpickr-prev-month:hover svg {
+      fill: var(--color-text);
+    }
+
+    .flatpickr-next-month:hover svg {
+      fill: var(--color-text);
+    }
+  }
+
+  .flatpickr-monthDropdown-months {
+    appearance: none;
+    border-radius: var(--rounded-md);
+    font-size: var(--text-sm);
+    font-weight: var(--font-medium);
+    line-height: var(--leading-normal);
+    padding: 0;
+    text-align: center;
+
+    &:hover {
+      background: var(--color-border-light);
+    }
+  }
+
+  .numInputWrapper {
+    input {
+      border-radius: var(--rounded-md);
+      color: var(--color-text);
+      font-size: var(--text-sm);
+      font-weight: var(--font-medium);
+      line-height: var(--leading-normal);
+      padding: 0;
+      text-align: center;
+    }
+
+    span {
+      border-color: var(--color-border);
+    }
+
+    span:hover {
+      background: transparent;
+    }
+
+    span.arrowUp::after {
+      border-bottom-color: var(--color-text);
+    }
+
+    span.arrowDown::after {
+      border-top-color: var(--color-text);
+    }
+
+    &:hover {
+      background: transparent;
+    }
+  }
+
+  .flatpickr-weekday {
+    color: var(--color-text-subtle);
+    font-weight: var(--font-normal);
+  }
+
+  .flatpickr-time {
+    .hasTime & {
+      border-top-color: var(--color-border);
+    }
+
+    .hasTime.noCalendar & {
+      border: 0;
+    }
+
+    .numInput {
+      background: transparent;
+      color: var(--color-text);
+    }
+
+    .flatpickr-time-separator {
+      color: var(--color-text);
+    }
+
+    .flatpickr-am-pm {
+      background: transparent;
+      color: var(--color-text);
+    }
+  }
+
+  .flatpickr-day {
+    border-radius: var(--rounded-md);
+    border-color: transparent !important;
+    box-shadow: none !important;
+    color: var(--color-text);
+    height: var(--day-size);
+    line-height: var(--day-size);
+    margin-block-start: var(--size-2);
+    max-width: var(--day-size);
+
+    &:is(.inRange) {
+      border-radius: 0;
+    }
+
+    &:is(.today, .inRange, :hover, :focus) {
+      background: var(--color-secondary);
+      color: var(--color-text);
+    }
+
+    &:is(
+      .flatpickr-disabled,
+      .flatpickr-disabled:hover,
+      .prevMonthDay,
+      .nextMonthDay,
+      .notAllowed,
+      .notAllowed.prevMonthDay,
+      .notAllowed.nextMonthDay
+    ) {
+      color: var(--color-text-subtle);
+    }
+
+    &:is(
+      .selected,
+      .startRange,
+      .endRange,
+      .selected.inRange,
+      .startRange.inRange,
+      .endRange.inRange,
+      .selected:focus,
+      .startRange:focus,
+      .endRange:focus,
+      .selected:hover,
+      .startRange:hover,
+      .endRange:hover,
+      .selected.prevMonthDay,
+      .startRange.prevMonthDay,
+      .endRange.prevMonthDay,
+      .selected.nextMonthDay,
+      .startRange.nextMonthDay,
+      .endRange.nextMonthDay
+    ) {
+      background: var(--color-primary);
+      color: var(--color-text-reversed);
+    }
+  }
+
+  &::before, &::after {
+    display: none;
+  }
+}

data/app/assets/stylesheets/rails_pulse/components/switch.css

@@ -0,0 +1,36 @@
+.switch {
+  appearance: none;
+  background-color: var(--color-border);
+  border-color: transparent;
+  border-radius: var(--rounded-full);
+  border-width: var(--border-2);
+  block-size: var(--size-5);
+  inline-size: var(--size-9);
+  transition: background-color var(--time-150);
+
+  &:checked {
+    background-color: var(--color-primary);
+  }
+
+  &:checked::before {
+    margin-inline-start: var(--size-4);
+  }
+
+  &::before {
+    aspect-ratio: var(--aspect-square);
+    background-color: var(--color-text-reversed);
+    block-size: var(--size-full);
+    border-radius: var(--rounded-full);
+    content: "";
+    display: block;
+    transition: margin var(--time-150);
+  }
+
+  &:focus-visible {
+    outline: var(--border-2) solid var(--color-selected-dark);
+  }
+
+  &:disabled {
+    cursor: not-allowed; opacity: var(--opacity-50);
+  }
+}

data/app/assets/stylesheets/rails_pulse/components/tags.css

@@ -0,0 +1,98 @@
+/* Tag Manager Container */
+.breadcrumb-container {
+  display: flex;
+  align-items: center;
+  justify-content: space-between;
+  gap: 1rem;
+  flex-wrap: wrap;
+}
+
+.breadcrumb-tags {
+  display: flex;
+  align-items: center;
+}
+
+/* Tag Manager */
+.tag-manager {
+  display: flex;
+  align-items: center;
+  gap: 0.5rem;
+}
+
+.tag-list {
+  display: flex;
+  align-items: center;
+  gap: 0.5rem;
+  flex-wrap: wrap;
+}
+
+/* Individual Tag */
+.tag {
+  display: inline-flex;
+  align-items: center;
+  gap: 0.25rem;
+  padding: 0.25rem 0.5rem;
+  background-color: var(--color-background-secondary);
+  border: 1px solid var(--color-border);
+  border-radius: 0.375rem;
+  font-size: 0.875rem;
+  line-height: 1.25;
+  white-space: nowrap;
+}
+
+/* Tag Remove Button */
+.tag-remove {
+  all: unset;
+  display: inline-flex;
+  align-items: center;
+  justify-content: center;
+  width: 1rem;
+  height: 1rem;
+  padding: 0;
+  margin: 0;
+  background: none;
+  border: none;
+  cursor: pointer;
+  color: currentColor;
+  opacity: 0.6;
+  transition: opacity 0.15s ease;
+}
+
+.tag-remove:hover {
+  opacity: 1;
+}
+
+.tag-remove span {
+  font-size: 1.25rem;
+  line-height: 1;
+  font-weight: bold;
+}
+
+/* Add Tag Container */
+.tag-add-container {
+  position: relative;
+  display: inline-block;
+}
+
+.tag-add-button {
+  padding: 0.25rem 0.5rem;
+  font-size: 0.875rem;
+  line-height: 1.25;
+  white-space: nowrap;
+}
+
+/* Responsive Design */
+@media (max-width: 768px) {
+  .breadcrumb-container {
+    flex-direction: column;
+    align-items: flex-start;
+  }
+
+  .breadcrumb-tags {
+    width: 100%;
+  }
+
+  .tag-manager {
+    width: 100%;
+  }
+}

data/app/assets/stylesheets/rails_pulse/components/utilities.css

@@ -34,3 +34,29 @@
 .max-w-md { max-width: 28rem; }
 .max-w-lg { max-width: 32rem; }
 .max-w-xl { max-width: 36rem; }
+
+/* Global filters active indicator */
+.global-filters-active {
+  position: relative;
+}
+
+.global-filters-active::after {
+  content: "";
+  position: absolute;
+  top: -2px;
+  right: -2px;
+  width: 8px;
+  height: 8px;
+  background-color: var(--color-primary);
+  border-radius: 50%;
+  border: 2px solid var(--color-bg);
+}
+
+/* Flatpickr z-index fix - ensure calendar appears above dialogs */
+.flatpickr-calendar,
+.flatpickr-calendar.open,
+.flatpickr-calendar.inline,
+.flatpickr-calendar.static,
+.flatpickr-calendar.static.open {
+  z-index: 999999 !important;
+}

data/app/controllers/concerns/response_range_concern.rb

@@ -5,9 +5,11 @@ module ResponseRangeConcern
     ransack_params = params[:q] || {}
     thresholds = RailsPulse.configuration.public_send("#{type}_thresholds")
 
-    # Check both avg_duration (for Summary) and duration (for Request/Operation)
-    duration_param = ransack_params[:avg_duration] || ransack_params[:duration]
+    # Check all duration-related parameters
+    # avg_duration for Summary, duration for Request/Operation, duration_gteq for direct Ransack filtering
+    duration_param = ransack_params[:avg_duration] || ransack_params[:duration] || ransack_params[:duration_gteq]
 
+    # Priority 1: Page-specific duration filter
     if duration_param.present?
       selected_range = duration_param
       start_duration =
@@ -17,6 +19,17 @@ module ResponseRangeConcern
         when :critical then thresholds[:critical]
         else 0
         end
+    # Priority 2: Global performance threshold filter
+    elsif (global_threshold = session_global_filters["performance_threshold"]).present?
+      selected_range = global_threshold.to_sym
+      start_duration =
+        case global_threshold.to_sym
+        when :slow then thresholds[:slow]
+        when :very_slow then thresholds[:very_slow]
+        when :critical then thresholds[:critical]
+        else 0
+        end
+    # Priority 3: No filter (show all)
     else
       start_duration = 0
       selected_range = :all

data/app/controllers/concerns/tag_filter_concern.rb

@@ -0,0 +1,26 @@
+module TagFilterConcern
+  extend ActiveSupport::Concern
+
+  private
+
+  # Apply tag filters to a query
+  # Excludes records that have ANY of the disabled tags
+  def apply_tag_filters(query)
+    disabled_tags = session_disabled_tags
+    query = disabled_tags.reduce(query) do |q, tag|
+      q.without_tag(tag)
+    end
+
+    apply_non_tagged_filter(query)
+  end
+
+  # Apply non-tagged filter to a query
+  # If show_non_tagged is false, exclude records with no tags
+  def apply_non_tagged_filter(query)
+    if session[:show_non_tagged] == false
+      query.with_tags
+    else
+      query
+    end
+  end
+end

data/app/controllers/concerns/time_range_concern.rb

@@ -6,7 +6,8 @@ module TimeRangeConcern
     const_set(:TIME_RANGE_OPTIONS, [
       [ "Last 24 hours", :last_day ],
       [ "Last Week", :last_week ],
-      [ "Last Month", :last_month ]
+      [ "Last Month", :last_month ],
+      [ "Custom Range...", :custom ]
     ].freeze)
   end
 
@@ -17,11 +18,8 @@ module TimeRangeConcern
 
     ransack_params = params[:q] || {}
 
-    if ransack_params[:occurred_at_gteq].present?
-      # Custom time range from chart zoom where there is no association
-      start_time = parse_time_param(ransack_params[:occurred_at_gteq])
-      end_time = parse_time_param(ransack_params[:occurred_at_lt])
-    elsif ransack_params[:period_start_range]
+    # Priority 1: Page-specific preset from dropdown (check this first!)
+    if ransack_params[:period_start_range].present? && ransack_params[:period_start_range].to_sym != :custom
       # Predefined time range from dropdown
       selected_time_range = ransack_params[:period_start_range]
       start_time =
@@ -31,7 +29,26 @@ module TimeRangeConcern
         when :last_month then 1.month.ago
         else 1.day.ago # Default fallback
         end
+    # Priority 2: Page-specific custom datetime range from picker (only if period_start_range is :custom)
+    elsif ransack_params[:period_start_range].present? && ransack_params[:period_start_range].to_sym == :custom && ransack_params[:custom_date_range].present? && ransack_params[:custom_date_range].include?(" to ")
+      # Custom datetime range from custom range picker
+      dates = ransack_params[:custom_date_range].split(" to ")
+      start_time = parse_time_param(dates[0].strip)
+      end_time = parse_time_param(dates[1].strip)
+      selected_time_range = :custom
+    # Priority 3: Page-specific filters (chart zoom)
+    elsif ransack_params[:occurred_at_gteq].present? && ransack_params[:occurred_at_lt].present?
+      # Custom time range from chart zoom
+      start_time = parse_time_param(ransack_params[:occurred_at_gteq])
+      end_time = parse_time_param(ransack_params[:occurred_at_lt])
+      selected_time_range = :custom
+    # Priority 4: Global filters (from session)
+    elsif session_global_filters["start_time"].present? || session_global_filters["end_time"].present?
+      start_time = parse_time_param(session_global_filters["start_time"]) if session_global_filters["start_time"].present?
+      end_time = parse_time_param(session_global_filters["end_time"]) if session_global_filters["end_time"].present?
+      selected_time_range = :custom
     end
+    # Priority 5: Default time range (already set above)
 
     time_diff = (end_time.to_i - start_time.to_i) / 3600.0
 
@@ -43,7 +60,7 @@ module TimeRangeConcern
       end_time = end_time.end_of_day
     end
 
-    [ start_time, end_time, selected_time_range, time_diff ]
+    [ start_time.to_i, end_time.to_i, selected_time_range, time_diff ]
   end
 
   private
@@ -53,7 +70,9 @@ module TimeRangeConcern
     when Time, DateTime
       param.in_time_zone
     when String
-      Time.zone.parse(param)
+      # Parse as server local time (not UTC, not Time.zone)
+      # This ensures flatpickr datetime strings are interpreted in server's timezone
+      Time.parse(param).localtime
     else
       # Assume it's an integer timestamp
       Time.zone.at(param.to_i)

data/app/controllers/rails_pulse/application_controller.rb

@@ -1,6 +1,8 @@
 module RailsPulse
   class ApplicationController < ActionController::Base
     before_action :authenticate_rails_pulse_user!
+    before_action :set_show_non_tagged_default
+    helper_method :session_global_filters, :session_disabled_tags
 
     def set_pagination_limit(limit = nil)
       limit = limit || params[:limit]
@@ -12,6 +14,48 @@ module RailsPulse
       end
     end
 
+    def set_global_filters
+      if params[:clear] == "true"
+        session.delete(:global_filters)
+      else
+        filters = session[:global_filters] || {}
+
+        # Update time filters if provided
+        if params[:start_time].present? && params[:end_time].present?
+          filters["start_time"] = params[:start_time]
+          filters["end_time"] = params[:end_time]
+        end
+
+        # Update performance threshold if provided (or remove if empty)
+        if params[:performance_threshold].present?
+          filters["performance_threshold"] = params[:performance_threshold]
+        else
+          filters.delete("performance_threshold")
+        end
+
+        # Update tag visibility - convert enabled tags to disabled tags
+        all_tags = RailsPulse.configuration.tags
+        enabled_tags = params[:enabled_tags] || []
+
+        # Handle "non_tagged" separately
+        session[:show_non_tagged] = enabled_tags.include?("non_tagged")
+        enabled_tags = enabled_tags - [ "non_tagged" ]
+
+        disabled_tags = all_tags - enabled_tags
+
+        if disabled_tags.any?
+          filters["disabled_tags"] = disabled_tags
+        else
+          filters.delete("disabled_tags")
+        end
+
+        session[:global_filters] = filters
+      end
+
+      # Redirect back to the referring page or root
+      redirect_back(fallback_location: root_path)
+    end
+
     private
 
     def authenticate_rails_pulse_user!
@@ -71,5 +115,34 @@ module RailsPulse
       validated_limit = limit.to_i.clamp(5, 50)
       session[:pagination_limit] = validated_limit if limit.present?
     end
+
+    def session_global_filters
+      session[:global_filters] || {}
+    end
+
+    def session_disabled_tags
+      session_global_filters["disabled_tags"] || []
+    end
+
+    # Get the minimum duration based on global performance threshold
+    # Returns nil if no threshold is set (show all)
+    # context: :route, :request, or :query
+    def global_performance_threshold_duration(context)
+      threshold = session_global_filters["performance_threshold"]
+      return nil unless threshold.present?
+
+      config_key = "#{context}_thresholds".to_sym
+      thresholds = RailsPulse.configuration.public_send(config_key)
+
+      thresholds[threshold.to_sym]
+    rescue StandardError => e
+      Rails.logger.warn "Failed to get performance threshold: #{e.message}"
+      nil
+    end
+
+    # Set default value for show_non_tagged if not already set
+    def set_show_non_tagged_default
+      session[:show_non_tagged] = true if session[:show_non_tagged].nil?
+    end
   end
 end

data/app/controllers/rails_pulse/queries_controller.rb

@@ -1,6 +1,7 @@
 module RailsPulse
   class QueriesController < ApplicationController
     include ChartTableConcern
+    include TagFilterConcern
 
     before_action :set_query, only: [ :show, :analyze ]
 
@@ -55,7 +56,7 @@ module RailsPulse
     end
 
     def table_model
-      show_action? ? Operation : Summary
+      Summary
     end
 
     def chart_class
@@ -76,7 +77,10 @@ module RailsPulse
       base_params[:avg_duration_gteq] = @start_duration if @start_duration && @start_duration > 0
 
       if show_action?
-        base_params.merge(summarizable_id_eq: @query.id)
+        base_params.merge(
+          summarizable_id_eq: @query.id,
+          summarizable_type_eq: "RailsPulse::Query"
+        )
       else
         base_params
       end
@@ -84,13 +88,14 @@ module RailsPulse
 
     def build_table_ransack_params(ransack_params)
       if show_action?
-        # For Operation model on show page
+        # For Summary model on show page
         params = ransack_params.merge(
-          occurred_at_gteq: Time.at(@table_start_time),
-          occurred_at_lt: Time.at(@table_end_time),
-          query_id_eq: @query.id
+          period_start_gteq: Time.at(@table_start_time),
+          period_start_lt: Time.at(@table_end_time),
+          summarizable_id_eq: @query.id,
+          summarizable_type_eq: "RailsPulse::Query"
         )
-        params[:duration_gteq] = @start_duration if @start_duration && @start_duration > 0
+        params[:avg_duration_gteq] = @start_duration if @start_duration && @start_duration > 0
         params
       else
         # For Summary model on index page
@@ -104,29 +109,21 @@ module RailsPulse
     end
 
     def default_table_sort
-      show_action? ? "occurred_at desc" : "period_start desc"
+      "period_start desc"
     end
 
     def build_table_results
       if show_action?
-        # Only show operations that belong to time periods where we have query summaries
-        # This ensures the table data is consistent with the chart data
-        @ransack_query.result
-          .joins(<<~SQL)
-            INNER JOIN rails_pulse_summaries ON
-              rails_pulse_summaries.summarizable_id = rails_pulse_operations.query_id AND
-              rails_pulse_summaries.summarizable_type = 'RailsPulse::Query' AND
-              rails_pulse_summaries.period_type = '#{period_type}' AND
-              rails_pulse_operations.occurred_at >= rails_pulse_summaries.period_start AND
-              rails_pulse_operations.occurred_at < rails_pulse_summaries.period_end
-          SQL
-          .distinct
+        # For Summary model on show page - ransack params already include query ID and type filters
+        # Summaries aren't taggable, so we don't apply tag filters here
+        @ransack_query.result.where(period_type: period_type)
       else
         Queries::Tables::Index.new(
           ransack_query: @ransack_query,
           period_type: period_type,
           start_time: @start_time,
-          params: params
+          params: params,
+          disabled_tags: session_disabled_tags
         ).to_table
       end
     end