rails_pod_kit 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a40b144ace0af8e73c9a44f21ebb7111e726543a343be3c8f8969ee7befb166c
-  data.tar.gz: 5ec92a058a63671e877011591d2a5585a98a9da5c851db86ea5924814cbed32a
+  metadata.gz: 136074682007e1265cd41d0d71fae7c1be18edc71edf881e82f14521391aa3bc
+  data.tar.gz: 8ab4e7116c77e72a60cda99934564124184aa1489f2ea04d5f49510293808d03
 SHA512:
-  metadata.gz: fca2fbe470f2eaa9c8039034d8795ca9006ea10e835d8db907c20aa3a1740eeffa2bc94a2d31bc024130028f15e4340e4c59dcc3fc330cbb34d12b649bd1f4b1
-  data.tar.gz: 04e115d689e42b62975846ca67a5312ba7de26fbec65ca970864dbc844131dda53188839ff05f1a81601aeaa652bd42e1f17682d8d22cc08203322b5072bf1b7
+  metadata.gz: d73285ade30683bfee3f9a933b31d672dbf04fe2ac604270f49f5394799565f65aaa1bfd1a107af0a4f70b6798d75e5dd3ed295696c79cfc65528696732a32a5
+  data.tar.gz: aa042f91445f4bd90b6c6c6e7dbdce8b10e0433293efc9239b61a5046443a6a6967c0c7ad040cccc3b70c927016c1749c3f0d70d302581e5ec8a301684dd3c0a

data/README.md

@@ -609,6 +609,26 @@ serves `solid_queue_*` and nothing else, so the check config needs no filters.
 - **Puma control app.** `yabeda-puma-plugin` reads Puma's thread-pool stats
   through Puma's control app, so `Puma.activate` activates one on a
   localhost-only socket (`no_token: true`, never network-exposed).
+- **`json` 3 needs Rails 8.1.** On ActiveSupport **< 8.1**, json **>= 3** breaks
+  *every* `to_json` call in the process, not just this gem's. ActiveSupport up
+  to 8.0 encodes with `JSON.generate(..., quirks_mode: true)`; json 3.0 turned
+  that unknown keyword from a silent no-op into an `ArgumentError`, and Rails
+  dropped the call only in 8.1. The whole ecosystem is pinning `json` to `"< 3"`
+  behind a Rails-version guard, and so should a host on 7.2 or 8.0 — the
+  appraisals here do exactly that.
+
+  What is specific to this gem is the *shape* of its symptom. Everywhere else
+  the error is loud; in the metrics path it is not. prometheus-client-mmap
+  builds each metric's mmap key with `to_json` and catches the failure in
+  `UsesValueType#value_object`, logging at INFO before falling back to
+  `SimpleValue` — which keeps the value in the recording process instead of the
+  shared mmap file. So `/metrics` still answers 200 and the series simply go
+  missing. If you are chasing an empty exposition, check this first.
+
+  Not expressible as a gemspec dependency: it applies only below ActiveSupport
+  8.1, and `json < 3` there would hold back Rails 8.1+ hosts, which are fine
+  (verified: AS 8.1.3.1 + json 3.0.2 encodes normally).
+
 - **Rack version.** Under **Rack 3+** the mmap exporter's WEBrick handler also
   needs the `rackup` gem. Under Rack 2.x `webrick` alone is enough, but on
   Ruby ≥ 4.0 make sure `ostruct` is in the bundle (Rack 2.2 requires it

data/VERSION

@@ -1 +1 @@
-0.3.1
+0.3.2

data/lib/rails_pod_kit/health.rb

@@ -36,10 +36,11 @@ module RailsPodKit
     # Configures HealthMonitor with the kit's defaults.
     #
     # redis:   optional Redis connection options hash (same shape the host
-    #          passes to Sidekiq) or a ready connection object (Redis /
-    #          ConnectionPool); when given the Redis provider is added. Omit
-    #          entirely (or pass nil) on hosts with no Redis dependency to get
-    #          a database + cache only endpoint.
+    #          passes to Sidekiq) or a ready connection object (Redis,
+    #          ConnectionPool, or a ConnectionPool::Wrapper, which is unwrapped
+    #          to the pool behind it); when given the Redis provider is added.
+    #          Omit entirely (or pass nil) on hosts with no Redis dependency to
+    #          get a database + cache only endpoint.
     # path:    mount-relative endpoint path (default :healthz).
     # sidekiq: optional thresholds hash; when given the Sidekiq provider is
     #          added with the provided `queue_size:` / `latency:` overrides
@@ -88,6 +89,17 @@ module RailsPodKit
     end
 
     def build_connection(redis)
+      # ConnectionPool::Wrapper is a BasicObject delegator: it defines no
+      # predicates of its own, so every `is_a?` on it falls through to
+      # method_missing and checks out a real connection. That costs a
+      # connection attempt here at boot -- fatal when the broker is down, the
+      # very outage a health endpoint exists to report -- and health_monitor's
+      # own `is_a?(ConnectionPool)` test misses the wrapper anyway and nests it
+      # in a second pool, paying another checkout per command. Hand over the
+      # pool it wraps. `respond_to?` is answered from the wrapper's own
+      # allowlist without touching the network, and is false for the hash,
+      # Redis and ConnectionPool arguments handled below.
+      return redis.wrapped_pool if redis.respond_to?(:wrapped_pool)
       return redis unless redis.is_a?(Hash)
 
       require 'redis'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_pod_kit
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Fabio Napoleoni