rails_performance 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb51d8480c3184c5dba0f1eb8ac6de2947d22dd9afa5aa2434a9ccf26704e71b
-  data.tar.gz: ea76f7ca185e5e531aaa5b936cc22fb60fb9319601b62773c3f6e9b6915287b9
+  metadata.gz: 3252836acfb4bfe1d62ace64e6c49633df64761b41f8aedf7286f41d9f11e889
+  data.tar.gz: 234011eabad7794de9d5fc6c367a3cd74d6db14db48907e8f0552f67229b4160
 SHA512:
-  metadata.gz: cf34b64cb3c9d55faeff3820f09f6f91a1a8d59138e4a4c4ad0f172c0c7489f1dd5307ad90a447013b8a317616c0d647c618831ca63ddea7cfbe0758c2002510
-  data.tar.gz: 6aaf94e150feb3aa16e7c18f7c2195c85af4aee035bffef2e9d48f5dd164e1ff45d3c2d5ea32b5395c1a8f23efef524ff4ecb6bc069922d7631e65fb785f93df
+  metadata.gz: c6b3e38a15d53cf1518542972fb5d5dfcaffff218ef325d97b6bb776d987c699936fa6237de1b0f191370185dad2ecbcc52821e0d13bd0fb21b0200c063e3f51
+  data.tar.gz: e7e77fb6229377c2550e70813f7276041c542b2bf0fa2c2c0ef00edca95d6ab82cc9802dfde0a995f4374559f0159c5224c4b21452e74fd392d9c91e9552ae69

data/app/controllers/rails_performance/rails_performance_controller.rb

@@ -13,6 +13,7 @@ module RailsPerformance
 
         @throughput_report_data = RailsPerformance::Reports::ThroughputReport.new(db).data
         @response_time_report_data = RailsPerformance::Reports::ResponseTimeReport.new(db).data
+        @percentile_report_data = RailsPerformance::Reports::PercentileReport.new(db).data
       end
 
       def summary

data/app/views/rails_performance/rails_performance/index.html.erb

@@ -4,6 +4,35 @@
   <%#= link_to raw("&larr; Back"), rails_performance_path, class: "back_link" %>
 <% end %>
 
+<div class="columns">
+  <div class="column">
+    <div class="card">
+      <div class="card-content">
+        <h2 class="subtitle is-size-1"><%= ms @percentile_report_data[:p50] %></h2>
+        <p class="content is-size-4">p50</p>
+      </div>
+    </div>
+  </div>
+
+  <div class="column">
+    <div class="card">
+      <div class="card-content">
+        <h2 class="subtitle is-size-1"><%= ms @percentile_report_data[:p95] %></h2>
+        <p class="content is-size-4">p95</p>
+      </div>
+    </div>
+  </div>
+
+  <div class="column">
+    <div class="card">
+      <div class="card-content">
+        <h2 class="subtitle is-size-1"><%= ms @percentile_report_data[:p99] %></h2>
+        <p class="content is-size-4">p99</p>
+      </div>
+    </div>
+  </div>
+</div>
+
 <div class="card">
   <div class="card-content">
     <h2 class="subtitle">Throughput Report</h2>

data/app/views/rails_performance/rails_performance/requests.html.erb

@@ -2,16 +2,17 @@
   <div class="card-content">
     <div class="columns is-vcentered">
       <div class="column">
-        <h2 class="subtitle">Requests (path, total number, average response time)</h2>
+        <h2 class="subtitle">Requests Analysis</h2>
       </div>
       <div class="column is-narrow">
-        <%= render "export" %> 
+        <%= render "export" %>
       </div>
     </div>
     <table class="table is-fullwidth is-hoverable is-narrow">
       <thead>
         <tr>
           <th colspan='3'>Name</th>
+          <th colspan='3' class="attention">Percentile</th>
           <th colspan='3'>Average</th>
           <th colspan='3'>Slowest</th>
         </tr>
@@ -19,6 +20,9 @@
           <th data-sort="string">Controller#action</th>
           <th data-sort="string">Format</th>
           <th data-sort="int">Requests</th>
+          <th data-sort="float" class="attention">P50</th>
+          <th data-sort="float" class="attention">P95</th>
+          <th data-sort="float" class="attention">P99</th>
           <th data-sort="float">Duration</th>
           <th data-sort="float">Views</th>
           <th data-sort="float">DB</th>
@@ -35,6 +39,9 @@
             <td><%= link_to groups[0],  rails_performance.rails_performance_summary_path({controller_eq: c, action_eq: a}), remote: true %></td>
             <td><%= link_to groups[1].try(:upcase),  rails_performance.rails_performance_summary_path({controller_eq: c, action_eq: a, format_eq: groups[1]}), remote: true %></td>
             <td><%= e[:count] %></td>
+            <td class="nowrap attention"><%= ms e[:p50_duration] %></td>
+            <td class="nowrap attention"><%= ms e[:p95_duration] %></td>
+            <td class="nowrap attention"><%= ms e[:p99_duration] %></td>
             <td class="nowrap"><%= ms e[:duration_average] %></td>
             <td class="nowrap"><%= ms e[:view_runtime_average] %></td>
             <td class="nowrap"><%= ms e[:db_runtime_average] %></td>

data/app/views/rails_performance/stylesheets/style.css

@@ -121,3 +121,7 @@ table th[data-sort] {
   font-size: 7px !important;
   line-height: 20px !important;
 }
+
+.attention {
+  background-color: #f6f5f5;
+}

data/lib/rails_performance/models/request_record.rb

@@ -30,6 +30,8 @@ module RailsPerformance
       def self.from_db(key, value)
         items = key.split("|")
 
+        parsed_value = JSON.parse(value) rescue {}
+
         RequestRecord.new(
           controller: items[2],
           action: items[4],
@@ -40,7 +42,10 @@ module RailsPerformance
           method: items[14],
           path: items[16],
           request_id: items[18],
-          json: value
+          json: value,
+          duration: parsed_value["duration"],
+          view_runtime: parsed_value["view_runtime"],
+          db_runtime: parsed_value["db_runtime"],
         )
       end
 

data/lib/rails_performance/reports/base_report.rb

@@ -12,15 +12,15 @@ module RailsPerformance
         set_defaults
       end
 
+      def set_defaults
+      end
+
       def collect
         db.group_by(group).each_with_object([]) do |(k, v), res|
           res << yield(k, v)
         end
       end
 
-      def set_defaults
-      end
-
       def self.time_in_app_time_zone(time)
         app_time_zone = ::Rails.application.config.time_zone
         if app_time_zone.present?

data/lib/rails_performance/reports/percentile_report.rb

@@ -0,0 +1,14 @@
+module RailsPerformance
+  module Reports
+    class PercentileReport < BaseReport
+      def data
+        durations = db.data.collect(&:duration)
+        {
+          p50: RailsPerformance::Utils.percentile(durations, 50),
+          p95: RailsPerformance::Utils.percentile(durations, 95),
+          p99: RailsPerformance::Utils.percentile(durations, 99)
+        }
+      end
+    end
+  end
+end

data/lib/rails_performance/reports/requests_report.rb

@@ -18,7 +18,10 @@ module RailsPerformance
             db_runtime_average: db_runtimes.sum.to_f / db_runtimes.size,
             duration_slowest: durations.max,
             view_runtime_slowest: view_runtimes.max,
-            db_runtime_slowest: db_runtimes.max
+            db_runtime_slowest: db_runtimes.max,
+            p50_duration: RailsPerformance::Utils.percentile(durations, 50),
+            p95_duration: RailsPerformance::Utils.percentile(durations, 95),
+            p99_duration: RailsPerformance::Utils.percentile(durations, 99),
           }
         end.sort_by { |e| -e[sort].to_f } # to_f because could ne NaN or nil
       end

data/lib/rails_performance/utils.rb

@@ -49,5 +49,16 @@ module RailsPerformance
         sorted[center]
       end
     end
+
+    def self.percentile(values, percentile)
+      return nil if values.empty?
+
+      sorted = values.sort
+      rank = (percentile.to_f / 100) * (sorted.size - 1)
+
+      lower = sorted[rank.floor]
+      upper = sorted[rank.ceil]
+      lower + (upper - lower) * (rank - rank.floor)
+    end
   end
 end

data/lib/rails_performance/version.rb

@@ -1,4 +1,4 @@
 module RailsPerformance
-  VERSION = "1.3.0"
+  VERSION = "1.3.1"
   SCHEMA = "1.0.1"
 end

data/lib/rails_performance.rb

@@ -1,5 +1,4 @@
 require "redis"
-require "redis-namespace"
 require "browser"
 require "active_support/core_ext/integer"
 require_relative "rails_performance/version"
@@ -24,6 +23,7 @@ require_relative "rails_performance/reports/recent_requests_report"
 require_relative "rails_performance/reports/slow_requests_report"
 require_relative "rails_performance/reports/breakdown_report"
 require_relative "rails_performance/reports/trace_report"
+require_relative "rails_performance/reports/percentile_report"
 require_relative "rails_performance/extensions/trace"
 require_relative "rails_performance/thread/current_request"
 
@@ -31,7 +31,7 @@ module RailsPerformance
   FORMAT = "%Y%m%dT%H%M"
 
   mattr_accessor :redis
-  @@redis = Redis::Namespace.new("{#{::Rails.env}-rails-performance}", redis: Redis.new)
+  @@redis = Redis.new
 
   mattr_accessor :duration
   @@duration = 4.hours

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_performance
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Igor Kasyanchuk
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-02 00:00:00.000000000 Z
+date: 2024-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -38,20 +38,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: redis-namespace
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: browser
   requirement: !ruby/object:Gem::Requirement
@@ -351,6 +337,7 @@ files:
 - lib/rails_performance/reports/base_report.rb
 - lib/rails_performance/reports/breakdown_report.rb
 - lib/rails_performance/reports/crash_report.rb
+- lib/rails_performance/reports/percentile_report.rb
 - lib/rails_performance/reports/recent_requests_report.rb
 - lib/rails_performance/reports/requests_report.rb
 - lib/rails_performance/reports/response_time_report.rb
@@ -379,7 +366,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
+rubygems_version: 3.3.7
 signing_key:
 specification_version: 4
 summary: Simple Rails Performance tracker. Alternative to the NewRelic, Datadog or