rails_performance 1.0.0.beta3 → 1.0.0.beta4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d95736df988ebe718c347259ae72fb5c33a10bd358c1ff5c459188d704ca89b6
-  data.tar.gz: 289ad1993e1a0cfb5f52143a5c45d37d898de0be6ef12101b7c2df6dde3d8966
+  metadata.gz: 38819433ac1ee118a96caab4f7ca4a539b2d995357df0a4bc04333ae55d3beb7
+  data.tar.gz: 207a4b1e375df67b0af5b3f446fe59cb50e608da207510fa64ad28e1f8366039
 SHA512:
-  metadata.gz: 841415e9db06b9cbc2fc820a349410b5d140b3bedb11731ba56d1359892f2226a732768cb908ebc1085bcca4bbd3653d1f49ebc3f6679aedb586df84a320c049
-  data.tar.gz: b8730fe25499f7303e28e900417ce759fc421adc95a2adab4142fac2bf7d30f90c847399fa442a1b1f0d42087f097ef74496f8d5531776221578100c889b94f8
+  metadata.gz: efa206d30d71c4b5721bbc8fad0df581b56a7ad0642b99f0d91c9e1ff1e5ff394951f68ddcd0ba498d5f60f2de8714bd9163a5f7912abdb548bd0d1bb8b2fce5
+  data.tar.gz: 9f4810ef1db85454e2ffefee36f2cedb43dd1d9495ef7ce993ecf4da364234fe04b0d644db7be9270fc2011f66bad47c6ebcdf73ed561e0711a07f88941c36aa

data/app/views/rails_performance/rails_performance/crashes.html.erb

@@ -9,6 +9,8 @@
           <th data-sort="string">Method</th>
           <th data-sort="string">Format</th>
           <th data-sort="string">Path</th>
+          <th data-sort="string">Exception</th>
+          <th data-sort="string">Backtrace</th>
           <th data-sort="string">Status</th>
           <th data-sort="float">Duration</th>
           <th data-sort="float">Views</th>
@@ -29,6 +31,10 @@
             <td><%= e[:method] %></td>
             <td><%= e[:format] %></td>
             <td><%= link_to_path(e) %></td>
+            <td><%= e[:exception] %></td>
+            <td class="very-small-text">
+              <%= raw e[:backtrace]&.join("<br/>") %>
+            </td>
             <td><%= status_tag e[:status] %></td>
             <td class="nowrap"><%= ms e[:duration] %></td>
             <td class="nowrap"><%= ms e[:view_runtime] %></td>

data/app/views/rails_performance/stylesheets/style.css

@@ -84,4 +84,8 @@
 
 table th[data-sort] {
   cursor: pointer;
+}
+
+.very-small-text {
+  font-size: 8px;
 }

data/lib/rails_performance.rb

@@ -69,11 +69,11 @@ module RailsPerformance
   mattr_accessor :skip
   @@skip = false
 
-  def self.setup
+  def RailsPerformance.setup
     yield(self)
   end
 
-  def self.log(message)
+  def RailsPerformance.log(message)
     return
 
     if ::Rails.logger

data/lib/rails_performance/instrument/metrics_collector.rb

@@ -17,6 +17,8 @@ module RailsPerformance
 
       def call(event_name, started, finished, event_id, payload)
         return if RailsPerformance.skip
+        return if CurrentRequest.current.data
+
         # TODO do we need this new?
         event = ActiveSupport::Notifications::Event.new(event_name, started, finished, event_id, payload)
 
@@ -33,9 +35,13 @@ module RailsPerformance
           path: event.payload[:path],
           view_runtime: event.payload[:view_runtime],
           db_runtime: event.payload[:db_runtime],
-          duration: event.duration
+          duration: event.duration,
+          exception: event.payload[:exception],
+          exception_object: event.payload[:exception_object]
         }
 
+        # pass the record to Thread.current
+        # and saves later in middleware
         CurrentRequest.current.data = record
       end
     end

data/lib/rails_performance/models/request_record.rb

@@ -3,6 +3,7 @@ module RailsPerformance
     class RequestRecord < BaseRecord
       attr_accessor :controller, :action, :format, :status, :datetime, :datetimei, :method, :path, :request_id, :json
       attr_accessor :view_runtime, :db_runtime, :duration, :http_referer
+      attr_accessor :exception, :exception_object
 
       def RequestRecord.find_by(request_id:)
         keys, values = RailsPerformance::Utils.fetch_from_redis("performance|*|request_id|#{request_id}|*")
@@ -24,7 +25,7 @@ module RailsPerformance
       # path|/|
       # request_id|454545454545454545|
       # END|1.0.0
-      # = {"view_runtime":8.444603008683771,"db_runtime":0,"duration":9.216095000000001}
+      # = {"view_runtime":null,"db_runtime":0,"duration":27.329741000000002,"http_referer":null,"exception":"ZeroDivisionError divided by 0","backtrace":["/root/projects/rails_performance/test/dummy/app/controllers/account/site_controller.rb:17:in `/'","/root/projects/rails_performance/test/dummy/app/controllers/account/site_controller.rb:17:in `crash'","/usr/local/rvm/gems/ruby-2.6.3/gems/actionpack-6.1.3.1/lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'"]}
       # value = JSON
       def RequestRecord.from_db(key, value)
         items = key.split("|")
@@ -43,7 +44,7 @@ module RailsPerformance
         )
       end
 
-      def initialize(controller:, action:, format:, status:, datetime:, datetimei:, method:, path:, request_id:, view_runtime: nil, db_runtime: nil, duration: nil, http_referer: nil, json: '{}')
+      def initialize(controller:, action:, format:, status:, datetime:, datetimei:, method:, path:, request_id:, view_runtime: nil, db_runtime: nil, duration: nil, http_referer: nil, exception: nil, exception_object: nil, json: '{}')
         @controller = controller
         @action     = action
         @format     = format
@@ -59,6 +60,9 @@ module RailsPerformance
         @duration     = duration
         @http_referer = http_referer
 
+        @exception        = Array.wrap(exception).compact.join(" ")
+        @exception_object = exception_object
+
         @json       = json
       end
 
@@ -84,12 +88,21 @@ module RailsPerformance
           duration: self.value['duration'],
           db_runtime: self.value['db_runtime'],
           view_runtime: self.value['view_runtime'],
+          exception: self.value['exception'],
+          backtrace: self.value['backtrace']
         }
       end
 
       def save
-        value = { view_runtime: view_runtime, db_runtime: db_runtime, duration: duration, http_referer: http_referer }
         key   = "performance|controller|#{controller}|action|#{action}|format|#{format}|status|#{status}|datetime|#{datetime}|datetimei|#{datetimei}|method|#{method}|path|#{path}|request_id|#{request_id}|END|#{RailsPerformance::SCHEMA}"
+        value = {
+          view_runtime: view_runtime,
+          db_runtime: db_runtime,
+          duration: duration,
+          http_referer: http_referer,
+        }
+        value[:exception] = exception if exception.present?
+        value[:backtrace] = exception_object.backtrace.take(3) if exception_object
         Utils.save_to_redis(key, value)
       end
 

data/lib/rails_performance/version.rb

@@ -1,4 +1,4 @@
 module RailsPerformance
-  VERSION = '1.0.0.beta3'
-  SCHEMA  = '1.0.0'
+  VERSION = '1.0.0.beta4'
+  SCHEMA  = '1.0.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_performance
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta3
+  version: 1.0.0.beta4
 platform: ruby
 authors:
 - Igor Kasyanchuk
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-04-21 00:00:00.000000000 Z
+date: 2021-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -270,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.1
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Simple Rails Performance tracker. Alternative to the NewRelic, Datadog or