rails_ops 1.4.3 → 1.4.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dcb574a4ebd4148a9db8bc6ae9e129b015140175352dccb01b0f9eb6e53a4afd
-  data.tar.gz: 31322cd290160be87eee75fe5ca3604d7611344f4b77faff2681364a34b166f5
+  metadata.gz: 53b02e867030bb59fff755cf97f414f6f20b073183b861f26b642b36efa1a00c
+  data.tar.gz: 78b4c1da977b81a71ccdb92cedf8f6dd156691f19568ebffc4b7a37b1710a00e
 SHA512:
-  metadata.gz: 81e0839e7d210cc6011868a3ea69bf5dd2714aabe96137ee6109468a00ff69400ccfe6fcc5a52a93c772dad15e3638bd0944ffc073f18f010ebd33f648cae1b1
-  data.tar.gz: 1bbc3608339025bd703a5a74a192056f462a5fb756f76531f570cedf754b0d5009d2e69319afc940a1dfc57e38a67fbf1a4fae8f62fb702fc35cb378adcc7825
+  metadata.gz: 89eb88d47fcdc5c73af5497418a4cc7f95c5539812c0d86322ab268c2ef18d4b2f5c21442d013ebe9063c216b83b84b860da4bf83bd8a79942a799cf0e13ea9c
+  data.tar.gz: f88c640775400979cbaeb788febaea743385445f9e10e4d3beab6233c63d9f78c9f83d03d34b4c8907bc6aaf8f4247b2d56def4cb849f8465d3f55fb7c10c148

data/.gitignore

@@ -16,3 +16,4 @@
 /test/dummy/log/
 /test/tmp/
 /gemfiles/*.lock
+/.idea

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 1.4.5 (2023-07-10)
+
+* Fix bug introduced in previous release 1.4.4.
+
+## 1.4.4 (2023-07-10)
+
+* Adapt method `sub_op` to catch `<op-class>.validation_errors` and re-throw
+  them as `RailsOps::Exceptions::SubOpValidationFailed`.
+
 ## 1.4.3 (2023-03-27)
 
 * Extend the `operation` generator to accept additional flags to skip the
@@ -32,7 +41,8 @@
 
 ### Upgrading
 
-Please see #33 for more information on this change. If all of your operations
+Please see [#33](https://github.com/sitrox/rails_ops/issues/33) for more information
+on this change. If all of your operations
 follow the standard naming conventions (e.g. `Operations::User::Update` for
 updating a model named `User`), no changes will be necessary. If you don't, you
 may need to manually specify a `param_key` when using nested model operations

data/Rakefile

@@ -24,6 +24,7 @@ task :gemspec do
     spec.add_development_dependency 'colorize'
     spec.add_development_dependency 'rubocop', '1.45.1'
     spec.add_development_dependency 'sprockets-rails'
+    spec.add_development_dependency 'simplecov'
     spec.add_dependency 'active_type', '>= 1.3.0'
     spec.add_dependency 'minitest'
     spec.add_dependency 'rails'

data/VERSION

@@ -1 +1 @@
-1.4.3
+1.4.5

data/lib/generators/operation/operation_generator.rb

@@ -52,16 +52,16 @@ class OperationGenerator < Rails::Generators::NamedBase
 
     operations_path += @underscored_name.to_s
 
-    if !@excluded_actions.include?(:show)
+    unless @excluded_actions.include?(:show)
       template 'load.erb', "#{operations_path}/load.rb"
     end
-    if !@excluded_actions.include?(:create)
+    unless @excluded_actions.include?(:create)
       template 'create.erb', "#{operations_path}/create.rb"
     end
-    if !@excluded_actions.include?(:update)
+    unless @excluded_actions.include?(:update)
       template 'update.erb', "#{operations_path}/update.rb"
     end
-    if !@excluded_actions.include?(:destroy)
+    unless @excluded_actions.include?(:destroy)
       template 'destroy.erb', "#{operations_path}/destroy.rb"
     end
   end

data/lib/rails_ops/hookup/dsl_validator.rb

@@ -10,7 +10,7 @@ class RailsOps::Hookup::DSLValidator
   def validate!
     # Check infinity loop
     if target_hooks.any? { |name, targets| recursion?(targets, name) }
-      fail StandardError::SystemStackError.new, "Infinite loop detected in hooks configuration: #{inspect_trace}."
+      fail SystemStackError.new, "Infinite loop detected in hooks configuration: #{inspect_trace}."
     end
   end
 

data/lib/rails_ops/hookup.rb

@@ -23,7 +23,7 @@ class RailsOps::Hookup
     unless @config_loaded
       @config_loaded = true
 
-      if File.exist?(CONFIG_PATH)
+      if File.exist?(Rails.root.join(CONFIG_PATH))
         load Rails.root.join(CONFIG_PATH)
       else
         Rails.logger.debug "RailsOps could not find hookup #{CONFIG_PATH}, using empty hookup configuration."

data/lib/rails_ops/mixins/sub_ops.rb

@@ -11,6 +11,8 @@ module RailsOps::Mixins::SubOps
   def sub_op(op, params = {})
     new_context = context.spawn(self)
     return op.new(new_context, params)
+  rescue Schemacop::Exceptions::ValidationError => e
+    fail RailsOps::Exceptions::SubOpValidationFailed, e
   end
 
   # Operation-equivalent of controller method 'run!': Instantiates and runs the

data/lib/rails_ops/operation.rb

@@ -149,7 +149,7 @@ class RailsOps::Operation
 
   # Fails with an exception if the operation has not been performed yet.
   def check_performed!
-    fail 'Operation has not yet been perfomed.' unless performed?
+    fail 'Operation has not yet been performed.' unless performed?
   end
 
   protected

data/rails_ops.gemspec

@@ -1,18 +1,18 @@
 # -*- encoding: utf-8 -*-
-# stub: rails_ops 1.4.3 ruby lib
+# stub: rails_ops 1.4.5 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rails_ops".freeze
-  s.version = "1.4.3"
+  s.version = "1.4.5"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2023-03-27"
-  s.files = [".github/workflows/rubocop.yml".freeze, ".github/workflows/ruby.yml".freeze, ".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, "Appraisals".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.md".freeze, "Rakefile".freeze, "VERSION".freeze, "gemfiles/rails_6.0.gemfile".freeze, "gemfiles/rails_6.1.gemfile".freeze, "gemfiles/rails_7.0.gemfile".freeze, "lib/generators/operation/USAGE".freeze, "lib/generators/operation/operation_generator.rb".freeze, "lib/generators/operation/templates/controller.erb".freeze, "lib/generators/operation/templates/controller_wrapper.erb".freeze, "lib/generators/operation/templates/create.erb".freeze, "lib/generators/operation/templates/destroy.erb".freeze, "lib/generators/operation/templates/load.erb".freeze, "lib/generators/operation/templates/update.erb".freeze, "lib/generators/operation/templates/view.erb".freeze, "lib/rails_ops.rb".freeze, "lib/rails_ops/authorization_backend/abstract.rb".freeze, "lib/rails_ops/authorization_backend/can_can_can.rb".freeze, "lib/rails_ops/configuration.rb".freeze, "lib/rails_ops/context.rb".freeze, "lib/rails_ops/controller_mixin.rb".freeze, "lib/rails_ops/exceptions.rb".freeze, "lib/rails_ops/hooked_job.rb".freeze, "lib/rails_ops/hookup.rb".freeze, "lib/rails_ops/hookup/dsl.rb".freeze, "lib/rails_ops/hookup/dsl_validator.rb".freeze, "lib/rails_ops/hookup/hook.rb".freeze, "lib/rails_ops/log_subscriber.rb".freeze, "lib/rails_ops/mixins.rb".freeze, "lib/rails_ops/mixins/authorization.rb".freeze, "lib/rails_ops/mixins/log_settings.rb".freeze, "lib/rails_ops/mixins/model.rb".freeze, "lib/rails_ops/mixins/model/authorization.rb".freeze, "lib/rails_ops/mixins/model/nesting.rb".freeze, "lib/rails_ops/mixins/param_authorization.rb".freeze, "lib/rails_ops/mixins/policies.rb".freeze, "lib/rails_ops/mixins/require_context.rb".freeze, "lib/rails_ops/mixins/routes.rb".freeze, "lib/rails_ops/mixins/schema_validation.rb".freeze, "lib/rails_ops/mixins/sub_ops.rb".freeze, "lib/rails_ops/model_mixins.rb".freeze, "lib/rails_ops/model_mixins/ar_extension.rb".freeze, "lib/rails_ops/model_mixins/marshalling.rb".freeze, "lib/rails_ops/model_mixins/parent_op.rb".freeze, "lib/rails_ops/model_mixins/sti_fixes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb".freeze, "lib/rails_ops/model_mixins/virtual_has_one.rb".freeze, "lib/rails_ops/model_mixins/virtual_model_name.rb".freeze, "lib/rails_ops/operation.rb".freeze, "lib/rails_ops/operation/model.rb".freeze, "lib/rails_ops/operation/model/create.rb".freeze, "lib/rails_ops/operation/model/destroy.rb".freeze, "lib/rails_ops/operation/model/load.rb".freeze, "lib/rails_ops/operation/model/update.rb".freeze, "lib/rails_ops/profiler.rb".freeze, "lib/rails_ops/profiler/node.rb".freeze, "lib/rails_ops/railtie.rb".freeze, "lib/rails_ops/scoped_env.rb".freeze, "lib/rails_ops/virtual_model.rb".freeze, "rails_ops.gemspec".freeze, "test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/animal.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/bird.rb".freeze, "test/dummy/app/models/cat.rb".freeze, "test/dummy/app/models/computer.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/cpu.rb".freeze, "test/dummy/app/models/dog.rb".freeze, "test/dummy/app/models/flower.rb".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/models/mainboard.rb".freeze, "test/dummy/app/models/nightingale.rb".freeze, "test/dummy/app/models/phoenix.rb".freeze, "test/dummy/app/models/user.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/generators/operation_generator_test.rb".freeze, "test/unit/rails_ops/mixins/model/deep_nesting_test.rb".freeze, "test/unit/rails_ops/mixins/param_authorization_test.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/sti_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation/update_auth_test.rb".freeze, "test/unit/rails_ops/operation/update_lazy_auth_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
+  s.date = "2023-07-11"
+  s.files = [".github/workflows/rubocop.yml".freeze, ".github/workflows/ruby.yml".freeze, ".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, "Appraisals".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.md".freeze, "Rakefile".freeze, "VERSION".freeze, "gemfiles/rails_6.0.gemfile".freeze, "gemfiles/rails_6.1.gemfile".freeze, "gemfiles/rails_7.0.gemfile".freeze, "lib/generators/operation/USAGE".freeze, "lib/generators/operation/operation_generator.rb".freeze, "lib/generators/operation/templates/controller.erb".freeze, "lib/generators/operation/templates/controller_wrapper.erb".freeze, "lib/generators/operation/templates/create.erb".freeze, "lib/generators/operation/templates/destroy.erb".freeze, "lib/generators/operation/templates/load.erb".freeze, "lib/generators/operation/templates/update.erb".freeze, "lib/generators/operation/templates/view.erb".freeze, "lib/rails_ops.rb".freeze, "lib/rails_ops/authorization_backend/abstract.rb".freeze, "lib/rails_ops/authorization_backend/can_can_can.rb".freeze, "lib/rails_ops/configuration.rb".freeze, "lib/rails_ops/context.rb".freeze, "lib/rails_ops/controller_mixin.rb".freeze, "lib/rails_ops/exceptions.rb".freeze, "lib/rails_ops/hooked_job.rb".freeze, "lib/rails_ops/hookup.rb".freeze, "lib/rails_ops/hookup/dsl.rb".freeze, "lib/rails_ops/hookup/dsl_validator.rb".freeze, "lib/rails_ops/hookup/hook.rb".freeze, "lib/rails_ops/log_subscriber.rb".freeze, "lib/rails_ops/mixins.rb".freeze, "lib/rails_ops/mixins/authorization.rb".freeze, "lib/rails_ops/mixins/log_settings.rb".freeze, "lib/rails_ops/mixins/model.rb".freeze, "lib/rails_ops/mixins/model/authorization.rb".freeze, "lib/rails_ops/mixins/model/nesting.rb".freeze, "lib/rails_ops/mixins/param_authorization.rb".freeze, "lib/rails_ops/mixins/policies.rb".freeze, "lib/rails_ops/mixins/require_context.rb".freeze, "lib/rails_ops/mixins/routes.rb".freeze, "lib/rails_ops/mixins/schema_validation.rb".freeze, "lib/rails_ops/mixins/sub_ops.rb".freeze, "lib/rails_ops/model_mixins.rb".freeze, "lib/rails_ops/model_mixins/ar_extension.rb".freeze, "lib/rails_ops/model_mixins/marshalling.rb".freeze, "lib/rails_ops/model_mixins/parent_op.rb".freeze, "lib/rails_ops/model_mixins/sti_fixes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb".freeze, "lib/rails_ops/model_mixins/virtual_has_one.rb".freeze, "lib/rails_ops/model_mixins/virtual_model_name.rb".freeze, "lib/rails_ops/operation.rb".freeze, "lib/rails_ops/operation/model.rb".freeze, "lib/rails_ops/operation/model/create.rb".freeze, "lib/rails_ops/operation/model/destroy.rb".freeze, "lib/rails_ops/operation/model/load.rb".freeze, "lib/rails_ops/operation/model/update.rb".freeze, "lib/rails_ops/profiler.rb".freeze, "lib/rails_ops/profiler/node.rb".freeze, "lib/rails_ops/railtie.rb".freeze, "lib/rails_ops/scoped_env.rb".freeze, "lib/rails_ops/virtual_model.rb".freeze, "rails_ops.gemspec".freeze, "test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/controllers/group_controller.rb".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/ability.rb".freeze, "test/dummy/app/models/animal.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/bird.rb".freeze, "test/dummy/app/models/cat.rb".freeze, "test/dummy/app/models/computer.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/cpu.rb".freeze, "test/dummy/app/models/dog.rb".freeze, "test/dummy/app/models/flower.rb".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/models/mainboard.rb".freeze, "test/dummy/app/models/nightingale.rb".freeze, "test/dummy/app/models/phoenix.rb".freeze, "test/dummy/app/models/user.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/hookup.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/generators/operation_generator_test.rb".freeze, "test/unit/rails_ops/hookup_test.rb".freeze, "test/unit/rails_ops/mixins/controller_test.rb".freeze, "test/unit/rails_ops/mixins/model/deep_nesting_test.rb".freeze, "test/unit/rails_ops/mixins/model/marshalling_test.rb".freeze, "test/unit/rails_ops/mixins/param_authorization_test.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/auth_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/destroy_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/sti_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation/update_lazy_auth_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze, "test/unit/rails_ops/profiler_test.rb".freeze]
   s.rubygems_version = "3.4.6".freeze
   s.summary = "An operations service layer for rails projects.".freeze
-  s.test_files = ["test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/animal.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/bird.rb".freeze, "test/dummy/app/models/cat.rb".freeze, "test/dummy/app/models/computer.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/cpu.rb".freeze, "test/dummy/app/models/dog.rb".freeze, "test/dummy/app/models/flower.rb".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/models/mainboard.rb".freeze, "test/dummy/app/models/nightingale.rb".freeze, "test/dummy/app/models/phoenix.rb".freeze, "test/dummy/app/models/user.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/generators/operation_generator_test.rb".freeze, "test/unit/rails_ops/mixins/model/deep_nesting_test.rb".freeze, "test/unit/rails_ops/mixins/param_authorization_test.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/sti_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation/update_auth_test.rb".freeze, "test/unit/rails_ops/operation/update_lazy_auth_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
+  s.test_files = ["test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/controllers/group_controller.rb".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/ability.rb".freeze, "test/dummy/app/models/animal.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/bird.rb".freeze, "test/dummy/app/models/cat.rb".freeze, "test/dummy/app/models/computer.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/cpu.rb".freeze, "test/dummy/app/models/dog.rb".freeze, "test/dummy/app/models/flower.rb".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/models/mainboard.rb".freeze, "test/dummy/app/models/nightingale.rb".freeze, "test/dummy/app/models/phoenix.rb".freeze, "test/dummy/app/models/user.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/hookup.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/generators/operation_generator_test.rb".freeze, "test/unit/rails_ops/hookup_test.rb".freeze, "test/unit/rails_ops/mixins/controller_test.rb".freeze, "test/unit/rails_ops/mixins/model/deep_nesting_test.rb".freeze, "test/unit/rails_ops/mixins/model/marshalling_test.rb".freeze, "test/unit/rails_ops/mixins/param_authorization_test.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/auth_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/destroy_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/sti_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation/update_lazy_auth_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze, "test/unit/rails_ops/profiler_test.rb".freeze]
 
   s.specification_version = 4
 
@@ -25,6 +25,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency(%q<colorize>.freeze, [">= 0"])
   s.add_development_dependency(%q<rubocop>.freeze, ["= 1.45.1"])
   s.add_development_dependency(%q<sprockets-rails>.freeze, [">= 0"])
+  s.add_development_dependency(%q<simplecov>.freeze, [">= 0"])
   s.add_runtime_dependency(%q<active_type>.freeze, [">= 1.3.0"])
   s.add_runtime_dependency(%q<minitest>.freeze, [">= 0"])
   s.add_runtime_dependency(%q<rails>.freeze, [">= 0"])

data/test/dummy/app/controllers/group_controller.rb

@@ -0,0 +1,28 @@
+class GroupController < ApplicationController
+  attr_reader :current_user
+  skip_before_action :verify_authenticity_token
+
+  def initialize
+    super
+    @current_user = Class.new
+  end
+
+  def show
+    cls = Class.new(RailsOps::Operation::Model::Load) do
+      model Group
+    end
+
+    op cls, id: params[:id]
+    render json: model
+  end
+
+  def update
+    cls = Class.new(RailsOps::Operation::Model::Update) do
+      model Group
+    end
+
+    op cls, id: params[:id], group: {name: params[:name]}
+    run!
+    render json: model
+  end
+end

data/test/dummy/app/models/ability.rb

@@ -0,0 +1,7 @@
+class Ability
+  include CanCan::Ability
+
+  def initialize(_user)
+    can :manage, :all
+  end
+end

data/test/dummy/app/models/animal.rb

@@ -1 +1,5 @@
-class Animal < ApplicationRecord; end
+class Animal < ApplicationRecord
+  has_many :dogs
+  belongs_to :bird, optional: true
+  belongs_to :phoenix, optional: true, validate: false, autosave: false
+end

data/test/dummy/app/models/bird.rb

@@ -1 +1,3 @@
-class Bird < Animal; end
+class Bird < Animal
+  has_one :phoenix, inverse_of: :bird
+end

data/test/dummy/app/models/phoenix.rb

@@ -1 +1,3 @@
-class Phoenix < Bird; end
+class Phoenix < Bird
+  belongs_to :bird, optional: true, autosave: false, inverse_of: :phoenix, validate: true
+end

data/test/dummy/config/environments/development.rb

@@ -51,4 +51,6 @@ Rails.application.configure do
   # Use an evented file watcher to asynchronously detect changes in source code,
   # routes, locales, etc. This feature depends on the listen gem.
   # config.file_watcher = ActiveSupport::EventedFileUpdateChecker
+
+  config.hosts = ['www.example.com']
 end

data/test/dummy/config/environments/production.rb

@@ -88,4 +88,6 @@ Rails.application.configure do
 
   # Do not dump schema after migrations.
   config.active_record.dump_schema_after_migration = false
+
+  config.hosts = ['www.example.com']
 end

data/test/dummy/config/hookup.rb

@@ -0,0 +1,5 @@
+RailsOps.hookup.draw do
+  run 'RailsOps::HookupTest::HookupTarget' do
+    on 'RailsOps::HookupTest::HookupStarter'
+  end
+end

data/test/dummy/config/routes.rb

@@ -1,3 +1,4 @@
 Rails.application.routes.draw do
   # For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
+  resources :group, only: [:show, :update]
 end

data/test/test_helper.rb

@@ -1,3 +1,8 @@
+require 'simplecov'
+SimpleCov.start do
+  add_filter '/test/'
+end
+
 require File.expand_path('../test/dummy/config/environment.rb', __dir__)
 # ActiveRecord::Migrator.migrations_paths = [File.expand_path("../../test/dummy/db/migrate", __FILE__)]
 require 'rails/test_help'

data/test/unit/rails_ops/hookup_test.rb

@@ -0,0 +1,82 @@
+require 'test_helper'
+
+class RailsOps::HookupTest < ActiveSupport::TestCase
+  include TestHelper
+
+  class RailsOps::HookupTest::HookupStarter < RailsOps::Operation::Model::Create
+    model ::Group
+  end
+
+  class RailsOps::HookupTest::HookupTarget < RailsOps::Operation
+    def perform
+      Group.find_by(name: 'hookup_test_group').update({ color: 'blue' })
+    end
+  end
+
+  def test_hooked_op
+    group = RailsOps::HookupTest::HookupStarter.run!(group: { name: 'hookup_test_group' }).model
+    group.reload
+    assert_equal 'blue', group.color
+  end
+
+  def test_recursive_hookup_raises
+    RailsOps.hookup.instance_variable_set(:@drawn, false)
+    RailsOps.hookup.instance_variable_set(:@config_loaded, false)
+    assert_raises SystemStackError do
+      RailsOps.hookup.draw do
+        run 'RailsOps::HookupTest::HookupTarget' do
+          on 'RailsOps::HookupTest::HookupStarter'
+        end
+
+        run 'RailsOps::HookupTest::HookupStarter' do
+          on 'RailsOps::HookupTest::HookupTarget'
+        end
+      end
+    end
+    RailsOps.hookup.load_config
+  end
+
+  def test_dont_draw_twice
+    assert_raises_with_message RuntimeError, "Hooks can't be drawn twice." do
+      RailsOps.hookup.draw do
+        run 'RailsOps::HookupTest::HookupTarget' do
+          on 'RailsOps::HookupTest::HookupStarter'
+        end
+      end
+    end
+  end
+
+  def test_missing_hookup_op
+    RailsOps.hookup.load_config
+    RailsOps.hookup.instance_variable_set(:@drawn, false)
+    RailsOps.hookup.draw do
+      run 'RailsOps::HookupTest::HookupIllusiveTarget' do
+        on 'RailsOps::HookupTest::HookupStarter'
+      end
+    end
+
+    assert_raises_with_message RuntimeError, 'Could not find hook target operation RailsOps::HookupTest::HookupIllusiveTarget.' do
+      RailsOps::HookupTest::HookupStarter.run!(group: { name: 'group' })
+    end
+
+    RailsOps.hookup.instance_variable_set(:@drawn, false)
+    RailsOps.hookup.instance_variable_set(:@config_loaded, false)
+    RailsOps.hookup.load_config
+  end
+
+  def test_missing_config_file
+    orig_path = RailsOps::Hookup::CONFIG_PATH
+    RailsOps::Hookup.const_set(:CONFIG_PATH, '/def/doesnt/exist')
+    RailsOps.hookup.instance_variable_set(:@drawn, false)
+    RailsOps.hookup.instance_variable_set(:@config_loaded, false)
+    assert_nothing_raised do
+      RailsOps.hookup.load_config
+    end
+    assert_equal({}, RailsOps.hookup.hooks)
+
+    RailsOps::Hookup.const_set(:CONFIG_PATH, orig_path)
+    RailsOps.hookup.instance_variable_set(:@drawn, false)
+    RailsOps.hookup.instance_variable_set(:@config_loaded, false)
+    RailsOps.hookup.load_config
+  end
+end

data/test/unit/rails_ops/mixins/controller_test.rb

@@ -0,0 +1,21 @@
+require 'test_helper'
+require 'cancancan'
+
+class RailsOps::Mixins::ControllerTest < ActionDispatch::IntegrationTest
+  include TestHelper
+
+  def test_controller_op
+    group = Group.create(name: 'group')
+    get group_url(group), as: :json
+    assert_equal 'group', JSON.parse(@response.body)['name']
+  end
+
+  def test_controller_op_run
+    group = Group.create(name: 'group')
+    patch group_url(group), params: { name: 'group2' }, as: :json
+    assert_equal 'group2', JSON.parse(@response.body)['name']
+
+    group.reload
+    assert_equal 'group2', group.name
+  end
+end

data/test/unit/rails_ops/mixins/model/deep_nesting_test.rb

@@ -92,6 +92,67 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
     assert_equal 'CPU', model.mainboard.cpu.name
   end
 
+  def test_without_asoc
+    assert_raises_with_message RuntimeError, 'Association cat could not be found for Animal.' do
+      Class.new(RailsOps::Operation::Model::Create) do
+        model Animal
+
+        nest_model_op :cat, Class.new(RailsOps::Operation::Model::Create) do
+          model Cat
+        end
+      end
+    end
+  end
+
+  def test_wrong_asoc_type
+    assert_raises_with_message RuntimeError,
+                               'Method nest_model_op only supports :belongs_to associations, but association dogs of model Animal is a has_many association.' do
+      Class.new(RailsOps::Operation::Model::Create) do
+        model Animal
+
+        nest_model_op :dogs, Class.new(RailsOps::Operation::Model::Create) do
+          model Dog
+        end
+      end
+    end
+  end
+
+  def test_autosave_on
+    assert_raises_with_message RuntimeError, 'Association bird of Animal has :autosave turned on. This is not supported by nest_model_op.' do
+      Class.new(RailsOps::Operation::Model::Create) do
+        model Animal
+
+        nest_model_op :bird, Class.new(RailsOps::Operation::Model::Create) do
+          model Bird
+        end
+      end
+    end
+  end
+
+  def test_validation_off
+    assert_raises_with_message RuntimeError, 'Association phoenix of Animal has :validate turned off. This is not supported by nest_model_op.' do
+      Class.new(RailsOps::Operation::Model::Create) do
+        model Animal
+
+        nest_model_op :phoenix, Class.new(RailsOps::Operation::Model::Create) do
+          model Phoenix
+        end
+      end
+    end
+  end
+
+  def test_inverse_autosave_on
+    assert_raises_with_message RuntimeError, 'Association phoenix of Bird has :autosave turned on. This is not supported by nest_model_op.' do
+      Class.new(RailsOps::Operation::Model::Create) do
+        model Phoenix
+
+        nest_model_op :bird, Class.new(RailsOps::Operation::Model::Create) do
+          model Bird
+        end
+      end
+    end
+  end
+
   def test_create_computer_level_1_validation_error
     op = COMPUTER_CREATION_OP.new(
       computer: {
@@ -197,7 +258,6 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
     )
 
     refute update_op.run
-    assert_equal :name, update_op.model.mainboard.errors.first.attribute
-    assert_equal :blank, update_op.model.mainboard.errors.first.type
+    assert update_op.model.mainboard.errors.added?(:name, :blank)
   end
 end

data/test/unit/rails_ops/mixins/model/marshalling_test.rb

@@ -0,0 +1,36 @@
+require 'test_helper'
+
+class RailsOps::Mixins::Model::MarshallingTest < ActiveSupport::TestCase
+  include TestHelper
+
+  class RailsOps::Mixins::Model::MarshallingTest::ParentOp < RailsOps::Operation::Model::Create
+    model Group
+    attr_reader :loaded_child_class
+    attr_reader :loaded_child_parent_op
+
+    def perform
+      sub_op = run_sub! RailsOps::Mixins::Model::MarshallingTest::ChildOp
+
+      dump_res = Marshal.dump(sub_op)
+      # rubocop:disable Security/MarshalLoad
+      load_res = Marshal.load(dump_res)
+      # rubocop:enable Security/MarshalLoad
+
+      @loaded_child_class = load_res.class
+      @loaded_child_parent_op = load_res.model.parent_op
+    end
+  end
+
+  class RailsOps::Mixins::Model::MarshallingTest::ChildOp < RailsOps::Operation::Model::Create
+    model Group
+    def perform; end
+  end
+
+  def test_marshal_dump_and_load
+    assert_nothing_raised do
+      op_res = RailsOps::Mixins::Model::MarshallingTest::ParentOp.run!
+      assert_equal RailsOps::Mixins::Model::MarshallingTest::ChildOp, op_res.loaded_child_class
+      assert_nil op_res.loaded_child_parent_op
+    end
+  end
+end

data/test/unit/rails_ops/operation/auth_test.rb

@@ -0,0 +1,120 @@
+require 'test_helper'
+require 'rails_ops/authorization_backend/can_can_can'
+require 'cancancan'
+
+class RailsOps::Operation::AuthTest < ActiveSupport::TestCase
+  include TestHelper
+
+  LOAD_OP = Class.new(RailsOps::Operation::Model::Load) do
+    model ::Group
+  end
+
+  LOAD_OP_WITHOUT_AUTH = Class.new(RailsOps::Operation::Model::Load) do
+    model ::Group
+    without_authorization
+  end
+
+  UPDATE_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model ::Group
+  end
+
+  CREATE_OP = Class.new(RailsOps::Operation::Model::Create) do
+    model ::Group
+  end
+
+  DESTROY_OP = Class.new(RailsOps::Operation::Model::Destroy) do
+    model ::Group
+  end
+
+  ABILITY = Class.new do
+    include CanCan::Ability
+
+    def initialize(read: false, update: false, create: false, destroy: false)
+      super()
+
+      can :read, Group if read
+      can :update, Group if update
+      can :create, Group if create
+      can :destroy, Group if destroy
+    end
+  end
+
+  setup do
+    Group.create!(id: 1, name: 'Group')
+    RailsOps.config.authorization_backend = 'RailsOps::AuthorizationBackend::CanCanCan'
+  end
+
+  def test_unpermitted_read
+    ctx = RailsOps::Context.new(ability: ABILITY.new)
+    assert_raises CanCan::AccessDenied do
+      LOAD_OP.new(ctx, id: 1)
+    end
+  end
+
+  def test_unpermitted_read_without_auth
+    ctx = RailsOps::Context.new(ability: ABILITY.new)
+    assert_nothing_raised do
+      LOAD_OP_WITHOUT_AUTH.new(ctx, id: 1)
+    end
+  end
+
+  def test_permitted_read
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
+    assert_nothing_raised do
+      res = LOAD_OP.new(ctx, id: 1)
+      assert_equal 'Group', res.model.name
+    end
+  end
+
+  def test_unpermitted_update
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
+    assert_raises CanCan::AccessDenied do
+      op = UPDATE_OP.new(ctx, id: 1, group: { name: 'Group2' })
+      res = op.run!
+      assert_equal 'Group', res.model.name
+    end
+  end
+
+  def test_permitted_update
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true, update: true))
+    assert_nothing_raised do
+      op = UPDATE_OP.new(ctx, id: 1, group: { name: 'Group2' })
+      res = op.run!
+      assert_equal 'Group2', res.model.name
+    end
+  end
+
+  def test_unpermitted_create
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
+    assert_raises CanCan::AccessDenied do
+      op = CREATE_OP.new(ctx, id: 2, group: { name: 'Group2' })
+      op.run!
+    end
+  end
+
+  def test_permitted_create
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true, create: true))
+    assert_nothing_raised do
+      op = CREATE_OP.new(ctx, id: 2, group: { name: 'Group2' })
+      op.run!
+      res = LOAD_OP.new(id: 2)
+      assert_equal 'Group2', res.model.name
+    end
+  end
+
+  def test_unpermitted_destroy
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
+    assert_raises CanCan::AccessDenied do
+      op = DESTROY_OP.new(ctx, id: 1)
+      op.run!
+    end
+  end
+
+  def test_permitted_destroy
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true, destroy: true))
+    assert_nothing_raised do
+      op = DESTROY_OP.new(ctx, id: 1)
+      op.run!
+    end
+  end
+end

data/test/unit/rails_ops/operation/model/destroy_test.rb

@@ -0,0 +1,31 @@
+class RailsOps::Operation::Model::DestroyTest < ActiveSupport::TestCase
+  include TestHelper
+
+  BASIC_OP = Class.new(RailsOps::Operation::Model::Destroy) do
+    model Group
+  end
+
+  def test_basic
+    g = Group.create
+    op = BASIC_OP.new(id: g.id)
+    assert_equal g, op.model
+    assert_equal Group, op.model.class
+    op.run!
+    assert op.model.destroyed?
+  end
+
+  def test_not_deletable
+    g = Group.create
+    cls = Class.new(RailsOps::Operation::Model::Destroy) do
+      model Group, 'NotDeletableGroup' do
+        def deleteable?
+          false
+        end
+      end
+    end
+    op = cls.new(id: g.id)
+    assert_raises RailsOps::Exceptions::ModelNotDeleteable do
+      op.run!
+    end
+  end
+end

data/test/unit/rails_ops/operation/model/load_test.rb

@@ -51,4 +51,13 @@ class RailsOps::Operation::Model::LoadTest < ActiveSupport::TestCase
     g = Group.create(name: 'g1')
     assert_equal g, cls.new(name: 'g1').model
   end
+
+  def test_too_many_authorization_actions
+    assert_raises_with_message ArgumentError, 'Too many arguments' do
+      Class.new(RailsOps::Operation::Model::Load) do
+        model Group
+        model_authorization_action :read, :update
+      end
+    end
+  end
 end

data/test/unit/rails_ops/operation/model_test.rb

@@ -47,6 +47,21 @@ class RailsOps::Operation::ModelTest < ActiveSupport::TestCase
     assert_equal 'Example', cls.model.virtual_model_name
   end
 
+  def test_virtual_model_write_attribute
+    cls = Class.new(RailsOps::Operation::Model) do
+      model RailsOps::VirtualModel, 'Example' do
+        attribute :name, default: 'name'
+      end
+    end
+
+    assert_equal 'name', cls.model.new.read_attribute(:name)
+    assert_nothing_raised do
+      obj = cls.model.new
+      obj.write_attribute(:name, 'name2')
+      assert_equal 'name2', obj.read_attribute(:name)
+    end
+  end
+
   def test_default_model_class
     cls = Class.new(RailsOps::Operation::Model) do
       model do
@@ -64,4 +79,13 @@ class RailsOps::Operation::ModelTest < ActiveSupport::TestCase
       end
     end
   end
+
+  def test_lazy_model
+    cls = Class.new(RailsOps::Operation::Model::Create) do
+      lazy_model 'Group'
+    end
+
+    assert_not cls.model.class < Group
+    assert cls.new.model.class < Group
+  end
 end

data/test/unit/rails_ops/operation_test.rb

@@ -40,6 +40,16 @@ class RailsOps::OperationTest < ActiveSupport::TestCase
     assert BASIC_OP.new.run!.done
   end
 
+  def test_run_without_perform
+    cls = Class.new(RailsOps::Operation)
+    assert_nothing_raised do
+      cls.new
+    end
+    assert_raises NotImplementedError do
+      cls.run!
+    end
+  end
+
   def test_non_validation_error
     assert_raises_with_message RuntimeError, 'Standard exception' do
       BASIC_OP.run(exception: 'Standard exception')
@@ -146,6 +156,17 @@ class RailsOps::OperationTest < ActiveSupport::TestCase
     assert op.performed?
   end
 
+  def test_check_performed
+    op = BASIC_OP.new
+    assert_raises_with_message RuntimeError, 'Operation has not yet been performed.' do
+      op.check_performed!
+    end
+    op.run!
+    assert_nothing_raised do
+      op.check_performed!
+    end
+  end
+
   def test_inspect
     assert_equal 'RailsOps::OperationTest::BASIC_OP ({"foo"=>:bar})',
                  BASIC_OP.new(foo: :bar).inspect
@@ -155,4 +176,104 @@ class RailsOps::OperationTest < ActiveSupport::TestCase
     assert_equal 'RailsOps::OperationTest::BASIC_OP ({1=>2})',
                  BASIC_OP.new(1 => 2).inspect
   end
+
+  def test_with_rollback_on_exception
+    op = Class.new(RailsOps::Operation) do
+      def perform
+        with_rollback_on_exception do
+          fail 'Rollback please'
+        end
+      end
+    end.new
+    assert_raises RailsOps::Exceptions::RollbackRequired do
+      op.run
+    end
+  end
+
+  def test_op_with_schema3(use_default: false)
+    op = Class.new(RailsOps::Operation) do
+      schema_block = proc do
+        int! :id
+        hsh! :hash do
+          int? :number
+          int! :required_number
+        end
+      end
+      if use_default
+        schema(&schema_block)
+      else
+        schema3(&schema_block)
+      end
+    end
+
+    assert_nothing_raised do
+      op.new(id: 1, hash: { required_number: 1 })
+    end
+    assert_raises Schemacop::Exceptions::ValidationError do
+      op.new(id: 1, hash: {})
+    end
+  end
+
+  def test_op_with_schema2(use_default: false)
+    op = Class.new(RailsOps::Operation) do
+      schema_block = proc do
+        req :id, :integer
+        req :hash, :hash do
+          opt :number, :integer
+          req :required_number, :integer
+        end
+      end
+
+      if use_default
+        schema(&schema_block)
+      else
+        schema2(&schema_block)
+      end
+    end
+
+    assert_nothing_raised do
+      op.new(id: 1, hash: { required_number: 1 })
+    end
+    assert_raises Schemacop::Exceptions::ValidationError do
+      op.new(id: 1, hash: {})
+    end
+  end
+
+  def test_op_with_schema_default
+    RailsOps.config.default_schemacop_version = 3
+    test_op_with_schema3(use_default: true)
+
+    RailsOps.config.default_schemacop_version = 2
+    test_op_with_schema2(use_default: true)
+
+    RailsOps.config.default_schemacop_version = -50
+    assert_raises_with_message RuntimeError, 'Schemacop schema versions supported are 2 and 3.' do
+      test_op_with_schema3(use_default: true)
+    end
+    RailsOps.config.default_schemacop_version = 3
+  end
+
+  def test_require_context
+    op = Class.new(RailsOps::Operation) do
+      require_context :user, :session
+    end
+
+    ctx = RailsOps::Context.new(user: Class.new, session: Class.new)
+    assert_raises_with_message RailsOps::Exceptions::MissingContextAttribute, 'This operation requires the context attribute :user to be present.' do
+      op.new
+    end
+    assert_nothing_raised do
+      op.new(ctx, foo: :bar)
+    end
+  end
+
+  def test_run_through_context
+    op = Class.new(RailsOps::Operation) do
+      def perform; end
+    end
+    ctx = RailsOps::Context.new(user: Class.new, session: Class.new)
+    assert_nothing_raised do
+      ctx.run! op, foo: :bar
+    end
+  end
 end

data/test/unit/rails_ops/profiler_test.rb

@@ -0,0 +1,11 @@
+class RailsOps::ProfilerTest < ActiveSupport::TestCase
+  include TestHelper
+
+  def test_time
+    assert_output(/Test - 1\d\.\dms elapsed./) do
+      RailsOps::Profiler.time 'Test' do
+        sleep 0.010
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_ops
 version: !ruby/object:Gem::Version
-  version: 1.4.3
+  version: 1.4.5
 platform: ruby
 authors:
 - Sitrox
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-03-27 00:00:00.000000000 Z
+date: 2023-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -136,6 +136,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: active_type
   requirement: !ruby/object:Gem::Requirement
@@ -301,9 +315,11 @@ files:
 - test/dummy/app/channels/application_cable/connection.rb
 - test/dummy/app/controllers/application_controller.rb
 - test/dummy/app/controllers/concerns/.keep
+- test/dummy/app/controllers/group_controller.rb
 - test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/jobs/application_job.rb
 - test/dummy/app/mailers/application_mailer.rb
+- test/dummy/app/models/ability.rb
 - test/dummy/app/models/animal.rb
 - test/dummy/app/models/application_record.rb
 - test/dummy/app/models/bird.rb
@@ -336,6 +352,7 @@ files:
 - test/dummy/config/environments/development.rb
 - test/dummy/config/environments/production.rb
 - test/dummy/config/environments/test.rb
+- test/dummy/config/hookup.rb
 - test/dummy/config/initializers/application_controller_renderer.rb
 - test/dummy/config/initializers/assets.rb
 - test/dummy/config/initializers/backtrace_silencers.rb
@@ -363,17 +380,22 @@ files:
 - test/dummy/tmp/.keep
 - test/test_helper.rb
 - test/unit/rails_ops/generators/operation_generator_test.rb
+- test/unit/rails_ops/hookup_test.rb
+- test/unit/rails_ops/mixins/controller_test.rb
 - test/unit/rails_ops/mixins/model/deep_nesting_test.rb
+- test/unit/rails_ops/mixins/model/marshalling_test.rb
 - test/unit/rails_ops/mixins/param_authorization_test.rb
 - test/unit/rails_ops/mixins/policies_test.rb
+- test/unit/rails_ops/operation/auth_test.rb
 - test/unit/rails_ops/operation/model/create_test.rb
+- test/unit/rails_ops/operation/model/destroy_test.rb
 - test/unit/rails_ops/operation/model/load_test.rb
 - test/unit/rails_ops/operation/model/sti_test.rb
 - test/unit/rails_ops/operation/model/update_test.rb
 - test/unit/rails_ops/operation/model_test.rb
-- test/unit/rails_ops/operation/update_auth_test.rb
 - test/unit/rails_ops/operation/update_lazy_auth_test.rb
 - test/unit/rails_ops/operation_test.rb
+- test/unit/rails_ops/profiler_test.rb
 homepage:
 licenses: []
 metadata: {}
@@ -392,7 +414,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.6
+rubygems_version: 3.4.10
 signing_key:
 specification_version: 4
 summary: An operations service layer for rails projects.
@@ -410,9 +432,11 @@ test_files:
 - test/dummy/app/channels/application_cable/connection.rb
 - test/dummy/app/controllers/application_controller.rb
 - test/dummy/app/controllers/concerns/.keep
+- test/dummy/app/controllers/group_controller.rb
 - test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/jobs/application_job.rb
 - test/dummy/app/mailers/application_mailer.rb
+- test/dummy/app/models/ability.rb
 - test/dummy/app/models/animal.rb
 - test/dummy/app/models/application_record.rb
 - test/dummy/app/models/bird.rb
@@ -445,6 +469,7 @@ test_files:
 - test/dummy/config/environments/development.rb
 - test/dummy/config/environments/production.rb
 - test/dummy/config/environments/test.rb
+- test/dummy/config/hookup.rb
 - test/dummy/config/initializers/application_controller_renderer.rb
 - test/dummy/config/initializers/assets.rb
 - test/dummy/config/initializers/backtrace_silencers.rb
@@ -472,14 +497,19 @@ test_files:
 - test/dummy/tmp/.keep
 - test/test_helper.rb
 - test/unit/rails_ops/generators/operation_generator_test.rb
+- test/unit/rails_ops/hookup_test.rb
+- test/unit/rails_ops/mixins/controller_test.rb
 - test/unit/rails_ops/mixins/model/deep_nesting_test.rb
+- test/unit/rails_ops/mixins/model/marshalling_test.rb
 - test/unit/rails_ops/mixins/param_authorization_test.rb
 - test/unit/rails_ops/mixins/policies_test.rb
+- test/unit/rails_ops/operation/auth_test.rb
 - test/unit/rails_ops/operation/model/create_test.rb
+- test/unit/rails_ops/operation/model/destroy_test.rb
 - test/unit/rails_ops/operation/model/load_test.rb
 - test/unit/rails_ops/operation/model/sti_test.rb
 - test/unit/rails_ops/operation/model/update_test.rb
 - test/unit/rails_ops/operation/model_test.rb
-- test/unit/rails_ops/operation/update_auth_test.rb
 - test/unit/rails_ops/operation/update_lazy_auth_test.rb
 - test/unit/rails_ops/operation_test.rb
+- test/unit/rails_ops/profiler_test.rb

data/test/unit/rails_ops/operation/update_auth_test.rb

@@ -1,64 +0,0 @@
-require 'test_helper'
-require 'rails_ops/authorization_backend/can_can_can'
-require 'cancancan'
-
-class RailsOps::Operation::UpdateLazyAuthTest < ActiveSupport::TestCase
-  include TestHelper
-
-  BASIC_OP = Class.new(RailsOps::Operation::Model::Update) do
-    model ::Group
-
-    model_authorization_action :update
-
-    def perform
-      fail osparams.exception if osparams.exception
-      @done = true
-    end
-  end
-
-  ABILITY = Class.new do
-    include CanCan::Ability
-
-    def initialize(read: false, update: false)
-      super()
-
-      can :read, Group if read
-      can :update, Group if update
-    end
-  end
-
-  setup do
-    Group.create!(id: 1, name: 'Group')
-    RailsOps.config.authorization_backend = 'RailsOps::AuthorizationBackend::CanCanCan'
-  end
-
-  def test_unpermitted_read
-    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
-    assert_raises CanCan::AccessDenied do
-      BASIC_OP.new(ctx, id: 1)
-    end
-  end
-
-  def test_permitted_read
-    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
-    assert_nothing_raised do
-      BASIC_OP.new(ctx, id: 1)
-    end
-  end
-
-  def test_unpermitted_update
-    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
-    op = BASIC_OP.new(ctx, id: 1)
-    assert_raises CanCan::AccessDenied do
-      op.run!
-    end
-  end
-
-  def test_permitted_update
-    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true, update: true))
-    op = BASIC_OP.new(ctx, id: 1)
-    assert_nothing_raised do
-      op.run!
-    end
-  end
-end