rails_ops 1.4.0 → 1.4.2

data/lib/rails_ops/profiler/node.rb

@@ -4,7 +4,7 @@ module RailsOps
       @object_id = object_id
       @description = description
       @parent = parent
-      parent.add_child(self) if parent
+      parent&.add_child(self)
       @children = []
       @erroneous = false
       @t_start = Time.now

data/lib/rails_ops/profiler.rb

@@ -5,7 +5,7 @@ module RailsOps
       self.tstore_current_parent = node
       begin
         res = yield
-      rescue
+      rescue StandardError
         node.erroneous!
         fail
       ensure

data/lib/rails_ops.rb

@@ -50,46 +50,46 @@ end
 # ---------------------------------------------------------------
 # Require RailsOps
 # ---------------------------------------------------------------
-require 'rails_ops/authorization_backend/abstract.rb'
-require 'rails_ops/configuration.rb'
-require 'rails_ops/context.rb'
-require 'rails_ops/controller_mixin.rb'
-require 'rails_ops/exceptions.rb'
-require 'rails_ops/hooked_job.rb' if defined?(ActiveJob)
-require 'rails_ops/hookup.rb'
-require 'rails_ops/hookup/dsl.rb'
-require 'rails_ops/hookup/dsl_validator.rb'
-require 'rails_ops/hookup/hook.rb'
-require 'rails_ops/log_subscriber.rb'
-require 'rails_ops/mixins.rb'
-require 'rails_ops/mixins/authorization.rb'
-require 'rails_ops/mixins/param_authorization.rb'
-require 'rails_ops/mixins/log_settings.rb'
-require 'rails_ops/mixins/model.rb'
-require 'rails_ops/mixins/model/authorization.rb'
-require 'rails_ops/mixins/model/nesting.rb'
-require 'rails_ops/mixins/policies.rb'
-require 'rails_ops/mixins/require_context.rb'
-require 'rails_ops/mixins/routes.rb'
-require 'rails_ops/mixins/schema_validation.rb'
-require 'rails_ops/mixins/sub_ops.rb'
-require 'rails_ops/model_mixins.rb'
-require 'rails_ops/model_mixins/ar_extension.rb'
-require 'rails_ops/model_mixins/parent_op.rb'
-require 'rails_ops/model_mixins/sti_fixes.rb'
-require 'rails_ops/model_mixins/marshalling.rb'
-require 'rails_ops/model_mixins/virtual_attributes.rb'
-require 'rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb'
-require 'rails_ops/model_mixins/virtual_has_one.rb'
-require 'rails_ops/model_mixins/virtual_model_name.rb'
-require 'rails_ops/operation.rb'
-require 'rails_ops/operation/model.rb'
-require 'rails_ops/operation/model/load.rb'
-require 'rails_ops/operation/model/create.rb'
-require 'rails_ops/operation/model/destroy.rb'
-require 'rails_ops/operation/model/update.rb'
-require 'rails_ops/profiler.rb'
-require 'rails_ops/profiler/node.rb'
-require 'rails_ops/railtie.rb' if defined?(Rails)
-require 'rails_ops/scoped_env.rb'
-require 'rails_ops/virtual_model.rb'
+require 'rails_ops/authorization_backend/abstract'
+require 'rails_ops/configuration'
+require 'rails_ops/context'
+require 'rails_ops/controller_mixin'
+require 'rails_ops/exceptions'
+require 'rails_ops/hooked_job' if defined?(ActiveJob)
+require 'rails_ops/hookup'
+require 'rails_ops/hookup/dsl'
+require 'rails_ops/hookup/dsl_validator'
+require 'rails_ops/hookup/hook'
+require 'rails_ops/log_subscriber'
+require 'rails_ops/mixins'
+require 'rails_ops/mixins/authorization'
+require 'rails_ops/mixins/param_authorization'
+require 'rails_ops/mixins/log_settings'
+require 'rails_ops/mixins/model'
+require 'rails_ops/mixins/model/authorization'
+require 'rails_ops/mixins/model/nesting'
+require 'rails_ops/mixins/policies'
+require 'rails_ops/mixins/require_context'
+require 'rails_ops/mixins/routes'
+require 'rails_ops/mixins/schema_validation'
+require 'rails_ops/mixins/sub_ops'
+require 'rails_ops/model_mixins'
+require 'rails_ops/model_mixins/ar_extension'
+require 'rails_ops/model_mixins/parent_op'
+require 'rails_ops/model_mixins/sti_fixes'
+require 'rails_ops/model_mixins/marshalling'
+require 'rails_ops/model_mixins/virtual_attributes'
+require 'rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper'
+require 'rails_ops/model_mixins/virtual_has_one'
+require 'rails_ops/model_mixins/virtual_model_name'
+require 'rails_ops/operation'
+require 'rails_ops/operation/model'
+require 'rails_ops/operation/model/load'
+require 'rails_ops/operation/model/create'
+require 'rails_ops/operation/model/destroy'
+require 'rails_ops/operation/model/update'
+require 'rails_ops/profiler'
+require 'rails_ops/profiler/node'
+require 'rails_ops/railtie' if defined?(Rails)
+require 'rails_ops/scoped_env'
+require 'rails_ops/virtual_model'

data/rails_ops.gemspec

@@ -1,52 +1,33 @@
 # -*- encoding: utf-8 -*-
-# stub: rails_ops 1.4.0 ruby lib
+# stub: rails_ops 1.4.2 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rails_ops".freeze
-  s.version = "1.4.0"
+  s.version = "1.4.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2023-02-21"
+  s.date = "2023-03-27"
   s.files = [".github/workflows/rubocop.yml".freeze, ".github/workflows/ruby.yml".freeze, ".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, "Appraisals".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.md".freeze, "Rakefile".freeze, "VERSION".freeze, "gemfiles/rails_6.0.gemfile".freeze, "gemfiles/rails_6.1.gemfile".freeze, "gemfiles/rails_7.0.gemfile".freeze, "lib/generators/operation/USAGE".freeze, "lib/generators/operation/operation_generator.rb".freeze, "lib/generators/operation/templates/controller.erb".freeze, "lib/generators/operation/templates/create.erb".freeze, "lib/generators/operation/templates/destroy.erb".freeze, "lib/generators/operation/templates/load.erb".freeze, "lib/generators/operation/templates/update.erb".freeze, "lib/generators/operation/templates/view.erb".freeze, "lib/rails_ops.rb".freeze, "lib/rails_ops/authorization_backend/abstract.rb".freeze, "lib/rails_ops/authorization_backend/can_can_can.rb".freeze, "lib/rails_ops/configuration.rb".freeze, "lib/rails_ops/context.rb".freeze, "lib/rails_ops/controller_mixin.rb".freeze, "lib/rails_ops/exceptions.rb".freeze, "lib/rails_ops/hooked_job.rb".freeze, "lib/rails_ops/hookup.rb".freeze, "lib/rails_ops/hookup/dsl.rb".freeze, "lib/rails_ops/hookup/dsl_validator.rb".freeze, "lib/rails_ops/hookup/hook.rb".freeze, "lib/rails_ops/log_subscriber.rb".freeze, "lib/rails_ops/mixins.rb".freeze, "lib/rails_ops/mixins/authorization.rb".freeze, "lib/rails_ops/mixins/log_settings.rb".freeze, "lib/rails_ops/mixins/model.rb".freeze, "lib/rails_ops/mixins/model/authorization.rb".freeze, "lib/rails_ops/mixins/model/nesting.rb".freeze, "lib/rails_ops/mixins/param_authorization.rb".freeze, "lib/rails_ops/mixins/policies.rb".freeze, "lib/rails_ops/mixins/require_context.rb".freeze, "lib/rails_ops/mixins/routes.rb".freeze, "lib/rails_ops/mixins/schema_validation.rb".freeze, "lib/rails_ops/mixins/sub_ops.rb".freeze, "lib/rails_ops/model_mixins.rb".freeze, "lib/rails_ops/model_mixins/ar_extension.rb".freeze, "lib/rails_ops/model_mixins/marshalling.rb".freeze, "lib/rails_ops/model_mixins/parent_op.rb".freeze, "lib/rails_ops/model_mixins/sti_fixes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb".freeze, "lib/rails_ops/model_mixins/virtual_has_one.rb".freeze, "lib/rails_ops/model_mixins/virtual_model_name.rb".freeze, "lib/rails_ops/operation.rb".freeze, "lib/rails_ops/operation/model.rb".freeze, "lib/rails_ops/operation/model/create.rb".freeze, "lib/rails_ops/operation/model/destroy.rb".freeze, "lib/rails_ops/operation/model/load.rb".freeze, "lib/rails_ops/operation/model/update.rb".freeze, "lib/rails_ops/profiler.rb".freeze, "lib/rails_ops/profiler/node.rb".freeze, "lib/rails_ops/railtie.rb".freeze, "lib/rails_ops/scoped_env.rb".freeze, "lib/rails_ops/virtual_model.rb".freeze, "rails_ops.gemspec".freeze, "test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/animal.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/bird.rb".freeze, "test/dummy/app/models/cat.rb".freeze, "test/dummy/app/models/computer.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/cpu.rb".freeze, "test/dummy/app/models/dog.rb".freeze, "test/dummy/app/models/flower.rb".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/models/mainboard.rb".freeze, "test/dummy/app/models/nightingale.rb".freeze, "test/dummy/app/models/phoenix.rb".freeze, "test/dummy/app/models/user.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/generators/operation_generator_test.rb".freeze, "test/unit/rails_ops/mixins/model/deep_nesting_test.rb".freeze, "test/unit/rails_ops/mixins/param_authorization_test.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/sti_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation/update_auth_test.rb".freeze, "test/unit/rails_ops/operation/update_lazy_auth_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
-  s.rubygems_version = "3.3.20".freeze
+  s.rubygems_version = "3.4.6".freeze
   s.summary = "An operations service layer for rails projects.".freeze
   s.test_files = ["test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/animal.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/bird.rb".freeze, "test/dummy/app/models/cat.rb".freeze, "test/dummy/app/models/computer.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/cpu.rb".freeze, "test/dummy/app/models/dog.rb".freeze, "test/dummy/app/models/flower.rb".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/models/mainboard.rb".freeze, "test/dummy/app/models/nightingale.rb".freeze, "test/dummy/app/models/phoenix.rb".freeze, "test/dummy/app/models/user.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/generators/operation_generator_test.rb".freeze, "test/unit/rails_ops/mixins/model/deep_nesting_test.rb".freeze, "test/unit/rails_ops/mixins/param_authorization_test.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/sti_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation/update_auth_test.rb".freeze, "test/unit/rails_ops/operation/update_lazy_auth_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
 
-  if s.respond_to? :specification_version then
-    s.specification_version = 4
-  end
+  s.specification_version = 4
 
-  if s.respond_to? :add_runtime_dependency then
-    s.add_development_dependency(%q<appraisal>.freeze, [">= 0"])
-    s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
-    s.add_development_dependency(%q<rake>.freeze, [">= 0"])
-    s.add_development_dependency(%q<sqlite3>.freeze, [">= 0"])
-    s.add_development_dependency(%q<cancancan>.freeze, [">= 0"])
-    s.add_development_dependency(%q<pry>.freeze, [">= 0"])
-    s.add_development_dependency(%q<colorize>.freeze, [">= 0"])
-    s.add_development_dependency(%q<rubocop>.freeze, ["= 0.47.1"])
-    s.add_development_dependency(%q<sprockets-rails>.freeze, [">= 0"])
-    s.add_runtime_dependency(%q<active_type>.freeze, [">= 1.3.0"])
-    s.add_runtime_dependency(%q<minitest>.freeze, [">= 0"])
-    s.add_runtime_dependency(%q<rails>.freeze, [">= 0"])
-    s.add_runtime_dependency(%q<request_store>.freeze, [">= 0"])
-    s.add_runtime_dependency(%q<schemacop>.freeze, [">= 2.4.2", "<= 3.1"])
-  else
-    s.add_dependency(%q<appraisal>.freeze, [">= 0"])
-    s.add_dependency(%q<bundler>.freeze, [">= 0"])
-    s.add_dependency(%q<rake>.freeze, [">= 0"])
-    s.add_dependency(%q<sqlite3>.freeze, [">= 0"])
-    s.add_dependency(%q<cancancan>.freeze, [">= 0"])
-    s.add_dependency(%q<pry>.freeze, [">= 0"])
-    s.add_dependency(%q<colorize>.freeze, [">= 0"])
-    s.add_dependency(%q<rubocop>.freeze, ["= 0.47.1"])
-    s.add_dependency(%q<sprockets-rails>.freeze, [">= 0"])
-    s.add_dependency(%q<active_type>.freeze, [">= 1.3.0"])
-    s.add_dependency(%q<minitest>.freeze, [">= 0"])
-    s.add_dependency(%q<rails>.freeze, [">= 0"])
-    s.add_dependency(%q<request_store>.freeze, [">= 0"])
-    s.add_dependency(%q<schemacop>.freeze, [">= 2.4.2", "<= 3.1"])
-  end
+  s.add_development_dependency(%q<appraisal>.freeze, [">= 0"])
+  s.add_development_dependency(%q<bundler>.freeze, [">= 0"])
+  s.add_development_dependency(%q<rake>.freeze, [">= 0"])
+  s.add_development_dependency(%q<sqlite3>.freeze, [">= 0"])
+  s.add_development_dependency(%q<cancancan>.freeze, [">= 0"])
+  s.add_development_dependency(%q<pry>.freeze, [">= 0"])
+  s.add_development_dependency(%q<colorize>.freeze, [">= 0"])
+  s.add_development_dependency(%q<rubocop>.freeze, ["= 1.45.1"])
+  s.add_development_dependency(%q<sprockets-rails>.freeze, [">= 0"])
+  s.add_runtime_dependency(%q<active_type>.freeze, [">= 1.3.0"])
+  s.add_runtime_dependency(%q<minitest>.freeze, [">= 0"])
+  s.add_runtime_dependency(%q<rails>.freeze, [">= 0"])
+  s.add_runtime_dependency(%q<request_store>.freeze, [">= 0"])
+  s.add_runtime_dependency(%q<schemacop>.freeze, [">= 2.4.2", "<= 3.1"])
 end

data/test/dummy/bin/bundle

@@ -1,3 +1,3 @@
 #!/usr/bin/env ruby
-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
 load Gem.bin_path('bundler', 'bundle')

data/test/dummy/bin/setup

@@ -4,7 +4,7 @@ require 'fileutils'
 include FileUtils
 
 # path to your application root.
-APP_ROOT = Pathname.new File.expand_path('../../', __FILE__)
+APP_ROOT = Pathname.new File.expand_path('..', __dir__)
 
 def system!(*args)
   system(*args) || abort("\n== Command #{args} failed ==")

data/test/dummy/bin/update

@@ -4,7 +4,7 @@ require 'fileutils'
 include FileUtils
 
 # path to your application root.
-APP_ROOT = Pathname.new File.expand_path('../../', __FILE__)
+APP_ROOT = Pathname.new File.expand_path('..', __dir__)
 
 def system!(*args)
   system(*args) || abort("\n== Command #{args} failed ==")

data/test/dummy/bin/yarn

@@ -1,11 +1,9 @@
 #!/usr/bin/env ruby
 VENDOR_PATH = File.expand_path('..', __dir__)
 Dir.chdir(VENDOR_PATH) do
-  begin
-    exec "yarnpkg #{ARGV.join(' ')}"
-  rescue Errno::ENOENT
-    $stderr.puts 'Yarn executable was not detected in the system.'
-    $stderr.puts 'Download Yarn at https://yarnpkg.com/en/docs/install'
-    exit 1
-  end
+  exec "yarnpkg #{ARGV.join(' ')}"
+rescue Errno::ENOENT
+  warn 'Yarn executable was not detected in the system.'
+  warn 'Download Yarn at https://yarnpkg.com/en/docs/install'
+  exit 1
 end

data/test/dummy/config/environments/production.rb

@@ -74,7 +74,7 @@ Rails.application.configure do
   config.active_support.deprecation = :notify
 
   # Use default logging formatter so that PID and timestamp are not suppressed.
-  config.log_formatter = ::Logger::Formatter.new
+  config.log_formatter = Logger::Formatter.new
 
   # Use a different logger for distributed setups.
   # require 'syslog/logger'

data/test/dummy/config/spring.rb

@@ -1,6 +1,6 @@
-%w(
+%w[
   .ruby-version
   .rbenv-vars
   tmp/restart.txt
   tmp/caching-dev.txt
-).each { |path| Spring.watch(path) }
+].each { |path| Spring.watch(path) }

data/test/test_helper.rb

@@ -1,4 +1,4 @@
-require File.expand_path('../../test/dummy/config/environment.rb', __FILE__)
+require File.expand_path('../test/dummy/config/environment.rb', __dir__)
 # ActiveRecord::Migrator.migrations_paths = [File.expand_path("../../test/dummy/db/migrate", __FILE__)]
 require 'rails/test_help'
 require 'pry'
@@ -14,13 +14,13 @@ Rails::TestUnitReporter.executable = 'bin/test'
 
 # Load fixtures from the engine
 if ActiveSupport::TestCase.respond_to?(:fixture_path=)
-  ActiveSupport::TestCase.fixture_path = File.expand_path('../fixtures', __FILE__)
+  ActiveSupport::TestCase.fixture_path = File.expand_path('fixtures', __dir__)
   ActionDispatch::IntegrationTest.fixture_path = ActiveSupport::TestCase.fixture_path
-  ActiveSupport::TestCase.file_fixture_path = ActiveSupport::TestCase.fixture_path + '/files'
+  ActiveSupport::TestCase.file_fixture_path = File.join(ActiveSupport::TestCase.fixture_path, '/files')
   ActiveSupport::TestCase.fixtures :all
 end
 
-load File.dirname(__FILE__) + '/dummy/db/schema.rb'
+load File.join(File.dirname(__FILE__), '/dummy/db/schema.rb')
 
 require 'request_store'
 
@@ -39,7 +39,7 @@ module TestHelper
       fail TypeError, "Expected #{expected.inspect} to be a kind of String or Regexp, not #{expected.class}"
     end
 
-    ex = assert_raises(exception, *msg) { yield }
+    ex = assert_raises(exception, *msg, &block)
     msg = message(msg, '') { "Expected Exception(#{exception}) was raised, but the message doesn't match" }
 
     if assert == :assert_equal

data/test/unit/rails_ops/generators/operation_generator_test.rb

@@ -10,12 +10,10 @@ class OperationGeneratorTest < Rails::Generators::TestCase
 
     # Add an empty routes file
     Dir.mkdir(File.join(destination_root, 'config'))
-    File.open(File.join(destination_root, 'config', 'routes.rb'), 'w') do |f|
-      f.write <<~ROUTES
-        Rails.application.routes.draw do
-        end
-      ROUTES
-    end
+    File.write(File.join(destination_root, 'config', 'routes.rb'), <<~ROUTES)
+      Rails.application.routes.draw do
+      end
+    ROUTES
   end
 
   def test_all
@@ -42,7 +40,7 @@ class OperationGeneratorTest < Rails::Generators::TestCase
     assert_routes
 
     # Check that the views were skipped
-    %w(index show new edit).each do |view|
+    %w[index show new edit].each do |view|
       assert_no_file "app/views/users/#{view}.html.haml"
     end
   end
@@ -85,7 +83,7 @@ class OperationGeneratorTest < Rails::Generators::TestCase
     end
 
     # Check that the views were skipped
-    %w(index show new edit).each do |view|
+    %w[index show new edit].each do |view|
       assert_no_file "app/views/users/#{view}.html.haml"
     end
   end
@@ -104,7 +102,7 @@ class OperationGeneratorTest < Rails::Generators::TestCase
     end
 
     # Check that the views were skipped
-    %w(index show new edit).each do |view|
+    %w[index show new edit].each do |view|
       assert_no_file "app/views/users/#{view}.html.haml"
     end
   end
@@ -154,7 +152,7 @@ class OperationGeneratorTest < Rails::Generators::TestCase
       end
 
       # Check that views are generated
-      %w(index show new edit).each do |view|
+      %w[index show new edit].each do |view|
         assert_file "app/views/admin/users/#{view}.html.haml"
       end
 
@@ -195,7 +193,7 @@ class OperationGeneratorTest < Rails::Generators::TestCase
     end
 
     # Check that views are generated
-    %w(index show new edit).each do |view|
+    %w[index show new edit].each do |view|
       assert_file "app/views/admin/foo/users/#{view}.html.haml"
     end
 
@@ -235,7 +233,7 @@ class OperationGeneratorTest < Rails::Generators::TestCase
   end
 
   def assert_views
-    %w(index show new edit).each do |view|
+    %w[index show new edit].each do |view|
       assert_file "app/views/users/#{view}.html.haml"
     end
   end

data/test/unit/rails_ops/mixins/model/deep_nesting_test.rb

@@ -25,6 +25,28 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
     nest_model_op :mainboard, MAINBOARD_CREATION_OP
   end
 
+  CPU_UPDATE_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model Cpu do
+      validates :name, presence: true
+    end
+  end
+
+  MAINBOARD_UPDATE_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model Mainboard do
+      validates :name, presence: true
+    end
+
+    nest_model_op :cpu, CPU_UPDATE_OP
+  end
+
+  COMPUTER_UPDATE_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model Computer do
+      validates :name, presence: true
+    end
+
+    nest_model_op :mainboard, MAINBOARD_UPDATE_OP
+  end
+
   def test_create_cpu
     assert_nothing_raised do
       CPU_CREATION_OP.run!(cpu: { name: 'CPU' })
@@ -35,7 +57,7 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
     assert_nothing_raised do
       MAINBOARD_CREATION_OP.run!(
         mainboard: {
-          name: 'Mainboard',
+          name:           'Mainboard',
           cpu_attributes: {
             name: 'CPU'
           }
@@ -48,10 +70,10 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
     model = assert_nothing_raised do
       COMPUTER_CREATION_OP.run!(
         computer: {
-          name: 'Computer',
+          name:                 'Computer',
 
           mainboard_attributes: {
-            name: 'Mainboard',
+            name:           'Mainboard',
 
             cpu_attributes: {
               name: 'CPU'
@@ -74,7 +96,7 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
     op = COMPUTER_CREATION_OP.new(
       computer: {
         mainboard_attributes: {
-          name: 'Mainboard',
+          name:           'Mainboard',
 
           cpu_attributes: {
             name: 'CPU'
@@ -94,7 +116,7 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
   def test_create_computer_level_2_validation_error
     op = COMPUTER_CREATION_OP.new(
       computer: {
-        name: 'Computer',
+        name:                 'Computer',
 
         mainboard_attributes: {
           cpu_attributes: {
@@ -108,7 +130,7 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
       op.run!
     end
 
-    assert_equal ["Mainboard is invalid"], op.model.errors.full_messages
+    assert_equal ['Mainboard is invalid'], op.model.errors.full_messages
     refute op.model.persisted?
 
     assert_equal ["Name can't be blank"], op.model.mainboard.errors.full_messages
@@ -118,10 +140,10 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
   def test_create_computer_level_3_validation_error
     op = COMPUTER_CREATION_OP.new(
       computer: {
-        name: 'Computer',
+        name:                 'Computer',
 
         mainboard_attributes: {
-          name: 'Mainboard',
+          name:           'Mainboard',
 
           cpu_attributes: {}
         }
@@ -132,13 +154,50 @@ class RailsOps::Mixins::Model::DeepNestingTest < ActiveSupport::TestCase
       op.run!
     end
 
-    assert_equal ["Mainboard is invalid"], op.model.errors.full_messages
+    assert_equal ['Mainboard is invalid'], op.model.errors.full_messages
     refute op.model.persisted?
 
-    assert_equal ["Cpu is invalid"], op.model.mainboard.errors.full_messages
+    assert_equal ['Cpu is invalid'], op.model.mainboard.errors.full_messages
     refute op.model.mainboard.persisted?
 
     assert_equal ["Name can't be blank"], op.model.mainboard.cpu.errors.full_messages
     refute op.model.mainboard.cpu.persisted?
   end
+
+  def test_update_validation_error
+    create_op = COMPUTER_CREATION_OP.new(
+      computer: {
+        name:                 'Computer',
+
+        mainboard_attributes: {
+          name:           'Mainboard',
+
+          cpu_attributes: {
+            name: 'CPU'
+          }
+        }
+      }
+    )
+
+    create_op.run!
+
+    update_op = COMPUTER_UPDATE_OP.new(
+      id:       Computer.first,
+      computer: {
+        name:                 'Computer',
+
+        mainboard_attributes: {
+          name:           '',
+
+          cpu_attributes: {
+            name: 'CPU'
+          }
+        }
+      }
+    )
+
+    refute update_op.run
+    assert_equal :name, update_op.model.mainboard.errors.first.attribute
+    assert_equal :blank, update_op.model.mainboard.errors.first.type
+  end
 end

data/test/unit/rails_ops/mixins/param_authorization_test.rb

@@ -32,9 +32,9 @@ class RailsOps::Mixins::ParamAuthorizationTest < ActiveSupport::TestCase
 
       model ::Group
 
-      authorize_param %i(foo), :foo, :subject_1
-      authorize_param %i(bar), :bar, :subject_1
-      authorize_param %i(bar baz), :baz, :subject_1
+      authorize_param %i[foo], :foo, :subject_1
+      authorize_param %i[bar], :bar, :subject_1
+      authorize_param %i[bar baz], :baz, :subject_1
 
       def perform
         # Do nothing

data/test/unit/rails_ops/mixins/policies_test.rb

@@ -29,7 +29,7 @@ class RailsOps::Mixins::PoliciesTest < ActiveSupport::TestCase
       end
     end
 
-    assert_equal %i(on_init default before_perform perform after_perform),
+    assert_equal %i[on_init default before_perform perform after_perform],
                  op.run!.sequence
   end
 
@@ -52,7 +52,7 @@ class RailsOps::Mixins::PoliciesTest < ActiveSupport::TestCase
       def perform; end
     end
 
-    assert_equal %i(before_perform_1 before_perform_2),
+    assert_equal %i[before_perform_1 before_perform_2],
                  op.run!.sequence
   end
 end

data/test/unit/rails_ops/operation/update_auth_test.rb

@@ -20,6 +20,8 @@ class RailsOps::Operation::UpdateLazyAuthTest < ActiveSupport::TestCase
     include CanCan::Ability
 
     def initialize(read: false, update: false)
+      super()
+
       can :read, Group if read
       can :update, Group if update
     end

data/test/unit/rails_ops/operation/update_lazy_auth_test.rb

@@ -20,6 +20,7 @@ class RailsOps::Operation::UpdateLazyAuthTest < ActiveSupport::TestCase
     include CanCan::Ability
 
     def initialize(read: false, update: false)
+      super()
       can :read, Group if read
       can :update, Group if update
     end

data/test/unit/rails_ops/operation_test.rb

@@ -99,7 +99,7 @@ class RailsOps::OperationTest < ActiveSupport::TestCase
   end
 
   def test_params
-    params = { a: 1, 'b': 1 }
+    params = { a: 1, b: 1 }
     op = BASIC_OP.new(params)
 
     # ---------------------------------------------------------------