rails_ops 1.1.7 → 1.1.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ada3a14729ab1131e595059d24a07a71d8a2fe93f1d4fa8c6fa30dbde1fe5837
-  data.tar.gz: f6b593632cc22387c02a9225c8c7545e69856f8c069f00e24d4d1701cf76df4d
+  metadata.gz: d17945478f8bed7549184c7a1cb5e621975c4aa7d72a90798344e383daf2916d
+  data.tar.gz: c7e2976dff38044a9881028aa71ec8346e0cf8fae9c29eb548b713eed10489dd
 SHA512:
-  metadata.gz: f6b7d06748e7c0794c323e47dacbe773cfdb74b6dfb84e9a51726b2362f35d1b514aac919bb411850ee4a4be84ad0c5b12cd327328dcb5d2e23858fcb7af3084
-  data.tar.gz: 63d0e95b712422e287a798c1de9803e2562cc22a4cd1650ff76b9b7be29bbecd029b4c733ca22ecff04cd40cc1dd93d8529e75a77354375bf25d8271d9514187
+  metadata.gz: f092efb563b201ff660fa3ad0993d7641284198fb0c54711d25ab5bc33900bb699472fc368f90c2286b2c01f33dcb7bce8bdc39bd601a5de272b7e891ba8faf0
+  data.tar.gz: c85ad5459c2233d4c6641747329114e78a2918117498adaf0d2061933a466c989f51a2e87aeaf58046cacd747bc5613ea8087b270935017c958420b586dc4fdc

data/CHANGELOG.md

@@ -1,6 +1,33 @@
 # Changelog
 
-## 1.1.6 (2020-06-18)
+## 1.1.12 (2020-11-24)
+
+* Add support for upcoming Schemacop 3. It is still backwards compatible and
+  the schemacop schema version still defaults to 2.
+
+  Note that support for the new Schemacop 3 features is not yet documented.
+
+## 1.1.11 (2020-10-29)
+
+* Add method `lazy_model` to `RailsOps::Operation::Model`
+
+## 1.1.10 (2020-08-29)
+
+* Fix parameter inspection bug introduced in 1.1.9.
+
+## 1.1.9 (2020-08-28)
+
+* Gracefully filter params when inspecting an operation. If the params included
+  numeric keys in `rails < 6`, this lead to an error. This error is now handeled
+  gracefully and params are not inspected.
+
+* Do not call `inspect` every time an op is run
+
+## 1.1.8 (2020-07-08)
+
+* Fix bug where only the first hooked operation was called
+
+## 1.1.7 (2020-06-18)
 
 * Add controller / helper method `model?`
 

data/README.md

@@ -580,16 +580,16 @@ source operations.
 
 ```ruby
 RailsOps.hookup.draw do
-  run Operations::Notifications::User::SendWelcomeEmail do
-    on Operations::User::Create
+  run 'Operations::Notifications::User::SendWelcomeEmail' do
+    on 'Operations::User::Create'
   end
 
-  run Operations::Todos::GenerateUserApprovalTodo do
-    on Operations::User::Create
+  run 'Operations::Todos::GenerateUserApprovalTodo' do
+    on 'Operations::User::Create'
   end
 
-  run Operations::Notification::SendTodoNotification do
-    on Operations::Todos::GenerateUserApprovalTodo
+  run 'Operations::Notification::SendTodoNotification' do
+    on 'Operations::Todos::GenerateUserApprovalTodo'
   end
 end
 ```

data/VERSION

@@ -1 +1 @@
-1.1.7
+1.1.12

data/lib/rails_ops/configuration.rb

@@ -3,4 +3,5 @@ class RailsOps::Configuration < ActiveType::Object
   attribute :authorization_backend, :string, default: nil
   attribute :trigger_hookups_without_authorization, :boolean, default: false
   attribute :ensure_authorize_called, :boolean, default: true
+  attribute :default_schemacop_version, :integer, default: 2
 end

data/lib/rails_ops/hookup.rb

@@ -84,7 +84,7 @@ class RailsOps::Hookup
       op = op_class.new(context, params)
 
       begin
-        return op.run!
+        op.run!
       rescue *op.validation_errors => e
         fail RailsOps::Exceptions::HookupOpValidationFailed, e
       end

data/lib/rails_ops/mixins/schema_validation.rb

@@ -21,8 +21,28 @@ module RailsOps::Mixins::SchemaValidation
     #
     # @param *args [Array] Parameters to pass at schema initialization
     # @yield Block to pass at schema initialization
-    def schema(*args, &block)
-      self._op_schema = Schemacop::Schema.new(*args, &block)
+    def schema(reference = nil, version: nil, **options, &block)
+      if reference
+        if version && version != 3
+          fail 'References are only supported with schemacop schema version 3.'
+        end
+
+        self._op_schema = Schemacop::Node.create(:reference, path: reference)
+      else
+        version ||= RailsOps.config.default_schemacop_version
+
+        if version == 3
+          self._op_schema = Schemacop::Node.create(:object, options, &block)
+        elsif version == 2
+          if defined?(Schemacop::V2)
+            self._op_schema = Schemacop::V2::Schema.new(:hash, options, &block)
+          else
+            self._op_schema = Schemacop::Schema.new(:hash, options, &block)
+          end
+        elsif
+          fail "Unsupported schemacop schema version #{version}. Schemacop supports 2 and 3."
+        end
+      end
     end
   end
 end

data/lib/rails_ops/operation.rb

@@ -107,7 +107,7 @@ class RailsOps::Operation
   # any validation exception.
   def run!
     ActiveSupport::Notifications.instrument('run.rails_ops', operation: self) do
-      ::RailsOps::Profiler.profile(object_id, inspect) do
+      ::RailsOps::Profiler.profile(object_id) do
         fail 'An operation can only be performed once.' if performed?
         @performed = true
         run_policies :before_perform
@@ -125,7 +125,12 @@ class RailsOps::Operation
   def inspect
     inspection = self.class.name || '(AnonymousOp)'
     if params
-      inspection += " (#{inspect_params(filtered_params)})"
+      begin
+        inspected_params = inspect_params(filtered_params)
+      rescue
+        inspected_params = '<could not inspect params>'
+      end
+      inspection += " (#{inspected_params})"
     end
     return inspection
   end

data/lib/rails_ops/operation/model.rb

@@ -3,6 +3,18 @@ class RailsOps::Operation::Model < RailsOps::Operation
   include RailsOps::Mixins::Model::Nesting
 
   class_attribute :_model_class
+  class_attribute :_lazy_model
+
+  # Works like `model` method (see its documentation), but takes a string as
+  # model class and constructs the effective model class lazily on first
+  # invocation of the `model` method (without params).
+  def self.lazy_model(model_class_name = nil, name = nil, &block)
+    self._lazy_model = {
+      model_class_name: model_class_name,
+      name:             name,
+      block:            block
+    }
+  end
 
   # Allows to set or get a model class associated with this operation.
   #
@@ -63,6 +75,8 @@ class RailsOps::Operation::Model < RailsOps::Operation
       else
         self._model_class = model_class
       end
+    elsif _lazy_model && _model_class.nil?
+      return model(_lazy_model[:model_class_name].safe_constantize, _lazy_model[:name], &_lazy_model[:block])
     elsif _model_class.nil?
       fail 'No model class has been set.'
     end

data/rails_ops.gemspec

@@ -1,16 +1,16 @@
 # -*- encoding: utf-8 -*-
-# stub: rails_ops 1.1.7 ruby lib
+# stub: rails_ops 1.1.12 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rails_ops".freeze
-  s.version = "1.1.7"
+  s.version = "1.1.12"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2020-06-18"
+  s.date = "2020-11-24"
   s.files = [".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, ".travis.yml".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE.txt".freeze, "README.md".freeze, "Rakefile".freeze, "VERSION".freeze, "lib/rails_ops.rb".freeze, "lib/rails_ops/authorization_backend/abstract.rb".freeze, "lib/rails_ops/authorization_backend/can_can_can.rb".freeze, "lib/rails_ops/configuration.rb".freeze, "lib/rails_ops/context.rb".freeze, "lib/rails_ops/controller_mixin.rb".freeze, "lib/rails_ops/exceptions.rb".freeze, "lib/rails_ops/hooked_job.rb".freeze, "lib/rails_ops/hookup.rb".freeze, "lib/rails_ops/hookup/dsl.rb".freeze, "lib/rails_ops/hookup/dsl_validator.rb".freeze, "lib/rails_ops/hookup/hook.rb".freeze, "lib/rails_ops/log_subscriber.rb".freeze, "lib/rails_ops/mixins.rb".freeze, "lib/rails_ops/mixins/authorization.rb".freeze, "lib/rails_ops/mixins/log_settings.rb".freeze, "lib/rails_ops/mixins/model.rb".freeze, "lib/rails_ops/mixins/model/authorization.rb".freeze, "lib/rails_ops/mixins/model/nesting.rb".freeze, "lib/rails_ops/mixins/param_authorization.rb".freeze, "lib/rails_ops/mixins/policies.rb".freeze, "lib/rails_ops/mixins/require_context.rb".freeze, "lib/rails_ops/mixins/routes.rb".freeze, "lib/rails_ops/mixins/schema_validation.rb".freeze, "lib/rails_ops/mixins/sub_ops.rb".freeze, "lib/rails_ops/model_casting.rb".freeze, "lib/rails_ops/model_mixins.rb".freeze, "lib/rails_ops/model_mixins/ar_extension.rb".freeze, "lib/rails_ops/model_mixins/parent_op.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb".freeze, "lib/rails_ops/model_mixins/virtual_has_one.rb".freeze, "lib/rails_ops/model_mixins/virtual_model_name.rb".freeze, "lib/rails_ops/operation.rb".freeze, "lib/rails_ops/operation/model.rb".freeze, "lib/rails_ops/operation/model/create.rb".freeze, "lib/rails_ops/operation/model/destroy.rb".freeze, "lib/rails_ops/operation/model/load.rb".freeze, "lib/rails_ops/operation/model/update.rb".freeze, "lib/rails_ops/patches/active_type_patch.rb".freeze, "lib/rails_ops/profiler.rb".freeze, "lib/rails_ops/profiler/node.rb".freeze, "lib/rails_ops/railtie.rb".freeze, "lib/rails_ops/scoped_env.rb".freeze, "lib/rails_ops/virtual_model.rb".freeze, "rails_ops.gemspec".freeze, "test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/mixins/model/nesting.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
-  s.rubygems_version = "3.1.2".freeze
+  s.rubygems_version = "3.1.4".freeze
   s.summary = "An operations service layer for rails projects.".freeze
   s.test_files = ["test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/mixins/model/nesting.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
 

data/test/unit/rails_ops/operation_test.rb

@@ -150,4 +150,9 @@ class RailsOps::OperationTest < ActiveSupport::TestCase
     assert_equal 'RailsOps::OperationTest::BASIC_OP ({"foo"=>:bar})',
                  BASIC_OP.new(foo: :bar).inspect
   end
+
+  def test_inspect_with_numeric_param_keys
+    assert_equal 'RailsOps::OperationTest::BASIC_OP ({1=>2})',
+                 BASIC_OP.new(1 => 2).inspect
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_ops
 version: !ruby/object:Gem::Version
-  version: 1.1.7
+  version: 1.1.12
 platform: ruby
 authors:
 - Sitrox
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-06-18 00:00:00.000000000 Z
+date: 2020-11-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -136,8 +136,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 2.4.2
-description: 
-email: 
+description:
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -268,10 +268,10 @@ files:
 - test/unit/rails_ops/operation/model/update_test.rb
 - test/unit/rails_ops/operation/model_test.rb
 - test/unit/rails_ops/operation_test.rb
-homepage: 
+homepage:
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -286,8 +286,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.1.4
+signing_key:
 specification_version: 4
 summary: An operations service layer for rails projects.
 test_files: