rails_ops 1.1.5 → 1.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d993250900a31344cb3663673fe87bf79381d487f24b1106c8e8129aa3a67898
-  data.tar.gz: 3eb133d66cdd3d851b2bb9cbd7b673017328b09d10800aeec3acd4c5b897a610
+  metadata.gz: d153a870aafb98f323f6fb99ff5be9363a3310cc6eb97a0ee9bcf85d23367e8b
+  data.tar.gz: 99ae30bd07dfe22a72b2c3922e1ae7bb58f5f181f508bb72a671b705567f3fee
 SHA512:
-  metadata.gz: dd8acbb3e987ff0804c249b9996e1af5d55415fecdbb9d4290d011182a0b3ece43dfa331d941147b72d6131b33e83e0ad3044963d242d894284ac3fd07b77a08
-  data.tar.gz: 2ae9a87032f0f6b3afbb1c558185794df8df5e31c4ae2b18f55372d7f605250a464b763fbc3701242021199b97d025a31ceb35f3673fb5af158b481e3159e51b
+  metadata.gz: b8adcfdf59177bcb66cfff1ed69d1ddc860d9be9e0d86728e95e0228e26753055a3ff1f3e14dc4e0cc1a911933e0d2a0af63271283533e7b6f0b474abc7415e3
+  data.tar.gz: 91769b652399b5f2b99e03acfc3ba34b2ac058dce439f7863eb178e3922e8612d1155262217b8cbf058442789622437061f3c38f8fabf7ce9536691658289a22

data/CHANGELOG.md

@@ -1,5 +1,31 @@
 # Changelog
 
+## 1.1.10 (2020-08-29)
+
+* Fix parameter inspection bug introduced in 1.1.10.
+
+## 1.1.9 (2020-08-28)
+
+* Gracefully filter params when inspecting an operation. If the params included
+  numeric keys in `rails < 6`, this lead to an error. This error is now handeled
+  gracefully and params are not inspected.
+
+* Do not call `inspect` every time an op is run
+
+## 1.1.8 (2020-07-08)
+
+* Fix bug where only the first hooked operation was called
+
+## 1.1.7 (2020-06-18)
+
+* Add controller / helper method `model?`
+
+## 1.1.6 (2020-04-08)
+
+* Fix suppressed validation errors by operations called via hookup. Now the
+  exception {RailsOps::Exceptions::HookupOpValidationFailed} is thrown if a hook
+  target operation throws a validation error throws a validation error
+
 ## 1.1.5 (2020-03-23)
 
 * Upgrade `active_type` to `~> 1.3.0` for Rails 6 compatibility

data/README.md

@@ -1361,6 +1361,9 @@ RailsOps conveniently provides you with a `model` instance method, which is a
 shortcut for `op.model`. This is particularly useful since this is available as
 a view helper method as well, see next section.
 
+You can check whether a model is available by using the `model?` method, which
+is available in both controllers and views.
+
 ### View helper methods
 
 The following controller methods are automatically provided as helper methods

data/VERSION

@@ -1 +1 @@
-1.1.5
+1.1.10

data/lib/rails_ops/controller_mixin.rb

@@ -21,6 +21,7 @@ module RailsOps
     included do
       if defined?(helper_method)
         helper_method :model
+        helper_method :model?
         helper_method :op
         helper_method :op?
         helper_method :op_context
@@ -85,6 +86,10 @@ module RailsOps
       return op.model
     end
 
+    def model?
+      !!(@model || op? && op.respond_to?(:model) && op.model)
+    end
+
     # Filters the `params` hash for use with RailsOps. This removes certain
     # web-specific parameters based on `EXCEPT_PARAMS`.
     def filter_op_params(params)

data/lib/rails_ops/exceptions.rb

@@ -16,4 +16,6 @@ module RailsOps::Exceptions
       super original_exception.message
     end
   end
+
+  class HookupOpValidationFailed < SubOpValidationFailed; end
 end

data/lib/rails_ops/hookup.rb

@@ -82,7 +82,12 @@ class RailsOps::Hookup
       end
 
       op = op_class.new(context, params)
-      op.run!
+
+      begin
+        op.run!
+      rescue *op.validation_errors => e
+        fail RailsOps::Exceptions::HookupOpValidationFailed, e
+      end
     end
   end
 end

data/lib/rails_ops/operation.rb

@@ -107,7 +107,7 @@ class RailsOps::Operation
   # any validation exception.
   def run!
     ActiveSupport::Notifications.instrument('run.rails_ops', operation: self) do
-      ::RailsOps::Profiler.profile(object_id, inspect) do
+      ::RailsOps::Profiler.profile(object_id) do
         fail 'An operation can only be performed once.' if performed?
         @performed = true
         run_policies :before_perform
@@ -125,7 +125,12 @@ class RailsOps::Operation
   def inspect
     inspection = self.class.name || '(AnonymousOp)'
     if params
-      inspection += " (#{inspect_params(filtered_params)})"
+      begin
+        inspected_params = inspect_params(filtered_params)
+      rescue
+        inspected_params = '<could not inspect params>'
+      end
+      inspection += " (#{inspected_params})"
     end
     return inspection
   end

data/rails_ops.gemspec

@@ -1,14 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: rails_ops 1.1.5 ruby lib
+# stub: rails_ops 1.1.10 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rails_ops".freeze
-  s.version = "1.1.5"
+  s.version = "1.1.10"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2020-03-23"
+  s.date = "2020-07-29"
   s.files = [".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, ".travis.yml".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE.txt".freeze, "README.md".freeze, "Rakefile".freeze, "VERSION".freeze, "lib/rails_ops.rb".freeze, "lib/rails_ops/authorization_backend/abstract.rb".freeze, "lib/rails_ops/authorization_backend/can_can_can.rb".freeze, "lib/rails_ops/configuration.rb".freeze, "lib/rails_ops/context.rb".freeze, "lib/rails_ops/controller_mixin.rb".freeze, "lib/rails_ops/exceptions.rb".freeze, "lib/rails_ops/hooked_job.rb".freeze, "lib/rails_ops/hookup.rb".freeze, "lib/rails_ops/hookup/dsl.rb".freeze, "lib/rails_ops/hookup/dsl_validator.rb".freeze, "lib/rails_ops/hookup/hook.rb".freeze, "lib/rails_ops/log_subscriber.rb".freeze, "lib/rails_ops/mixins.rb".freeze, "lib/rails_ops/mixins/authorization.rb".freeze, "lib/rails_ops/mixins/log_settings.rb".freeze, "lib/rails_ops/mixins/model.rb".freeze, "lib/rails_ops/mixins/model/authorization.rb".freeze, "lib/rails_ops/mixins/model/nesting.rb".freeze, "lib/rails_ops/mixins/param_authorization.rb".freeze, "lib/rails_ops/mixins/policies.rb".freeze, "lib/rails_ops/mixins/require_context.rb".freeze, "lib/rails_ops/mixins/routes.rb".freeze, "lib/rails_ops/mixins/schema_validation.rb".freeze, "lib/rails_ops/mixins/sub_ops.rb".freeze, "lib/rails_ops/model_casting.rb".freeze, "lib/rails_ops/model_mixins.rb".freeze, "lib/rails_ops/model_mixins/ar_extension.rb".freeze, "lib/rails_ops/model_mixins/parent_op.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb".freeze, "lib/rails_ops/model_mixins/virtual_has_one.rb".freeze, "lib/rails_ops/model_mixins/virtual_model_name.rb".freeze, "lib/rails_ops/operation.rb".freeze, "lib/rails_ops/operation/model.rb".freeze, "lib/rails_ops/operation/model/create.rb".freeze, "lib/rails_ops/operation/model/destroy.rb".freeze, "lib/rails_ops/operation/model/load.rb".freeze, "lib/rails_ops/operation/model/update.rb".freeze, "lib/rails_ops/patches/active_type_patch.rb".freeze, "lib/rails_ops/profiler.rb".freeze, "lib/rails_ops/profiler/node.rb".freeze, "lib/rails_ops/railtie.rb".freeze, "lib/rails_ops/scoped_env.rb".freeze, "lib/rails_ops/virtual_model.rb".freeze, "rails_ops.gemspec".freeze, "test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/mixins/model/nesting.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
   s.rubygems_version = "3.1.2".freeze
   s.summary = "An operations service layer for rails projects.".freeze

data/test/unit/rails_ops/operation_test.rb

@@ -150,4 +150,9 @@ class RailsOps::OperationTest < ActiveSupport::TestCase
     assert_equal 'RailsOps::OperationTest::BASIC_OP ({"foo"=>:bar})',
                  BASIC_OP.new(foo: :bar).inspect
   end
+
+  def test_inspect_with_numeric_param_keys
+    assert_equal 'RailsOps::OperationTest::BASIC_OP ({1=>2})',
+                 BASIC_OP.new(1 => 2).inspect
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_ops
 version: !ruby/object:Gem::Version
-  version: 1.1.5
+  version: 1.1.10
 platform: ruby
 authors:
 - Sitrox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-23 00:00:00.000000000 Z
+date: 2020-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler