rails_ops 1.1.4 → 1.1.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5e92309cb9695a9a40cc114e43dc43d204e00ba041d6f29da8a4debe4d1b9369
-  data.tar.gz: 5210b10eb4a5e13515f37a845c4b9a332d2f514de5251dce54753b93e363aa93
+  metadata.gz: 71da3242717173869f38ccd3f40f17ae4a395b068feaac00e5147a8133bb1544
+  data.tar.gz: 45f855da0ce0deb441e7d22f91b40c721af7daefdfd3e31e4b45df3af66ce3a2
 SHA512:
-  metadata.gz: 59a9cafba888578f8d9420543060576d07e83a1c4f1f1f76e91766af185997465ea1d1ac5648123731bb036bfca77abe4e1a079abdc0166b85a97ca35b35f218
-  data.tar.gz: ce6eb1524e3f3c8bcd1c62c960f6cc67abb76dadb04117c63d49d389d0b02f1a44659683db36aaf71bca721ab00c3f7f92f169d3a29053e75ef2750c96e00292
+  metadata.gz: d125f6a04f7eaa72862480b0e5319af1d6f21a991b53d0eeb72522b5f2eaa59fae4fd1192d8b1fc14f53038902844545b718355e0fa03b9bb59f0c707d226358
+  data.tar.gz: 9e92c942492f0b6c3dad3a9663ff6f04f90781f0f22d08424d83f791c524f0dc614c81feb1cd710e7f419a90ce0ffe7e5f763b1ada27639eb0f260f939b89ed6

data/CHANGELOG.md

@@ -1,5 +1,33 @@
 # Changelog
 
+## 1.1.10 (2020-08-28)
+
+* Gracefully filter params when inspecting an operation. If the params included
+  numeric keys in `rails < 6`, this lead to an error. This error is now handeled
+  gracefully and params are not inspected.
+
+## 1.1.9 (2020-07-22)
+
+* Do not call `inspect` every time an op is run
+
+## 1.1.8 (2020-07-08)
+
+* Fix bug where only the first hooked operation was called
+
+## 1.1.7 (2020-06-18)
+
+* Add controller / helper method `model?`
+
+## 1.1.6 (2020-04-08)
+
+* Fix suppressed validation errors by operations called via hookup. Now the
+  exception {RailsOps::Exceptions::HookupOpValidationFailed} is thrown if a hook
+  target operation throws a validation error throws a validation error
+
+## 1.1.5 (2020-03-23)
+
+* Upgrade `active_type` to `~> 1.3.0` for Rails 6 compatibility
+
 ## 1.1.4 (2020-03-10)
 
 * Remove debug output.

data/README.md

@@ -1361,6 +1361,9 @@ RailsOps conveniently provides you with a `model` instance method, which is a
 shortcut for `op.model`. This is particularly useful since this is available as
 a view helper method as well, see next section.
 
+You can check whether a model is available by using the `model?` method, which
+is available in both controllers and views.
+
 ### View helper methods
 
 The following controller methods are automatically provided as helper methods

data/Rakefile

@@ -19,7 +19,7 @@ task :gemspec do
     spec.add_development_dependency 'rake'
     spec.add_development_dependency 'sqlite3'
     spec.add_development_dependency 'rubocop', '0.47.1'
-    spec.add_dependency 'active_type', '~> 0.7.1'
+    spec.add_dependency 'active_type', '~> 1.3.0'
     spec.add_dependency 'minitest'
     spec.add_dependency 'rails'
     spec.add_dependency 'request_store'

data/VERSION

@@ -1 +1 @@
-1.1.4
+1.1.9

data/lib/rails_ops/controller_mixin.rb

@@ -21,6 +21,7 @@ module RailsOps
     included do
       if defined?(helper_method)
         helper_method :model
+        helper_method :model?
         helper_method :op
         helper_method :op?
         helper_method :op_context
@@ -85,6 +86,10 @@ module RailsOps
       return op.model
     end
 
+    def model?
+      !!(@model || op? && op.respond_to?(:model) && op.model)
+    end
+
     # Filters the `params` hash for use with RailsOps. This removes certain
     # web-specific parameters based on `EXCEPT_PARAMS`.
     def filter_op_params(params)

data/lib/rails_ops/exceptions.rb

@@ -16,4 +16,6 @@ module RailsOps::Exceptions
       super original_exception.message
     end
   end
+
+  class HookupOpValidationFailed < SubOpValidationFailed; end
 end

data/lib/rails_ops/hookup.rb

@@ -82,7 +82,12 @@ class RailsOps::Hookup
       end
 
       op = op_class.new(context, params)
-      op.run!
+
+      begin
+        op.run!
+      rescue *op.validation_errors => e
+        fail RailsOps::Exceptions::HookupOpValidationFailed, e
+      end
     end
   end
 end

data/lib/rails_ops/operation.rb

@@ -107,7 +107,7 @@ class RailsOps::Operation
   # any validation exception.
   def run!
     ActiveSupport::Notifications.instrument('run.rails_ops', operation: self) do
-      ::RailsOps::Profiler.profile(object_id, inspect) do
+      ::RailsOps::Profiler.profile(object_id) do
         fail 'An operation can only be performed once.' if performed?
         @performed = true
         run_policies :before_perform
@@ -125,7 +125,12 @@ class RailsOps::Operation
   def inspect
     inspection = self.class.name || '(AnonymousOp)'
     if params
-      inspection += " (#{inspect_params(filtered_params)})"
+      begin
+        inspected_params = inspected_params(filtered_params)
+      rescue
+        inspected_params = '<could not inspect params>'
+      end
+      inspection += " (#{inspected_params})"
     end
     return inspection
   end

data/rails_ops.gemspec

@@ -1,14 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: rails_ops 1.1.4 ruby lib
+# stub: rails_ops 1.1.9 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rails_ops".freeze
-  s.version = "1.1.4"
+  s.version = "1.1.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2020-03-10"
+  s.date = "2020-07-28"
   s.files = [".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, ".travis.yml".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE.txt".freeze, "README.md".freeze, "Rakefile".freeze, "VERSION".freeze, "lib/rails_ops.rb".freeze, "lib/rails_ops/authorization_backend/abstract.rb".freeze, "lib/rails_ops/authorization_backend/can_can_can.rb".freeze, "lib/rails_ops/configuration.rb".freeze, "lib/rails_ops/context.rb".freeze, "lib/rails_ops/controller_mixin.rb".freeze, "lib/rails_ops/exceptions.rb".freeze, "lib/rails_ops/hooked_job.rb".freeze, "lib/rails_ops/hookup.rb".freeze, "lib/rails_ops/hookup/dsl.rb".freeze, "lib/rails_ops/hookup/dsl_validator.rb".freeze, "lib/rails_ops/hookup/hook.rb".freeze, "lib/rails_ops/log_subscriber.rb".freeze, "lib/rails_ops/mixins.rb".freeze, "lib/rails_ops/mixins/authorization.rb".freeze, "lib/rails_ops/mixins/log_settings.rb".freeze, "lib/rails_ops/mixins/model.rb".freeze, "lib/rails_ops/mixins/model/authorization.rb".freeze, "lib/rails_ops/mixins/model/nesting.rb".freeze, "lib/rails_ops/mixins/param_authorization.rb".freeze, "lib/rails_ops/mixins/policies.rb".freeze, "lib/rails_ops/mixins/require_context.rb".freeze, "lib/rails_ops/mixins/routes.rb".freeze, "lib/rails_ops/mixins/schema_validation.rb".freeze, "lib/rails_ops/mixins/sub_ops.rb".freeze, "lib/rails_ops/model_casting.rb".freeze, "lib/rails_ops/model_mixins.rb".freeze, "lib/rails_ops/model_mixins/ar_extension.rb".freeze, "lib/rails_ops/model_mixins/parent_op.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb".freeze, "lib/rails_ops/model_mixins/virtual_has_one.rb".freeze, "lib/rails_ops/model_mixins/virtual_model_name.rb".freeze, "lib/rails_ops/operation.rb".freeze, "lib/rails_ops/operation/model.rb".freeze, "lib/rails_ops/operation/model/create.rb".freeze, "lib/rails_ops/operation/model/destroy.rb".freeze, "lib/rails_ops/operation/model/load.rb".freeze, "lib/rails_ops/operation/model/update.rb".freeze, "lib/rails_ops/patches/active_type_patch.rb".freeze, "lib/rails_ops/profiler.rb".freeze, "lib/rails_ops/profiler/node.rb".freeze, "lib/rails_ops/railtie.rb".freeze, "lib/rails_ops/scoped_env.rb".freeze, "lib/rails_ops/virtual_model.rb".freeze, "rails_ops.gemspec".freeze, "test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/mixins/model/nesting.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
   s.rubygems_version = "3.1.2".freeze
   s.summary = "An operations service layer for rails projects.".freeze
@@ -23,7 +23,7 @@ Gem::Specification.new do |s|
     s.add_development_dependency(%q<rake>.freeze, [">= 0"])
     s.add_development_dependency(%q<sqlite3>.freeze, [">= 0"])
     s.add_development_dependency(%q<rubocop>.freeze, ["= 0.47.1"])
-    s.add_runtime_dependency(%q<active_type>.freeze, ["~> 0.7.1"])
+    s.add_runtime_dependency(%q<active_type>.freeze, ["~> 1.3.0"])
     s.add_runtime_dependency(%q<minitest>.freeze, [">= 0"])
     s.add_runtime_dependency(%q<rails>.freeze, [">= 0"])
     s.add_runtime_dependency(%q<request_store>.freeze, [">= 0"])
@@ -33,7 +33,7 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<rake>.freeze, [">= 0"])
     s.add_dependency(%q<sqlite3>.freeze, [">= 0"])
     s.add_dependency(%q<rubocop>.freeze, ["= 0.47.1"])
-    s.add_dependency(%q<active_type>.freeze, ["~> 0.7.1"])
+    s.add_dependency(%q<active_type>.freeze, ["~> 1.3.0"])
     s.add_dependency(%q<minitest>.freeze, [">= 0"])
     s.add_dependency(%q<rails>.freeze, [">= 0"])
     s.add_dependency(%q<request_store>.freeze, [">= 0"])

data/test/unit/rails_ops/operation_test.rb

@@ -150,4 +150,9 @@ class RailsOps::OperationTest < ActiveSupport::TestCase
     assert_equal 'RailsOps::OperationTest::BASIC_OP ({"foo"=>:bar})',
                  BASIC_OP.new(foo: :bar).inspect
   end
+
+  def test_inspect_with_numeric_param_keys
+    assert_equal 'RailsOps::OperationTest::BASIC_OP ({1=>2})',
+                 BASIC_OP.new(1 => 2).inspect
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_ops
 version: !ruby/object:Gem::Version
-  version: 1.1.4
+  version: 1.1.9
 platform: ruby
 authors:
 - Sitrox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-10 00:00:00.000000000 Z
+date: 2020-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 1.3.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.1
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement