rails_ops 1.1.28 → 1.1.31

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 47bf9f1036ce2dc4920702cf743def5630af73960f1a750abedc578708454d61
-  data.tar.gz: d0ddd78f73c479e26f6d601d3dfdbeeefc0f667f0b5d094538f2e1faa210275d
+  metadata.gz: 907920fe74866a9348fa0f53641dbc7b98413414202c0ef5c363934d2328619d
+  data.tar.gz: 3861776f020b5832f86f045362dbc24f0bcfd4cf295d0151db91ccfea1e10de1
 SHA512:
-  metadata.gz: 47bd674965ba4ff732f343391b1ad77d11c8ceed69505d519979a2c9a81d45344a9dd21151b1a749ad24fed922c15d3223eee4418317acee947b5cfcb3dbf8cd
-  data.tar.gz: dea5e80197169cf93b06ea713ca198b97ff711b9171a3869d0da922341d6ebe5286993045009051b03f3eec2e41ed2172bdcc4c9a15943bea93a5bf042fdfbca
+  metadata.gz: 526e0abfe3cebc331d237fda390d0666e35a4435cf0db264bac7b0fcccfeefb9535fbb73d1da5e98561f88ab72535a2c9ec9d0ef7628556b494ae718dc2b76e0
+  data.tar.gz: f6420fed022c7b2eb61f8692726331ddc95af840f50301473651084aa5c7ba9fca07cc51d3e43e8327618b7799de56f1f49957d7aeece87d2ed87ea9bcafdf76

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 1.1.31 (2022-04-19)
+
+* Deprecate undocumented `virtual_has_one` feature
+
+## 1.1.30 (2022-02-18)
+
+* [PR#27](https://github.com/sitrox/rails_ops/pull/27): Update id schemata in templates
+
+## 1.1.29 (2022-02-17)
+
+*  Fix sti type not correct on creating of record
+
 ## 1.1.28 (2022-02-16)
 
 * [#22](https://github.com/sitrox/rails_ops/issues/22): Fix error with active_type `>= 2`

data/VERSION

@@ -1 +1 @@
-1.1.28
+1.1.31

data/lib/generators/operation/templates/destroy.erb

@@ -5,7 +5,7 @@ module Operations::<%= @class_name %>
 <% end -%>
   class Destroy < RailsOps::Operation::Model::Destroy
     schema3 do
-      str! :id
+      int! :id, cast_str: true
     end
 
     model ::<%= @class_name %>

data/lib/generators/operation/templates/load.erb

@@ -5,7 +5,7 @@ module Operations::<%= @class_name %>
 <% end -%>
   class Load < RailsOps::Operation::Model::Load
     schema3 do
-      str! :id
+      int! :id, cast_str: true
     end
 
     model ::<%= @class_name %>

data/lib/generators/operation/templates/update.erb

@@ -5,7 +5,7 @@ module Operations::<%= @class_name %>
 <% end -%>
   class Update < RailsOps::Operation::Model::Update
     schema3 do
-      str! :id
+      int! :id, cast_str: true
       hsh? :<%= @underscored_name %> do
 
       end

data/lib/rails_ops/model_mixins/virtual_has_one.rb

@@ -4,13 +4,9 @@ module RailsOps
       extend ActiveSupport::Concern
 
       module ClassMethods
-        # TODO: Passing type Fixnum currently requires a monkey-patch of ActiveType.
-        # This would need to be changed when releasing this functionality as a Gem.
-        # See config/initializers/patch_active_type.rb and
-        # https://github.com/remofritzsche/active_type/commit/fb8c2cb4cccaaec
-        #
-        # TODO: Document.
         def virtual_has_one(name, base_class, required: false, default: nil, type: Integer)
+          ActiveSupport::Deprecation.warn('virtual_has_one is deprecated and will be removed in a future version.')
+
           fk = "#{name}_id"
           attribute fk, type, default: default
           belongs_to name, anonymous_class: base_class, foreign_key: fk, class_name: base_class.name, required: required

data/lib/rails_ops/operation/model.rb

@@ -134,6 +134,11 @@ class RailsOps::Operation::Model < RailsOps::Operation
       attributes = attributes.except(*self.class.nested_model_param_keys)
     end
 
+    # Assign the "type" attribute if we need it
+    if _model_class.superclass.finder_needs_type_condition?
+      attributes[_model_class.inheritance_column] ||= _model_class.superclass.name
+    end
+
     # Do nothing if there are no attributes to assign
     return if attributes.nil? || attributes.empty?
 

data/rails_ops.gemspec

@@ -1,14 +1,14 @@
 # -*- encoding: utf-8 -*-
-# stub: rails_ops 1.1.28 ruby lib
+# stub: rails_ops 1.1.31 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "rails_ops".freeze
-  s.version = "1.1.28"
+  s.version = "1.1.31"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib".freeze]
   s.authors = ["Sitrox".freeze]
-  s.date = "2022-02-16"
+  s.date = "2022-04-19"
   s.files = [".github/workflows/rubocop.yml".freeze, ".github/workflows/ruby.yml".freeze, ".gitignore".freeze, ".releaser_config".freeze, ".rubocop.yml".freeze, "Appraisals".freeze, "CHANGELOG.md".freeze, "Gemfile".freeze, "LICENSE".freeze, "README.md".freeze, "Rakefile".freeze, "VERSION".freeze, "gemfiles/rails_5.1.gemfile".freeze, "gemfiles/rails_5.2.gemfile".freeze, "gemfiles/rails_6.0.gemfile".freeze, "gemfiles/rails_6.1.gemfile".freeze, "gemfiles/rails_7.0.gemfile".freeze, "lib/generators/operation/USAGE".freeze, "lib/generators/operation/operation_generator.rb".freeze, "lib/generators/operation/templates/controller.erb".freeze, "lib/generators/operation/templates/create.erb".freeze, "lib/generators/operation/templates/destroy.erb".freeze, "lib/generators/operation/templates/load.erb".freeze, "lib/generators/operation/templates/update.erb".freeze, "lib/generators/operation/templates/view.erb".freeze, "lib/rails_ops.rb".freeze, "lib/rails_ops/authorization_backend/abstract.rb".freeze, "lib/rails_ops/authorization_backend/can_can_can.rb".freeze, "lib/rails_ops/configuration.rb".freeze, "lib/rails_ops/context.rb".freeze, "lib/rails_ops/controller_mixin.rb".freeze, "lib/rails_ops/exceptions.rb".freeze, "lib/rails_ops/hooked_job.rb".freeze, "lib/rails_ops/hookup.rb".freeze, "lib/rails_ops/hookup/dsl.rb".freeze, "lib/rails_ops/hookup/dsl_validator.rb".freeze, "lib/rails_ops/hookup/hook.rb".freeze, "lib/rails_ops/log_subscriber.rb".freeze, "lib/rails_ops/mixins.rb".freeze, "lib/rails_ops/mixins/authorization.rb".freeze, "lib/rails_ops/mixins/log_settings.rb".freeze, "lib/rails_ops/mixins/model.rb".freeze, "lib/rails_ops/mixins/model/authorization.rb".freeze, "lib/rails_ops/mixins/model/nesting.rb".freeze, "lib/rails_ops/mixins/param_authorization.rb".freeze, "lib/rails_ops/mixins/policies.rb".freeze, "lib/rails_ops/mixins/require_context.rb".freeze, "lib/rails_ops/mixins/routes.rb".freeze, "lib/rails_ops/mixins/schema_validation.rb".freeze, "lib/rails_ops/mixins/sub_ops.rb".freeze, "lib/rails_ops/model_mixins.rb".freeze, "lib/rails_ops/model_mixins/ar_extension.rb".freeze, "lib/rails_ops/model_mixins/parent_op.rb".freeze, "lib/rails_ops/model_mixins/sti_fixes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes.rb".freeze, "lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb".freeze, "lib/rails_ops/model_mixins/virtual_has_one.rb".freeze, "lib/rails_ops/model_mixins/virtual_model_name.rb".freeze, "lib/rails_ops/operation.rb".freeze, "lib/rails_ops/operation/model.rb".freeze, "lib/rails_ops/operation/model/create.rb".freeze, "lib/rails_ops/operation/model/destroy.rb".freeze, "lib/rails_ops/operation/model/load.rb".freeze, "lib/rails_ops/operation/model/update.rb".freeze, "lib/rails_ops/profiler.rb".freeze, "lib/rails_ops/profiler/node.rb".freeze, "lib/rails_ops/railtie.rb".freeze, "lib/rails_ops/scoped_env.rb".freeze, "lib/rails_ops/virtual_model.rb".freeze, "rails_ops.gemspec".freeze, "test/db/models.rb".freeze, "test/db/schema.rb".freeze, "test/dummy/Rakefile".freeze, "test/dummy/app/assets/config/manifest.js".freeze, "test/dummy/app/assets/images/.keep".freeze, "test/dummy/app/assets/javascripts/application.js".freeze, "test/dummy/app/assets/javascripts/cable.js".freeze, "test/dummy/app/assets/javascripts/channels/.keep".freeze, "test/dummy/app/assets/stylesheets/application.css".freeze, "test/dummy/app/channels/application_cable/channel.rb".freeze, "test/dummy/app/channels/application_cable/connection.rb".freeze, "test/dummy/app/controllers/application_controller.rb".freeze, "test/dummy/app/controllers/concerns/.keep".freeze, "test/dummy/app/helpers/application_helper.rb".freeze, "test/dummy/app/jobs/application_job.rb".freeze, "test/dummy/app/mailers/application_mailer.rb".freeze, "test/dummy/app/models/animal.rb".freeze, "test/dummy/app/models/application_record.rb".freeze, "test/dummy/app/models/bird.rb".freeze, "test/dummy/app/models/cat.rb".freeze, "test/dummy/app/models/concerns/.keep".freeze, "test/dummy/app/models/dog.rb".freeze, "test/dummy/app/models/flower.rb".freeze, "test/dummy/app/models/group.rb".freeze, "test/dummy/app/models/nightingale.rb".freeze, "test/dummy/app/models/phoenix.rb".freeze, "test/dummy/app/models/user.rb".freeze, "test/dummy/app/views/layouts/application.html.erb".freeze, "test/dummy/app/views/layouts/mailer.html.erb".freeze, "test/dummy/app/views/layouts/mailer.text.erb".freeze, "test/dummy/bin/bundle".freeze, "test/dummy/bin/rails".freeze, "test/dummy/bin/rake".freeze, "test/dummy/bin/setup".freeze, "test/dummy/bin/update".freeze, "test/dummy/bin/yarn".freeze, "test/dummy/config.ru".freeze, "test/dummy/config/application.rb".freeze, "test/dummy/config/boot.rb".freeze, "test/dummy/config/cable.yml".freeze, "test/dummy/config/database.yml".freeze, "test/dummy/config/environment.rb".freeze, "test/dummy/config/environments/development.rb".freeze, "test/dummy/config/environments/production.rb".freeze, "test/dummy/config/environments/test.rb".freeze, "test/dummy/config/initializers/application_controller_renderer.rb".freeze, "test/dummy/config/initializers/assets.rb".freeze, "test/dummy/config/initializers/backtrace_silencers.rb".freeze, "test/dummy/config/initializers/cookies_serializer.rb".freeze, "test/dummy/config/initializers/filter_parameter_logging.rb".freeze, "test/dummy/config/initializers/inflections.rb".freeze, "test/dummy/config/initializers/mime_types.rb".freeze, "test/dummy/config/initializers/rails_ops.rb".freeze, "test/dummy/config/initializers/wrap_parameters.rb".freeze, "test/dummy/config/locales/en.yml".freeze, "test/dummy/config/puma.rb".freeze, "test/dummy/config/routes.rb".freeze, "test/dummy/config/secrets.yml".freeze, "test/dummy/config/spring.rb".freeze, "test/dummy/db/schema.rb".freeze, "test/dummy/lib/assets/.keep".freeze, "test/dummy/log/.keep".freeze, "test/dummy/package.json".freeze, "test/dummy/public/404.html".freeze, "test/dummy/public/422.html".freeze, "test/dummy/public/500.html".freeze, "test/dummy/public/apple-touch-icon-precomposed.png".freeze, "test/dummy/public/apple-touch-icon.png".freeze, "test/dummy/public/favicon.ico".freeze, "test/dummy/tmp/.keep".freeze, "test/test_helper.rb".freeze, "test/unit/rails_ops/generators/operation_generator_test.rb".freeze, "test/unit/rails_ops/mixins/model/nesting.rb".freeze, "test/unit/rails_ops/mixins/policies_test.rb".freeze, "test/unit/rails_ops/operation/model/create_test.rb".freeze, "test/unit/rails_ops/operation/model/load_test.rb".freeze, "test/unit/rails_ops/operation/model/sti_test.rb".freeze, "test/unit/rails_ops/operation/model/update_test.rb".freeze, "test/unit/rails_ops/operation/model_test.rb".freeze, "test/unit/rails_ops/operation/update_auth_test.rb".freeze, "test/unit/rails_ops/operation/update_lazy_auth_test.rb".freeze, "test/unit/rails_ops/operation_test.rb".freeze]
   s.rubygems_version = "3.1.2".freeze
   s.summary = "An operations service layer for rails projects.".freeze

data/test/unit/rails_ops/operation/model/sti_test.rb

@@ -34,6 +34,30 @@ class RailsOps::Operation::Model::StiTest < ActiveSupport::TestCase
     end
   end
 
+  UPDATE_DOG_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model Dog do
+      attribute :my_virtual_dog_name
+    end
+  end
+
+  CREATE_DOG_OP = Class.new(RailsOps::Operation::Model::Create) do
+    model Dog do
+      attribute :my_virtual_dog_name
+    end
+  end
+
+  UPDATE_PHOENIX_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model Phoenix do
+      attribute :my_virtual_phoenix_name
+    end
+  end
+
+  CREATE_PHOENIX_OP = Class.new(RailsOps::Operation::Model::Create) do
+    model Phoenix do
+      attribute :my_virtual_phoenix_name
+    end
+  end
+
   def test_load_animal
     model = LOAD_ANIMAL_OP.new(id: @dog.id).model
     assert_equal 'Dog', model.type
@@ -67,4 +91,36 @@ class RailsOps::Operation::Model::StiTest < ActiveSupport::TestCase
     assert model.is_a?(LOAD_PHOENIX_OP.model)
     assert_nothing_raised { model.my_virtual_phoenix_name = 'Lenny' }
   end
+
+  def test_create_dog
+    op = CREATE_DOG_OP.new.run!
+
+    assert_equal 'Dog', op.model.type
+    assert op.model.is_a?(CREATE_DOG_OP.model)
+    assert_nothing_raised { op.model.my_virtual_dog_name = 'Lenny' }
+  end
+
+  def test_update_dog
+    op = UPDATE_DOG_OP.new(id: @dog.id).run!
+
+    assert_equal 'Dog', op.model.type
+    assert op.model.is_a?(UPDATE_DOG_OP.model)
+    assert_nothing_raised { op.model.my_virtual_dog_name = 'Lenny' }
+  end
+
+  def test_create_phoenix
+    op = CREATE_PHOENIX_OP.new.run!
+
+    assert_equal 'Phoenix', op.model.type
+    assert op.model.is_a?(CREATE_PHOENIX_OP.model)
+    assert_nothing_raised { op.model.my_virtual_phoenix_name = 'Lenny' }
+  end
+
+  def test_update_phoenix
+    op = UPDATE_PHOENIX_OP.new(id: @phoenix.id).run!
+
+    assert_equal 'Phoenix', op.model.type
+    assert op.model.is_a?(UPDATE_PHOENIX_OP.model)
+    assert_nothing_raised { op.model.my_virtual_phoenix_name = 'Lenny' }
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_ops
 version: !ruby/object:Gem::Version
-  version: 1.1.28
+  version: 1.1.31
 platform: ruby
 authors:
 - Sitrox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-02-16 00:00:00.000000000 Z
+date: 2022-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal