rails_ops 1.1.21 → 1.1.25

data/test/dummy/app/models/bird.rb

@@ -0,0 +1 @@
+class Bird < Animal; end

data/test/dummy/app/models/cat.rb

@@ -0,0 +1 @@
+class Cat < Animal; end

data/test/dummy/app/models/dog.rb

@@ -0,0 +1 @@
+class Dog < Animal; end

data/test/dummy/app/models/flower.rb

@@ -0,0 +1,7 @@
+class Flower < ApplicationRecord
+  # default_scope ->() { where(planted: true) }
+
+  def self.default_scope
+    where(planted: true)
+  end
+end

data/test/dummy/app/models/nightingale.rb

@@ -0,0 +1 @@
+class Nightingale < Bird; end

data/test/dummy/app/models/phoenix.rb

@@ -0,0 +1 @@
+class Phoenix < Bird; end

data/test/dummy/app/models/user.rb

@@ -0,0 +1,3 @@
+class User < ApplicationRecord
+  belongs_to :group
+end

data/test/dummy/config/application.rb

@@ -1,6 +1,17 @@
 require_relative 'boot'
 
-require 'rails/all'
+require 'rails'
+
+require 'active_model/railtie'
+require 'active_job/railtie'
+require 'active_record/railtie'
+# require "active_storage/engine"
+require 'action_controller/railtie'
+require 'action_mailer/railtie'
+require 'action_view/railtie'
+require 'action_cable/engine'
+require 'sprockets/railtie'
+require 'rails/test_unit/railtie'
 
 Bundler.require(*Rails.groups)
 require 'rails_ops'

data/test/dummy/config/environments/test.rb

@@ -10,7 +10,7 @@ Rails.application.configure do
   # Do not eager load code on boot. This avoids loading your whole application
   # just for the purpose of running a single test. If you are using a tool that
   # preloads Rails for running tests, you may have to set it to true.
-  config.eager_load = false
+  config.eager_load = true
 
   # Configure public file server for tests with Cache-Control for performance.
   config.public_file_server.enabled = true

data/test/dummy/config/initializers/backtrace_silencers.rb

@@ -4,4 +4,4 @@
 # Rails.backtrace_cleaner.add_silencer { |line| line =~ /my_noisy_library/ }
 
 # You can also remove all the silencers if you're trying to debug a problem that might stem from framework code.
-# Rails.backtrace_cleaner.remove_silencers!
+Rails.backtrace_cleaner.remove_silencers!

data/test/dummy/db/schema.rb

@@ -6,4 +6,12 @@ ActiveRecord::Schema.define do
     t.string :color
     t.timestamps
   end
+
+  create_table :animals, force: true do |t|
+    t.string :type
+  end
+
+  create_table :flowers, force: true do |t|
+    t.boolean :planted, null: false, default: true
+  end
 end

data/test/test_helper.rb

@@ -1,6 +1,8 @@
 require File.expand_path('../../test/dummy/config/environment.rb', __FILE__)
 # ActiveRecord::Migrator.migrations_paths = [File.expand_path("../../test/dummy/db/migrate", __FILE__)]
 require 'rails/test_help'
+require 'pry'
+require 'colorize'
 
 # Filter out Minitest backtrace while allowing backtrace from other libraries
 # to be shown.

data/test/unit/rails_ops/generators/operation_generator_test.rb

@@ -0,0 +1,170 @@
+require 'test_helper'
+require 'generators/operation/operation_generator'
+
+class OperationGeneratorTest < Rails::Generators::TestCase
+  tests OperationGenerator
+  destination File.expand_path('../../../tmp', File.dirname(__FILE__))
+
+  setup do
+    prepare_destination
+
+    # Add an empty routes file
+    Dir.mkdir(File.join(destination_root, 'config'))
+    File.open(File.join(destination_root, 'config', 'routes.rb'), 'w') do |f|
+      f.write <<~ROUTES
+        Rails.application.routes.draw do
+        end
+      ROUTES
+    end
+  end
+
+  def test_all
+    run_generator ['User']
+
+    # Check that operations are generated
+    assert_operations
+
+    # Check that views are generated
+    assert_views
+
+    # Check that the controller is generated
+    assert_controller
+
+    # Check that the routes entry is added
+    assert_routes
+  end
+
+  def test_no_views
+    run_generator ['User', '--skip-views']
+
+    assert_operations
+    assert_controller
+    assert_routes
+
+    # Check that the views were skipped
+    %w(index show new edit).each do |view|
+      assert_no_file "app/views/users/#{view}.html.haml"
+    end
+  end
+
+  def test_no_controller
+    run_generator ['User', '--skip-controller']
+
+    assert_operations
+    assert_views
+    assert_routes
+
+    # Check that the controller was skipped
+    assert_no_file 'app/controllers/users_controller.rb'
+  end
+
+  def test_no_routes
+    run_generator ['User', '--skip-routes']
+
+    assert_operations
+    assert_views
+    assert_controller
+
+    # Check that the routes were not added
+    assert_file 'config/routes.rb' do |routes|
+      assert_no_match(/resources :users/, routes)
+    end
+  end
+
+  def test_skip_all
+    run_generator ['User', '--skip-controller', '--skip-routes', '--skip-views']
+
+    assert_operations
+
+    # Check that the controller was skipped
+    assert_no_file 'app/controllers/users_controller.rb'
+
+    # Check that the routes were not added
+    assert_file 'config/routes.rb' do |routes|
+      assert_no_match(/resources :users/, routes)
+    end
+
+    # Check that the views were skipped
+    %w(index show new edit).each do |view|
+      assert_no_file "app/views/users/#{view}.html.haml"
+    end
+  end
+
+  def test_only_operations
+    run_generator ['User', '--only-operations']
+
+    assert_operations
+
+    # Check that the controller was skipped
+    assert_no_file 'app/controllers/users_controller.rb'
+
+    # Check that the routes were not added
+    assert_file 'config/routes.rb' do |routes|
+      assert_no_match(/resources :users/, routes)
+    end
+
+    # Check that the views were skipped
+    %w(index show new edit).each do |view|
+      assert_no_file "app/views/users/#{view}.html.haml"
+    end
+  end
+
+  def test_lowercase_name
+    run_generator ['user']
+
+    # Check that operations are generated
+    assert_operations
+
+    # Check that views are generated
+    assert_views
+
+    # Check that the controller is generated
+    assert_controller
+
+    # Check that the routes entry is added
+    assert_routes
+  end
+
+  private
+
+  def assert_operations
+    assert_file 'app/operations/user/create.rb' do |operation|
+      assert_match(/module Operations::User/, operation)
+      assert_match(/class Create < RailsOps::Operation::Model::Create/, operation)
+      assert_match(/model ::User/, operation)
+    end
+    assert_file 'app/operations/user/destroy.rb' do |operation|
+      assert_match(/module Operations::User/, operation)
+      assert_match(/class Destroy < RailsOps::Operation::Model::Destroy/, operation)
+      assert_match(/model ::User/, operation)
+    end
+    assert_file 'app/operations/user/load.rb' do |operation|
+      assert_match(/module Operations::User/, operation)
+      assert_match(/class Load < RailsOps::Operation::Model::Load/, operation)
+      assert_match(/model ::User/, operation)
+    end
+    assert_file 'app/operations/user/update.rb' do |operation|
+      assert_match(/module Operations::User/, operation)
+      assert_match(/class Update < RailsOps::Operation::Model::Update/, operation)
+      assert_match(/model ::User/, operation)
+    end
+  end
+
+  def assert_views
+    %w(index show new edit).each do |view|
+      assert_file "app/views/users/#{view}.html.haml"
+    end
+  end
+
+  def assert_controller
+    assert_file 'app/controllers/users_controller.rb' do |controller|
+      assert_match(/class UsersController < ApplicationController/, controller)
+    end
+  end
+
+  def assert_routes
+    assert_file 'config/routes.rb' do |routes|
+      assert_match(/resources :users/, routes)
+    end
+  end
+end

data/test/unit/rails_ops/operation/model/sti_test.rb

@@ -0,0 +1,70 @@
+require 'test_helper'
+
+class RailsOps::Operation::Model::StiTest < ActiveSupport::TestCase
+  include TestHelper
+
+  setup do
+    @dog = Dog.create!
+    @cat = Cat.create!
+    @phoenix = Phoenix.create!
+    @nightingale = Nightingale.create!
+  end
+
+  LOAD_ANIMAL_OP = Class.new(RailsOps::Operation::Model::Load) do
+    model Animal do
+      attribute :my_virtual_animal_name
+    end
+  end
+
+  LOAD_DOG_OP = Class.new(RailsOps::Operation::Model::Load) do
+    model Dog do
+      attribute :my_virtual_dog_name
+    end
+  end
+
+  LOAD_BIRD_OP = Class.new(RailsOps::Operation::Model::Load) do
+    model Bird do
+      attribute :my_virtual_bird_name
+    end
+  end
+
+  LOAD_PHOENIX_OP = Class.new(RailsOps::Operation::Model::Load) do
+    model Phoenix do
+      attribute :my_virtual_phoenix_name
+    end
+  end
+
+  def test_load_animal
+    model = LOAD_ANIMAL_OP.new(id: @dog.id).model
+    assert_equal 'Dog', model.type
+    assert model.is_a?(LOAD_ANIMAL_OP.model)
+    assert_nothing_raised { model.my_virtual_animal_name = 'Lenny' }
+  end
+
+  def test_load_dog
+    model = LOAD_DOG_OP.new(id: @dog.id).model
+
+    assert_equal 'Dog', model.type
+    assert model.is_a?(LOAD_DOG_OP.model)
+    assert_nothing_raised { model.my_virtual_dog_name = 'Lenny' }
+  end
+
+  def test_load_birds
+    phoenix = LOAD_BIRD_OP.new(id: @phoenix.id).model
+    nightingale = LOAD_BIRD_OP.new(id: @nightingale.id).model
+
+    assert_equal 'Phoenix', phoenix.type
+    assert phoenix.is_a?(LOAD_BIRD_OP.model)
+    assert nightingale.is_a?(LOAD_BIRD_OP.model)
+    assert_nothing_raised { phoenix.my_virtual_bird_name = 'Lenny' }
+    assert_nothing_raised { nightingale.my_virtual_bird_name = 'Lenny' }
+  end
+
+  def test_load_phoenix
+    model = LOAD_PHOENIX_OP.new(id: @phoenix.id).model
+
+    assert_equal 'Phoenix', model.type
+    assert model.is_a?(LOAD_PHOENIX_OP.model)
+    assert_nothing_raised { model.my_virtual_phoenix_name = 'Lenny' }
+  end
+end

data/test/unit/rails_ops/operation/model/update_test.rb

@@ -7,6 +7,12 @@ class RailsOps::Operation::Model::UpdateTest < ActiveSupport::TestCase
     model Group
   end
 
+  FLOWER_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model Flower do
+      attribute :color
+    end
+  end
+
   def test_basic
     g = Group.create
     op = BASIC_OP.new(id: g.id)
@@ -19,4 +25,24 @@ class RailsOps::Operation::Model::UpdateTest < ActiveSupport::TestCase
     op = BASIC_OP.new(id: g.id)
     assert_equal op, op.model.parent_op
   end
+
+  def test_issue_59992
+    flower1 = Flower.create!(planted: true)
+    flower2 = Flower.create!(planted: false)
+
+    op = FLOWER_OP.new(id: flower1.id)
+
+    assert op.model.respond_to?(:color)
+    assert op.model.is_a?(FLOWER_OP.model)
+
+    op.model.color = :red
+
+    assert_equal :red, op.model.color
+
+    op = FLOWER_OP.new(id: flower2.id)
+
+    assert_raises ActiveRecord::RecordNotFound do
+      op.model
+    end
+  end
 end

data/test/unit/rails_ops/operation/update_auth_test.rb

@@ -0,0 +1,62 @@
+require 'test_helper'
+require 'rails_ops/authorization_backend/can_can_can'
+require 'cancancan'
+
+class RailsOps::Operation::UpdateLazyAuthTest < ActiveSupport::TestCase
+  include TestHelper
+
+  BASIC_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model ::Group
+
+    model_authorization_action :update
+
+    def perform
+      fail osparams.exception if osparams.exception
+      @done = true
+    end
+  end
+
+  ABILITY = Class.new do
+    include CanCan::Ability
+
+    def initialize(read: false, update: false)
+      can :read, Group if read
+      can :update, Group if update
+    end
+  end
+
+  setup do
+    Group.create!(id: 1, name: 'Group')
+    RailsOps.config.authorization_backend = 'RailsOps::AuthorizationBackend::CanCanCan'
+  end
+
+  def test_unpermitted_read
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
+    assert_raises CanCan::AccessDenied do
+      BASIC_OP.new(ctx, id: 1)
+    end
+  end
+
+  def test_permitted_read
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
+    assert_nothing_raised do
+      BASIC_OP.new(ctx, id: 1)
+    end
+  end
+
+  def test_unpermitted_update
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
+    op = BASIC_OP.new(ctx, id: 1)
+    assert_raises CanCan::AccessDenied do
+      op.run!
+    end
+  end
+
+  def test_permitted_update
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true, update: true))
+    op = BASIC_OP.new(ctx, id: 1)
+    assert_nothing_raised do
+      op.run!
+    end
+  end
+end

data/test/unit/rails_ops/operation/update_lazy_auth_test.rb

@@ -0,0 +1,63 @@
+require 'test_helper'
+require 'rails_ops/authorization_backend/can_can_can'
+require 'cancancan'
+
+class RailsOps::Operation::UpdateLazyAuthTest < ActiveSupport::TestCase
+  include TestHelper
+
+  BASIC_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model ::Group
+
+    model_authorization_action :update, lazy: true
+
+    def perform
+      fail osparams.exception if osparams.exception
+      @done = true
+    end
+  end
+
+  ABILITY = Class.new do
+    include CanCan::Ability
+
+    def initialize(read: false, update: false)
+      can :read, Group if read
+      can :update, Group if update
+    end
+  end
+
+  setup do
+    Group.delete_all
+    Group.create!(id: 1, name: 'Group')
+    RailsOps.config.authorization_backend = 'RailsOps::AuthorizationBackend::CanCanCan'
+  end
+
+  def test_unpermitted_read
+    ctx = RailsOps::Context.new(ability: ABILITY.new)
+    assert_raises CanCan::AccessDenied do
+      BASIC_OP.new(ctx, id: 1)
+    end
+  end
+
+  def test_permitted_read
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
+    assert_nothing_raised do
+      BASIC_OP.new(ctx, id: 1)
+    end
+  end
+
+  def test_unpermitted_update
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true))
+    op = BASIC_OP.new(ctx, id: 1)
+    assert_raises CanCan::AccessDenied do
+      op.run!
+    end
+  end
+
+  def test_permitted_update
+    ctx = RailsOps::Context.new(ability: ABILITY.new(read: true, update: true))
+    op = BASIC_OP.new(ctx, id: 1)
+    assert_nothing_raised do
+      op.run!
+    end
+  end
+end