rails_ops 1.0.0.beta6 → 1.0.0.beta7

data/test/test_helper.rb

@@ -1,19 +1,53 @@
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
-require 'active_record'
-require 'minitest/autorun'
-require 'rails_ops'
-require 'db/models'
+require File.expand_path('../../test/dummy/config/environment.rb', __FILE__)
+# ActiveRecord::Migrator.migrations_paths = [File.expand_path("../../test/dummy/db/migrate", __FILE__)]
+require 'rails/test_help'
 
-ActiveRecord::Base.establish_connection adapter: 'sqlite3', database: ':memory:'
+# Filter out Minitest backtrace while allowing backtrace from other libraries
+# to be shown.
+Minitest.backtrace_filter = Minitest::BacktraceFilter.new
+
+require 'rails/test_unit/reporter'
+
+Rails::TestUnitReporter.executable = 'bin/test'
+
+# Load fixtures from the engine
+if ActiveSupport::TestCase.respond_to?(:fixture_path=)
+  ActiveSupport::TestCase.fixture_path = File.expand_path('../fixtures', __FILE__)
+  ActionDispatch::IntegrationTest.fixture_path = ActiveSupport::TestCase.fixture_path
+  ActiveSupport::TestCase.file_fixture_path = ActiveSupport::TestCase.fixture_path + '/files'
+  ActiveSupport::TestCase.fixtures :all
+end
+
+load File.dirname(__FILE__) + '/dummy/db/schema.rb'
+
+require 'request_store'
 
 module TestHelper
   extend ActiveSupport::Concern
 
-  module ClassMethods
-    def setup_db
-      load File.dirname(__FILE__) + '/db/schema.rb'
+  # Help test raise errors message
+  # https://ruby-doc.org/stdlib-2.1.5/libdoc/test/unit/rdoc/Test/Unit/Assertions.html#method-i-assert_raise
+  def assert_raises_with_message(exception, expected, msg = nil, &block)
+    case expected
+    when String
+      assert = :assert_equal
+    when Regexp
+      assert = :assert_match
+    else
+      fail TypeError, "Expected #{expected.inspect} to be a kind of String or Regexp, not #{expected.class}"
+    end
+
+    ex = assert_raises(exception, *msg) { yield }
+    msg = message(msg, '') { "Expected Exception(#{exception}) was raised, but the message doesn't match" }
+
+    if assert == :assert_equal
+      assert_equal(expected, ex.message, msg)
+    else
+      msg = message(msg) { "Expected #{mu_pp expected} to match #{mu_pp ex.message}" }
+      assert expected =~ ex.message, msg
+      block.binding.eval('proc{|_|$~=_}').call($LAST_MATCH_INFO)
     end
 
-    def setup_base_data; end
+    return ex
   end
 end

data/test/unit/rails_ops/operation/model/create_test.rb

@@ -0,0 +1,52 @@
+require 'test_helper'
+
+class RailsOps::Operation::Model::CreateTest < ActiveSupport::TestCase
+  include TestHelper
+
+  BASIC_OP = Class.new(RailsOps::Operation::Model::Create) do
+    model Group
+  end
+
+  def test_basic
+    op = BASIC_OP.run!(group: { name: 'test', color: 'red' })
+
+    assert_equal 'test', op.model.name
+    assert_equal 'red', op.model.color
+    assert op.model.persisted?
+    refute op.model.changed?
+  end
+
+  def test_model_extension
+    cls = Class.new(RailsOps::Operation::Model::Create) do
+      model Group do
+        validates :color, presence: true
+      end
+    end
+
+    assert cls.new.model.class < Group
+
+    assert_raises ActiveRecord::RecordInvalid do
+      cls.run!(group: { name: 'test' })
+    end
+  end
+
+  def test_parent_op
+    op = BASIC_OP.new
+    assert_equal op, op.model.parent_op
+  end
+
+  def test_always_extend_model_class
+    assert RailsOps::Operation::Model::Create.always_extend_model_class?
+  end
+
+  def test_build
+    op = BASIC_OP.new
+    op.build_model
+
+    assert op.instance_variable_get(:@model)
+
+    assert_raises_with_message RuntimeError, 'Model can only be built once.' do
+      op.build_model
+    end
+  end
+end

data/test/unit/rails_ops/operation/model/load_test.rb

@@ -0,0 +1,54 @@
+require 'test_helper'
+
+class RailsOps::Operation::Model::LoadTest < ActiveSupport::TestCase
+  include TestHelper
+
+  BASIC_OP = Class.new(RailsOps::Operation::Model::Load) do
+    model Group
+  end
+
+  def test_basic
+    g = Group.create
+    op = BASIC_OP.new(id: g.id)
+    assert_equal g, op.model
+    assert_equal Group, op.model.class
+  end
+
+  def test_parent_op
+    g = Group.create
+    cls = Class.new(RailsOps::Operation::Model::Load) do
+      model Group do
+        # Nothing do do
+      end
+    end
+    op = cls.new(id: g.id)
+    assert_equal op, op.model.parent_op
+  end
+
+  def test_without_id
+    op = BASIC_OP.new
+    assert_raises_with_message RuntimeError, 'Param :id must be given.' do
+      op.model
+    end
+  end
+
+  def test_not_found
+    op = BASIC_OP.new(id: 5)
+    assert_raise ActiveRecord::RecordNotFound do
+      op.model
+    end
+  end
+
+  def test_other_model_id_field
+    cls = Class.new(RailsOps::Operation::Model::Load) do
+      model Group
+
+      def model_id_field
+        :name
+      end
+    end
+
+    g = Group.create(name: 'g1')
+    assert_equal g, cls.new(name: 'g1').model
+  end
+end

data/test/unit/rails_ops/operation/model/update_test.rb

@@ -0,0 +1,22 @@
+require 'test_helper'
+
+class RailsOps::Operation::Model::UpdateTest < ActiveSupport::TestCase
+  include TestHelper
+
+  BASIC_OP = Class.new(RailsOps::Operation::Model::Update) do
+    model Group
+  end
+
+  def test_basic
+    g = Group.create
+    op = BASIC_OP.new(id: g.id)
+    assert_equal g.id, op.model.id
+    assert op.model.class < Group
+  end
+
+  def test_parent_op
+    g = Group.create
+    op = BASIC_OP.new(id: g.id)
+    assert_equal op, op.model.parent_op
+  end
+end

data/test/unit/rails_ops/operation/model_test.rb

@@ -0,0 +1,67 @@
+require 'test_helper'
+
+class RailsOps::Operation::ModelTest < ActiveSupport::TestCase
+  include TestHelper
+
+  def test_always_extend_model_class_true
+    cls = Class.new(RailsOps::Operation::Model) do
+      def self.always_extend_model_class?
+        true
+      end
+
+      model Group
+    end
+
+    refute_equal Group, cls.model
+  end
+
+  def test_always_extend_model_class_false
+    cls = Class.new(RailsOps::Operation::Model) do
+      def self.always_extend_model_class?
+        false
+      end
+
+      model Group
+    end
+
+    assert_equal Group, cls.model
+  end
+
+  def test_model_mixins
+    cls = Class.new(RailsOps::Operation::Model) do
+      def self.always_extend_model_class?
+        true
+      end
+
+      model Group
+    end
+
+    assert cls.model.included_modules.include?(RailsOps::ModelMixins)
+  end
+
+  def test_virtual_model_name
+    cls = Class.new(RailsOps::Operation::Model) do
+      model RailsOps::VirtualModel, 'Example'
+    end
+
+    assert_equal 'Example', cls.model.virtual_model_name
+  end
+
+  def test_default_model_class
+    cls = Class.new(RailsOps::Operation::Model) do
+      model do
+        attribute :name, :string
+      end
+    end
+
+    assert cls.model < ActiveType::Object
+  end
+
+  def test_no_model_class
+    assert_raises_with_message RuntimeError, 'No model class has been set.' do
+      Class.new(RailsOps::Operation::Model) do
+        model
+      end
+    end
+  end
+end

data/test/unit/rails_ops/operation_test.rb

@@ -0,0 +1,145 @@
+require 'test_helper'
+
+class RailsOps::OperationTest < ActiveSupport::TestCase
+  include TestHelper
+
+  EXCEPTION = Class.new(StandardError)
+
+  BASIC_OP = Class.new(RailsOps::Operation) do
+    attr_reader :done
+
+    def validation_errors
+      super + [EXCEPTION]
+    end
+
+    def perform
+      fail osparams.exception if osparams.exception
+      @done = true
+    end
+  end
+
+  def test_basic_operation
+    op = BASIC_OP.new
+    op.run
+    assert op.done
+  end
+
+  def test_static_run
+    assert BASIC_OP.run
+  end
+
+  def test_static_run!
+    assert BASIC_OP.run!.done
+  end
+
+  def test_non_validation_error
+    assert_raises_with_message RuntimeError, 'Standard exception' do
+      BASIC_OP.run(exception: 'Standard exception')
+    end
+
+    assert_raises_with_message RuntimeError, 'Standard exception' do
+      BASIC_OP.run!(exception: 'Standard exception')
+    end
+  end
+
+  def test_validation_errors
+    assert_raises_with_message RailsOps::Exceptions::ValidationFailed, 'A message' do
+      BASIC_OP.run!(exception: RailsOps::Exceptions::ValidationFailed.new('A message'))
+    end
+
+    refute BASIC_OP.run(exception: RailsOps::Exceptions::ValidationFailed.new('A message'))
+  end
+
+  def test_constructor
+    context = RailsOps::Context.new
+
+    # new()
+    op = BASIC_OP.new
+    assert_not_equal context.object_id, op.context.object_id
+    assert_equal({}, op.params)
+
+    # new(nil)
+    op = BASIC_OP.new(nil)
+    assert_not_equal context.object_id, op.context.object_id
+    assert_equal({}, op.params)
+
+    # new(nil, nil)
+    op = BASIC_OP.new(nil)
+    assert_not_equal context.object_id, op.context.object_id
+    assert_equal({}, op.params)
+
+    # new(context, params)
+    op = BASIC_OP.new(context, key: :val)
+    assert_equal context.object_id, op.context.object_id
+    assert_equal({ key: :val }.with_indifferent_access, op.params)
+
+    # new(context)
+    op = BASIC_OP.new(context)
+    assert_equal context.object_id, op.context.object_id
+    assert_equal({}, op.params)
+
+    # new(params)
+    op = BASIC_OP.new(key: :val)
+    assert_not_equal context.object_id, op.context.object_id
+    assert_equal({ key: :val }.with_indifferent_access, op.params)
+
+    # new(params) with ActionController::Parameters
+    params = ActionController::Parameters.new(key: :val)
+    op = BASIC_OP.new(params)
+    assert_not_equal params.object_id, op.params.object_id
+    assert_equal({ key: :val }.with_indifferent_access, op.params)
+  end
+
+  def test_params
+    params = { a: 1, 'b': 1 }
+    op = BASIC_OP.new(params)
+
+    # ---------------------------------------------------------------
+    # Check if op.params and op.osparams are correctly populated
+    # ---------------------------------------------------------------
+    assert_equal params.with_indifferent_access, op.params
+    assert_equal op.params, op.osparams.to_h.with_indifferent_access
+
+    # ---------------------------------------------------------------
+    # Verify that operations work with a duplicate params hash,
+    # and op.params and op.osparams are not connected
+    # ---------------------------------------------------------------
+
+    # Change of outside params hash
+    params[:a] = 2
+    assert_equal 1, op.params[:a]
+    assert_equal 1, op.osparams[:a]
+
+    # Change of op.params hash
+    op.params[:a] = 3
+    assert_equal 2, params[:a]
+    assert_equal 1, op.osparams[:a]
+
+    # Change of op.osparams hash
+    op.osparams.a = 4
+    assert_equal 2, params[:a]
+    assert_equal 3, op.params[:a]
+
+    # ---------------------------------------------------------------
+    # Verify that the params hash is deep duplicated
+    # ---------------------------------------------------------------
+    params = { a: { foo: :bar } }
+    op = Class.new(RailsOps::Operation).new(params)
+    params[:a][:foo] = :baz
+
+    assert_equal :bar, op.params[:a][:foo]
+    assert_equal :bar, op.osparams.a[:foo]
+  end
+
+  def test_performed
+    op = BASIC_OP.new
+    refute op.performed?
+    op.run!
+    assert op.performed?
+  end
+
+  def test_inspect
+    assert_equal 'RailsOps::OperationTest::BASIC_OP ({"foo"=>:bar})',
+                 BASIC_OP.new(foo: :bar).inspect
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_ops
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta6
+  version: 1.0.0.beta7
 platform: ruby
 authors:
 - Sitrox
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-27 00:00:00.000000000 Z
+date: 2017-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: yard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -80,20 +66,6 @@ dependencies:
     - - '='
       - !ruby/object:Gem::Version
         version: 0.47.1
-- !ruby/object:Gem::Dependency
-  name: redcarpet
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: active_type
   requirement: !ruby/object:Gem::Requirement
@@ -123,21 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: activerecord
+  name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -151,7 +109,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: activejob
+  name: request_store
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -222,7 +180,6 @@ files:
 - lib/rails_ops/model_mixins.rb
 - lib/rails_ops/model_mixins/ar_extension.rb
 - lib/rails_ops/model_mixins/parent_op.rb
-- lib/rails_ops/model_mixins/protected_attributes.rb
 - lib/rails_ops/model_mixins/virtual_attributes.rb
 - lib/rails_ops/model_mixins/virtual_attributes/virtual_column_wrapper.rb
 - lib/rails_ops/model_mixins/virtual_has_one.rb
@@ -241,8 +198,72 @@ files:
 - rails_ops.gemspec
 - test/db/models.rb
 - test/db/schema.rb
-- test/rails_ops/operation/example_test.rb
+- test/dummy/Rakefile
+- test/dummy/app/assets/config/manifest.js
+- test/dummy/app/assets/images/.keep
+- test/dummy/app/assets/javascripts/application.js
+- test/dummy/app/assets/javascripts/cable.js
+- test/dummy/app/assets/javascripts/channels/.keep
+- test/dummy/app/assets/stylesheets/application.css
+- test/dummy/app/channels/application_cable/channel.rb
+- test/dummy/app/channels/application_cable/connection.rb
+- test/dummy/app/controllers/application_controller.rb
+- test/dummy/app/controllers/concerns/.keep
+- test/dummy/app/helpers/application_helper.rb
+- test/dummy/app/jobs/application_job.rb
+- test/dummy/app/mailers/application_mailer.rb
+- test/dummy/app/models/application_record.rb
+- test/dummy/app/models/concerns/.keep
+- test/dummy/app/models/group.rb
+- test/dummy/app/views/layouts/application.html.erb
+- test/dummy/app/views/layouts/mailer.html.erb
+- test/dummy/app/views/layouts/mailer.text.erb
+- test/dummy/bin/bundle
+- test/dummy/bin/rails
+- test/dummy/bin/rake
+- test/dummy/bin/setup
+- test/dummy/bin/update
+- test/dummy/bin/yarn
+- test/dummy/config.ru
+- test/dummy/config/application.rb
+- test/dummy/config/boot.rb
+- test/dummy/config/cable.yml
+- test/dummy/config/database.yml
+- test/dummy/config/environment.rb
+- test/dummy/config/environments/development.rb
+- test/dummy/config/environments/production.rb
+- test/dummy/config/environments/test.rb
+- test/dummy/config/initializers/application_controller_renderer.rb
+- test/dummy/config/initializers/assets.rb
+- test/dummy/config/initializers/backtrace_silencers.rb
+- test/dummy/config/initializers/cookies_serializer.rb
+- test/dummy/config/initializers/filter_parameter_logging.rb
+- test/dummy/config/initializers/inflections.rb
+- test/dummy/config/initializers/mime_types.rb
+- test/dummy/config/initializers/rails_ops.rb
+- test/dummy/config/initializers/wrap_parameters.rb
+- test/dummy/config/locales/en.yml
+- test/dummy/config/puma.rb
+- test/dummy/config/routes.rb
+- test/dummy/config/secrets.yml
+- test/dummy/config/spring.rb
+- test/dummy/db/schema.rb
+- test/dummy/lib/assets/.keep
+- test/dummy/log/.keep
+- test/dummy/package.json
+- test/dummy/public/404.html
+- test/dummy/public/422.html
+- test/dummy/public/500.html
+- test/dummy/public/apple-touch-icon-precomposed.png
+- test/dummy/public/apple-touch-icon.png
+- test/dummy/public/favicon.ico
+- test/dummy/tmp/.keep
 - test/test_helper.rb
+- test/unit/rails_ops/operation/model/create_test.rb
+- test/unit/rails_ops/operation/model/load_test.rb
+- test/unit/rails_ops/operation/model/update_test.rb
+- test/unit/rails_ops/operation/model_test.rb
+- test/unit/rails_ops/operation_test.rb
 homepage: 
 licenses: []
 metadata: {}
@@ -269,5 +290,69 @@ summary: An operations service layer for rails projects.
 test_files:
 - test/db/models.rb
 - test/db/schema.rb
-- test/rails_ops/operation/example_test.rb
+- test/dummy/Rakefile
+- test/dummy/app/assets/config/manifest.js
+- test/dummy/app/assets/images/.keep
+- test/dummy/app/assets/javascripts/application.js
+- test/dummy/app/assets/javascripts/cable.js
+- test/dummy/app/assets/javascripts/channels/.keep
+- test/dummy/app/assets/stylesheets/application.css
+- test/dummy/app/channels/application_cable/channel.rb
+- test/dummy/app/channels/application_cable/connection.rb
+- test/dummy/app/controllers/application_controller.rb
+- test/dummy/app/controllers/concerns/.keep
+- test/dummy/app/helpers/application_helper.rb
+- test/dummy/app/jobs/application_job.rb
+- test/dummy/app/mailers/application_mailer.rb
+- test/dummy/app/models/application_record.rb
+- test/dummy/app/models/concerns/.keep
+- test/dummy/app/models/group.rb
+- test/dummy/app/views/layouts/application.html.erb
+- test/dummy/app/views/layouts/mailer.html.erb
+- test/dummy/app/views/layouts/mailer.text.erb
+- test/dummy/bin/bundle
+- test/dummy/bin/rails
+- test/dummy/bin/rake
+- test/dummy/bin/setup
+- test/dummy/bin/update
+- test/dummy/bin/yarn
+- test/dummy/config.ru
+- test/dummy/config/application.rb
+- test/dummy/config/boot.rb
+- test/dummy/config/cable.yml
+- test/dummy/config/database.yml
+- test/dummy/config/environment.rb
+- test/dummy/config/environments/development.rb
+- test/dummy/config/environments/production.rb
+- test/dummy/config/environments/test.rb
+- test/dummy/config/initializers/application_controller_renderer.rb
+- test/dummy/config/initializers/assets.rb
+- test/dummy/config/initializers/backtrace_silencers.rb
+- test/dummy/config/initializers/cookies_serializer.rb
+- test/dummy/config/initializers/filter_parameter_logging.rb
+- test/dummy/config/initializers/inflections.rb
+- test/dummy/config/initializers/mime_types.rb
+- test/dummy/config/initializers/rails_ops.rb
+- test/dummy/config/initializers/wrap_parameters.rb
+- test/dummy/config/locales/en.yml
+- test/dummy/config/puma.rb
+- test/dummy/config/routes.rb
+- test/dummy/config/secrets.yml
+- test/dummy/config/spring.rb
+- test/dummy/db/schema.rb
+- test/dummy/lib/assets/.keep
+- test/dummy/log/.keep
+- test/dummy/package.json
+- test/dummy/public/404.html
+- test/dummy/public/422.html
+- test/dummy/public/500.html
+- test/dummy/public/apple-touch-icon-precomposed.png
+- test/dummy/public/apple-touch-icon.png
+- test/dummy/public/favicon.ico
+- test/dummy/tmp/.keep
 - test/test_helper.rb
+- test/unit/rails_ops/operation/model/create_test.rb
+- test/unit/rails_ops/operation/model/load_test.rb
+- test/unit/rails_ops/operation/model/update_test.rb
+- test/unit/rails_ops/operation/model_test.rb
+- test/unit/rails_ops/operation_test.rb