rails_onboarding 0.8.3 → 0.8.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98452f929df5910d698c5309c4bb1b1c2e5e9d4e3322f41ec4a4407b14bea0b4
-  data.tar.gz: ea59a57c10f7fa497a4c1cfce14ff3b9f828e0b645fc1e652c08087e8c07ff09
+  metadata.gz: f8afb9ad8022edcb79752a590ddc52652c947b42be298065194aa28399347fcc
+  data.tar.gz: 46d9cfba7ca062ea59075ab52d796a250691e1fcddc58f53438f049af131d2e3
 SHA512:
-  metadata.gz: f26e666c6aca70b79c69aa9b1d25e83ffb2be711bf9249bb1061ca9f76d57c7c7526f1a6d8ac0a8a25e9ae4135cc35ffe01956b65cd6b5931e00540f4676d43b
-  data.tar.gz: eeae8264bc96aa699ba8b86a9d29c15ae5ebe2355475c74df0b1b877eb8217c137688dee247e4445956a1a13135deb02f7f7592a5f6c1e738b7868012e351aa3
+  metadata.gz: d933e36a68ab7d438a06c2dea6dcbf7536d90ae9e5df4e060bf5bd2bccd503f24ff0061c2a1fb40046fbeefd2d211552c0750b9f48bac05e61db027ba02936df
+  data.tar.gz: 295d2dc68da00f371d82a592f3355a691d49732270fb45dcc3992958a3cb9d1501cd2433bae931a2b15d661a7b1b9925e9727023f1d7a7759a42d2640bd200c1

data/app/models/concerns/rails_onboarding/progressive_disclosure.rb

@@ -242,12 +242,23 @@ module RailsOnboarding
 
     # Check if milestone-based feature is ready
     def milestone_based_ready?(feature)
-      return false unless respond_to?(:earned_milestones)
+      # Onboardable exposes the awarded keys as #achieved_milestones. This used
+      # to guard on #earned_milestones, which the engine has never defined, so
+      # the guard was false for every host and a :milestone_based feature was
+      # never revealed to anyone - silently, since a reveal that does not happen
+      # looks exactly like one whose condition is not met yet. #earned_milestones
+      # is still honoured for any host that defines it itself.
+      milestones = if respond_to?(:achieved_milestones)
+                     achieved_milestones
+      elsif respond_to?(:earned_milestones)
+                     earned_milestones
+      end
+      return false unless milestones
 
       required_milestone = feature[:required_milestone]
       return false unless required_milestone
 
-      earned_milestones.include?(required_milestone.to_s)
+      milestones.map(&:to_s).include?(required_milestone.to_s)
     end
 
     # Check if engagement-based feature is ready

data/app/views/layouts/rails_onboarding/application.html.erb

@@ -6,7 +6,7 @@
       viewport and zooms out to fit the physical screen - everything (text,
       buttons, spacing) looks shrunk even though the CSS itself is correct. %>
   <meta name="viewport" content="width=device-width, initial-scale=1">
-  <title><%= Rails.application.class.module_parent.name %> Onboarding</title>
+  <title><%= RailsOnboarding.configuration.app_name.presence || Rails.application.class.module_parent.name %> Onboarding</title>
   <%= csrf_meta_tags %>
   <%= csp_meta_tag %>
 

data/lib/rails_onboarding/configuration.rb

@@ -33,7 +33,8 @@ module RailsOnboarding
     include RateLimiting
     include Templates
 
-    attr_accessor :user_class_name,
+    attr_accessor :app_name,
+                  :user_class_name,
                   :include_host_styles,
                   :redirect_after_completion,
                   :redirect_after_skip,
@@ -45,6 +46,11 @@ module RailsOnboarding
                   :admin_user_search
 
     def initialize
+      # What to call the host product on onboarding pages. Defaults to the Rails
+      # application's module name, which is a code identifier and often not what
+      # the product is actually called - "Gift" for an app called Gift Posse.
+      # nil keeps the derived name.
+      @app_name = nil
       @user_class_name = "User"
       @include_host_styles = true  # Default to including host app css
 

data/lib/rails_onboarding/version.rb

@@ -1,3 +1,3 @@
 module RailsOnboarding
-  VERSION = "0.8.3"
+  VERSION = "0.8.5"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_onboarding
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.8.5
 platform: ruby
 authors:
 - David Lewis
@@ -282,7 +282,7 @@ licenses:
 metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/bunnahabhain/rails_onboarding
-  source_code_uri: https://github.com/bunnahabhain/rails_onboarding/tree/v0.8.3
+  source_code_uri: https://github.com/bunnahabhain/rails_onboarding/tree/v0.8.5
   changelog_uri: https://github.com/bunnahabhain/rails_onboarding/blob/master/docs/CHANGELOG.md
 rdoc_options: []
 require_paths: