rails_onboarding 0.8.2 → 0.8.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a33d58aa73f7c851196a6ed683c0a907eabc60addda69cc841206ef7765201e
-  data.tar.gz: 28b37e7d218f6503e256e35292eb71c48a2074bb18f89be4581e417a98365cc0
+  metadata.gz: 007cab6c758c3d50c9c2b9dca6c8f798956b6c09d61a0078de8c347f2b857395
+  data.tar.gz: d431ee736da8d5de6af011483929f64cefd5da668844d88934ad48d30e3af5a1
 SHA512:
-  metadata.gz: b1e1fa8588b97a8402ae6f68c0c968e88a0e8229fff82f9f1e79249bfec60b067f465369800241f56bcf63543663d979dcc5dbb14eefabd7982af921695edcaa
-  data.tar.gz: eb6c36a63a60df9e93e83713022ffa175d6579fba9cd9b73246f1a82f8c1cc7fa165729b8d5f852564d494e246e7e0b099fcd3a6478bf184cb5a7d1e36ec125a
+  metadata.gz: b6f99c18d8a9e4143aa445392866e46e88561ec28e51f8d29a72c37458eecfbab311bed79ed9c400104849ba2669acecc8307464a5bbb8edbe3001543df763ec
+  data.tar.gz: c4db1b37aeec6472fb839ac1647f8d4ddc9fd1f643e4118e889e0a14db9a5ec1b9793bd3d3af0cfbb1f1550cced75c5439216f8a3c1b7f26402bf26d276a0dfb

data/app/controllers/rails_onboarding/milestones_controller.rb

@@ -112,7 +112,15 @@ module RailsOnboarding
     private
 
     def authenticate_user!
-      unless respond_to?(:current_user) && current_user
+      # respond_to? omits private methods, and a host app that hand-rolls
+      # authentication commonly keeps current_user private - a public method on
+      # a controller can be reached as an action. Without the second argument
+      # this guard is false for every such host and the page is unreachable no
+      # matter who is signed in. (Gift Posse is exactly that shape.) The helper
+      # and layout uses of respond_to?(:current_user) elsewhere are fine as they
+      # stand: they run in view context, where helper_method has already defined
+      # a public current_user.
+      unless respond_to?(:current_user, true) && current_user
         redirect_to main_app.root_path, alert: "Please log in to view milestones"
       end
     end

data/app/models/concerns/rails_onboarding/progressive_disclosure.rb

@@ -242,12 +242,23 @@ module RailsOnboarding
 
     # Check if milestone-based feature is ready
     def milestone_based_ready?(feature)
-      return false unless respond_to?(:earned_milestones)
+      # Onboardable exposes the awarded keys as #achieved_milestones. This used
+      # to guard on #earned_milestones, which the engine has never defined, so
+      # the guard was false for every host and a :milestone_based feature was
+      # never revealed to anyone - silently, since a reveal that does not happen
+      # looks exactly like one whose condition is not met yet. #earned_milestones
+      # is still honoured for any host that defines it itself.
+      milestones = if respond_to?(:achieved_milestones)
+                     achieved_milestones
+      elsif respond_to?(:earned_milestones)
+                     earned_milestones
+      end
+      return false unless milestones
 
       required_milestone = feature[:required_milestone]
       return false unless required_milestone
 
-      earned_milestones.include?(required_milestone.to_s)
+      milestones.map(&:to_s).include?(required_milestone.to_s)
     end
 
     # Check if engagement-based feature is ready

data/lib/rails_onboarding/version.rb

@@ -1,3 +1,3 @@
 module RailsOnboarding
-  VERSION = "0.8.2"
+  VERSION = "0.8.4"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_onboarding
 version: !ruby/object:Gem::Version
-  version: 0.8.2
+  version: 0.8.4
 platform: ruby
 authors:
 - David Lewis
@@ -282,7 +282,7 @@ licenses:
 metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/bunnahabhain/rails_onboarding
-  source_code_uri: https://github.com/bunnahabhain/rails_onboarding/tree/v0.8.2
+  source_code_uri: https://github.com/bunnahabhain/rails_onboarding/tree/v0.8.4
   changelog_uri: https://github.com/bunnahabhain/rails_onboarding/blob/master/docs/CHANGELOG.md
 rdoc_options: []
 require_paths: