rails_onboarding 0.8.12 → 0.8.13

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 532f89d681d2a2bf5cdf575a99b26742497707b65c1109525f51307d09bc50c6
-  data.tar.gz: 6f5e6c0c374b350ac09ac25c36846ad93eee2c2e10d31a531629f65cb19062f7
+  metadata.gz: 593e5e47988a8b3f81d6ea034f186669a099d98b09707723ed723128bcdad01d
+  data.tar.gz: 790f85934b3f9573cc6421488b882fcf3ac80340e27a0b6b587cc2de93bcdcab
 SHA512:
-  metadata.gz: 68277199c94e5109304653b498934f8971779b6fe58696133b992b365753527545b06982f013e75faa2fd34e4cb7f71f4730937c2c599da30efdbd0a218d7f7e
-  data.tar.gz: f2b95e0a399d1981f5f01783231179ea62d7398e8145f0aed809e0621f158c8949e1152c8305f9c5f05daf328350eddf4a293885f954dfa99400c5bf8dac491f
+  metadata.gz: f9bc4b4bd26ace6d84e153b906a0b687035e6d0ccb1b81d13ed15f6219bcc1e7be6c02ae30aa85658fc3c79933c5a7c374243bdffc9bf0197b923172ce1c2a36
+  data.tar.gz: 1d1bed61cc8462db8e23fe1e92a114d7df9be93cc7254e6f0cecfe8d56a8fcae765ffe072769c768044f5315795510c0c9533339f9835ac57fc48213a6f83e77

data/app/models/concerns/rails_onboarding/onboardable.rb

@@ -7,6 +7,45 @@ module RailsOnboarding
     MAX_MILESTONES_ACHIEVED = 500
     MAX_JSON_SIZE_BYTES = 65_535 # ~64KB for TEXT columns
 
+    # Whether the host model's table can be inspected right now.
+    #
+    # `columns_hash` and `column_names` both query the database, and the
+    # `included do` block below runs the moment the host model is loaded --
+    # which can be long before that table exists. A host that references its
+    # user model from an initializer hits this immediately: the common OmniAuth
+    # `:identity` setup passes `model: User`, so the model loads during boot,
+    # the include queries `columns_hash`, and against an empty database the
+    # whole process dies with "Table 'users' doesn't exist".
+    #
+    # That is circular and unrecoverable: loading the schema requires booting
+    # the app, and booting the app requires the schema. It stops `db:prepare`
+    # bootstrapping a genuinely new database, a restore into an empty schema,
+    # and CI against a fresh database service.
+    #
+    # A missing table, a missing database and an absent connection all mean the
+    # same thing here -- the column types cannot be known yet -- so degrade
+    # instead of raising. Nothing is lost: a process that boots against an empty
+    # database is bootstrapping it, not serving from it, and the next process
+    # configures everything normally once the schema is in place.
+    #
+    # Only ever answers false when the table is positively known to be absent.
+    # This concern is deliberately includable into plain classes that are not
+    # ActiveRecord models -- hence the `respond_to?(:has_many)` and
+    # `respond_to?(:validate)` guards below -- and such a class has no
+    # `table_exists?` while still answering `columns_hash`. Saying "not
+    # available" for those would silently stop configuring them, so anything
+    # that cannot be asked is treated as queryable and left to the callers'
+    # own guards, exactly as before this check existed.
+    def self.columns_queryable?(model)
+      return true unless model.respond_to?(:table_exists?)
+
+      model.table_exists?
+    rescue ActiveRecord::NoDatabaseError,
+           ActiveRecord::ConnectionNotEstablished,
+           ActiveRecord::StatementInvalid
+      false
+    end
+
     included do
       # Add fields via migration or expect them in the host model
       # The host app should have these columns:
@@ -21,17 +60,21 @@ module RailsOnboarding
       # - onboarding_replay_started_at: datetime
       # - onboarding_replay_steps: text (serialized JSON array)
 
-      # Fix for Rails 8: Use the new serialize syntax
-      if columns_hash["feature_tooltips_shown"]&.type == :text
-        serialize :feature_tooltips_shown, coder: JSON
-      end
+      # Fix for Rails 8: Use the new serialize syntax.
+      # Guarded because columns_hash queries the database -- see
+      # Onboardable.columns_queryable? above.
+      if RailsOnboarding::Onboardable.columns_queryable?(self)
+        if columns_hash["feature_tooltips_shown"]&.type == :text
+          serialize :feature_tooltips_shown, coder: JSON
+        end
 
-      if columns_hash["milestones_achieved"]&.type == :text
-        serialize :milestones_achieved, coder: JSON
-      end
+        if columns_hash["milestones_achieved"]&.type == :text
+          serialize :milestones_achieved, coder: JSON
+        end
 
-      if columns_hash["onboarding_replay_steps"]&.type == :text
-        serialize :onboarding_replay_steps, coder: JSON
+        if columns_hash["onboarding_replay_steps"]&.type == :text
+          serialize :onboarding_replay_steps, coder: JSON
+        end
       end
 
       # Association with analytics events (only if ActiveRecord is available)
@@ -56,6 +99,7 @@ module RailsOnboarding
       # than raising on a column that isn't there.
       def onboarding_replay_supported?
         return false unless respond_to?(:column_names)
+        return false unless RailsOnboarding::Onboardable.columns_queryable?(self)
 
         column_names.include?("onboarding_replay_started_at") &&
           column_names.include?("onboarding_replay_steps")

data/lib/rails_onboarding/version.rb

@@ -1,3 +1,3 @@
 module RailsOnboarding
-  VERSION = "0.8.12"
+  VERSION = "0.8.13"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_onboarding
 version: !ruby/object:Gem::Version
-  version: 0.8.12
+  version: 0.8.13
 platform: ruby
 authors:
 - David Lewis
@@ -282,7 +282,7 @@ licenses:
 metadata:
   allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/bunnahabhain/rails_onboarding
-  source_code_uri: https://github.com/bunnahabhain/rails_onboarding/tree/v0.8.12
+  source_code_uri: https://github.com/bunnahabhain/rails_onboarding/tree/v0.8.13
   changelog_uri: https://github.com/bunnahabhain/rails_onboarding/blob/master/docs/CHANGELOG.md
 rdoc_options: []
 require_paths: