rails_modal_manager 1.0.41 → 1.0.43

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5884364bb07444f45c08e4733c5623883a775592ba853a1275f5f2bd84bb5c03
-  data.tar.gz: 06a78be76359c81f55ec9e904488a1f3d961fdababf4bb8b31c24d0d19a8b7e1
+  metadata.gz: 37be545accc1417617473c793c6141fbf2ab14d6ca3bf1bf8279a0c008749bdf
+  data.tar.gz: dd2b26619197fedab1629888b9d07f7c9946f1639e5c824eb980b424d8850c64
 SHA512:
-  metadata.gz: 985fca2add00de7fca1c9c5d05d66be9b8a6dbc208526de6811dad2c4b27977be9aa332dce1287d561d0fe04c3ec365768abbeeac89f582f07af8250aed843e2
-  data.tar.gz: ab10ad1ad3a86cd5a6ad64af536d015cbfeccc030523e03c980c74cb042cab25bd70bd936cd7247980097a18140d2c0969f18c9afb6c6df8fc66301c959c4232
+  metadata.gz: 29970d10f36b4576572d2459f6a9dc6eeaf459242757072788b02b0af57a331b6a142039186a805cd3ce42669dd0f4c46c6546618c71cbf6e0fd9e21679e5aae
+  data.tar.gz: b67c38c317b8cca2b2855b9f881279e423f8bb6324b4c844dc19569ee46cafbbf8c417c93d4b71dde9291a578d3113be10f333a57c0613acd4670f652dbef8a8

data/app/javascript/rails_modal_manager/controllers/rmm_header_controller.js

@@ -16,18 +16,24 @@ export default class extends Controller {
   connect() {
     // Listen for sidebar toggled event to update icon
     this.handleSidebarToggled = this.handleSidebarToggled.bind(this)
+    this.handleModalClosed = this.handleModalClosed.bind(this)
+
     const modal = this.element.closest('.rmm-modal')
     if (modal) {
       modal.addEventListener('rmm-sidebar:toggled', this.handleSidebarToggled)
+      modal.addEventListener('rmm:closed', this.handleModalClosed)
     }
 
-    // Title 더블클릭 이벤트 리스너 추가
+    // Title 더블클릭 이벤트 리스너 추가 및 원래 title 저장
     this.setupTitleEdit()
   }
 
   setupTitleEdit() {
     const titleEl = this.element.querySelector('.rmm-header-title')
     if (titleEl) {
+      // 원래 title 저장 (모달 닫힐 때 복원용)
+      this.originalTitle = titleEl.textContent.trim()
+
       titleEl.addEventListener('dblclick', (e) => this.editTitle(e))
       titleEl.style.cursor = 'default'
     }
@@ -37,6 +43,21 @@ export default class extends Controller {
     const modal = this.element.closest('.rmm-modal')
     if (modal) {
       modal.removeEventListener('rmm-sidebar:toggled', this.handleSidebarToggled)
+      modal.removeEventListener('rmm:closed', this.handleModalClosed)
+    }
+  }
+
+  // 모달 닫힐 때 title을 원래 값으로 복원
+  handleModalClosed() {
+    this.resetTitle()
+  }
+
+  resetTitle() {
+    if (!this.originalTitle) return
+
+    const titleEl = this.element.querySelector('.rmm-header-title')
+    if (titleEl) {
+      titleEl.textContent = this.originalTitle
     }
   }
 

data/app/javascript/rails_modal_manager/controllers/rmm_submenu_controller.js

@@ -44,6 +44,7 @@ export default class extends Controller {
   connect() {
     this.ajaxCache = new Map()
     this.currentItemId = null
+    this.currentAbortController = null
 
     // Find initial active item
     const activeItem = this.element.querySelector('.rmm-submenu-item.rmm-active')
@@ -140,6 +141,8 @@ export default class extends Controller {
 
   /**
    * AJAX mode: Load content from URL
+   * Uses AbortController to cancel previous pending requests and
+   * validates response against current active item to prevent race conditions.
    */
   async loadAjaxContent(item) {
     const url = item.dataset.url
@@ -161,12 +164,22 @@ export default class extends Controller {
       return
     }
 
+    // Abort previous pending request
+    if (this.currentAbortController) {
+      this.currentAbortController.abort()
+    }
+
+    const abortController = new AbortController()
+    this.currentAbortController = abortController
+    const requestItemId = item.dataset.itemId
+
     // Show loading state
     contentContainer.classList.add('rmm-tab-loading')
     contentContainer.innerHTML = '<div class="rmm-tab-loader"><div class="rmm-spinner"></div><span>로딩 중...</span></div>'
 
     try {
       const response = await fetch(url, {
+        signal: abortController.signal,
         headers: {
           'Accept': 'text/html',
           'X-Requested-With': 'XMLHttpRequest'
@@ -179,6 +192,11 @@ export default class extends Controller {
 
       const html = await response.text()
 
+      // Validate: only update if this request is still the current one
+      if (this.currentItemId !== requestItemId) {
+        return
+      }
+
       // Cache the response
       if (this.cacheAjaxValue) {
         this.ajaxCache.set(url, html)
@@ -192,6 +210,11 @@ export default class extends Controller {
         detail: { modalId: this.modalIdValue, itemId: item.dataset.itemId, fromCache: false }
       })
     } catch (error) {
+      // Ignore abort errors (expected when switching tabs quickly)
+      if (error.name === 'AbortError') {
+        return
+      }
+
       console.error('RMM Submenu: Failed to load content', error)
       contentContainer.innerHTML = `
         <div class="rmm-tab-error">

data/lib/rails_modal_manager/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsModalManager
-  VERSION = "1.0.41"
+  VERSION = "1.0.43"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_modal_manager
 version: !ruby/object:Gem::Version
-  version: 1.0.41
+  version: 1.0.43
 platform: ruby
 authors:
 - reshacs