rails_lens 0.5.1 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1bd96547bfc5ae90c3971f787bbb03cad57e8912ed25c4ea0005ab3652401408
-  data.tar.gz: 95f1bcfa75b796a22c1fd5fb861c79e41e048608648388d1d9b255b4a3466157
+  metadata.gz: 792f89c06b8c11b77fb6892aa7488397d068104e2f30b7c343e38039660b0a2f
+  data.tar.gz: d808455520cffa29f877e43ca8492a1e6dae238e231c641fe8ddd36663ba3d07
 SHA512:
-  metadata.gz: 960195b484708f9904f1d96d5f52e5fca70580431deffdc9a5cb56c99ab57af3509c33ad88eb7cdfa84c75067ea04f1d542568152cc60ab6dbcb162b036d1b61
-  data.tar.gz: da71bed238e3fa5742039fa0f931d4fc625f52a6d1df3cc831678bd070b65b38e6f3ea4b01b998c7e163409764db0aebfaab83af9a10733081d99513f6a80893
+  metadata.gz: a754d8353f7a75e11283af18fb2c128bdedec40bf673b5c2cae042d48c14d98dd3c7f26c118d81e0af09a836e0624a4ad2dbd5d092b7b64e4c8664aa9540df0f
+  data.tar.gz: 821f26b9307bfd92914e9c1e6266c3bad0db90c16593e98eb91c1878f9662b3409485a0f32d03d8a007fd1d73bb9f114faec367ce533c41699f01cc2b0b12dc9

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [0.5.3](https://github.com/seuros/rails_lens/compare/rails_lens/v0.5.2...rails_lens/v0.5.3) (2026-02-17)
+
+
+### Bug Fixes
+
+* handle edge cases table naming. ([dec95af](https://github.com/seuros/rails_lens/commit/dec95af7866a9ed3c5430974a1492749ca0a5f8e))
+
+## [0.5.2](https://github.com/seuros/rails_lens/compare/rails_lens/v0.5.1...rails_lens/v0.5.2) (2026-02-16)
+
+
+### Bug Fixes
+
+* reduce INVERSE_OF false positives for vanilla associations ([#39](https://github.com/seuros/rails_lens/issues/39)) ([b209c2a](https://github.com/seuros/rails_lens/commit/b209c2a6b2a894193561e9aa30985c3043b40ac3))
+
 ## [0.5.1](https://github.com/seuros/rails_lens/compare/rails_lens/v0.5.0...rails_lens/v0.5.1) (2025-12-07)
 
 

data/lib/rails_lens/analyzers/association_analyzer.rb

@@ -42,7 +42,7 @@ module RailsLens
       def associations_needing_inverse
         all_associations.select do |association|
           association.options[:inverse_of].nil? &&
-            !association.options[:through] &&
+            needs_explicit_inverse_of?(association) &&
             !association.polymorphic? &&
             bidirectional_association?(association)
         end
@@ -71,6 +71,16 @@ module RailsLens
         false
       end
 
+      def needs_explicit_inverse_of?(association)
+        # Rails can auto-infer inverse_of for vanilla associations
+        # Only require explicit inverse_of when using custom options
+        association.options[:class_name].present? ||
+          association.options[:foreign_key].present? ||
+          association.options[:as].present? ||
+          association.options[:source].present? ||
+          association.options[:through].present?
+      end
+
       def should_have_counter_cache?(association)
         return false unless association.macro == :belongs_to
 

data/lib/rails_lens/analyzers/callbacks.rb

@@ -116,23 +116,23 @@ module RailsLens
         case filter
         when Symbol
           # Check if method is defined in the model class itself
-          return true if model_class.instance_methods(false).include?(filter)
-          return true if model_class.private_instance_methods(false).include?(filter)
+          return true if model_class.method_defined?(filter, false)
+          return true if model_class.private_method_defined?(filter, false)
 
           # Check if defined in included concerns (non-Rails modules)
           model_class.included_modules.each do |mod|
             next if mod.name.nil?
             next if mod.name.start_with?('ActiveRecord', 'ActiveModel', 'ActiveSupport')
 
-            return true if mod.instance_methods(false).include?(filter)
-            return true if mod.private_instance_methods(false).include?(filter)
+            return true if mod.method_defined?(filter, false)
+            return true if mod.private_method_defined?(filter, false)
           end
 
           # For STI: check parent classes up to (but not including) ActiveRecord::Base
           klass = model_class.superclass
           while klass && klass < ActiveRecord::Base
-            return true if klass.instance_methods(false).include?(filter)
-            return true if klass.private_instance_methods(false).include?(filter)
+            return true if klass.method_defined?(filter, false)
+            return true if klass.private_method_defined?(filter, false)
 
             klass = klass.superclass
           end

data/lib/rails_lens/analyzers/composite_keys.rb

@@ -35,7 +35,7 @@ module RailsLens
 
       def detect_composite_primary_key_from_db
         # Query PostgreSQL system catalogs to find composite primary keys
-        sql = <<-SQL.squish
+        sql = <<~SQL.squish
           SELECT a.attname
           FROM pg_index i
           JOIN pg_attribute a ON a.attrelid = i.indrelid AND a.attnum = ANY(i.indkey)

data/lib/rails_lens/analyzers/generated_columns.rb

@@ -22,7 +22,7 @@ module RailsLens
 
       def detect_generated_columns
         # PostgreSQL system query to find generated columns
-        sql = <<-SQL.squish
+        sql = <<~SQL.squish
           SELECT
             a.attname AS column_name,
             pg_get_expr(d.adbin, d.adrelid) AS generation_expression

data/lib/rails_lens/analyzers/notes.rb

@@ -312,8 +312,7 @@ module RailsLens
       def associations_needing_inverse
         associations.select do |association|
           association.options[:inverse_of].nil? &&
-            !association.options[:through] &&
-            !association.options[:as] &&
+            needs_explicit_inverse_of?(association) &&
             association.macro != :has_and_belongs_to_many
         end
       end
@@ -418,6 +417,16 @@ module RailsLens
         RailsLens.logger.debug { "Error checking view existence for #{view_name}: #{e.message}" }
         false
       end
+
+      def needs_explicit_inverse_of?(association)
+        # Rails can auto-infer inverse_of for vanilla associations
+        # Only require explicit inverse_of when using custom options
+        association.options[:class_name].present? ||
+          association.options[:foreign_key].present? ||
+          association.options[:as].present? ||
+          association.options[:source].present? ||
+          association.options[:through].present?
+      end
     end
   end
 end

data/lib/rails_lens/model_detector.rb

@@ -78,13 +78,38 @@ module RailsLens
 
       # rubocop:disable Naming/PredicateMethod
       def check_postgresql_view(connection, table_name)
+        # Handle schema-qualified table names (e.g., 'audit.audit_logs')
+        if table_name.include?('.')
+          schema_name, unqualified_name = table_name.split('.', 2)
+          schema_filter = "'#{connection.quote_string(schema_name)}'"
+          table_to_check = unqualified_name
+        else
+          # Extract search_path schemas for unqualified table names
+          search_path = connection.schema_search_path
+            .split(',')
+            .map(&:strip)
+            .reject { |s| s == '"$user"' || s.empty? }
+
+          # Default to 'public' if search_path is empty
+          search_path = ['public'] if search_path.empty?
+
+          schema_filter = search_path.map { |s| "'#{connection.quote_string(s)}'" }.join(', ')
+          table_to_check = table_name
+        end
+
         # Check both regular views and materialized views
+        # Exclude system schemas to prevent false positives when user table names
+        # match PostgreSQL system view names (e.g., 'triggers', 'tables', 'columns')
         result = connection.exec_query(<<~SQL.squish, 'Check PostgreSQL View')
           SELECT 1 FROM information_schema.views
-          WHERE table_name = '#{connection.quote_string(table_name)}'
+          WHERE table_name = '#{connection.quote_string(table_to_check)}'
+          AND table_schema IN (#{schema_filter})
+          AND table_schema NOT IN ('information_schema', 'pg_catalog', 'pg_toast')
           UNION ALL
           SELECT 1 FROM pg_matviews
-          WHERE matviewname = '#{connection.quote_string(table_name)}'
+          WHERE matviewname = '#{connection.quote_string(table_to_check)}'
+          AND schemaname IN (#{schema_filter})
+          AND schemaname NOT IN ('information_schema', 'pg_catalog', 'pg_toast')
           LIMIT 1
         SQL
         result.rows.any?

data/lib/rails_lens/schema/adapters/database_info.rb

@@ -84,7 +84,7 @@ module RailsLens
         def extensions
           return [] unless adapter_name == 'PostgreSQL'
 
-          connection.select_all(<<-SQL.squish).to_a
+          connection.select_all(<<~SQL.squish).to_a
             SELECT extname as name, extversion as version
             FROM pg_extension
             WHERE extname NOT IN ('plpgsql')
@@ -97,7 +97,7 @@ module RailsLens
         def schemas
           return [] unless adapter_name == 'PostgreSQL'
 
-          connection.select_values(<<-SQL.squish)
+          connection.select_values(<<~SQL.squish)
             SELECT schema_name
             FROM information_schema.schemata
             WHERE schema_name NOT IN ('pg_catalog', 'information_schema', 'pg_toast')

data/lib/rails_lens/schema/adapters/mysql.rb

@@ -211,12 +211,12 @@ module RailsLens
         def has_partitions?
           return false unless connection.respond_to?(:execute)
 
-          result = connection.execute(<<-SQL.squish)
-          SELECT COUNT(*) as count
-          FROM information_schema.partitions
-          WHERE table_schema = DATABASE()
-            AND table_name = '#{table_name}'
-            AND partition_name IS NOT NULL
+          result = connection.execute(<<~SQL.squish)
+            SELECT COUNT(*) as count
+            FROM information_schema.partitions
+            WHERE table_schema = DATABASE()
+              AND table_name = '#{table_name}'
+              AND partition_name IS NOT NULL
           SQL
 
           count = if result.first.is_a?(Hash)
@@ -241,13 +241,13 @@ module RailsLens
         def add_partitions(lines)
           return unless connection.respond_to?(:execute)
 
-          partitions = connection.execute(<<-SQL.squish)
-          SELECT partition_name, partition_expression, partition_description
-          FROM information_schema.partitions
-          WHERE table_schema = DATABASE()
-            AND table_name = '#{table_name}'
-            AND partition_name IS NOT NULL
-          ORDER BY partition_ordinal_position
+          partitions = connection.execute(<<~SQL.squish)
+            SELECT partition_name, partition_expression, partition_description
+            FROM information_schema.partitions
+            WHERE table_schema = DATABASE()
+              AND table_name = '#{table_name}'
+              AND partition_name IS NOT NULL
+            ORDER BY partition_ordinal_position
           SQL
 
           return if partitions.none?
@@ -269,13 +269,13 @@ module RailsLens
         def add_partitions_toml(lines)
           return unless connection.respond_to?(:execute)
 
-          partitions = connection.execute(<<-SQL.squish)
-          SELECT partition_name, partition_expression, partition_description
-          FROM information_schema.partitions
-          WHERE table_schema = DATABASE()
-            AND table_name = '#{table_name}'
-            AND partition_name IS NOT NULL
-          ORDER BY partition_ordinal_position
+          partitions = connection.execute(<<~SQL.squish)
+            SELECT partition_name, partition_expression, partition_description
+            FROM information_schema.partitions
+            WHERE table_schema = DATABASE()
+              AND table_name = '#{table_name}'
+              AND partition_name IS NOT NULL
+            ORDER BY partition_ordinal_position
           SQL
 
           return if partitions.none?

data/lib/rails_lens/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsLens
-  VERSION = '0.5.1'
+  VERSION = '0.5.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_lens
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.3
 platform: ruby
 authors:
 - Abdelkader Boudih
@@ -270,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Comprehensive Rails application visualization and annotation
 test_files: []