rails_lens 0.5.0 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 983d1382bf42b79549a4a504e696814846eccf606cd17f9fc3e521cce211f729
-  data.tar.gz: 69714d9bfaf91dc139158649596b8111b6910d7515adb9be9928476ff95e6c3a
+  metadata.gz: 5180524144ca10c72173e0410e924877e7de878379a7924a0931adba19be185b
+  data.tar.gz: 4b76f310866feb24bb206b9004a4091c78553c147e9e0114131a693eb1d78097
 SHA512:
-  metadata.gz: e580de20d715134c6066995921030e9aaf27ecdce188f455b93eb4bfd3b84d1bf9fcce109d75fe0d0fd340fd856c428d8da0e338e5d3b97299efc60098f72ebd
-  data.tar.gz: b069e0140d3ff3924b4f0ba18695f7646a88167a797e10bdd35d5fb25783ac2f8c7c305e59b22458b1424be22b75c494d2ab37b6f4d4d79448ee189624c869aa
+  metadata.gz: 655c2c927177454346c7b0dae09c4faaed881e2df93941c27a29511ba2c48dd5e42742f426036c0187f60bfa631ec60941e0e00de8b26b91012ef6e6a4727a9f
+  data.tar.gz: b7d9465fdb5daa3ed000dbca03c673a39fc8c7141ccebeb3d7c050d478358b99ba25a95c1f425365472d75c1ed06cf1cc4e332f78e0015a1bd289bf8eb5beff9

data/CHANGELOG.md

@@ -1,5 +1,19 @@
 # Changelog
 
+## [0.5.2](https://github.com/seuros/rails_lens/compare/rails_lens/v0.5.1...rails_lens/v0.5.2) (2026-02-16)
+
+
+### Bug Fixes
+
+* reduce INVERSE_OF false positives for vanilla associations ([#39](https://github.com/seuros/rails_lens/issues/39)) ([b209c2a](https://github.com/seuros/rails_lens/commit/b209c2a6b2a894193561e9aa30985c3043b40ac3))
+
+## [0.5.1](https://github.com/seuros/rails_lens/compare/rails_lens/v0.5.0...rails_lens/v0.5.1) (2025-12-07)
+
+
+### Bug Fixes
+
+* add by_source ([f6693f3](https://github.com/seuros/rails_lens/commit/f6693f384761de505eac0e525c7b70f4c053d14c))
+
 ## [0.5.0](https://github.com/seuros/rails_lens/compare/rails_lens/v0.3.0...rails_lens/v0.5.0) (2025-12-06)
 
 

data/lib/rails_lens/analyzers/association_analyzer.rb

@@ -42,7 +42,7 @@ module RailsLens
       def associations_needing_inverse
         all_associations.select do |association|
           association.options[:inverse_of].nil? &&
-            !association.options[:through] &&
+            needs_explicit_inverse_of?(association) &&
             !association.polymorphic? &&
             bidirectional_association?(association)
         end
@@ -71,6 +71,16 @@ module RailsLens
         false
       end
 
+      def needs_explicit_inverse_of?(association)
+        # Rails can auto-infer inverse_of for vanilla associations
+        # Only require explicit inverse_of when using custom options
+        association.options[:class_name].present? ||
+          association.options[:foreign_key].present? ||
+          association.options[:as].present? ||
+          association.options[:source].present? ||
+          association.options[:through].present?
+      end
+
       def should_have_counter_cache?(association)
         return false unless association.macro == :belongs_to
 

data/lib/rails_lens/analyzers/callbacks.rb

@@ -116,23 +116,23 @@ module RailsLens
         case filter
         when Symbol
           # Check if method is defined in the model class itself
-          return true if model_class.instance_methods(false).include?(filter)
-          return true if model_class.private_instance_methods(false).include?(filter)
+          return true if model_class.method_defined?(filter, false)
+          return true if model_class.private_method_defined?(filter, false)
 
           # Check if defined in included concerns (non-Rails modules)
           model_class.included_modules.each do |mod|
             next if mod.name.nil?
             next if mod.name.start_with?('ActiveRecord', 'ActiveModel', 'ActiveSupport')
 
-            return true if mod.instance_methods(false).include?(filter)
-            return true if mod.private_instance_methods(false).include?(filter)
+            return true if mod.method_defined?(filter, false)
+            return true if mod.private_method_defined?(filter, false)
           end
 
           # For STI: check parent classes up to (but not including) ActiveRecord::Base
           klass = model_class.superclass
           while klass && klass < ActiveRecord::Base
-            return true if klass.instance_methods(false).include?(filter)
-            return true if klass.private_instance_methods(false).include?(filter)
+            return true if klass.method_defined?(filter, false)
+            return true if klass.private_method_defined?(filter, false)
 
             klass = klass.superclass
           end

data/lib/rails_lens/analyzers/composite_keys.rb

@@ -35,7 +35,7 @@ module RailsLens
 
       def detect_composite_primary_key_from_db
         # Query PostgreSQL system catalogs to find composite primary keys
-        sql = <<-SQL.squish
+        sql = <<~SQL.squish
           SELECT a.attname
           FROM pg_index i
           JOIN pg_attribute a ON a.attrelid = i.indrelid AND a.attnum = ANY(i.indkey)

data/lib/rails_lens/analyzers/generated_columns.rb

@@ -22,7 +22,7 @@ module RailsLens
 
       def detect_generated_columns
         # PostgreSQL system query to find generated columns
-        sql = <<-SQL.squish
+        sql = <<~SQL.squish
           SELECT
             a.attname AS column_name,
             pg_get_expr(d.adbin, d.adrelid) AS generation_expression

data/lib/rails_lens/analyzers/notes.rb

@@ -312,8 +312,7 @@ module RailsLens
       def associations_needing_inverse
         associations.select do |association|
           association.options[:inverse_of].nil? &&
-            !association.options[:through] &&
-            !association.options[:as] &&
+            needs_explicit_inverse_of?(association) &&
             association.macro != :has_and_belongs_to_many
         end
       end
@@ -418,6 +417,16 @@ module RailsLens
         RailsLens.logger.debug { "Error checking view existence for #{view_name}: #{e.message}" }
         false
       end
+
+      def needs_explicit_inverse_of?(association)
+        # Rails can auto-infer inverse_of for vanilla associations
+        # Only require explicit inverse_of when using custom options
+        association.options[:class_name].present? ||
+          association.options[:foreign_key].present? ||
+          association.options[:as].present? ||
+          association.options[:source].present? ||
+          association.options[:through].present?
+      end
     end
   end
 end

data/lib/rails_lens/schema/adapters/database_info.rb

@@ -84,7 +84,7 @@ module RailsLens
         def extensions
           return [] unless adapter_name == 'PostgreSQL'
 
-          connection.select_all(<<-SQL.squish).to_a
+          connection.select_all(<<~SQL.squish).to_a
             SELECT extname as name, extversion as version
             FROM pg_extension
             WHERE extname NOT IN ('plpgsql')
@@ -97,7 +97,7 @@ module RailsLens
         def schemas
           return [] unless adapter_name == 'PostgreSQL'
 
-          connection.select_values(<<-SQL.squish)
+          connection.select_values(<<~SQL.squish)
             SELECT schema_name
             FROM information_schema.schemata
             WHERE schema_name NOT IN ('pg_catalog', 'information_schema', 'pg_toast')

data/lib/rails_lens/schema/adapters/mysql.rb

@@ -211,12 +211,12 @@ module RailsLens
         def has_partitions?
           return false unless connection.respond_to?(:execute)
 
-          result = connection.execute(<<-SQL.squish)
-          SELECT COUNT(*) as count
-          FROM information_schema.partitions
-          WHERE table_schema = DATABASE()
-            AND table_name = '#{table_name}'
-            AND partition_name IS NOT NULL
+          result = connection.execute(<<~SQL.squish)
+            SELECT COUNT(*) as count
+            FROM information_schema.partitions
+            WHERE table_schema = DATABASE()
+              AND table_name = '#{table_name}'
+              AND partition_name IS NOT NULL
           SQL
 
           count = if result.first.is_a?(Hash)
@@ -241,13 +241,13 @@ module RailsLens
         def add_partitions(lines)
           return unless connection.respond_to?(:execute)
 
-          partitions = connection.execute(<<-SQL.squish)
-          SELECT partition_name, partition_expression, partition_description
-          FROM information_schema.partitions
-          WHERE table_schema = DATABASE()
-            AND table_name = '#{table_name}'
-            AND partition_name IS NOT NULL
-          ORDER BY partition_ordinal_position
+          partitions = connection.execute(<<~SQL.squish)
+            SELECT partition_name, partition_expression, partition_description
+            FROM information_schema.partitions
+            WHERE table_schema = DATABASE()
+              AND table_name = '#{table_name}'
+              AND partition_name IS NOT NULL
+            ORDER BY partition_ordinal_position
           SQL
 
           return if partitions.none?
@@ -269,13 +269,13 @@ module RailsLens
         def add_partitions_toml(lines)
           return unless connection.respond_to?(:execute)
 
-          partitions = connection.execute(<<-SQL.squish)
-          SELECT partition_name, partition_expression, partition_description
-          FROM information_schema.partitions
-          WHERE table_schema = DATABASE()
-            AND table_name = '#{table_name}'
-            AND partition_name IS NOT NULL
-          ORDER BY partition_ordinal_position
+          partitions = connection.execute(<<~SQL.squish)
+            SELECT partition_name, partition_expression, partition_description
+            FROM information_schema.partitions
+            WHERE table_schema = DATABASE()
+              AND table_name = '#{table_name}'
+              AND partition_name IS NOT NULL
+            ORDER BY partition_ordinal_position
           SQL
 
           return if partitions.none?

data/lib/rails_lens/schema/annotation_manager.rb

@@ -148,12 +148,13 @@ module RailsLens
       end
 
       def self.annotate_all(options = {})
-        results = { annotated: [], skipped: [], failed: [] }
+        results = { annotated: [], skipped: [], failed: [], by_source: {} }
 
         # Iterate through all model sources
         ModelSourceLoader.load_sources.each do |source|
           puts "Annotating #{source.source_name} models..." if options[:verbose]
           source_results = annotate_source(source, options)
+          results[:by_source][source.source_name] = source_results[:annotated].length
           merge_results(results, source_results)
         end
 
@@ -312,12 +313,13 @@ module RailsLens
       end
 
       def self.remove_all(options = {})
-        results = { removed: [], skipped: [], failed: [] }
+        results = { removed: [], skipped: [], failed: [], by_source: {} }
 
         # Iterate through all model sources
         ModelSourceLoader.load_sources.each do |source|
           puts "Removing annotations from #{source.source_name} models..." if options[:verbose]
           source_results = remove_source(source, options)
+          results[:by_source][source.source_name] = source_results[:removed].length
           merge_remove_results(results, source_results)
         end
 

data/lib/rails_lens/tasks/annotate.rake

@@ -11,7 +11,13 @@ namespace :rails_lens do
 
     results = RailsLens::Schema::AnnotationManager.annotate_all(options)
 
-    puts "Annotated #{results[:annotated].length} models"
+    if results[:by_source]&.any?
+      results[:by_source].each do |source_name, count|
+        puts "Annotated #{count} #{source_name} models" if count.positive?
+      end
+    else
+      puts "Annotated #{results[:annotated].length} models"
+    end
     puts "Skipped #{results[:skipped].length} models" if results[:skipped].any?
     if results[:failed].any?
       puts "Failed to annotate #{results[:failed].length} models:"
@@ -27,7 +33,13 @@ namespace :rails_lens do
 
     results = RailsLens::Schema::AnnotationManager.remove_all
 
-    puts "Removed annotations from #{results[:removed].length} models" if results[:removed].any?
+    if results[:by_source]&.any?
+      results[:by_source].each do |source_name, count|
+        puts "Removed annotations from #{count} #{source_name} models" if count.positive?
+      end
+    elsif results[:removed].any?
+      puts "Removed annotations from #{results[:removed].length} models"
+    end
     puts "Skipped #{results[:skipped].length} models (no annotations)" if results[:skipped].any?
     if results[:failed].any?
       puts "Failed to remove annotations from #{results[:failed].length} models:"

data/lib/rails_lens/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsLens
-  VERSION = '0.5.0'
+  VERSION = '0.5.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_lens
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.2
 platform: ruby
 authors:
 - Abdelkader Boudih
@@ -270,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Comprehensive Rails application visualization and annotation
 test_files: []