rails_lens 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7eaa2e258c8608dfd893bb5220840fc9febce43478aca9573ae0dbb885b33bf5
-  data.tar.gz: ed99614fc744e7f32e6c439a8f61e99b5d94787a684c694fbca7ed1eb546e6c6
+  metadata.gz: 7b17142784a27f1ffd45512665eea05a135e1c97b0e1dcc38505f8a07b067ad0
+  data.tar.gz: 9ae11ad7619a74b5662a8b6bb2e767c33ad1523f5c6a2cf590cb809389d0ab9e
 SHA512:
-  metadata.gz: 0fc9a2a6d597e0d5a5e9b5e1c5eddf79bdca77448e780686fd28eabc26c5085829fe543595bdde05d31949a0e5ca42475bd379d89b9d552c128c06070d7a555c
-  data.tar.gz: 3982294a0d8a11b0ba516a7f90dc5595b488a3dcae79ef874c8d7d0cb0369f4a6438304adf1dd476d3aa8542bd445ec44022b549dcdeb48bf63084b5bebdd22d
+  metadata.gz: 7ebe5bfc79a4415138fc65f03f393796780e514a32f5226c0fbf66acb2d4d6dd2ac5e1b8878429f3383023f7489b5b40a35d9930876d8ffecf563a14f8bdbfb5
+  data.tar.gz: 2b40b476f42536db544130081063e3a0e992bbeda51d4ff993b4b3be3d0b8073a5ea00c3df98d57321de995d3dca6120f335fc9c2fca652abe3794cc4c704cdd

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.2.4](https://github.com/seuros/rails_lens/compare/rails_lens/v0.2.3...rails_lens/v0.2.4) (2025-07-31)
+
+
+### Bug Fixes
+
+* centralize connection management to prevent "too many clients" errors ([#10](https://github.com/seuros/rails_lens/issues/10)) ([1f9adf9](https://github.com/seuros/rails_lens/commit/1f9adf9b7dd0648add324492189c1322726da52f))
+
 ## [0.2.3](https://github.com/seuros/rails_lens/compare/rails_lens/v0.2.2...rails_lens/v0.2.3) (2025-07-31)
 
 

data/lib/rails_lens/analyzers/generated_columns.rb

@@ -25,7 +25,7 @@ module RailsLens
       def detect_generated_columns
         # PostgreSQL system query to find generated columns
         sql = <<-SQL.squish
-          SELECT#{' '}
+          SELECT
             a.attname AS column_name,
             pg_get_expr(d.adbin, d.adrelid) AS generation_expression
           FROM pg_attribute a

data/lib/rails_lens/analyzers/notes.rb

@@ -399,24 +399,24 @@ module RailsLens
         case @connection.adapter_name.downcase
         when 'postgresql'
           result = @connection.exec_query(<<~SQL.squish, 'Check PostgreSQL View Existence')
-            SELECT 1 FROM information_schema.views#{' '}
+            SELECT 1 FROM information_schema.views
             WHERE table_name = '#{@connection.quote_string(view_name)}'
             UNION ALL
-            SELECT 1 FROM pg_matviews#{' '}
+            SELECT 1 FROM pg_matviews
             WHERE matviewname = '#{@connection.quote_string(view_name)}'
             LIMIT 1
           SQL
           result.rows.any?
         when 'mysql', 'mysql2'
           result = @connection.exec_query(<<~SQL.squish, 'Check MySQL View Existence')
-            SELECT 1 FROM information_schema.views#{' '}
+            SELECT 1 FROM information_schema.views
             WHERE table_name = '#{@connection.quote_string(view_name)}'
             LIMIT 1
           SQL
           result.rows.any?
         when 'sqlite', 'sqlite3'
           result = @connection.exec_query(<<~SQL.squish, 'Check SQLite View Existence')
-            SELECT 1 FROM sqlite_master#{' '}
+            SELECT 1 FROM sqlite_master
             WHERE type = 'view' AND name = '#{@connection.quote_string(view_name)}'
             LIMIT 1
           SQL

data/lib/rails_lens/model_detector.rb

@@ -82,10 +82,10 @@ module RailsLens
       def check_postgresql_view(connection, table_name)
         # Check both regular views and materialized views
         result = connection.exec_query(<<~SQL.squish, 'Check PostgreSQL View')
-          SELECT 1 FROM information_schema.views#{' '}
+          SELECT 1 FROM information_schema.views
           WHERE table_name = '#{connection.quote_string(table_name)}'
           UNION ALL
-          SELECT 1 FROM pg_matviews#{' '}
+          SELECT 1 FROM pg_matviews
           WHERE matviewname = '#{connection.quote_string(table_name)}'
           LIMIT 1
         SQL
@@ -94,7 +94,7 @@ module RailsLens
 
       def check_mysql_view(connection, table_name)
         result = connection.exec_query(<<~SQL.squish, 'Check MySQL View')
-          SELECT 1 FROM information_schema.views#{' '}
+          SELECT 1 FROM information_schema.views
           WHERE table_name = '#{connection.quote_string(table_name)}'
           AND table_schema = DATABASE()
           LIMIT 1
@@ -104,7 +104,7 @@ module RailsLens
 
       def check_sqlite_view(connection, table_name)
         result = connection.exec_query(<<~SQL.squish, 'Check SQLite View')
-          SELECT 1 FROM sqlite_master#{' '}
+          SELECT 1 FROM sqlite_master
           WHERE type = 'view' AND name = '#{connection.quote_string(table_name)}'
           LIMIT 1
         SQL

data/lib/rails_lens/schema/adapters/database_info.rb

@@ -104,8 +104,8 @@ module RailsLens
           return [] unless adapter_name == 'PostgreSQL'
 
           connection.select_values(<<-SQL.squish)
-            SELECT schema_name#{' '}
-            FROM information_schema.schemata#{' '}
+            SELECT schema_name
+            FROM information_schema.schemata
             WHERE schema_name NOT IN ('pg_catalog', 'information_schema', 'pg_toast')
             ORDER BY schema_name
           SQL

data/lib/rails_lens/schema/adapters/mysql.rb

@@ -319,7 +319,7 @@ module RailsLens
         # Fetch all view metadata in a single consolidated query
         def fetch_view_metadata
           result = connection.exec_query(<<~SQL.squish, 'MySQL View Metadata')
-            SELECT#{' '}
+            SELECT
               v.is_updatable,
               COALESCE(
                 (

data/lib/rails_lens/schema/adapters/postgresql.rb

@@ -247,17 +247,15 @@ module RailsLens
           result = connection.exec_query(<<~SQL.squish, 'PostgreSQL View Metadata')
             WITH view_info AS (
               -- Check for materialized view
-              SELECT#{' '}
+              SELECT
                 'materialized' as view_type,
                 false as is_updatable,
                 mv.matviewname as view_name
               FROM pg_matviews mv
               WHERE mv.matviewname = '#{connection.quote_string(table_name)}'
-            #{'  '}
               UNION ALL
-            #{'  '}
               -- Check for regular view
-              SELECT#{' '}
+              SELECT
                 'regular' as view_type,
                 CASE WHEN v.is_updatable = 'YES' THEN true ELSE false END as is_updatable,
                 v.table_name as view_name
@@ -274,7 +272,7 @@ module RailsLens
               AND c2.relkind IN ('r', 'v', 'm')
               AND d.deptype = 'n'
             )
-            SELECT#{' '}
+            SELECT
               vi.view_type,
               vi.is_updatable,
               COALESCE(

data/lib/rails_lens/schema/adapters/sqlite3.rb

@@ -136,7 +136,7 @@ module RailsLens
         # Fetch all view metadata in a single consolidated query
         def fetch_view_metadata
           result = connection.exec_query(<<~SQL.squish, 'SQLite View Metadata')
-            SELECT sql FROM sqlite_master#{' '}
+            SELECT sql FROM sqlite_master
             WHERE type = 'view' AND name = '#{connection.quote_string(table_name)}'
             LIMIT 1
           SQL
@@ -186,7 +186,7 @@ module RailsLens
 
         def view_definition
           result = connection.exec_query(<<~SQL.squish, 'SQLite View Definition')
-            SELECT sql FROM sqlite_master#{' '}
+            SELECT sql FROM sqlite_master
             WHERE type = 'view' AND name = '#{connection.quote_string(table_name)}'
             LIMIT 1
           SQL

data/lib/rails_lens/schema/annotation_manager.rb

@@ -61,7 +61,33 @@ module RailsLens
 
       def generate_annotation
         pipeline = AnnotationPipeline.new
-        results = pipeline.process(model_class)
+
+        # If we have a connection set by annotate_all, use it to process all providers
+        if @connection
+          results = { schema: nil, sections: [], notes: [] }
+
+          pipeline.instance_variable_get(:@providers).each do |provider|
+            next unless provider.applicable?(model_class)
+
+            begin
+              result = provider.process(model_class, @connection)
+
+              case provider.type
+              when :schema
+                results[:schema] = result
+              when :section
+                results[:sections] << result if result
+              when :notes
+                results[:notes].concat(Array(result))
+              end
+            rescue StandardError => e
+              warn "Provider #{provider.class} error for #{model_class}: #{e.message}"
+            end
+          end
+        else
+          # Fall back to normal processing without connection management
+          results = pipeline.process(model_class)
+        end
 
         annotation = Annotation.new
 
@@ -105,51 +131,77 @@ module RailsLens
 
         results = { annotated: [], skipped: [], failed: [] }
 
-        models.each do |model|
-          # Ensure model is actually a class, not a hash or other object
-          unless model.is_a?(Class)
-            results[:failed] << { model: model.inspect, error: "Expected Class, got #{model.class}" }
-            next
-          end
+        # Group models by their connection pool to process each database separately
+        models_by_connection_pool = models.group_by do |model|
+          model.connection_pool
+        rescue StandardError
+          nil # Models without connection pools will be processed separately
+        end
 
-          # Skip models without tables or with missing tables (but not abstract classes)
-          unless model.abstract_class? || model.table_exists?
-            results[:skipped] << model.name
-            warn "Skipping #{model.name} - table does not exist" if options[:verbose]
-            next
+        models_by_connection_pool.each do |connection_pool, pool_models|
+          if connection_pool
+            # Process all models for this database using a single connection
+            connection_pool.with_connection do |connection|
+              pool_models.each do |model|
+                process_model_with_connection(model, connection, results, options)
+              end
+            end
+          else
+            # Process models without connection pools individually
+            pool_models.each do |model|
+              process_model_with_connection(model, nil, results, options)
+            end
           end
+        end
 
-          manager = new(model)
-
-          # Determine file path based on options
-          file_path = if options[:models_path]
-                        File.join(options[:models_path], "#{model.name.underscore}.rb")
-                      else
-                        nil # Use default model_file_path
-                      end
+        results
+      end
 
-          # Allow external files when models_path is provided (for testing)
-          allow_external = options[:models_path].present?
+      def self.process_model_with_connection(model, connection, results, options)
+        # Ensure model is actually a class, not a hash or other object
+        unless model.is_a?(Class)
+          results[:failed] << { model: model.inspect, error: "Expected Class, got #{model.class}" }
+          return
+        end
 
-          if manager.annotate_file(file_path, allow_external_files: allow_external)
-            results[:annotated] << model.name
-          else
-            results[:skipped] << model.name
-          end
-        rescue ActiveRecord::StatementInvalid => e
-          # Handle database-related errors (missing tables, schemas, etc.)
+        # Skip models without tables or with missing tables (but not abstract classes)
+        unless model.abstract_class? || model.table_exists?
           results[:skipped] << model.name
-          warn "Skipping #{model.name} - database error: #{e.message}" if options[:verbose]
-        rescue StandardError => e
-          model_name = if model.is_a?(Class) && model.respond_to?(:name)
-                         model.name
-                       else
-                         model.inspect
-                       end
-          results[:failed] << { model: model_name, error: e.message }
+          warn "Skipping #{model.name} - table does not exist" if options[:verbose]
+          return
         end
 
-        results
+        manager = new(model)
+
+        # Set the connection in the manager if provided
+        manager.instance_variable_set(:@connection, connection) if connection
+
+        # Determine file path based on options
+        file_path = if options[:models_path]
+                      File.join(options[:models_path], "#{model.name.underscore}.rb")
+                    else
+                      nil # Use default model_file_path
+                    end
+
+        # Allow external files when models_path is provided (for testing)
+        allow_external = options[:models_path].present?
+
+        if manager.annotate_file(file_path, allow_external_files: allow_external)
+          results[:annotated] << model.name
+        else
+          results[:skipped] << model.name
+        end
+      rescue ActiveRecord::StatementInvalid => e
+        # Handle database-related errors (missing tables, schemas, etc.)
+        results[:skipped] << model.name
+        warn "Skipping #{model.name} - database error: #{e.message}" if options[:verbose]
+      rescue StandardError => e
+        model_name = if model.is_a?(Class) && model.respond_to?(:name)
+                       model.name
+                     else
+                       model.inspect
+                     end
+        results[:failed] << { model: model_name, error: e.message }
       end
 
       def self.remove_all(options = {})

data/lib/rails_lens/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsLens
-  VERSION = '0.2.3'
+  VERSION = '0.2.4'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_lens
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Abdelkader Boudih