rails_failover 0.5.6 → 0.5.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c3a3ec0058f66ac60c355117284cc6c3ef9edbde71d74d966e38c2e10d38b828
-  data.tar.gz: dbfbe03fe13a70ecbc32729ce47223e41b4d9c53d6baeb42df296391490b6116
+  metadata.gz: 6711544c6ae90ab17b509fc3cb97e7b5cc4fd5579daee706dfcc9abb03141a22
+  data.tar.gz: 4bea899af7859b72f88a5e9bd185f72fbca2b968b4a8ed0d73dbc6e41be5acce
 SHA512:
-  metadata.gz: 7283bd61a7804eb4b5e501e03b71343c620e84f3b334665783a99d8c19fb135d5f49bb97d2f537938d4e73427086c7815981eb4c684b7ed3a38befd878014753
-  data.tar.gz: 3856f52865af591c157d29b0613382dd54a4614cc943313f373077db4ab950beaaba953f696faf7298304c283123e0b40ff48d29ea4d8672025ff7d49e778b1f
+  metadata.gz: 9d58e8aeec4c77b22e8a44d80667b8af553b10323d826fa16da493ab71326e3f0fb4c8f8b4f00fa89f2e53a357642b6c84d138590561c2d389a03de83cac8510
+  data.tar.gz: a6de657f916e8ced227f21c06ab36f168ca8c17adfde474e80526d9a1ab145ab2b00500c93775b22bd6efa35e604fb0c8f9d9b91256caf567a80cb9599c9e270

data/CHANGELOG.md

@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.5.7] - 2020-09-16
+
+- FIX: Avoid disconnecting Redis connections abruptly.
+
 ## [0.5.6] - 2020-09-14
 
 - FIX: Iteration and mutation of primaries_down in separate threads (#5)
@@ -23,7 +27,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
   [1]: https://github.com/ruby-concurrency/concurrent-ruby/issues/528
 
-
 ## [0.5.5] - 2020-08-04
 
 - FIX: Rescue from `Redis::TimeoutError` instead of `Timeout::Error`.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rails_failover (0.5.6)
+    rails_failover (0.5.7)
       activerecord (~> 6.0)
       railties (~> 6.0)
 

data/lib/rails_failover/redis/handler.rb

@@ -177,9 +177,16 @@ module RailsFailover
         key = options[:id]
 
         mon_synchronize do
-          if clients[key]
-            clients[key].dup.each do |c|
-              c.disconnect
+          if to_disconnect = clients[key].dup
+            # Don't disconnect connections abruptly since it may lead to unexepcted
+            # errors. Is there a better way to do this without having to monkey patch
+            # the redis-rb gem heavily?
+            ObjectSpace.each_object(::Redis).each do |redis|
+              to_disconnect.each do |c|
+                if redis._client == c
+                  redis.synchronize { |_client| _client.disconnect }
+                end
+              end
             end
           end
         end

data/lib/rails_failover/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsFailover
-  VERSION = "0.5.6"
+  VERSION = "0.5.7"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_failover
 version: !ruby/object:Gem::Version
-  version: 0.5.6
+  version: 0.5.7
 platform: ruby
 authors:
 - Alan Tan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-09-14 00:00:00.000000000 Z
+date: 2020-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord