rails_exception_handler 1.2.1 → 1.3.0

data/Gemfile.lock

@@ -30,7 +30,7 @@ GEM
     activesupport (3.0.9)
     arel (2.0.10)
     builder (2.1.2)
-    diff-lcs (1.1.2)
+    diff-lcs (1.1.3)
     erubis (2.6.6)
       abstract (>= 1.0.0)
     git (1.2.5)
@@ -39,6 +39,7 @@ GEM
       bundler (~> 1.0)
       git (>= 1.2.5)
       rake
+    json (1.6.4)
     mail (2.2.19)
       activesupport (>= 2.3.6)
       i18n (>= 0.4.0)
@@ -47,7 +48,7 @@ GEM
     mime-types (1.16)
     mysql2 (0.2.6)
     polyglot (0.3.1)
-    rack (1.2.3)
+    rack (1.2.5)
     rack-mount (0.6.14)
       rack (>= 1.0.0)
     rack-test (0.5.7)
@@ -66,25 +67,26 @@ GEM
       rake (>= 0.8.7)
       rdoc (~> 3.4)
       thor (~> 0.14.4)
-    rake (0.9.2)
-    rdoc (3.8)
-    rspec (2.6.0)
-      rspec-core (~> 2.6.0)
-      rspec-expectations (~> 2.6.0)
-      rspec-mocks (~> 2.6.0)
-    rspec-core (2.6.4)
-    rspec-expectations (2.6.0)
+    rake (0.9.2.2)
+    rdoc (3.12)
+      json (~> 1.4)
+    rspec (2.8.0)
+      rspec-core (~> 2.8.0)
+      rspec-expectations (~> 2.8.0)
+      rspec-mocks (~> 2.8.0)
+    rspec-core (2.8.0)
+    rspec-expectations (2.8.0)
       diff-lcs (~> 1.1.2)
-    rspec-mocks (2.6.0)
-    rspec-rails (2.6.1)
-      actionpack (~> 3.0)
-      activesupport (~> 3.0)
-      railties (~> 3.0)
-      rspec (~> 2.6.0)
+    rspec-mocks (2.8.0)
+    rspec-rails (2.8.1)
+      actionpack (>= 3.0)
+      activesupport (>= 3.0)
+      railties (>= 3.0)
+      rspec (~> 2.8.0)
     thor (0.14.6)
     treetop (1.4.9)
       polyglot (>= 0.3.1)
-    tzinfo (0.3.29)
+    tzinfo (0.3.31)
 
 PLATFORMS
   ruby

data/HISTORY

@@ -1,6 +1,9 @@
 CHANGELOG
 
 
+v1.3.0 - January 13th 2012
+ - Added filtering option for getting rid of 404s created by anonymous users
+
 v1.2.1 - September 19th 2011
  - Fixed a couple of issues that made the exception handler break if active record was not loaded
 

data/README.markdown

@@ -4,7 +4,7 @@ This is an exception handler for Rails 3 built as Rack middleware. It enables yo
 
 ## Compatiblity
 
-The gem is tested against Rails 3.0.9. It does not work with Rails 2.
+The gem should work with all versions of Rails 3. It does not work with Rails 2.
 See travis-ci for info on which rubies it is tested against:
 http://travis-ci.org/#!/Sharagoz/rails_exception_handler
 
@@ -26,6 +26,7 @@ RailsExceptionHandler.configure do |config|
   # config.filters = [                                                      # No filters are  enabled by default
   #   :all_404s,
   #   :no_referer_404s,
+  #   :anon_404s,
   #   {:user_agent_regxp => /\b(ApptusBot|TurnitinBot|DotBot|SiteBot)\b/i},
   #   {:target_url_regxp => /\b(myphpadmin)\b/i}
   # ]
@@ -121,6 +122,14 @@ config.filters = [:all_404s]
 When turned on the following exceptions will no longer be stored: ActionController::RoutingError, AbstractController::ActionNotFound, ActiveRecord::RecordNotFound
 Consider this a last resort. You will miss all "real" 404s when this is turned on, like broken redirections.
 
+**:all_404s**
+
+```ruby
+config.filters = [:anon_404s]
+```
+
+When turned on the following exceptions will no longer be stored unless a user is logged in: ActionController::RoutingError, AbstractController::ActionNotFound, ActiveRecord::RecordNotFound
+
 **:no_referer_404s**
 
 ```ruby

data/VERSION

@@ -1 +1 @@
-1.2.1
+1.3.0

data/lib/rails_exception_handler/parser.rb

@@ -40,6 +40,10 @@ class RailsExceptionHandler::Parser
     routing_errors.include?(@exception.class.to_s)
   end
 
+  def anon_user?
+    [nil,'Anonymous'].include?(user_info)
+  end
+
   private
 
   def blank_referer?
@@ -61,6 +65,10 @@ class RailsExceptionHandler::Parser
     routing_error? && blank_referer?
   end
 
+  def filter_anon_404s
+    routing_error? && anon_user?
+  end
+
   def filter_user_agent_regxp(regxp)
     result = relevant_info[:user_agent].match(regxp)
     result != nil

data/rails_exception_handler.gemspec

@@ -4,14 +4,14 @@
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
-  s.name = %q{rails_exception_handler}
-  s.version = "1.2.1"
+  s.name = "rails_exception_handler"
+  s.version = "1.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = [%q{Sharagoz}]
-  s.date = %q{2011-09-19}
-  s.description = %q{}
-  s.email = %q{contact@sharagoz.com}
+  s.authors = ["Sharagoz"]
+  s.date = "2012-01-13"
+  s.description = ""
+  s.email = "contact@sharagoz.com"
   s.extra_rdoc_files = [
     "README.markdown"
   ]
@@ -70,11 +70,11 @@ Gem::Specification.new do |s|
     "spec/unit/handler_spec.rb",
     "spec/unit/parser_spec.rb"
   ]
-  s.homepage = %q{http://github.com/Sharagoz/rails_exception_handler}
-  s.licenses = [%q{MIT}]
-  s.require_paths = [%q{lib}]
-  s.rubygems_version = %q{1.8.8}
-  s.summary = %q{Exception Handling for Rails 3}
+  s.homepage = "http://github.com/Sharagoz/rails_exception_handler"
+  s.licenses = ["MIT"]
+  s.require_paths = ["lib"]
+  s.rubygems_version = "1.8.11"
+  s.summary = "Exception Handling for Rails 3"
 
   if s.respond_to? :specification_version then
     s.specification_version = 3

data/spec/integration/configuration_spec.rb

@@ -53,6 +53,7 @@ describe RailsExceptionHandler::Configuration do
         get "/home/view_error"
         ErrorMessage.count.should == 1
       end
+
     end
 
     describe ":user_agent_regxp" do
@@ -82,6 +83,41 @@ describe RailsExceptionHandler::Configuration do
         ErrorMessage.count.should == 1
       end
     end
+
+    describe ":anon_404s" do
+      it "should log a 404 from a logged in user" do
+        RailsExceptionHandler.configure do |config|
+          config.environments = [Rails.env.to_sym]
+          config.storage_strategies = [:active_record]
+          config.store_user_info = {:method => :current_user, :field => :login}
+          config.filters = [:anon_404s]
+        end
+        get "/incorrect_route"
+        ErrorMessage.count.should == 1
+      end
+
+      it "should filter 404s from anonymous users" do
+        RailsExceptionHandler.configure do |config|
+          config.environments = [Rails.env.to_sym]
+          config.storage_strategies = [:active_record]
+          config.store_user_info = {:method => :nil_user, :field => :login}
+          config.filters = [:anon_404s]
+        end
+        get "/incorrect_route"
+        ErrorMessage.count.should == 0
+      end
+
+      it "should not filter 500s from anonymous users" do
+        RailsExceptionHandler.configure do |config|
+          config.environments = [Rails.env.to_sym]
+          config.storage_strategies = [:active_record]
+          config.store_user_info = {:method => :nil_user, :field => :login}
+          config.filters = [:anon_404s]
+        end
+        get "/home/model_error"
+        ErrorMessage.count.should == 1
+      end
+    end
   end
 
   describe ".environments" do

data/spec/testapp_30/app/controllers/application_controller.rb

@@ -9,4 +9,8 @@ class ApplicationController < ActionController::Base
     return mock
   end
 
+  def nil_user
+    return nil
+  end
+
 end

data/spec/unit/parser_spec.rb

@@ -109,4 +109,28 @@ describe RailsExceptionHandler::Parser do
       parser.relevant_info[:user_info].should == nil
     end
   end
+
+  describe "anon_user?" do
+    it "should return true if user_info is nil" do
+      RailsExceptionHandler.configure {|config| config.store_user_info = false}
+      controller = mock(ApplicationController)
+      parser = create_parser(nil, nil, controller)
+      parser.anon_user?.should be_true
+    end
+
+    it "should return true if user_info is 'Anonymous'" do
+      RailsExceptionHandler.configure {|config| config.store_user_info = {:method => :current_user, :field => :login}}
+      controller = mock(ApplicationController, :current_user => nil)
+      parser = create_parser(nil, nil, controller)
+      parser.relevant_info[:user_info].should == 'Anonymous'
+      parser.anon_user?.should be_true
+    end
+
+    it "should return false if user info is present" do
+      RailsExceptionHandler.configure {|config| config.store_user_info = {:method => :current_user, :field => :login}}
+      controller = mock(ApplicationController, :current_user => mock(Object, :login => 'matz'))
+      parser = create_parser(nil, nil, controller)
+      parser.anon_user?.should be_false
+    end
+  end
 end

metadata

@@ -2,7 +2,7 @@
 name: rails_exception_handler
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.2.1
+  version: 1.3.0
 platform: ruby
 authors: 
 - Sharagoz
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-19 00:00:00 Z
+date: 2012-01-13 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: rails
@@ -152,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.8
+rubygems_version: 1.8.11
 signing_key: 
 specification_version: 3
 summary: Exception Handling for Rails 3