rails_exception_handler 1.1.2 → 1.2.0

data/HISTORY

@@ -1,6 +1,10 @@
 CHANGELOG
 
 
+v1.2.0 - August 21st 2011
+ - Bug fixed where exception_database had to be configured even if active record storage was not chosen
+ - If public/500.html and/or public/400.html exists, these will be used as responses
+
 v1.1.2 - July 19th 2011
  - It should now be able to store user_info on routing errors too
  - The RailsExceptionHandler class have been turned into a rails engine so that the load path manipulation could be removed

data/README.markdown

@@ -29,7 +29,7 @@ RailsExceptionHandler.configure do |config|
   #   {:user_agent_regxp => /\b(ApptusBot|TurnitinBot|DotBot|SiteBot)\b/i},
   #   {:target_url_regxp => /\b(myphpadmin)\b/i}
   # ]
-  # config.responses = {                                                    # There must be a default response. The rest is up to you.
+  # config.responses = {                                                    # There must be a default response if public/500.html and public/400.html does not exist.
   #   :default => "<h1>500</h1><p>Internal server error</p>",
   #   :custom => "<h1>404</h1><p>Page not found</p>"
   # }
@@ -86,6 +86,8 @@ If you turn this on and the error is generated by a client that is not logged in
 
 ### responses and response_mapping
 
+Note: public/500.html and public/400.html will be used if these exists. Remove these files before applying the configuration below.
+
 Create a set of responses and then map specific exceptions to these responses. There needs to be a response called :default which is used for the exceptions that are not explicity mapped to a response.
 
 ```ruby
@@ -223,3 +225,11 @@ config.storage_strategies = [:remote_url => {:target => 'http://example.com/erro
 ```
 This option is meant for those who want to store the exception in a database table, but does not have direct access to the database itself, making active record store unsuitable. You need a web app on a server that has access to the database. An HTTP POST request will be sent to the specified URL with the error message as data.
 If you use a Rails app at the other end you should simply be able to do _ErrorMessage.create(params[:error_message])_ to save the report.
+
+## Contributors
+
+David Rice
+
+## Licence
+
+Copyright © 2011 Bjørn Trondsen, released under the MIT license

data/VERSION

@@ -1 +1 @@
-1.1.2
+1.2.0

data/app/models/error_message.rb

@@ -1,3 +1,3 @@
 class ErrorMessage < ActiveRecord::Base
-  establish_connection(:exception_database)
+  establish_connection(:exception_database) if RailsExceptionHandler.configuration.active_record?
 end

data/lib/rails_exception_handler/configuration.rb

@@ -8,6 +8,11 @@ class RailsExceptionHandler::Configuration
     @store_user_info = false
     @fallback_layout = 'application'
     @response_mapping = {}
-    @responses = { :default => '<h1>Internal server error</h1><p>The application has encountered an unexpected issue.</p>' }
+    @responses = {}
   end
+
+  def active_record?
+    @storage_strategies.include?(:active_record)
+  end
+
 end

data/lib/rails_exception_handler/handler.rb

@@ -67,7 +67,15 @@ class RailsExceptionHandler::Handler
     @env['exception_handler.layout'] = response_layout
     @env['exception_handler.response'] = response_text
     response = ErrorResponseController.action(:index).call(@env)
-    response[0] = @parsed_error.routing_error? ? 404 : 500
+    if @parsed_error.routing_error? 
+      response[0] = 404
+      file = "#{Rails.root}/public/404.html"
+      response[2].body = File.read(file) if File.exists?(file)
+    else
+      response[0] = 500
+      file = "#{Rails.root}/public/500.html"
+      response[2].body = File.read(file) if File.exists?(file)
+    end
     return response
   end
 

data/rails_exception_handler.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_exception_handler}
-  s.version = "1.1.2"
+  s.version = "1.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Sharagoz"]
-  s.date = %q{2011-07-19}
+  s.date = %q{2011-08-22}
   s.description = %q{}
   s.email = %q{contact@sharagoz.com}
   s.extra_rdoc_files = [

data/spec/testapp_30/Gemfile

@@ -5,7 +5,7 @@ gem 'rails', '3.0.9'
 # Bundle edge Rails instead:
 # gem 'rails', :git => 'git://github.com/rails/rails.git'
 
-gem 'mysql2'
+gem 'mysql2', '0.2.6'
 
 # Use unicorn as the web server
 # gem 'unicorn'

data/spec/testapp_30/Gemfile.lock

@@ -39,7 +39,7 @@ GEM
       mime-types (~> 1.16)
       treetop (~> 1.4.8)
     mime-types (1.16)
-    mysql2 (0.3.6)
+    mysql2 (0.2.6)
     polyglot (0.3.1)
     rack (1.2.3)
     rack-mount (0.6.14)
@@ -71,5 +71,5 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  mysql2
+  mysql2 (= 0.2.6)
   rails (= 3.0.9)

data/spec/unit/configuration_spec.rb

@@ -22,8 +22,8 @@ describe RailsExceptionHandler::Configuration do
       @configuration.filters.should == []
     end
 
-    it "should set the default response" do
-      @configuration.responses.should == {:default => '<h1>Internal server error</h1><p>The application has encountered an unexpected issue.</p>' }
+    it "should initialize responses to an empty hash" do
+      @configuration.responses.should == {}
     end
 
     it "should set the reponse_mapping to {}" do

metadata

@@ -2,7 +2,7 @@
 name: rails_exception_handler
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.1.2
+  version: 1.2.0
 platform: ruby
 authors: 
 - Sharagoz
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-07-19 00:00:00 +02:00
+date: 2011-08-22 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency