rails_exception_handler 1.1.0 → 1.1.1

data/HISTORY

@@ -1,6 +1,9 @@
 CHANGELOG
 
 
+v1.1.1 - 18. Jul 2011
+ - Fixed issue related to the handling of routing errors
+
 v1.1.0 - 18. Jul 2011
  - Better handling of ajax requests
  - Exceptions can be mapped to specific responses

data/README.markdown

@@ -30,13 +30,13 @@ RailsExceptionHandler.configure do |config|
   #   {:target_url_regxp => /\b(myphpadmin)\b/i}
   # ]
   # config.responses = {                                                    # There must be a default response. The rest is up to you.
-  #   :default => "<h1>500</h1><p>Internal server error</p>"
-  #   :custom => "<h1>404</h1><p>Page not found</p>",
+  #   :default => "<h1>500</h1><p>Internal server error</p>",
+  #   :custom => "<h1>404</h1><p>Page not found</p>"
   # }
   # config.response_mapping = {                                             # All errors are mapped to the :default response unless overridden here
-  #  'ActiveRecord::RecordNotFound' => :not_found,
-  #  'ActionController:RoutingError' => :not_found,
-  #  'AbstractController::ActionNotFound' => :not_found,
+  #  'ActiveRecord::RecordNotFound' => :custom,
+  #  'ActionController::RoutingError' => :custom,
+  #  'AbstractController::ActionNotFound' => :custom
   # }
 end
 ```
@@ -82,7 +82,7 @@ config.store_user_info = {:method => :current_user, :field => :login}
 ```
 
 Default value: false (no info will be stored)
-If you turn this on and the error is generated by a client that is not logged in, then "Anonymous" will be used.
+If you turn this on and the error is generated by a client that is not logged in, then "Anonymous" will be used. Currently, "Anonymous" is always used on routing errors, regardless of whether the user is logged in or not. This because the error happens before a controller instance has been initialized, and I haven't found a safe way to do this manually yet.
 
 ### responses and response_mapping
 

data/VERSION

@@ -1 +1 @@
-1.1.0
+1.1.1

data/lib/rails_exception_handler/handler.rb

@@ -4,16 +4,7 @@ class RailsExceptionHandler::Handler
     @env = env
     @request = ActionDispatch::Request.new(@env)
     @parsed_error = nil
-    if(@env['action_controller.instance'])
-      @controller = @env['action_controller.instance']
-    else
-      # During routing errors a controller object must be created manually and the before filters run, 
-      # in case they are used to set up the authentication mechanism that provides the current_user object
-      @controller = ApplicationController.new
-      @controller.request = @request
-      filters = @controller._process_action_callbacks.collect {|cb| cb.filter if(cb.kind == :before)}
-      filters.each { |filter| @controller.send(filter) }
-    end
+    @controller = @env['action_controller.instance'] || ApplicationController.new
   end
 
   def handle_exception

data/lib/rails_exception_handler/parser.rb

@@ -49,7 +49,11 @@ class RailsExceptionHandler::Parser
   def user_info
     config = RailsExceptionHandler.configuration.store_user_info
     return nil unless(config)
-    user_object = @controller.send(config[:method])
+    begin
+      user_object = @controller.send(config[:method])
+    rescue
+      user_object = nil
+    end
     user_object ? user_object.send(config[:field]) : 'Anonymous'
   end
 

data/rails_exception_handler.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_exception_handler}
-  s.version = "1.1.0"
+  s.version = "1.1.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Sharagoz"]

metadata

@@ -2,7 +2,7 @@
 name: rails_exception_handler
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors: 
 - Sharagoz