rails_error_dashboard 0.5.14 → 0.6.0

data/lib/rails_error_dashboard/services/backtrace_parser.rb

@@ -94,13 +94,19 @@ module RailsErrorDashboard
       end
 
       def app_code?(file_path)
-        # Match /app/, /lib/ directories in the application
-        file_path.include?("/app/") ||
-          (file_path.include?("/lib/") && !file_path.include?("/gems/") && !file_path.include?("/ruby/"))
+        # Match /app/ or app/ (shortened paths start without leading /)
+        return true if file_path.include?("/app/") || file_path.start_with?("app/")
+
+        # Match /lib/ or lib/ but exclude gems and ruby stdlib
+        lib_path = file_path.include?("/lib/") || file_path.start_with?("lib/")
+        return false unless lib_path
+
+        !file_path.include?("/gems/") && !file_path.include?("/ruby/") &&
+          !file_path.start_with?("gems/") && !file_path.start_with?("ruby/")
       end
 
       def gem_code?(file_path)
-        file_path.include?("/gems/") ||
+        file_path.include?("/gems/") || file_path.start_with?("gems/") ||
           file_path.include?("/bundler/gems/") ||
           file_path.include?("/vendor/bundle/")
       end

data/lib/rails_error_dashboard/services/backtrace_processor.rb

@@ -5,7 +5,15 @@ module RailsErrorDashboard
     # Pure algorithm service for backtrace processing
     # Handles truncation and signature generation with no database access.
     class BacktraceProcessor
-      # Truncate backtrace to a maximum number of lines
+      # Truncate backtrace to a maximum number of lines and shorten gem paths.
+      #
+      # Gem paths like:
+      #   /home/user/.local/share/mise/installs/ruby/4.0.2/lib/ruby/gems/4.0.0/gems/actionpack-8.1.3/lib/...
+      # are shortened to:
+      #   gems/actionpack-8.1.3/lib/...
+      #
+      # This saves significant disk space without losing debugging value (issue #115).
+      #
       # @param backtrace [Array<String>, nil] The backtrace lines
       # @param max_lines [Integer] Maximum lines to keep
       # @return [String, nil] Truncated backtrace as a single string
@@ -14,7 +22,7 @@ module RailsErrorDashboard
 
         max_lines ||= RailsErrorDashboard.configuration.max_backtrace_lines
 
-        limited_backtrace = backtrace.first(max_lines)
+        limited_backtrace = backtrace.first(max_lines).map { |line| shorten_gem_path(line) }
         result = limited_backtrace.join("\n")
 
         if backtrace.length > max_lines
@@ -25,6 +33,40 @@ module RailsErrorDashboard
         result
       end
 
+      # Shorten gem/ruby paths to remove user-specific prefixes.
+      # Preserves gem name + version for debugging.
+      #
+      # Examples:
+      #   /home/user/.gem/ruby/3.4.0/gems/rack-3.2.6/lib/rack/head.rb:15
+      #   → gems/rack-3.2.6/lib/rack/head.rb:15
+      #
+      #   /home/user/.local/share/mise/installs/ruby/4.0.2/lib/ruby/4.0.0/net/http.rb:1234
+      #   → ruby/4.0.0/net/http.rb:1234
+      #
+      #   /home/user/myapp/app/controllers/users_controller.rb:10
+      #   → app/controllers/users_controller.rb:10
+      #
+      # @param line [String] A single backtrace line
+      # @return [String] The line with shortened path
+      def self.shorten_gem_path(line)
+        # Strip everything before /gems/ (gem code)
+        if line.include?("/gems/")
+          line.sub(%r{^.*/gems/}, "gems/")
+        # Strip everything before /lib/ruby/ (Ruby stdlib)
+        elsif line.include?("/lib/ruby/")
+          line.sub(%r{^.*/lib/ruby/}, "ruby/")
+        # Strip everything before /app/ (application code)
+        elsif line.include?("/app/")
+          line.sub(%r{^.*/app/}, "app/")
+        # Strip everything before /lib/ for app lib code (but not gem/ruby paths already handled)
+        elsif line.include?("/lib/")
+          line.sub(%r{^.*/lib/}, "lib/")
+        else
+          line
+        end
+      end
+      # Keep public — used by LogError for cause chain backtrace shortening too.
+
       # Calculate a signature hash from backtrace for fuzzy similarity matching
       # Extracts file paths and method names, ignoring line numbers,
       # then produces an order-independent SHA256 digest.

data/lib/rails_error_dashboard/services/error_broadcaster.rb

@@ -90,17 +90,32 @@ module RailsErrorDashboard
         )
       end
 
-      # Check if broadcasting infrastructure is available
+      # Check if broadcasting infrastructure is available.
+      # Returns false when Turbo/ActionCable isn't loaded, or when the
+      # ActionCable pubsub adapter can't be reached (e.g., Redis down).
+      # Uses a 60-second cooldown after failure to avoid hammering a
+      # dead Redis on every error (issue #114).
       # @return [Boolean]
       def self.available?
         return false unless defined?(Turbo)
         return false unless defined?(ActionCable)
 
-        Rails.cache.write("rails_error_dashboard_broadcast_test", true, expires_in: 1.second)
-        Rails.cache.delete("rails_error_dashboard_broadcast_test")
+        # Circuit breaker: skip broadcast attempts for 60s after a failure
+        if @broadcast_unavailable_until && Time.current < @broadcast_unavailable_until
+          return false
+        end
+
+        # Verify the pubsub adapter is reachable — without this,
+        # broadcast_* calls attempt Redis and fail loudly when it's down
+        server = ActionCable.server
+        return false unless server.respond_to?(:pubsub)
+
+        server.pubsub
+        @broadcast_unavailable_until = nil
         true
       rescue => e
-        Rails.logger.debug("[RailsErrorDashboard] Broadcast not available: #{e.message}")
+        @broadcast_unavailable_until = Time.current + 60
+        RailsErrorDashboard::Logger.debug("[RailsErrorDashboard] Broadcast not available (pausing 60s): #{e.message}")
         false
       end
     end

data/lib/rails_error_dashboard/services/notification_helpers.rb

@@ -13,9 +13,16 @@ module RailsErrorDashboard
       # @param error_log [ErrorLog] The error
       # @return [String] Full URL to the error detail page
       def dashboard_url(error_log)
-        base_url = RailsErrorDashboard.configuration.dashboard_base_url || "http://localhost:3000"
+        base_url = (RailsErrorDashboard.configuration.dashboard_base_url || "http://localhost:3000").chomp("/")
         mount_path = RailsErrorDashboard.configuration.engine_mount_path
-        "#{base_url}#{mount_path}/errors/#{error_log.id}"
+
+        # Avoid doubling the mount path when base_url already includes it.
+        # e.g., base_url="https://app.com/red" + mount_path="/red" → don't produce "/red/red"
+        if mount_path.present? && base_url.end_with?(mount_path.chomp("/"))
+          "#{base_url}/errors/#{error_log.id}"
+        else
+          "#{base_url}#{mount_path}/errors/#{error_log.id}"
+        end
       end
 
       # Truncate a message to a maximum length

data/lib/rails_error_dashboard/subscribers/issue_tracker_subscriber.rb

@@ -53,6 +53,27 @@ module RailsErrorDashboard
           return false unless config.enable_issue_tracking
           return false if error_log.external_issue_url.present?
 
+          # Check if another error record with the same hash already has a linked
+          # issue. The 24-hour dedup window in FindOrIncrementError can create new
+          # ErrorLog records for the same logical error — we must not create
+          # duplicate GitHub/GitLab issues for them (issue #114 screenshot).
+          existing = ErrorLog
+            .where(error_hash: error_log.error_hash, application_id: error_log.application_id)
+            .where.not(external_issue_url: [ nil, "" ])
+            .where.not(id: error_log.id)
+            .order(created_at: :desc)
+            .first
+
+          if existing
+            # Link this record to the existing issue instead of creating a new one
+            error_log.update_columns(
+              external_issue_url: existing.external_issue_url,
+              external_issue_number: existing.external_issue_number,
+              external_issue_provider: existing.external_issue_provider
+            )
+            return false
+          end
+
           # First occurrence — always auto-create
           return true if error_log.occurrence_count == 1
 

data/lib/rails_error_dashboard/version.rb

@@ -1,3 +1,3 @@
 module RailsErrorDashboard
-  VERSION = "0.5.14"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_error_dashboard
 version: !ruby/object:Gem::Version
-  version: 0.5.14
+  version: 0.6.0
 platform: ruby
 authors:
 - Anjan Jagirdar
@@ -496,7 +496,7 @@ metadata:
   funding_uri: https://github.com/sponsors/AnjanJ
 post_install_message: |
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-    RED (Rails Error Dashboard) v0.5.14
+    RED (Rails Error Dashboard) v0.6.0
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   First install: