rails_error_dashboard 0.14.2 → 0.14.4

data/lib/tasks/error_dashboard.rake

@@ -34,6 +34,25 @@ namespace :error_dashboard do
     end
     checks_passed += 1
 
+    # 2b. Separate database: the database.yml entry for this environment. Without
+    # it the engine skips connects_to and RED uses the main database, which
+    # usually has no RED tables, so nothing is recorded.
+    if config.use_separate_database
+      print "  Error database entry... "
+      db_name = config.database || :error_dashboard
+      if config.separate_database_entry?
+        puts "OK"
+        checks_passed += 1
+      else
+        puts "FAILED"
+        puts "    config/database.yml has no '#{db_name}' entry for the '#{Rails.env}' environment."
+        puts "    RED is using the main database instead, so errors are not recorded in the error database."
+        puts "    Add '#{db_name}:' under '#{Rails.env}:' with migrations_paths: db/error_dashboard_migrate"
+        puts "    (see docs/guides/DATABASE_OPTIONS.md), then restart."
+        checks_failed += 1
+      end
+    end
+
     # 3. Database connection
     print "  Database connection... "
     begin
@@ -177,8 +196,12 @@ namespace :error_dashboard do
       if config.refuse_default_credentials?
         puts "WARNING - #{label} outside development and test!"
         checks_failed += 1
+      elsif problem == :blank
+        # The login denies everyone on a blank credential, in every environment.
+        puts "WARNING - #{label}: every login is denied"
+        warnings += 1
       else
-        puts "OK (#{label} - change before production)"
+        puts "OK (#{label} - set ERROR_DASHBOARD_USER and ERROR_DASHBOARD_PASSWORD before deploying)"
         warnings += 1
       end
     elsif config.dashboard_password == RailsErrorDashboard::Configuration::DEFAULT_DASHBOARD_PASSWORD
@@ -189,6 +212,53 @@ namespace :error_dashboard do
       checks_passed += 1
     end
 
+    # 9. Solid Queue config. A section with workers and no dispatchers runs no
+    # dispatcher, so no delayed job ever runs, the app's own included; the
+    # retired rails_error_dashboard:solid_queue generator wrote exactly that.
+    # Checked whenever Solid Queue is loaded, not only when it is the current
+    # adapter: Rails 8 sets it in production only, and verify usually runs locally.
+    queue_check = RailsErrorDashboard::Services::SolidQueueConfigCheck
+    queue_config = queue_check.config_path(Rails.root)
+    if defined?(SolidQueue) && queue_config.exist?
+      print "  Solid Queue config... "
+      environments = queue_check.app_environments(Rails.root).presence || [ Rails.env.to_s ]
+      result = queue_check.call(queue_config, environments: environments)
+      if result[:skipped]
+        puts "SKIPPED (#{result[:skipped]})"
+        warnings += 1
+      elsif result[:problems].any?
+        puts "FAILED"
+        result[:problems].each { |problem| puts "    - #{problem}" }
+        queue_check::FIX.each { |line| puts "    #{line}" }
+        checks_failed += 1
+      else
+        puts "OK"
+        checks_passed += 1
+      end
+    end
+
+    # 10. json 3.0 breaks Rails before 8.1.4 and 7.2.4: dashboard pages return
+    # 500 and captures can fail, with no error message. The bug is in Rails.
+    json_version = Gem.loaded_specs["json"]&.version
+    if json_version && json_version >= Gem::Version.new("3")
+      print "  json gem... "
+      rails_version = Gem::Version.new(Rails.version)
+      series = rails_version.segments.first(2)
+      json3_ok = (series == [ 8, 1 ] && rails_version >= Gem::Version.new("8.1.4")) ||
+                 (series == [ 7, 2 ] && rails_version >= Gem::Version.new("7.2.4")) ||
+                 (series <=> [ 8, 1 ]) == 1
+      if json3_ok
+        puts "OK (json #{json_version}, Rails #{Rails.version})"
+        checks_passed += 1
+      else
+        puts "WARNING"
+        puts "    json #{json_version} breaks Rails #{Rails.version} (fixed in Rails 8.1.4 and 7.2.4):"
+        puts "    dashboard pages return 500 and errors can fail to be captured."
+        puts "    Add gem \"json\", \"< 3\" to your Gemfile and run bundle update json, or upgrade Rails."
+        warnings += 1
+      end
+    end
+
     # Summary
     puts "\n" + "-" * 70
     puts "  Results: #{checks_passed} passed, #{checks_failed} failed, #{warnings} warnings"
@@ -295,7 +365,7 @@ namespace :error_dashboard do
 
     # Confirm before proceeding
     print "\nProceed with backfill? (y/N): "
-    confirmation = $stdin.gets.chomp.downcase
+    confirmation = $stdin.gets.to_s.chomp.downcase
 
     unless confirmation == "y" || confirmation == "yes"
       puts "\n✗ Backfill cancelled"
@@ -453,7 +523,7 @@ namespace :error_dashboard do
 
     # Confirm before proceeding
     print "\nProceed with deletion? (y/N): "
-    confirmation = $stdin.gets.chomp.downcase
+    confirmation = $stdin.gets.to_s.chomp.downcase
 
     unless confirmation == "y" || confirmation == "yes"
       puts "\n✗ Cleanup cancelled"
@@ -463,7 +533,9 @@ namespace :error_dashboard do
 
     puts "\nDeleting errors..."
     start_time = Time.current
-    deleted = scope.delete_all
+    # Dependents first, in batches: occurrences, comments and cascade patterns
+    # hold foreign keys to the log, so a plain delete_all failed on them.
+    deleted = RailsErrorDashboard::RetentionCleanupJob.delete_with_dependents(scope)
     # delete_all skips callbacks, and the stat cards are cached.
     RailsErrorDashboard::Services::AnalyticsCacheManager.clear
     elapsed = (Time.current - start_time).round(2)
@@ -538,7 +610,7 @@ namespace :error_dashboard do
     end
 
     print "\n  Proceed with deletion? (y/N): "
-    confirmation = $stdin.gets.chomp.downcase
+    confirmation = $stdin.gets.to_s.chomp.downcase
 
     unless confirmation == "y" || confirmation == "yes"
       puts "\n  Cleanup cancelled"

data/lib/tasks/rails_error_dashboard_tasks.rake

@@ -16,75 +16,69 @@ namespace :rails_error_dashboard do
       puts "=" * 80
       puts "\n"
 
-      # List tables that will be dropped
-      tables_to_drop = [
-        "rails_error_dashboard_error_comments",
-        "rails_error_dashboard_error_occurrences",
-        "rails_error_dashboard_cascade_patterns",
-        "rails_error_dashboard_error_baselines",
-        "rails_error_dashboard_error_logs"
-      ]
+      # The connection RED's models use: the separate or shared error database
+      # when there is one. Raises if the engine fell back to the primary one.
+      connection = RailsErrorDashboard::Commands::DropAllTables.connection
+      database = connection.pool.db_config.name
+      plan = RailsErrorDashboard::Queries::UninstallPlan.call(connection)
 
-      existing_tables = tables_to_drop.select do |table|
-        ActiveRecord::Base.connection.table_exists?(table)
-      end
-
-      if existing_tables.empty?
-        puts "No Rails Error Dashboard tables found in the database."
+      if plan.empty?
+        puts "No Rails Error Dashboard tables found in the '#{database}' database."
         puts "\n"
-        exit 0
+        next
       end
 
-      puts "The following tables will be PERMANENTLY DELETED:"
-      existing_tables.each do |table|
-        record_count = ActiveRecord::Base.connection.execute("SELECT COUNT(*) FROM #{table}").first.values.first rescue 0
-        puts "  • #{table} (#{record_count} records)"
+      puts "The following tables in the '#{database}' database will be PERMANENTLY DELETED:"
+      plan.each do |entry|
+        puts "  • #{entry[:table]} (#{entry[:rows] || '?'} records)"
       end
       puts "\n"
+
+      if plan.any? { |entry| entry[:table] == "rails_error_dashboard_applications" }
+        names = connection.select_values("SELECT name FROM #{connection.quote_table_name('rails_error_dashboard_applications')} ORDER BY name")
+        if names.size > 1
+          puts "⚠️  This database holds errors for #{names.size} applications, and ALL of them will be deleted:"
+          names.each { |name| puts "  • #{name}" }
+          puts "\n"
+        end
+      end
+
       puts "⚠️  This action CANNOT be undone!"
       puts "\n"
 
-      # Ask for confirmation
       print "Type 'DELETE ALL DATA' to confirm: "
-      confirmation = $stdin.gets.chomp
+      confirmation = $stdin.gets.to_s.chomp
 
       if confirmation != "DELETE ALL DATA"
         puts "\n"
         puts "Cancelled. No tables were dropped."
         puts "\n"
-        exit 0
+        next
       end
 
       puts "\n"
       puts "Dropping tables..."
-
-      # Drop tables in reverse order (respects foreign keys)
-      dropped_count = 0
-      existing_tables.reverse.each do |table|
-        begin
-          ActiveRecord::Base.connection.drop_table(table, if_exists: true)
-          puts "  ✓ Dropped #{table}"
-          dropped_count += 1
-        rescue => e
-          puts "  ✗ Failed to drop #{table}: #{e.message}"
-        end
-      end
+      dropped = RailsErrorDashboard::Commands::DropAllTables.call(connection: connection)
+      dropped.each { |table| puts "  ✓ Dropped #{table}" }
 
       puts "\n"
       puts "=" * 80
-      puts "  ✅ Successfully dropped #{dropped_count} table(s)"
+      puts "  ✅ Successfully dropped #{dropped.size} table(s)"
       puts "=" * 80
       puts "\n"
       puts "Next steps:"
-      puts "  1. Remove gem 'rails_error_dashboard' from Gemfile"
-      puts "  2. Run: bundle install"
-      puts "  3. Remove initializer: config/initializers/rails_error_dashboard.rb"
-      puts "  4. Remove route from config/routes.rb"
-      puts "  5. Delete migration files: db/migrate/*rails_error_dashboard*.rb"
-      puts "  6. Restart your Rails server"
+      puts "  1. Remove the initializer: config/initializers/rails_error_dashboard.rb"
+      puts "  2. Remove the route from config/routes.rb (mount RailsErrorDashboard::Engine)"
+      puts "  3. Delete RED's migrations: db/migrate/*rails_error_dashboard*.rb"
+      puts "     (and db/error_dashboard_migrate/ with a separate database)"
+      puts "  4. Separate database: remove its entry from config/database.yml"
+      puts "  5. Regenerate the schema file: bin/rails db:schema:dump"
+      puts "     (otherwise db:schema:load recreates these tables)"
+      puts "  6. Remove gem 'rails_error_dashboard' from the Gemfile and run: bundle install"
+      puts "  7. Restart your Rails server"
       puts "\n"
-      puts "Or use the automated uninstaller:"
-      puts "  rails generate rails_error_dashboard:uninstall"
+      puts "Or use the automated uninstaller, before removing the gem:"
+      puts "  bin/rails generate rails_error_dashboard:uninstall"
       puts "\n"
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_error_dashboard
 version: !ruby/object:Gem::Version
-  version: 0.14.2
+  version: 0.14.4
 platform: ruby
 authors:
 - Anjan Jagirdar
@@ -429,7 +429,6 @@ files:
 - lib/generators/rails_error_dashboard/install/templates/README
 - lib/generators/rails_error_dashboard/install/templates/initializer.rb
 - lib/generators/rails_error_dashboard/solid_queue/solid_queue_generator.rb
-- lib/generators/rails_error_dashboard/solid_queue/templates/queue.yml
 - lib/generators/rails_error_dashboard/uninstall/uninstall_generator.rb
 - lib/rails_error_dashboard.rb
 - lib/rails_error_dashboard/commands/add_error_comment.rb
@@ -442,6 +441,7 @@ files:
 - lib/rails_error_dashboard/commands/batch_unmute_errors.rb
 - lib/rails_error_dashboard/commands/calculate_cascade_probability.rb
 - lib/rails_error_dashboard/commands/create_issue.rb
+- lib/rails_error_dashboard/commands/drop_all_tables.rb
 - lib/rails_error_dashboard/commands/find_or_create_application.rb
 - lib/rails_error_dashboard/commands/find_or_increment_error.rb
 - lib/rails_error_dashboard/commands/flush_rack_attack_events.rb
@@ -508,6 +508,7 @@ files:
 - lib/rails_error_dashboard/queries/similar_errors.rb
 - lib/rails_error_dashboard/queries/storm_history.rb
 - lib/rails_error_dashboard/queries/swallowed_exception_summary.rb
+- lib/rails_error_dashboard/queries/uninstall_plan.rb
 - lib/rails_error_dashboard/queries/user_impact_summary.rb
 - lib/rails_error_dashboard/services/ai_agent_classifier.rb
 - lib/rails_error_dashboard/services/analytics_cache_manager.rb
@@ -563,6 +564,7 @@ files:
 - lib/rails_error_dashboard/services/severity_classifier.rb
 - lib/rails_error_dashboard/services/similarity_calculator.rb
 - lib/rails_error_dashboard/services/slack_payload_builder.rb
+- lib/rails_error_dashboard/services/solid_queue_config_check.rb
 - lib/rails_error_dashboard/services/source_code_reader.rb
 - lib/rails_error_dashboard/services/statistical_classifier.rb
 - lib/rails_error_dashboard/services/storm_protection/circuit_breaker.rb
@@ -599,7 +601,7 @@ metadata:
   funding_uri: https://github.com/sponsors/AnjanJ
 post_install_message: |
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-    RED (Rails Error Dashboard) v0.14.2
+    RED (Rails Error Dashboard) v0.14.4
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   First install:

data/lib/generators/rails_error_dashboard/solid_queue/templates/queue.yml

@@ -1,55 +0,0 @@
-# Solid Queue configuration for RailsErrorDashboard
-#
-# This file configures workers for error logging and notifications.
-# Adjust threads and processes based on your application's needs.
-
-# Development environment - optimized for low resource usage
-development:
-  workers:
-    # Error notifications (Slack, Email, Discord, PagerDuty, Webhooks)
-    - queues: error_notifications
-      threads: 2
-      processes: 1
-      polling_interval: 1
-
-    # Default queue (includes async error logging)
-    - queues: default
-      threads: 3
-      processes: 1
-      polling_interval: 1
-
-# Test environment - minimal configuration
-test:
-  workers:
-    - queues: "*"
-      threads: 1
-      processes: 1
-      polling_interval: 0.1
-
-# Production environment - optimized for throughput
-production:
-  workers:
-    # Error notifications - lower concurrency (external API calls)
-    - queues: error_notifications
-      threads: 3
-      processes: 1
-      polling_interval: 0.5
-
-    # Default queue - higher concurrency (database operations)
-    - queues: default
-      threads: 5
-      processes: 2
-      polling_interval: 0.5
-
-# Staging environment - similar to production but scaled down
-staging:
-  workers:
-    - queues: error_notifications
-      threads: 2
-      processes: 1
-      polling_interval: 0.5
-
-    - queues: default
-      threads: 3
-      processes: 1
-      polling_interval: 0.5