rails_error_dashboard 0.11.5 → 0.11.7

data/lib/rails_error_dashboard/services/system_health_snapshot.rb

@@ -8,11 +8,18 @@ module RailsErrorDashboard
     # Puma stats, job queue, RubyVM/YJIT, ActionCable, file descriptors, system load,
     # system memory pressure, GC context, and TCP connection states.
     #
-    # NOT memoized — fresh data every call (unlike EnvironmentSnapshot).
+    # NOT memoized — fresh data every call (unlike EnvironmentSnapshot), with
+    # one exception: job-queue depth counts are queries against the queue
+    # store, so they are cached per process for
+    # config.system_health_queue_stats_cache_seconds (failures included), with
+    # one refresh in flight at a time (and can be switched off with
+    # config.system_health_queue_stats = false).
     # Every metric call individually wrapped in rescue => nil.
     #
     # Safety contract (from HOST_APP_SAFETY.md):
-    # - Total snapshot < 1ms budget (~0.3ms typical on Linux)
+    # - In-process metrics < 1ms budget (~0.3ms typical on Linux). The
+    #   queue-depth counts are the documented exception: their latency is
+    #   the queue store's, which is why they are cached and optional.
     # - NEVER ObjectSpace.each_object or ObjectSpace.count_objects (heap scan)
     # - NEVER Thread.list.map(&:backtrace) (GVL hold)
     # - Thread.list.count only (O(1), safe)
@@ -133,7 +140,59 @@ module RailsErrorDashboard
 
       # Auto-detect and capture job queue stats
       # @return [Hash, nil] Job queue stats with :adapter key, or nil
+      # Process-wide cache for the queue-depth counts: { at: monotonic, stats: Hash|nil }.
+      # A nil stats entry is a FAILED collection, cached for the same interval
+      # so a broken queue store is not re-queried on every error.
+      def self.queue_stats_cache
+        @queue_stats_cache ||= Concurrent::AtomicReference.new(nil)
+      end
+
+      # Single-flight guard for the refresh. Never blocks: a thread that finds
+      # a refresh already running serves the stale entry (or nil) instead of
+      # starting a second one, so a burst of errors on a cold cache runs the
+      # queue counts once, not once per thread.
+      def self.queue_stats_refresh_lock
+        @queue_stats_refresh_lock ||= Mutex.new
+      end
+
+      def self.reset_queue_stats_cache!
+        queue_stats_cache.set(nil)
+      end
+
       def job_queue_stats
+        config = RailsErrorDashboard.configuration
+        return nil unless config.system_health_queue_stats
+
+        ttl = config.system_health_queue_stats_cache_seconds.to_f
+        return collect_job_queue_stats if ttl <= 0
+
+        now = Process.clock_gettime(Process::CLOCK_MONOTONIC)
+        cached = self.class.queue_stats_cache.get
+        return present_cached(cached, now) if cached && (now - cached[:at]) < ttl
+
+        lock = self.class.queue_stats_refresh_lock
+        return present_cached(cached, now, stale: true) unless lock.try_lock
+
+        begin
+          stats = collect_job_queue_stats
+          self.class.queue_stats_cache.set({ at: now, stats: stats })
+          stats
+        ensure
+          lock.unlock
+        end
+      rescue => e
+        nil
+      end
+
+      def present_cached(cached, now, stale: false)
+        return nil unless cached && cached[:stats]
+
+        presented = cached[:stats].merge(cached_age_seconds: (now - cached[:at]).round(1))
+        presented[:stale] = true if stale
+        presented
+      end
+
+      def collect_job_queue_stats
         if defined?(::Sidekiq::Stats)
           sidekiq_stats
         elsif defined?(::SolidQueue)

data/lib/rails_error_dashboard/value_objects/error_context.rb

@@ -7,7 +7,7 @@ module RailsErrorDashboard
     class ErrorContext
       attr_reader :user_id, :request_url, :request_params, :user_agent, :ip_address, :platform,
                   :controller_name, :action_name, :request_id, :session_id,
-                  :http_method, :hostname, :content_type, :request_duration_ms
+                  :http_method, :hostname, :content_type, :request_duration_ms, :environment
 
       def initialize(context, source = nil)
         @context = context
@@ -27,8 +27,15 @@ module RailsErrorDashboard
         @hostname = extract_hostname
         @content_type = extract_content_type
         @request_duration_ms = extract_request_duration_ms
+        @environment = extract_environment
       end
 
+      # Everything a second ErrorContext needs to rebuild THIS context from a
+      # plain hash. ErrorReporter hands `to_h` to LogError, which constructs a
+      # new ErrorContext from it, so any reader that is not represented here
+      # is silently nil on the far side of that hop. request_id/session_id
+      # were exactly that: extracted from the request, dropped here, and every
+      # occurrence on the main capture path stored nil for both.
       def to_h
         {
           user_id: user_id,
@@ -39,10 +46,13 @@ module RailsErrorDashboard
           platform: platform,
           controller_name: controller_name,
           action_name: action_name,
+          request_id: request_id,
+          session_id: session_id,
           http_method: http_method,
           hostname: hostname,
           content_type: content_type,
-          request_duration_ms: request_duration_ms
+          request_duration_ms: request_duration_ms,
+          environment: environment
         }
       end
 
@@ -246,6 +256,13 @@ module RailsErrorDashboard
         nil
       end
 
+      # An explicit environment from the caller (a sender attributing an event
+      # to its own environment). nil means "resolve from configuration".
+      def extract_environment
+        value = @context[:environment].to_s.strip
+        value.empty? ? nil : value
+      end
+
       # Auto-detect user_id from ActiveSupport::CurrentAttributes
       # Checks for common patterns: Current.user, Current.account (with .id)
       # Returns nil if CurrentAttributes is not used or user is not set

data/lib/rails_error_dashboard/version.rb

@@ -1,3 +1,3 @@
 module RailsErrorDashboard
-  VERSION = "0.11.5"
+  VERSION = "0.11.7"
 end

data/lib/tasks/error_dashboard.rake

@@ -52,6 +52,30 @@ namespace :error_dashboard do
       checks_failed += 1
     end
 
+    # 3b. MySQL only: named-zone conversion needs the server's time zone
+    # tables; without them groupdate (charts, baselines) raises.
+    begin
+      conn = RailsErrorDashboard::ErrorLogsRecord.connection
+      if conn.adapter_name.match?(/mysql|trilogy/i)
+        print "  MySQL time zone tables... "
+        zone = (Time.zone || ActiveSupport::TimeZone["UTC"]).tzinfo.name
+        converted = conn.select_value("SELECT CONVERT_TZ(NOW(), '+00:00', #{conn.quote(zone)})")
+        if converted.nil?
+          puts "MISSING"
+          puts "    CONVERT_TZ to '#{zone}' returned NULL: the server has no time zone tables,"
+          puts "    so the dashboard's time-bucketed charts and baselines will raise."
+          puts "    Fix (on the MySQL server): mysql_tzinfo_to_sql /usr/share/zoneinfo | mysql -u root mysql"
+          puts "    See docs/guides/DATABASE_OPTIONS.md (MySQL)."
+          warnings += 1
+        else
+          puts "OK (#{zone})"
+          checks_passed += 1
+        end
+      end
+    rescue => e
+      puts "SKIPPED (#{e.message.truncate(60)})"
+    end
+
     # 4. Tables check
     print "  Required tables... "
     required_tables = %w[

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_error_dashboard
 version: !ruby/object:Gem::Version
-  version: 0.11.5
+  version: 0.11.7
 platform: ruby
 authors:
 - Anjan Jagirdar
@@ -279,6 +279,7 @@ files:
 - app/jobs/rails_error_dashboard/application_job.rb
 - app/jobs/rails_error_dashboard/async_error_logging_job.rb
 - app/jobs/rails_error_dashboard/baseline_alert_job.rb
+- app/jobs/rails_error_dashboard/baseline_calculation_job.rb
 - app/jobs/rails_error_dashboard/close_linked_issue_job.rb
 - app/jobs/rails_error_dashboard/concerns/localized_job.rb
 - app/jobs/rails_error_dashboard/create_issue_job.rb
@@ -407,6 +408,8 @@ files:
 - db/migrate/20260730000001_create_rails_error_dashboard_rack_attack_events.rb
 - db/migrate/20260824000001_add_user_agent_to_rack_attack_events.rb
 - db/migrate/20260826000001_add_environment_to_error_logs.rb
+- db/migrate/20260908000001_add_release_to_error_occurrences.rb
+- db/migrate/20260908220001_add_missing_postgresql_indexes_to_error_logs.rb
 - lib/generators/rails_error_dashboard/install/install_generator.rb
 - lib/generators/rails_error_dashboard/install/templates/README
 - lib/generators/rails_error_dashboard/install/templates/initializer.rb
@@ -575,7 +578,7 @@ metadata:
   funding_uri: https://github.com/sponsors/AnjanJ
 post_install_message: |
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-    RED (Rails Error Dashboard) v0.11.5
+    RED (Rails Error Dashboard) v0.11.7
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   First install: