rails_error_dashboard 0.10.0 → 0.11.0

data/lib/rails_error_dashboard/services/notification_throttler.rb

@@ -29,6 +29,29 @@ module RailsErrorDashboard
           true
         end
 
+        # Does this error's environment pass config.notification_environments?
+        #
+        # nil list → everything notifies (the pre-0.11 behaviour). Accepts an
+        # ErrorLog, a bare environment name, or nothing (the process
+        # environment) — the storm and baseline paths have no row to hand over.
+        # A legacy row with a NULL environment is judged as the process
+        # environment, so upgrading never silences an error that was notifying
+        # before. Fails open: an allowlist bug must not lose a page.
+        #
+        # @param subject [ErrorLog, String, nil]
+        # @return [Boolean]
+        def environment_allowed?(subject = nil)
+          allowed = RailsErrorDashboard.configuration.notification_environments
+          return true if allowed.nil?
+
+          name = subject.respond_to?(:environment) ? subject.environment : subject
+          name = RailsErrorDashboard.configuration.current_environment if name.blank?
+          allowed.include?(name.to_s)
+        rescue => e
+          RailsErrorDashboard::Logger.debug("[RailsErrorDashboard] NotificationThrottler.environment_allowed? failed: #{e.message}")
+          true
+        end
+
         # Does the error's severity meet the configured minimum?
         # @param error_log [ErrorLog] The error to check
         # @return [Boolean] true if severity is at or above minimum

data/lib/rails_error_dashboard/services/pagerduty_payload_builder.rb

@@ -46,6 +46,7 @@ module RailsErrorDashboard
               controller: error_log.controller_name,
               action: error_log.action_name,
               platform: error_log.platform,
+              environment: error_log.environment,
               occurrences: error_log.occurrence_count,
               first_seen_at: error_log.first_seen_at&.iso8601,
               last_seen_at: error_log.last_seen_at&.iso8601,

data/lib/rails_error_dashboard/services/slack_payload_builder.rb

@@ -64,6 +64,7 @@ module RailsErrorDashboard
                 locale
               )
             },
+            *environment_fields(error_log, locale),
             {
               type: "mrkdwn",
               text: NotificationHelpers.field(
@@ -74,6 +75,14 @@ module RailsErrorDashboard
         }
       end
 
+      # One field when the error carries an environment, none for a legacy
+      # row — so pre-0.11 notifications render exactly as they did.
+      def self.environment_fields(error_log, locale)
+        return [] unless error_log.respond_to?(:environment) && error_log.environment.present?
+
+        [ { type: "mrkdwn", text: NotificationHelpers.field(:environment, error_log.environment, locale) } ]
+      end
+
       def self.message_block(error_log, locale)
         {
           type: "section",

data/lib/rails_error_dashboard/services/storm_protection/gate.rb

@@ -232,6 +232,8 @@ module RailsErrorDashboard
           def maybe_storm_notification(state)
             return if state == :closed
             return unless RailsErrorDashboard.configuration.storm_notification
+            # A storm on staging should not page whoever is on call for production.
+            return unless RailsErrorDashboard::Services::NotificationThrottler.environment_allowed?
 
             episode = breaker.episode_snapshot
             return unless episode

data/lib/rails_error_dashboard/services/webhook_payload_builder.rb

@@ -37,6 +37,7 @@ module RailsErrorDashboard
             message: error_log.message,
             severity: error_log.severity.to_s,
             platform: error_log.platform,
+            environment: error_log.environment,
             controller: error_log.controller_name,
             action: error_log.action_name,
             occurrence_count: error_log.occurrence_count,

data/lib/rails_error_dashboard/version.rb

@@ -1,3 +1,3 @@
 module RailsErrorDashboard
-  VERSION = "0.10.0"
+  VERSION = "0.11.0"
 end

data/lib/rails_error_dashboard.rb

@@ -109,6 +109,7 @@ require "rails_error_dashboard/commands/resolve_error"
 require "rails_error_dashboard/commands/create_issue"
 require "rails_error_dashboard/commands/link_existing_issue"
 require "rails_error_dashboard/commands/flush_storm_counts"
+require "rails_error_dashboard/commands/backfill_environments"
 require "rails_error_dashboard/services/issue_body_formatter"
 require "rails_error_dashboard/commands/batch_resolve_errors"
 require "rails_error_dashboard/commands/batch_delete_errors"

data/lib/tasks/rails_error_dashboard_tasks.rake

@@ -1,6 +1,12 @@
 # frozen_string_literal: true
 
 namespace :rails_error_dashboard do
+  desc "Fill in environment on error logs captured before the column existed (from environment_info.rails_env)"
+  task backfill_environments: :environment do
+    updated = RailsErrorDashboard::Commands::BackfillEnvironments.call
+    puts "rails_error_dashboard: backfilled environment on #{updated} error log(s)."
+  end
+
   namespace :db do
     desc "Drop all Rails Error Dashboard database tables (⚠️  DESTRUCTIVE - deletes all error data)"
     task drop: :environment do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_error_dashboard
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Anjan Jagirdar
@@ -392,6 +392,7 @@ files:
 - db/migrate/20260613000001_create_storm_events.rb
 - db/migrate/20260730000001_create_rails_error_dashboard_rack_attack_events.rb
 - db/migrate/20260824000001_add_user_agent_to_rack_attack_events.rb
+- db/migrate/20260826000001_add_environment_to_error_logs.rb
 - lib/generators/rails_error_dashboard/install/install_generator.rb
 - lib/generators/rails_error_dashboard/install/templates/README
 - lib/generators/rails_error_dashboard/install/templates/initializer.rb
@@ -401,6 +402,7 @@ files:
 - lib/rails_error_dashboard.rb
 - lib/rails_error_dashboard/commands/add_error_comment.rb
 - lib/rails_error_dashboard/commands/assign_error.rb
+- lib/rails_error_dashboard/commands/backfill_environments.rb
 - lib/rails_error_dashboard/commands/batch_delete_errors.rb
 - lib/rails_error_dashboard/commands/batch_mute_errors.rb
 - lib/rails_error_dashboard/commands/batch_resolve_errors.rb
@@ -559,7 +561,7 @@ metadata:
   funding_uri: https://github.com/sponsors/AnjanJ
 post_install_message: |
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
-    RED (Rails Error Dashboard) v0.10.0
+    RED (Rails Error Dashboard) v0.11.0
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
 
   First install: