rails_error_dashboard 0.1.23 → 0.1.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e8ebc7a75413a15752df2dc4a425f0c2dc046480e92d394d68212646360787e9
-  data.tar.gz: c4174fc14f0e8c9ca2da761bf7895f0ff5d3cf85d99470b31705dc748d9083f2
+  metadata.gz: 3ca536416dd8806b35ae7b3bda7aaad734d7d12f9af382db58db91ac8cfa3d3e
+  data.tar.gz: c015a441f1aea077f1cd742f008d1a5cc08749247e6e00714994a421c4a32e98
 SHA512:
-  metadata.gz: 33ab7875fcef261cc93f8af9ac7a7203e5b1c49a708baf247e63c7c2c9e40932d1fa21eb25c34f8b1f0d4e4f63dff3f1fdbb43f0f2b7b252575de6aaccd9cd08
-  data.tar.gz: 9213caf3f27b27b6a04e0dc198da8e45c7561734f6c5f14f8ccbaf150f17015b3e6693c05a14b4c73e47674ca6d12ae90f75097167e65ec80d47f03e7de9e507
+  metadata.gz: 2f7e9246fd8327c6f6a7109e6c283cc42ae4eeaa85125b0eddf96f53128d7560acefac4303b2367d7d82fb07287ac05907f8929a58644bf41768702dc6120951
+  data.tar.gz: 6b952f9198afcfeb7d40b44a118d29303eb8bac87cc52ca0635c394c111b05ce94f877f56cb498b87c036519b90a0a692dc03b3aab155c1265588be8c72eca50

data/app/controllers/rails_error_dashboard/errors_controller.rb

@@ -6,6 +6,23 @@ module RailsErrorDashboard
 
     before_action :authenticate_dashboard_user!
 
+    FILTERABLE_PARAMS = %i[
+      error_type
+      unresolved
+      platform
+      application_id
+      search
+      severity
+      timeframe
+      frequency
+      status
+      assigned_to
+      priority_level
+      hide_snoozed
+      sort_by
+      sort_direction
+    ].freeze
+
     def overview
       # Get dashboard stats using Query
       @stats = Queries::DashboardStats.call
@@ -266,24 +283,7 @@ module RailsErrorDashboard
     end
 
     def filter_params
-      {
-        error_type: params[:error_type],
-        unresolved: params[:unresolved],
-        platform: params[:platform],
-        application_id: params[:application_id],
-        search: params[:search],
-        severity: params[:severity],
-        timeframe: params[:timeframe],
-        frequency: params[:frequency],
-        # Phase 3: Workflow filter params
-        status: params[:status],
-        assigned_to: params[:assigned_to],
-        priority_level: params[:priority_level],
-        hide_snoozed: params[:hide_snoozed],
-        # Sorting params
-        sort_by: params[:sort_by],
-        sort_direction: params[:sort_direction]
-      }
+      params.permit(*FILTERABLE_PARAMS).to_h.symbolize_keys
     end
 
     def authenticate_dashboard_user!

data/app/helpers/rails_error_dashboard/application_helper.rb

@@ -81,6 +81,15 @@ module RailsErrorDashboard
       RailsErrorDashboard.configuration.dashboard_username || ENV["USER"] || "unknown"
     end
 
+    # Returns a sanitized hash of filter params safe for query links
+    # @param extra_keys [Array<Symbol>] Additional permitted keys for specific contexts
+    # @return [Hash] Whitelisted params for building URLs
+    def permitted_filter_params(extra_keys: [])
+      base_keys = RailsErrorDashboard::ErrorsController::FILTERABLE_PARAMS + %i[page per_page days]
+      allowed_keys = base_keys + Array(extra_keys)
+      params.permit(*allowed_keys).to_h.symbolize_keys
+    end
+
     # Generates a sortable column header link
     # @param label [String] The column label to display
     # @param column [String] The column name to sort by
@@ -103,8 +112,8 @@ module RailsErrorDashboard
         "⇅"  # Unsorted indicator
       end
 
-      # Preserve existing filter params while adding sort params
-      link_params = params.permit!.to_h.merge(sort_by: column, sort_direction: new_direction)
+      # Preserve whitelisted filter params while adding sort params
+      link_params = permitted_filter_params.merge(sort_by: column, sort_direction: new_direction)
 
       link_to errors_path(link_params), class: "text-decoration-none" do
         content_tag(:span, "#{label} ", class: current_sort == column ? "fw-bold" : "") +

data/app/models/rails_error_dashboard/application.rb

@@ -12,22 +12,32 @@ module RailsErrorDashboard
     scope :ordered_by_name, -> { order(:name) }
 
     # Class method for finding or creating with caching
-    # Only caches successful finds, not creates (to avoid caching nil on creation failures)
+    # Caches application IDs (not objects) to avoid stale ActiveRecord references
+    # This is safer with transactional fixtures and database rollbacks
     def self.find_or_create_by_name(name)
-      # Try to find in cache or database first
-      cached = Rails.cache.read("error_dashboard/application/#{name}")
-      return cached if cached
+      # Try to find ID in cache
+      cached_id = Rails.cache.read("error_dashboard/application_id/#{name}")
+      if cached_id
+        # Verify the cached ID still exists in database
+        # (could have been deleted in tests with transactional rollback)
+        cached_record = find_by(id: cached_id)
+        return cached_record if cached_record
+        # Cache was stale, clear it
+        Rails.cache.delete("error_dashboard/application_id/#{name}")
+      end
 
-      # Try to find existing
+      # Try to find existing in database
       found = find_by(name: name)
       if found
-        Rails.cache.write("error_dashboard/application/#{name}", found, expires_in: 1.hour)
+        # Cache the ID (not the object) for future lookups
+        Rails.cache.write("error_dashboard/application_id/#{name}", found.id, expires_in: 1.hour)
         return found
       end
 
-      # Create if not found (don't cache until successful)
+      # Create if not found
       created = create!(name: name)
-      Rails.cache.write("error_dashboard/application/#{name}", created, expires_in: 1.hour)
+      # Cache the ID (not the object)
+      Rails.cache.write("error_dashboard/application_id/#{name}", created.id, expires_in: 1.hour)
       created
     end
 

data/app/models/rails_error_dashboard/error_logs_record.rb

@@ -1,14 +1,15 @@
 # frozen_string_literal: true
 
-# Abstract base class for models stored in the error_logs database
+# Abstract base class for models stored in the error dashboard database
 #
 # By default, this connects to the same database as the main application.
 #
-# To enable a separate error logs database:
+# To enable a separate error dashboard database:
 # 1. Set use_separate_database: true in the gem configuration
-# 2. Configure error_logs_database settings in config/database.yml
-# 3. Run: rails db:create:error_logs
-# 4. Run: rails db:migrate:error_logs
+# 2. Set database: :error_dashboard (or your custom name) in the gem configuration
+# 3. Configure error_dashboard settings in config/database.yml
+# 4. Run: rails db:create
+# 5. Run: rails db:migrate
 #
 # Benefits of separate database:
 # - Performance isolation (error logging doesn't slow down user requests)
@@ -25,10 +26,8 @@ module RailsErrorDashboard
   class ErrorLogsRecord < ActiveRecord::Base
     self.abstract_class = true
 
-    # Connect to error_logs database (or primary if not using separate DB)
-    # Only connect to separate database if configuration is enabled
-    if RailsErrorDashboard.configuration&.use_separate_database
-      connects_to database: { writing: :error_logs, reading: :error_logs }
-    end
+    # Database connection will be configured by the engine initializer
+    # after the user's configuration is loaded
+    # See lib/rails_error_dashboard/engine.rb
   end
 end

data/app/views/layouts/rails_error_dashboard.html.erb

@@ -866,16 +866,20 @@
                 <% end %>
               </button>
               <ul class="dropdown-menu dropdown-menu-end" aria-labelledby="appSwitcher">
+                <%
+                  base_route_params = request.path_parameters.slice(:controller, :action)
+                  current_filter_params = permitted_filter_params
+                %>
                 <li>
                   <%= link_to "All Applications",
-                      url_for(params.permit!.except(:controller, :action, :application_id)),
+                      url_for(base_route_params.merge(current_filter_params.except(:application_id))),
                       class: "dropdown-item #{'active' unless params[:application_id].present?}" %>
                 </li>
                 <li><hr class="dropdown-divider"></li>
                 <% @applications.each do |app_name, app_id| %>
                   <li>
                     <%= link_to app_name,
-                        url_for(params.permit!.except(:controller, :action).merge(application_id: app_id)),
+                        url_for(base_route_params.merge(current_filter_params.merge(application_id: app_id))),
                         class: "dropdown-item #{params[:application_id].to_s == app_id.to_s ? 'active' : ''}" %>
                   </li>
                 <% end %>

data/app/views/rails_error_dashboard/errors/index.html.erb

@@ -158,7 +158,7 @@
         <% active_filters.each do |filter| %>
           <%
             # Build URL without this specific filter
-            filter_params = params.permit!.except(:controller, :action, filter[:param])
+            filter_params = permitted_filter_params.except(filter[:param])
           %>
           <%= link_to errors_path(filter_params), class: "badge bg-primary text-decoration-none filter-pill" do %>
             <%= filter[:label] %>

data/db/migrate/20260106094233_add_application_to_error_logs.rb

@@ -7,11 +7,11 @@ class AddApplicationToErrorLogs < ActiveRecord::Migration[7.0]
     add_index :rails_error_dashboard_error_logs, :application_id
 
     add_index :rails_error_dashboard_error_logs,
-              [:application_id, :occurred_at],
+              [ :application_id, :occurred_at ],
               name: 'index_error_logs_on_app_occurred'
 
     add_index :rails_error_dashboard_error_logs,
-              [:application_id, :resolved],
+              [ :application_id, :resolved ],
               name: 'index_error_logs_on_app_resolved'
   end
 

data/lib/generators/rails_error_dashboard/install/install_generator.rb

@@ -18,6 +18,7 @@ module RailsErrorDashboard
       class_option :async_logging, type: :boolean, default: false, desc: "Enable async error logging"
       class_option :error_sampling, type: :boolean, default: false, desc: "Enable error sampling (reduce volume)"
       class_option :separate_database, type: :boolean, default: false, desc: "Use separate database for errors"
+      class_option :database, type: :string, default: nil, desc: "Database name to use for errors (e.g., 'error_dashboard')"
       # Advanced analytics options
       class_option :baseline_alerts, type: :boolean, default: false, desc: "Enable baseline anomaly alerts"
       class_option :similar_errors, type: :boolean, default: false, desc: "Enable fuzzy error matching"
@@ -185,6 +186,7 @@ module RailsErrorDashboard
         @enable_async_logging = @selected_features&.dig(:async_logging) || options[:async_logging]
         @enable_error_sampling = @selected_features&.dig(:error_sampling) || options[:error_sampling]
         @enable_separate_database = @selected_features&.dig(:separate_database) || options[:separate_database]
+        @database_name = options[:database]
 
         # Advanced Analytics
         @enable_baseline_alerts = @selected_features&.dig(:baseline_alerts) || options[:baseline_alerts]
@@ -275,7 +277,14 @@ module RailsErrorDashboard
         say "  → Set PAGERDUTY_INTEGRATION_KEY in .env", :yellow if @enable_pagerduty
         say "  → Set WEBHOOK_URLS in .env", :yellow if @enable_webhooks
         say "  → Ensure Sidekiq/Solid Queue running", :yellow if @enable_async_logging
-        say "  → Configure database.yml (docs/guides/DATABASE_OPTIONS.md)", :yellow if @enable_separate_database
+        if @enable_separate_database
+          if @database_name
+            say "  → Configure '#{@database_name}' database in database.yml", :yellow
+          else
+            say "  → Configure database in database.yml and set config.database", :yellow
+          end
+          say "    See docs/guides/DATABASE_OPTIONS.md for details", :yellow
+        end
 
         say "\n"
         say "Next Steps:", :cyan

data/lib/generators/rails_error_dashboard/install/templates/initializer.rb

@@ -153,6 +153,11 @@ RailsErrorDashboard.configure do |config|
   # Errors will be stored in a dedicated database
   # See docs/guides/DATABASE_OPTIONS.md for setup instructions
   config.use_separate_database = true
+<% if @database_name -%>
+  config.database = :<%= @database_name %>
+<% else -%>
+  # config.database = :error_dashboard  # Uncomment and set your database name
+<% end -%>
   # To disable: Set config.use_separate_database = false
 
 <% else -%>
@@ -160,6 +165,7 @@ RailsErrorDashboard.configure do |config|
   # Errors are stored in your main application database
   # To enable: Set config.use_separate_database = true and configure database.yml
   config.use_separate_database = false
+  # config.database = :error_dashboard  # Database name when using separate database
 
 <% end -%>
   # ============================================================================

data/lib/rails_error_dashboard/commands/log_error.rb

@@ -143,15 +143,15 @@ module RailsErrorDashboard
       # Find or create application for multi-app support
       def find_or_create_application
         app_name = RailsErrorDashboard.configuration.application_name ||
-                   ENV['APPLICATION_NAME'] ||
+                   ENV["APPLICATION_NAME"] ||
                    (defined?(Rails) && Rails.application.class.module_parent_name) ||
-                   'Rails Application'
+                   "Rails Application"
 
         Application.find_or_create_by_name(app_name)
       rescue => e
         RailsErrorDashboard::Logger.error("[RailsErrorDashboard] Failed to find/create application: #{e.message}")
         # Fallback: try to find any application or create default
-        Application.first || Application.create!(name: 'Default Application')
+        Application.first || Application.create!(name: "Default Application")
       end
 
       # Trigger notification callbacks for error logging

data/lib/rails_error_dashboard/engine.rb

@@ -2,6 +2,20 @@ module RailsErrorDashboard
   class Engine < ::Rails::Engine
     isolate_namespace RailsErrorDashboard
 
+    # Configure database connection for error models
+    # This runs early, before middleware setup, but after database.yml is loaded
+    initializer "rails_error_dashboard.database", before: :load_config_initializers do
+      config.after_initialize do
+        if RailsErrorDashboard.configuration&.use_separate_database
+          database_name = RailsErrorDashboard.configuration&.database || :error_dashboard
+
+          RailsErrorDashboard::ErrorLogsRecord.connects_to(
+            database: { writing: database_name, reading: database_name }
+          )
+        end
+      end
+    end
+
     # Initialize the engine
     initializer "rails_error_dashboard.middleware" do |app|
       # Enable Flash middleware for Error Dashboard routes in API-only apps

data/lib/rails_error_dashboard/version.rb

@@ -1,3 +1,3 @@
 module RailsErrorDashboard
-  VERSION = "0.1.23"
+  VERSION = "0.1.24"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_error_dashboard
 version: !ruby/object:Gem::Version
-  version: 0.1.23
+  version: 0.1.24
 platform: ruby
 authors:
 - Anjan Jagirdar
@@ -83,16 +83,16 @@ dependencies:
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.21'
+        version: 0.24.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.21'
+        version: 0.24.0
 - !ruby/object:Gem::Dependency
   name: turbo-rails
   requirement: !ruby/object:Gem::Requirement
@@ -386,7 +386,7 @@ metadata:
   source_code_uri: https://github.com/AnjanJ/rails_error_dashboard
   changelog_uri: https://github.com/AnjanJ/rails_error_dashboard/blob/main/CHANGELOG.md
 post_install_message: "━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n
-  \ Rails Error Dashboard v0.1.23\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n\n\U0001F195
+  \ Rails Error Dashboard v0.1.24\n━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━\n\n\U0001F195
   First time? Quick start:\n   rails generate rails_error_dashboard:install\n   rails
   db:migrate\n   # Add to config/routes.rb:\n   mount RailsErrorDashboard::Engine
   => '/error_dashboard'\n\n\U0001F504 Upgrading from v0.1.x?\n   rails db:migrate\n