rails_email_validator 0.0.3 → 0.1.0

data/Gemfile

@@ -8,6 +8,5 @@ source "http://rubygems.org"
 group :development do
   gem "bundler", "~> 1.0.0"
   gem "jeweler", "~> 1.5.1"
-  gem "rcov", ">= 0"
-  gem "reek", "~> 1.2.8"
+  gem "idn", :git => "git://github.com/mihu/idn.git"
 end

data/README.rdoc

@@ -9,17 +9,28 @@ If you want to use it as plugin
 
 == Using
 Use to validate email
-  validate :email => true
+  validates :email, :email => true
 
 Use email validation without mx validation
-  validate :email => { :validate_mx => false }
+  validates :email, :email => { :validate_mx => false }
 
+Use email validation without idn support
+  validates :email, :email => { :allow_idn => false }
 
 == Features
 
 * validates local part of email
 * validates domain part of email
 * validate domain has a valid mx entry
+* idn support if idn available
+* tests for validator
+
+== IDN support
+
+If you want to support idn for email, you must install idn.
+
+fork with ruby 1.9 support
+  gem "idn", :git => "git://github.com/mihu/idn.git"
 
 == Contributing to rails_email_validator
  

data/Rakefile

@@ -33,20 +33,6 @@ Rake::TestTask.new(:test) do |test|
   test.verbose = true
 end
 
-require 'rcov/rcovtask'
-Rcov::RcovTask.new do |test|
-  test.libs << 'test'
-  test.pattern = 'test/**/test_*.rb'
-  test.verbose = true
-end
-
-require 'reek/rake/task'
-Reek::Rake::Task.new do |t|
-  t.fail_on_error = true
-  t.verbose = false
-  t.source_files = 'lib/**/*.rb'
-end
-
 task :default => :test
 
 require 'rake/rdoctask'

data/VERSION

@@ -1 +1 @@
-0.0.3
+0.1.0

data/lib/rails_email_validator.rb

@@ -1,12 +1,16 @@
-
 require 'active_model'
 
+# Validator for email
 class EmailValidator < ActiveModel::EachValidator
   # check the options for do mx validation
   def validate_mx?
     options[:validate_mx].nil? or options[:validate_mx] == true
   end
 
+  def allow_idn?
+    options[:allow_idn].nil? or options[:allow_idn] == true
+  end
+
   # validate if an mx exists on domain
   def has_mx?(domain)
     require 'resolv'
@@ -17,18 +21,41 @@ class EmailValidator < ActiveModel::EachValidator
     not mx.nil? and mx.size > 0
   end
 
+  def convert_idn(domain_part)
+    if allow_idn?
+      # idn suport if available
+      begin
+        require 'idn'
+        # encode domain part
+        return IDN::Idna.toASCII(domain_part)
+      rescue LoadError
+      rescue IDN::Idna::IdnaError
+      end
+    end
+    domain_part
+  end
+
   # main validator for email
   def validate_each(record, attribute, value)
     unless value.blank?
-      # split local and domain part
-      (local_part, domain_part) = value.split('@', 2)
 
       # pre var
       valid = true
+      local_part = nil
+      domain_part = nil
+
+      if valid
+        # split local and domain part
+        (local_part, domain_part) = value.to_s.split('@', 2)
+      end
 
-      # check syntax
-      valid = false unless local_part =~ /\A[A-Za-z0-9.!\#$%&'*+-\/=?^_`{|}~]+\Z/
-      valid = false unless domain_part =~ /\A((?:[-a-zA-Z0-9]+\.)+[a-zA-Z]{2,})\Z/
+      domain_part = convert_idn domain_part
+
+      if valid
+        # check syntax
+        valid = false unless local_part =~ /\A[A-Za-z0-9.!\#$%&'*+-\/=?^_`{|}~]+\Z/
+        valid = false unless domain_part =~ /\A((?:[-a-zA-Z0-9]+\.)+[a-zA-Z]{2,})(.|)\Z/
+      end
 
       # check mx
       if valid and validate_mx?

data/rails_email_validator.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_email_validator}
-  s.version = "0.0.3"
+  s.version = "0.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Marco Scholl"]
-  s.date = %q{2010-12-08}
+  s.date = %q{2011-01-22}
   s.description = %q{a class to validate emails. it builded for rails}
   s.email = %q{develop@marco-scholl.de}
   s.extra_rdoc_files = [
@@ -47,23 +47,20 @@ Gem::Specification.new do |s|
       s.add_runtime_dependency(%q<activemodel>, [">= 3.0.0"])
       s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.5.1"])
-      s.add_development_dependency(%q<rcov>, [">= 0"])
-      s.add_development_dependency(%q<reek>, ["~> 1.2.8"])
+      s.add_development_dependency(%q<idn>, [">= 0"])
       s.add_runtime_dependency(%q<activemodel>, [">= 3.0.0"])
     else
       s.add_dependency(%q<activemodel>, [">= 3.0.0"])
       s.add_dependency(%q<bundler>, ["~> 1.0.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.5.1"])
-      s.add_dependency(%q<rcov>, [">= 0"])
-      s.add_dependency(%q<reek>, ["~> 1.2.8"])
+      s.add_dependency(%q<idn>, [">= 0"])
       s.add_dependency(%q<activemodel>, [">= 3.0.0"])
     end
   else
     s.add_dependency(%q<activemodel>, [">= 3.0.0"])
     s.add_dependency(%q<bundler>, ["~> 1.0.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.5.1"])
-    s.add_dependency(%q<rcov>, [">= 0"])
-    s.add_dependency(%q<reek>, ["~> 1.2.8"])
+    s.add_dependency(%q<idn>, [">= 0"])
     s.add_dependency(%q<activemodel>, [">= 3.0.0"])
   end
 end

data/test/test_rails_email_validator.rb

@@ -1,7 +1,126 @@
+# encoding:utf-8
+
 require 'helper'
 
+class ValidateEmailWithMx
+  include ActiveModel::Validations
+  attr_accessor :email
+  validates :email, :email => true
+end
+
+class ValidateEmailWithoutMx
+  include ActiveModel::Validations
+  attr_accessor :email
+  validates :email, :email => {:validate_mx => false}
+end
+
+class ValidateEmailDisabledIdm
+  include ActiveModel::Validations
+  attr_accessor :email
+  validates :email, :email => {:allow_idn => false}
+end
+
+
 class TestRailsEmailValidator < Test::Unit::TestCase
-  def test_something_for_real
-    flunk "hey buddy, you should probably rename this file and start testing for real"
+
+
+  def test_valid_emails_with_mx_validation
+    model = ValidateEmailWithMx.new
+
+    [
+        'test@marco-scholl.de'
+    ].each do |email|
+
+      model.email = email
+      assert model.valid?, ">>#{email}<<"
+
+    end
+  end
+
+  def test_invalid_emails_with_mx_validation
+    model = ValidateEmailWithMx.new
+
+    [
+        'test@invalidmx.marco-scholl.de'
+    ].each do |email|
+
+      model.email = email
+      assert !model.valid?, ">>#{email}<<"
+
+    end
   end
+
+
+  def test_valid_emails_without_mx_validation
+    model = ValidateEmailWithoutMx.new
+
+    [
+        nil,
+        '',
+        ' ',
+        'test@example.net',
+        'test@sub1.example.net',
+        'test@sub1.example.co.uk',
+        'test@sub2.sub1.example.net',
+        'test@sub2.sub1.example.tttttttt',
+        'test@mexample.net.'
+    ].each do |email|
+
+      model.email = email
+      assert model.valid?, ">>#{email}<<"
+
+    end
+  end
+
+  def test_invalid_emails_without_mx_validation
+    model = ValidateEmailWithoutMx.new
+
+    [
+        1.2,
+        1,
+        'email',
+        'test@localhost',
+        'müller@example.net',
+        'test@example.net..'
+    ].each do |email|
+
+      model.email = email
+      assert !model.valid?, ">>#{email}<<"
+
+    end
+  end
+
+  def test_idn_adresses
+    model = ValidateEmailWithoutMx.new
+
+    [
+        'mueller@müller.de',
+        'test@räksmörgås.nu',
+        'test@sub1.räksmörgås.nu',
+        'test@xn--rksmrgs-5wao1o.nu',
+        'test@sub1.xn--rksmrgs-5wao1o.nu'
+    ].each do |email|
+
+      model.email = email
+      assert model.valid?, ">>#{email}<<"
+    end
+  end
+
+  def test_idn_with_disabled_idn_support
+    model = ValidateEmailDisabledIdm.new
+
+    [
+        'mueller@müller.de',
+        'test@räksmörgås.nu',
+        'test@sub1.räksmörgås.nu',
+        'test@xn--rksmrgs-5wao1o.nu',
+        'test@sub1.xn--rksmrgs-5wao1o.nu'
+    ].each do |email|
+
+      model.email = email
+      assert !model.valid?, ">>#{email}<<"
+    end
+  end
+
+
 end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
+  - 1
   - 0
-  - 3
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors: 
 - Marco Scholl
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-12-08 00:00:00 +01:00
+date: 2011-01-22 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -63,7 +63,7 @@ dependencies:
   prerelease: false
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: rcov
+  name: idn
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -75,24 +75,9 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: reek
-  requirement: &id005 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        segments: 
-        - 1
-        - 2
-        - 8
-        version: 1.2.8
-  type: :development
-  prerelease: false
-  version_requirements: *id005
 - !ruby/object:Gem::Dependency 
   name: activemodel
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -104,7 +89,7 @@ dependencies:
         version: 3.0.0
   type: :runtime
   prerelease: false
-  version_requirements: *id006
+  version_requirements: *id005
 description: a class to validate emails. it builded for rails
 email: develop@marco-scholl.de
 executables: []
@@ -140,7 +125,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 4213132792556836098
+      hash: -2629671929889912192
       segments: 
       - 0
       version: "0"