rails_discord_notifier 0.3.0 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6527e49521148326dc463e191ed0fe51097c0625e7a09b89074615eb6b21f431
-  data.tar.gz: 3502ab8e704d8e0d995cdd17fb8d06fc36d9c6bae13122455cb33b013c9eff3c
+  metadata.gz: 78212ad50963b77ccf50a72b4d7c0d79efd23557465c73cd829dc6bcc3c88251
+  data.tar.gz: c394690be33b31b3ff588041ccbe8232079657a479b204f968c9e58b3f30b6d0
 SHA512:
-  metadata.gz: 2933ce5afd5ee5ae228d589c4c556fdde5dee1def8146a07204fc2230b80ccdbe89dbcbd055786af2389653518d8518e3de564d1dc3147851a8236a50f48ac5f
-  data.tar.gz: 01a951280d579cac677a76e6e2120b9fb30b4c8c94fd584459423a0b4e1b7d65e8ab178584ef4e9b41178a216a3b010d2a0d34950d481e0ef341d28050609bc5
+  metadata.gz: 6b2c309fd867f9b24963e37b04958c081a984fd4c3cadb1a969b08ed981d5776dfaeea0555b87ea89722dd22249600ed7ff792ffac426d7fa367d9c57a1aba31
+  data.tar.gz: 39e26aa259b490ddfd3227183350a4a8dd74123e6c93527f2a228519da99ab67d83703b50c21d3179918e8c70a67a0b21ae1ed668413b9536bb2b150edfaaeca

data/CHANGELOG.md

@@ -7,6 +7,29 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [0.3.2] - 2026-10-28
+
+### Security
+
+- **The URL field no longer includes the query string.** Query values were
+  sent twice, filtered, in the URL and in Params, and the URL copy was still
+  sent with `config.include_params = false`. The query string is now sent only
+  as part of Params, so `include_params = false` leaves it out. An exception
+  message that quotes a value is still sent, with its best-effort scrub.
+
+## [0.3.1] - 2026-10-28
+
+### Changed
+
+- **Backtraces show your app's frames.** The backtrace goes through
+  `Rails.backtrace_cleaner`, so your own lines are no longer crowded out by gem
+  frames and cut off at the size limit. An error that never reaches your code
+  keeps its library frames, with short gem paths.
+- **`Host` shows the Heroku dyno name** (`web.1`, `worker.2`) instead of the
+  dyno's random hostname.
+- **Google Chat reports from outside a request no longer repeat the error
+  class** as a heading above the message.
+
 ## [0.3.0] - 2026-10-28
 
 ### Added

data/README.md

@@ -63,7 +63,7 @@ Exception in POST /orders
 ActiveRecord::RecordInvalid: Validation failed: Email can't be blank
 Caused by ArgumentError: missing email
 
-URL          https://shop.example.com/orders?utm_source=newsletter
+URL          https://shop.example.com/orders
 Controller   orders          Action   create
 Environment  production      Release  a1b2c3d
 Request ID   8f3c…           Host     web-01
@@ -75,6 +75,12 @@ In Google Chat, the same details as a single text message, with the params and
 backtrace in code blocks. Chat has no per-message sender name or avatar: those
 come from the name and avatar you gave the webhook when you created it.
 
+The backtrace goes through `Rails.backtrace_cleaner`, as on Rails' own error
+pages, so it shows your app's frames rather than gem internals. When an error
+never reaches your code, such as a job class that doesn't exist, the library
+frames are shown with short gem paths instead. On Heroku, `Host` is the dyno
+name (`web.1`, `worker.2`) rather than the dyno's random hostname.
+
 ## Configuration
 
 Everything is optional except `webhook_url`.
@@ -90,7 +96,7 @@ Everything is optional except `webhook_url`.
 | `ignored_exceptions` | routing/404-style noise (see below) | Exception class names, matched including subclasses. |
 | `include_params` | `true` | Include filtered request parameters. |
 | `filter_parameters` | `[]` | Extra redaction matchers, unioned with your app's `config.filter_parameters` and the gem's built-in list. |
-| `backtrace_lines` | `10` | Backtrace lines to send, trimmed to fit the message size limit. |
+| `backtrace_lines` | `10` | Backtrace lines to send after cleaning, trimmed to fit the message size limit. |
 | `open_timeout` / `read_timeout` / `write_timeout` | `2` / `5` / `5` | Seconds. |
 | `environment` | `Rails.env`, else `RAILS_ENV`/`RACK_ENV` | Shown as a field, and decides the `enabled` default. |
 | `release` | `nil` | Shown as a field; handy for matching an error to a deploy. |
@@ -134,9 +140,11 @@ Parameters and query strings are filtered recursively with
    `session`, `credential`).
 
 Because it is a union, enabling this gem can never redact less than your
-application already does. To send no parameters at all, set
-`config.include_params = false`. The same filter applies to extra fields from
-`config.context` and from `Rails.error` context.
+application already does. The URL field leaves out the query string, so the
+query string is sent only as part of the filtered params. To leave out params
+and the query string, set `config.include_params = false`. An exception message
+that quotes a parameter value is still sent (see below). The same filter
+applies to extra fields from `config.context` and from `Rails.error` context.
 
 Exception messages are free text rather than structured parameters, so they get
 a best-effort scrub instead: `token=abc`, `password="x"`, `Api_Key: abc`,

data/lib/rails_discord_notifier/google_chat_payload.rb

@@ -22,8 +22,11 @@ module RailsDiscordNotifier
 
     private
 
+    # Outside a request the title is only the class name, which the description
+    # already opens with, so it is left out rather than repeated.
     def render(embed)
-      heading = [bold(embed[:title]), embed[:description], ""]
+      heading = [embed[:description], ""]
+      heading.unshift(bold(embed[:title])) if request
       (heading + embed[:fields].map { |field| render_field(field) }).join("\n")
     end
 
@@ -42,7 +45,7 @@ module RailsDiscordNotifier
     end
 
     def formatted_backtrace
-      lines = Array(exception.backtrace).first(config.backtrace_lines)
+      lines = clean_backtrace
       return "No backtrace available" if lines.empty?
 
       fence(lines.join("\n"))

data/lib/rails_discord_notifier/payload.rb

@@ -112,7 +112,7 @@ module RailsDiscordNotifier
 
     def request_fields
       [
-        { name: "URL", value: filtered_url },
+        { name: "URL", value: request_url },
         { name: "Controller", value: rails_params["controller"], inline: true },
         { name: "Action", value: rails_params["action"], inline: true },
         { name: "Environment", value: config.environment, inline: true },
@@ -169,7 +169,7 @@ module RailsDiscordNotifier
     end
 
     def formatted_backtrace
-      lines = Array(exception.backtrace).first(config.backtrace_lines)
+      lines = clean_backtrace
       return "No backtrace available" if lines.empty?
 
       lines.each_with_object(+"") do |line, out|
@@ -181,21 +181,25 @@ module RailsDiscordNotifier
       end
     end
 
-    def filtered_url
-      return nil unless request
+    # The app's own frames, as on Rails' error pages, so the lines that matter
+    # fit the message. An error raised entirely inside library code keeps its
+    # library frames, with gem paths shortened. Raw frames when the cleaner is
+    # unavailable (no Rails) or raises, and without an app root: Rails 6.1 and
+    # 7.0 would then strip the leading "/" from every path.
+    def clean_backtrace
+      lines = Array(exception.backtrace)
+      return lines.first(config.backtrace_lines) unless Rails.root
 
-      base  = "#{request.base_url}#{request.path}"
-      query = filtered_query_string
-      query.empty? ? base : "#{base}?#{query}"
+      app_frames = Rails.backtrace_cleaner.clean(lines)
+      (app_frames.empty? ? Rails.backtrace_cleaner.clean(lines, :all) : app_frames).first(config.backtrace_lines)
+    rescue StandardError
+      Array(exception.backtrace).first(config.backtrace_lines)
     end
 
-    def filtered_query_string
-      raw = request.query_string.to_s
-      return "" if raw.empty?
-
-      Rack::Utils.build_nested_query(parameter_filter.filter(Rack::Utils.parse_nested_query(raw)))
-    rescue StandardError
-      ""
+    # Without the query string, which is sent only as part of the filtered
+    # Params field, so include_params = false leaves it out.
+    def request_url
+      request && "#{request.base_url}#{request.path}"
     end
 
     def request_params
@@ -232,8 +236,10 @@ module RailsDiscordNotifier
       @parameter_filter ||= ActiveSupport::ParameterFilter.new(config.filter_parameters)
     end
 
+    # Heroku hostnames are random IDs; DYNO ("web.1", "worker.2") names the process.
     def hostname
-      @hostname ||= Socket.gethostname
+      dyno = ENV.fetch("DYNO", "")
+      @hostname ||= dyno.empty? ? Socket.gethostname : dyno
     rescue StandardError
       nil
     end

data/lib/rails_discord_notifier/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsDiscordNotifier
-  VERSION = "0.3.0"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_discord_notifier
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.2
 platform: ruby
 authors:
 - GettinDrikkieWithIt